nextcloud / circles

lib/Service/EventsService.php

Doc Comments +1 added lines, -1 removed lines

@@ -282,7 +282,7 @@
 	 * generateEvent()
 	 * Create an Activity Event with the basic settings for the app.
 	 *
-	 * @param $type
+	 * @param string $type
 	 *
 	 * @return \OCP\Activity\IEvent
 	 */

lib/Service/SearchService.php

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
 			$searcher = \OC::$server->query((string)$container);
 
 			if (!($searcher instanceof ISearch)) {
-				$this->miscService->log('Search ' . $container . ' is not compatible exception');
+				$this->miscService->log('Search '.$container.' is not compatible exception');
 				continue;
 			}
 

lib/Model/FederatedLink.php

Doc Comments +3 added lines

@@ -303,6 +303,9 @@
 	}
 
 
+	/**
+	 * @param integer $status
+	 */
 	public function hasToBeValidStatusUpdate($status) {
 		try {
 			$this->hasToBeValidStatusUpdateWhileLinkDown($status);

lib/Controller/TestController.php

Doc Comments +1 added lines, -1 removed lines

@@ -128,7 +128,7 @@
 
 
 	/**
-	 * @return DataResponse
+	 * @return string
 	 */
 	public function testAsyncStatus() {
 		return $this->miscService->success(

Spacing +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
 	 * @return string
 	 */
 	private function generateTestAsyncURL($remote) {
-		return $this->configService->generateRemoteHost($remote) . Application::TEST_URL_ASYNC;
+		return $this->configService->generateRemoteHost($remote).Application::TEST_URL_ASYNC;
 	}
 
 

lib/Service/MiscService.php

Spacing +1 added lines, -1 removed lines

@@ -284,7 +284,7 @@
 		ob_start();
 		echo(json_encode($result));
 		$size = ob_get_length();
-		header('Content-Length: ' . $size);
+		header('Content-Length: '.$size);
 		ob_end_flush();
 		flush();
 	}

Doc Comments +5 added lines, -2 removed lines

@@ -78,7 +78,7 @@ 
 
 	/**
 	 * @param $arr
-	 * @param $k
+	 * @param string $k
 	 *
 	 * @param string $default
 	 *
@@ -93,6 +93,9 @@ 
 	}
 
 
+	/**
+	 * @param string[] $arr
+	 */
 	public static function mustContains($data, $arr) {
 		if (!is_array($arr)) {
 			$arr = [$arr];
@@ -250,7 +253,7 @@ 
 
 
 	/**
-	 * @param $ident
+	 * @param string $ident
 	 *
 	 * @return mixed|string
 	 * @deprecated

lib/ShareByCircleProvider.php

Doc Comments +2 added lines, -2 removed lines

@@ -438,8 +438,8 @@
 
 	/**
 	 * @param string $userId
-	 * @param $shareType
-	 * @param Node $node
+	 * @param integer $shareType
+	 * @param Node|null $node
 	 * @param int $limit
 	 * @param int $offset
 	 *

Spacing +9 added lines, -9 removed lines

@@ -300,19 +300,19 @@ 
 	 */
 	private function createShare($share) {
 		$this->miscService->log(
-			'Creating share (1/4) - type: ' . $share->getShareType() . ' - token: '
-			. $share->getToken() . ' - type: ' . $share->getShareType() . ' - with: '
-			. $share->getSharedWith() . ' - permissions: ' . $share->getPermissions(), 0
+			'Creating share (1/4) - type: '.$share->getShareType().' - token: '
+			. $share->getToken().' - type: '.$share->getShareType().' - with: '
+			. $share->getSharedWith().' - permissions: '.$share->getPermissions(), 0
 		);
 
 		$qb = $this->getBaseInsertSql($share);
-		$this->miscService->log('Share creation (2/4) : ' . json_encode($qb->getSQL()), 0);
+		$this->miscService->log('Share creation (2/4) : '.json_encode($qb->getSQL()), 0);
 
 		$result = $qb->execute();
-		$this->miscService->log('Share creation result (3/4) : ' . json_encode($result), 0);
+		$this->miscService->log('Share creation result (3/4) : '.json_encode($result), 0);
 
 		$id = $qb->getLastInsertId();
-		$this->miscService->log('Share created ID (4/4) : ' . $id, 0);
+		$this->miscService->log('Share created ID (4/4) : '.$id, 0);
 
 		try {
 			$share->setId($id);
@@ -537,7 +537,7 @@ 
 	public function getShareByToken($token) {
 		$qb = $this->dbConnection->getQueryBuilder();
 
-		$this->miscService->log("Opening share by token '#" . $token . "'", 0);
+		$this->miscService->log("Opening share by token '#".$token."'", 0);
 
 		$cursor = $qb->select('*')
 					 ->from('share')
@@ -561,7 +561,7 @@ 
 			try {
 				$data = $this->getShareByPersonalToken($token);
 			} catch (Exception $e) {
-				$this->miscService->log("Share '#" . $token . "' not found.", 0);
+				$this->miscService->log("Share '#".$token."' not found.", 0);
 				throw new ShareNotFound('Share not found', $this->l10n->t('Could not find share'));
 			}
 		}
@@ -570,7 +570,7 @@ 
 			$share = $this->createShareObject($data);
 		} catch (InvalidShare $e) {
 			$this->miscService->log(
-				"Share Object '#" . $token . "' not created. " . json_encode($data), 0
+				"Share Object '#".$token."' not created. ".json_encode($data), 0
 			);
 			throw new ShareNotFound('Share not found', $this->l10n->t('Could not find share'));
 		}

lib/Service/FederatedLinkService.php

Spacing +1 added lines, -1 removed lines

@@ -217,7 +217,7 @@
 	 * @return string
 	 */
 	public function generateLinkRemoteURL($remote) {
-		return $this->configService->generateRemoteHost($remote) . self::REMOTE_URL_LINK;
+		return $this->configService->generateRemoteHost($remote).self::REMOTE_URL_LINK;
 	}
 
 

lib/Controller/FederatedController.php

Spacing +1 added lines, -1 removed lines

@@ -265,7 +265,7 @@
 	 * @return DataResponse
 	 */
 	private function federatedFail($reason) {
-		$this->miscService->log(0, 'federated fail: ' . $reason);
+		$this->miscService->log(0, 'federated fail: '.$reason);
 
 		return new DataResponse(
 			[

lib/Service/MembersService.php

Spacing +1 added lines, -1 removed lines

@@ -344,7 +344,7 @@
 			);
 		}
 
-		$tmpContact = $this->userId . ':' . $ident;
+		$tmpContact = $this->userId.':'.$ident;
 		$result = MiscService::getContactData($tmpContact);
 		if (empty($result)) {
 			throw new NoUserException($this->l10n->t("This contact is not available"));

Doc Comments +7 added lines, -7 removed lines

@@ -349,8 +349,8 @@ 
 	/**
 	 * Verify if a local account is valid.
 	 *
-	 * @param $ident
-	 * @param $type
+	 * @param string $ident
+	 * @param integer $type
 	 *
 	 * @param string $instance
 	 *
@@ -401,8 +401,8 @@ 
 	/**
 	 * Verify if a contact exist in current user address books.
 	 *
-	 * @param $ident
-	 * @param $type
+	 * @param string $ident
+	 * @param integer $type
 	 *
 	 * @throws NoUserException
 	 * @throws EmailAccountInvalidFormatException
@@ -494,8 +494,8 @@ 
 	 * Will return any data of a user related to a circle (as a Member). User can be a 'non-member'
 	 * Viewer needs to be at least Member of the Circle
 	 *
-	 * @param $circleId
-	 * @param $userId
+	 * @param string $circleId
+	 * @param string $userId
 	 * @param $type
 	 * @param bool $forceAll
 	 *
@@ -551,7 +551,7 @@ 
 	 * @param int $level
 	 * @param bool $force
 	 *
-	 * @return array
+	 * @return DeprecatedMember[]
 	 * @throws CircleDoesNotExistException
 	 * @throws CircleTypeNotValidException
 	 * @throws ConfigNoCircleAvailableException