Completed
Push — master ( c8832b...c655ce )
by Maxence
04:09
created
lib/Service/FederatedLinkService.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
 	 *
221 221
 	 * @param Circle $circle
222 222
 	 * @param FederatedLink $link
223
-	 * @param $status
223
+	 * @param integer $status
224 224
 	 *
225 225
 	 * @return bool
226 226
 	 */
@@ -278,8 +278,8 @@  discard block
 block discarded – undo
278 278
 
279 279
 
280 280
 	/**
281
-	 * @param $circleUniqueId
282
-	 * @param $remote
281
+	 * @param string $circleUniqueId
282
+	 * @param string $remote
283 283
 	 *
284 284
 	 * @return FederatedLink
285 285
 	 */
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
392 392
 	 *
393 393
 	 * Will parse the error reason returned by requestLink() and throw an Exception
394 394
 	 *
395
-	 * @param $reason
395
+	 * @param string $reason
396 396
 	 *
397 397
 	 * @throws Exception
398 398
 	 * @throws FederatedRemoteCircleDoesNotExistException
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -307,7 +307,7 @@  discard block
 block discarded – undo
307 307
 	 * @return string
308 308
 	 */
309 309
 	private function generateLinkRemoteURL($remote) {
310
-		return $this->configService->generateRemoteHost($remote) . Application::REMOTE_URL_LINK;
310
+		return $this->configService->generateRemoteHost($remote).Application::REMOTE_URL_LINK;
311 311
 	}
312 312
 
313 313
 
@@ -321,7 +321,7 @@  discard block
 block discarded – undo
321 321
 	 * @return boolean
322 322
 	 * @throws Exception
323 323
 	 */
324
-	private function requestLink(Circle $circle, FederatedLink &$link) {
324
+	private function requestLink(Circle $circle, FederatedLink & $link) {
325 325
 		$args = array_merge(self::generateLinkData($link), ['sourceName' => $circle->getName()]);
326 326
 
327 327
 		try {
@@ -368,7 +368,7 @@  discard block
 block discarded – undo
368 368
 	 *
369 369
 	 * @throws Exception
370 370
 	 */
371
-	private function eventOnRequestLink(Circle $circle, FederatedLink &$link, $status, $reason) {
371
+	private function eventOnRequestLink(Circle $circle, FederatedLink & $link, $status, $reason) {
372 372
 
373 373
 		switch ($status) {
374 374
 			case FederatedLink::STATUS_LINK_UP:
@@ -505,7 +505,7 @@  discard block
 block discarded – undo
505 505
 	 * @return bool
506 506
 	 * @throws Exception
507 507
 	 */
508
-	public function updateLinkRemote(FederatedLink &$link) {
508
+	public function updateLinkRemote(FederatedLink & $link) {
509 509
 
510 510
 		try {
511 511
 			$client = $this->clientService->newClient();
@@ -532,7 +532,7 @@  discard block
 block discarded – undo
532 532
 	 *
533 533
 	 * @throws Exception
534 534
 	 */
535
-	public function initiateLink(Circle $circle, FederatedLink &$link) {
535
+	public function initiateLink(Circle $circle, FederatedLink & $link) {
536 536
 
537 537
 		try {
538 538
 			$this->checkLinkRequestValidity($circle, $link);
@@ -615,7 +615,7 @@  discard block
 block discarded – undo
615 615
 	 * @param Circle $circle
616 616
 	 * @param FederatedLink $link
617 617
 	 */
618
-	private function checkUpdateLinkFromRemoteLinkRequestSent(Circle $circle, FederatedLink &$link) {
618
+	private function checkUpdateLinkFromRemoteLinkRequestSent(Circle $circle, FederatedLink & $link) {
619 619
 
620 620
 		if ($link->getStatus() !== FederatedLink::STATUS_REQUEST_SENT) {
621 621
 			return;
@@ -630,7 +630,7 @@  discard block
 block discarded – undo
630 630
 	 * @param Circle $circle
631 631
 	 * @param FederatedLink $link
632 632
 	 */
633
-	private function checkUpdateLinkFromRemoteLinkRequested(Circle $circle, FederatedLink &$link) {
633
+	private function checkUpdateLinkFromRemoteLinkRequested(Circle $circle, FederatedLink & $link) {
634 634
 
635 635
 		if ($link->getStatus() !== FederatedLink::STATUS_LINK_REQUESTED) {
636 636
 			return;
@@ -645,7 +645,7 @@  discard block
 block discarded – undo
645 645
 	 * @param Circle $circle
646 646
 	 * @param FederatedLink $link
647 647
 	 */
648
-	private function checkUpdateLinkFromRemoteLinkDown(Circle $circle, FederatedLink &$link) {
648
+	private function checkUpdateLinkFromRemoteLinkDown(Circle $circle, FederatedLink & $link) {
649 649
 
650 650
 		if ($link->getStatus() < FederatedLink::STATUS_LINK_DOWN) {
651 651
 			return;
Please login to merge, or discard this patch.