Nexendrie\Menu\ConditionCallback::isAllowed()

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	1

<?php
  public function isAllowed($parameter = null): bool {
    if(!is_callable($parameter)) {
      throw new \InvalidArgumentException("Method " . __METHOD__ . " expects callback as parameter.");
    }
    $result = call_user_func($parameter);

It seems like $parameter can also be of type null; however, parameter $callback of call_user_func() does only seem to accept callable, maybe add an additional type check?

    if(!is_bool($result)) {
      throw new \UnexpectedValueException("The callback for method " . __METHOD__ . " has to return boolean, " . gettype($result) . " returned.");

Line exceeds 120 characters; contains 146 characters

    }
    return $result;
  }
?>