Nexendrie\Menu\ConditionCallback

Complexity

Total Complexity

3

Size/Duplication

Total Lines	15
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	1	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	isAllowed()	0	9	3

<?php
declare(strict_types=1);

namespace Nexendrie\Menu;

/**
 * ConditionCallback
 *
 * @author Jakub Konečný
 */
final class ConditionCallback extends BaseCondition {
  /**
   * @param callable $parameter
   * @throws \InvalidArgumentException
   * @throws \UnexpectedValueException
   */
  public function isAllowed($parameter = null): bool {
    if(!is_callable($parameter)) {
      throw new \InvalidArgumentException("Method " . __METHOD__ . " expects callback as parameter.");
    }
    $result = call_user_func($parameter);

It seems like $parameter can also be of type null; however, parameter $callback of call_user_func() does only seem to accept callable, maybe add an additional type check?

    if(!is_bool($result)) {
      throw new \UnexpectedValueException("The callback for method " . __METHOD__ . " has to return boolean, " . gettype($result) . " returned.");

Line exceeds 120 characters; contains 146 characters

    }
    return $result;
  }
}
?>