Completed
Push — master ( ad0611...abd676 )
by Tom
09:08 queued 04:30
created
src/N98/Magento/Command/AbstractMagentoCommand.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
     /**
84 84
      * @param array $codeArgument
85 85
      * @param bool  $status
86
-     * @return bool
86
+     * @return boolean|null
87 87
      */
88 88
     protected function saveCacheStatus($codeArgument, $status)
89 89
     {
@@ -288,8 +288,8 @@  discard block
 block discarded – undo
288 288
     /**
289 289
      * brings locally cached repository up to date if it is missing the requested tag
290 290
      *
291
-     * @param $package
292
-     * @param $targetFolder
291
+     * @param PackageInterface $package
292
+     * @param string $targetFolder
293 293
      */
294 294
     protected function checkRepository($package, $targetFolder)
295 295
     {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
         if (!$silent) {
204 204
             $editionString = ($this->_magentoEnterprise ? ' (Enterprise Edition) ' : '');
205 205
             $output->writeln(
206
-                '<info>Found Magento '. $editionString . 'in folder "' . $this->_magentoRootFolder . '"</info>'
206
+                '<info>Found Magento ' . $editionString . 'in folder "' . $this->_magentoRootFolder . '"</info>'
207 207
             );
208 208
         }
209 209
 
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
         $preferSource = true
273 273
     ) {
274 274
         $dm = $this->getComposerDownloadManager($input, $output);
275
-        if (! $config instanceof PackageInterface) {
275
+        if (!$config instanceof PackageInterface) {
276 276
             $package = $this->createComposerPackageByConfig($config);
277 277
         } else {
278 278
             $package = $config;
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
                 escapeshellarg($targetFolder),
317 317
                 escapeshellarg($package->getSourceReference())
318 318
             );
319
-            $existingTag =  shell_exec($command);
319
+            $existingTag = shell_exec($command);
320 320
             if ($existingTag === $package->getSourceReference()) {
321 321
                 $command = sprintf('cd %s && hg pull', escapeshellarg($targetFolder));
322 322
                 shell_exec($command);
Please login to merge, or discard this patch.
src/N98/Magento/Command/Developer/Module/CreateCommand.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
     }
144 144
 
145 145
     /**
146
-     * @param $configBag
146
+     * @param ConfigBag $configBag
147 147
      */
148 148
     private function initConfigBagDefaultValues($configBag)
149 149
     {
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/SubCommand/InstallMagento.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -252,7 +252,7 @@
 block discarded – undo
252 252
     }
253 253
 
254 254
     /**
255
-     * @param array $installArgs
255
+     * @param string $installArgs
256 256
      *
257 257
      * @throws \Exception
258 258
      */
Please login to merge, or discard this patch.
src/N98/Magento/Command/Script/Repository/ScriptLoader.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@
 block discarded – undo
78 78
     /**
79 79
      * Reads the first line. If it's a comment return it.
80 80
      *
81
-     * @param $file
81
+     * @param string $file
82 82
      *
83 83
      * @return string
84 84
      */
Please login to merge, or discard this patch.
src/N98/Magento/Command/ScriptCommand.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
     /**
255 255
      * @param InputInterface $input
256 256
      * @param OutputInterface $output
257
-     * @param $commandString
257
+     * @param string $commandString
258 258
      * @throws \RuntimeException
259 259
      */
260 260
     protected function runMagerunCommand(InputInterface $input, OutputInterface $output, $commandString)
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
 
271 271
     /**
272 272
      * @param string $commandString
273
-     * @return mixed|string
273
+     * @return string
274 274
      */
275 275
     protected function _prepareShellCommand($commandString)
276 276
     {
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
 
321 321
     /**
322 322
      * @param $commandString
323
-     * @return mixed
323
+     * @return string
324 324
      */
325 325
     protected function _replaceScriptVars($commandString)
326 326
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@
 block discarded – undo
171 171
                 if (isset($parts[1])) {
172 172
                     $value = $parts[1];
173 173
                 }
174
-                $this->scriptVars['${' . $variable. '}'] = $value;
174
+                $this->scriptVars['${' . $variable . '}'] = $value;
175 175
             }
176 176
         }
177 177
     }
Please login to merge, or discard this patch.
src/N98/Magento/Command/SubCommand/SubCommandInterface.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -10,21 +10,25 @@  discard block
 block discarded – undo
10 10
 {
11 11
     /**
12 12
      * @param ConfigBag $config
13
+     * @return void
13 14
      */
14 15
     public function setConfig(ConfigBag $config);
15 16
 
16 17
     /**
17 18
      * @param array $commandConfig
19
+     * @return void
18 20
      */
19 21
     public function setCommandConfig(array $commandConfig);
20 22
 
21 23
     /**
22 24
      * @param InputInterface $input
25
+     * @return void
23 26
      */
24 27
     public function setInput(InputInterface $input);
25 28
 
26 29
     /**
27 30
      * @param OutputInterface $output
31
+     * @return void
28 32
      */
29 33
     public function setOutput(OutputInterface $output);
30 34
 
@@ -35,6 +39,7 @@  discard block
 block discarded – undo
35 39
 
36 40
     /**
37 41
      * @param AbstractMagentoCommand $command
42
+     * @return void
38 43
      */
39 44
     public function setCommand(AbstractMagentoCommand $command);
40 45
 
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/Cron/RunCommand.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@
 block discarded – undo
97 97
      * @param InputInterface $input
98 98
      * @param OutputInterface $output
99 99
      * @param array $jobs
100
-     * @return mixed
100
+     * @return string
101 101
      * @throws \InvalidArgumentException
102 102
      * @throws \Exception
103 103
      */
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 
49 49
         $jobConfig = $this->getJobConfig($jobCode);
50 50
 
51
-        if (empty($jobCode)|| !isset($jobConfig['instance'])) {
51
+        if (empty($jobCode) || !isset($jobConfig['instance'])) {
52 52
             throw new \InvalidArgumentException('No job config found!');
53 53
         }
54 54
 
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
     protected function askJobCode(InputInterface $input, OutputInterface $output, $jobs)
107 107
     {
108 108
         foreach ($jobs as $key => $job) {
109
-            $question[] = '<comment>[' . ($key+1) . ']</comment> ' . $job['Job'] . PHP_EOL;
109
+            $question[] = '<comment>[' . ($key + 1) . ']</comment> ' . $job['Job'] . PHP_EOL;
110 110
         }
111 111
         $question[] = '<question>Please select job: </question>' . PHP_EOL;
112 112
 
Please login to merge, or discard this patch.
src/N98/Magento/Framework/App/Magerun.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
      *
52 52
      * @param Bootstrap $bootstrap
53 53
      * @param \Exception $exception
54
-     * @return bool
54
+     * @return boolean|null
55 55
      */
56 56
     public function catchException(Bootstrap $bootstrap, \Exception $exception)
57 57
     {
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/DatabaseHelper.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use PDOException;
7 7
 use RuntimeException;
8 8
 use Symfony\Component\Console\Helper\Helper as AbstractHelper;
9
-use N98\Magento\Application;
10 9
 use Symfony\Component\Console\Output\NullOutput;
11 10
 use Symfony\Component\Console\Output\OutputInterface;
12 11
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -298,7 +298,7 @@
 block discarded – undo
298 298
                         $definitions,
299 299
                         $resolved
300 300
                     );
301
-                    $resolvedList    = array_merge($resolvedList, $tables);
301
+                    $resolvedList = array_merge($resolvedList, $tables);
302 302
                 }
303 303
                 continue;
304 304
             }
Please login to merge, or discard this patch.