Completed
Push — develop ( a787a3...20155f )
by Tom
04:25
created
src/N98/Magento/Command/SubCommand/SubCommandInterface.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -10,21 +10,25 @@  discard block
 block discarded – undo
10 10
 {
11 11
     /**
12 12
      * @param ConfigBag $config
13
+     * @return void
13 14
      */
14 15
     public function setConfig(ConfigBag $config);
15 16
 
16 17
     /**
17 18
      * @param array $commandConfig
19
+     * @return void
18 20
      */
19 21
     public function setCommandConfig(array $commandConfig);
20 22
 
21 23
     /**
22 24
      * @param InputInterface $input
25
+     * @return void
23 26
      */
24 27
     public function setInput(InputInterface $input);
25 28
 
26 29
     /**
27 30
      * @param OutputInterface $output
31
+     * @return void
28 32
      */
29 33
     public function setOutput(OutputInterface $output);
30 34
 
@@ -35,6 +39,7 @@  discard block
 block discarded – undo
35 39
 
36 40
     /**
37 41
      * @param AbstractMagentoCommand $command
42
+     * @return void
38 43
      */
39 44
     public function setCommand(AbstractMagentoCommand $command);
40 45
 
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/Cron/RunCommand.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@
 block discarded – undo
97 97
      * @param InputInterface $input
98 98
      * @param OutputInterface $output
99 99
      * @param array $jobs
100
-     * @return mixed
100
+     * @return string
101 101
      * @throws \InvalidArgumentException
102 102
      * @throws \Exception
103 103
      */
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 
49 49
         $jobConfig = $this->getJobConfig($jobCode);
50 50
 
51
-        if (empty($jobCode)|| !isset($jobConfig['instance'])) {
51
+        if (empty($jobCode) || !isset($jobConfig['instance'])) {
52 52
             throw new \InvalidArgumentException('No job config found!');
53 53
         }
54 54
 
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
     protected function askJobCode(InputInterface $input, OutputInterface $output, $jobs)
107 107
     {
108 108
         foreach ($jobs as $key => $job) {
109
-            $question[] = '<comment>[' . ($key+1) . ']</comment> ' . $job['Job'] . PHP_EOL;
109
+            $question[] = '<comment>[' . ($key + 1) . ']</comment> ' . $job['Job'] . PHP_EOL;
110 110
         }
111 111
         $question[] = '<question>Please select job: </question>' . PHP_EOL;
112 112
 
Please login to merge, or discard this patch.
src/N98/Magento/Framework/App/Magerun.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
      *
52 52
      * @param Bootstrap $bootstrap
53 53
      * @param \Exception $exception
54
-     * @return bool
54
+     * @return boolean|null
55 55
      */
56 56
     public function catchException(Bootstrap $bootstrap, \Exception $exception)
57 57
     {
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/DatabaseHelper.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use PDOException;
7 7
 use RuntimeException;
8 8
 use Symfony\Component\Console\Helper\Helper as AbstractHelper;
9
-use N98\Magento\Application;
10 9
 use Symfony\Component\Console\Output\NullOutput;
11 10
 use Symfony\Component\Console\Output\OutputInterface;
12 11
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -298,7 +298,7 @@
 block discarded – undo
298 298
                         $definitions,
299 299
                         $resolved
300 300
                     );
301
-                    $resolvedList    = array_merge($resolvedList, $tables);
301
+                    $resolvedList = array_merge($resolvedList, $tables);
302 302
                 }
303 303
                 continue;
304 304
             }
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/MagentoHelper.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace N98\Util\Console\Helper;
4 4
 
5 5
 use N98\Magento\Application;
6
-use N98\Util\BinaryString;
7 6
 use RuntimeException;
8 7
 use Symfony\Component\Console\Helper\Helper as AbstractHelper;
9 8
 use Symfony\Component\Console\Input\ArgvInput;
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -387,6 +387,9 @@
 block discarded – undo
387 387
         return $application;
388 388
     }
389 389
 
390
+    /**
391
+     * @param string $configFileName
392
+     */
390 393
     private function addBaseConfig($root, $configFileName)
391 394
     {
392 395
         $configFile = $root . '/' . $configFileName;
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/ParameterHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -202,7 +202,7 @@
 block discarded – undo
202 202
      * @param OutputInterface                                $output
203 203
      * @param string                                         $name
204 204
      * @param string                                         $value
205
-     * @param Constraints\Collection|Constraint|Constraint[] $constraints The constraint(s) to validate against.
205
+     * @param Constraints\Collection $constraints The constraint(s) to validate against.
206 206
      *
207 207
      * @return mixed
208 208
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use Symfony\Component\Console\Helper\Helper as AbstractHelper;
10 10
 use Symfony\Component\Console\Output\OutputInterface;
11 11
 use Symfony\Component\Console\Input\InputInterface;
12
-use Symfony\Component\Console\Output\Output;
13 12
 use Symfony\Component\Translation\Translator;
14 13
 use Symfony\Component\Validator\Constraint;
15 14
 use Symfony\Component\Validator\Validator;
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/Table/Renderer/RendererInterface.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -9,6 +9,7 @@
 block discarded – undo
9 9
     /**
10 10
      * @param OutputInterface $output
11 11
      * @param array $rows
12
+     * @return void
12 13
      */
13 14
     public function render(OutputInterface $output, array $rows);
14 15
 }
Please login to merge, or discard this patch.
src/N98/View/PhpView.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 
17 17
     /**
18 18
      * @param string $template
19
-     * @return Php
19
+     * @return PhpView
20 20
      */
21 21
     public function setTemplate($template)
22 22
     {
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
      * @param string $key
30 30
      * @param mixed $value
31 31
      *
32
-     * @return Php
32
+     * @return PhpView
33 33
      */
34 34
     public function assign($key, $value)
35 35
     {
Please login to merge, or discard this patch.
src/N98/View/View.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -4,6 +4,13 @@
 block discarded – undo
4 4
 
5 5
 interface View
6 6
 {
7
+    /**
8
+     * @return PhpView
9
+     */
7 10
     public function assign($key, $value);
11
+
12
+    /**
13
+     * @return string
14
+     */
8 15
     public function render();
9 16
 }
Please login to merge, or discard this patch.