Completed
Pull Request — develop (#182)
by Tom
04:45
created
src/N98/Magento/Command/Installer/SubCommand/PreCheckPhp.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -44,8 +44,8 @@
 block discarded – undo
44 44
     {
45 45
         if (extension_loaded('xdebug') && xdebug_is_enabled() && ini_get('xdebug.max_nesting_level') < 200) {
46 46
             $errorMessage = 'Please change PHP ini setting "xdebug.max_nesting_level". '
47
-                          . 'Please change it to a value >= 200. '
48
-                          . 'Your current value is ' . ini_get('xdebug.max_nesting_level');
47
+                            . 'Please change it to a value >= 200. '
48
+                            . 'Your current value is ' . ini_get('xdebug.max_nesting_level');
49 49
             throw new \RuntimeException($errorMessage);
50 50
         }
51 51
     }
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
      *
52 52
      * @param Bootstrap $bootstrap
53 53
      * @param \Exception $exception
54
-     * @return bool
54
+     * @return boolean|null
55 55
      */
56 56
     public function catchException(Bootstrap $bootstrap, \Exception $exception)
57 57
     {
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/SubCommand/SetDirectoryPermissions.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -28,10 +28,10 @@
 block discarded – undo
28 28
             @chmod($varCacheFolder, 0777);
29 29
 
30 30
             $mediaFolder = $installationFolder
31
-                         . DIRECTORY_SEPARATOR
32
-                         . 'pub'
33
-                         . DIRECTORY_SEPARATOR
34
-                         . 'media';
31
+                            . DIRECTORY_SEPARATOR
32
+                            . 'pub'
33
+                            . DIRECTORY_SEPARATOR
34
+                            . 'media';
35 35
             if (!is_dir($mediaFolder)) {
36 36
                 @mkdir($mediaFolder);
37 37
             }
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
      *
52 52
      * @param Bootstrap $bootstrap
53 53
      * @param \Exception $exception
54
-     * @return bool
54
+     * @return boolean|null
55 55
      */
56 56
     public function catchException(Bootstrap $bootstrap, \Exception $exception)
57 57
     {
Please login to merge, or discard this patch.
src/N98/Magento/Command/SelfUpdateCommand.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
     protected function execute(InputInterface $input, OutputInterface $output)
47 47
     {
48 48
         $localFilename = realpath($_SERVER['argv'][0]) ?: $_SERVER['argv'][0];
49
-        $tempFilename = dirname($localFilename) . '/' . basename($localFilename, '.phar').'-temp.phar';
49
+        $tempFilename = dirname($localFilename) . '/' . basename($localFilename, '.phar') . '-temp.phar';
50 50
 
51 51
         // check for permissions in local filesystem before start connection process
52 52
         if (!is_writable($tempDirectory = dirname($tempFilename))) {
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
                 if (!$e instanceof \UnexpectedValueException && !$e instanceof \PharException) {
129 129
                     throw $e;
130 130
                 }
131
-                $output->writeln('<error>The download is corrupted ('.$e->getMessage().').</error>');
131
+                $output->writeln('<error>The download is corrupted (' . $e->getMessage() . ').</error>');
132 132
                 $output->writeln('<error>Please re-run the self-update command to try again.</error>');
133 133
             }
134 134
         } else {
Please login to merge, or discard this patch.
src/N98/Magento/Command/SubCommand/SubCommandFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
         }
75 75
 
76 76
         $subCommand = new $className();
77
-        if (! $subCommand instanceof SubCommandInterface) {
77
+        if (!$subCommand instanceof SubCommandInterface) {
78 78
             throw new \InvalidArgumentException('Subcommand must implement SubCommandInterface.');
79 79
         }
80 80
 
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/Cron/HistoryCommand.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,8 +47,7 @@
 block discarded – undo
47 47
         }
48 48
 
49 49
         $timezone = $input->getOption('timezone')
50
-            ? $input->getOption('timezone') :
51
-            $this->_scopeConfig->getValue('general/locale/timezone');
50
+            ? $input->getOption('timezone') : $this->_scopeConfig->getValue('general/locale/timezone');
52 51
 
53 52
         if (!$input->getOption('format')) {
54 53
             $output->writeln('<info>Times shown in <comment>' . $timezone . '</comment></info>');
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/InfoCommand.php 2 patches
Indentation   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -151,32 +151,32 @@
 block discarded – undo
151 151
     protected function addProductCount()
152 152
     {
153 153
         $this->infos['Product Count'] = $this->productFactory
154
-                                             ->create()
155
-                                             ->getCollection()
156
-                                             ->getSize();
154
+                                                ->create()
155
+                                                ->getCollection()
156
+                                                ->getSize();
157 157
     }
158 158
 
159 159
     protected function addCustomerCount()
160 160
     {
161 161
         $this->infos['Customer Count'] = $this->customerFactory->create()
162
-                                              ->getCollection()
163
-                                              ->getSize();
162
+                                                ->getCollection()
163
+                                                ->getSize();
164 164
     }
165 165
 
166 166
     protected function addCategoryCount()
167 167
     {
168 168
         $this->infos['Category Count'] = $this->categoryFactory
169
-                                              ->create()
170
-                                              ->getCollection()
171
-                                              ->getSize();
169
+                                                ->create()
170
+                                                ->getCollection()
171
+                                                ->getSize();
172 172
     }
173 173
 
174 174
     protected function addAttributeCount()
175 175
     {
176 176
         $this->infos['Attribute Count'] = $this->attributeFactory
177
-                                               ->create()
178
-                                               ->getCollection()
179
-                                               ->getSize();
177
+                                                ->create()
178
+                                                ->getCollection()
179
+                                                ->getSize();
180 180
     }
181 181
 
182 182
     protected function addCacheInfos()
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@
 block discarded – undo
103 103
 
104 104
     public function hasInfo()
105 105
     {
106
-        return ! empty($this->infos);
106
+        return !empty($this->infos);
107 107
     }
108 108
 
109 109
     public function getInfo($key = null)
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/ComposerHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
         $process = ProcessBuilder::create($commandArgs)->getProcess();
30 30
         $process->setInput($this->input);
31 31
         $process->setTimeout(3600);
32
-        $process->run(function ($type, $buffer) use ($silent) {
32
+        $process->run(function($type, $buffer) use ($silent) {
33 33
             if ($silent) {
34 34
                 return;
35 35
             }
Please login to merge, or discard this patch.
src/N98/Util/Console/Helper/InjectionHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
             $argumentsToInject[] = $objectManager->get($parameter[1]);
33 33
         }
34 34
 
35
-        call_user_func_array([ $object, $methodName ], $argumentsToInject);
35
+        call_user_func_array([$object, $methodName], $argumentsToInject);
36 36
     }
37 37
 
38 38
     /**
Please login to merge, or discard this patch.
tests/N98/Magento/Command/Cache/EnableCommandTest.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,9 +1,9 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @todo    writing unit tests for toggling caches is complicated because environments differ
4
- *          touching caches changes state and will result in different test result second time
5
- *          solutions: disabling/enabling, faking&mocking or having one defined test environment
6
- */
3
+     * @todo    writing unit tests for toggling caches is complicated because environments differ
4
+     *          touching caches changes state and will result in different test result second time
5
+     *          solutions: disabling/enabling, faking&mocking or having one defined test environment
6
+     */
7 7
 namespace N98\Magento\Command\Cache;
8 8
 
9 9
 use Symfony\Component\Console\Tester\CommandTester;
Please login to merge, or discard this patch.