Completed
Pull Request — develop (#182)
by Tom
04:45
created
src/N98/Magento/Application.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -319,7 +319,7 @@
 block discarded – undo
319 319
      * @TODO Move logic into "EventSubscriber"
320 320
      *
321 321
      * @param OutputInterface $output
322
-     * @return bool
322
+     * @return null|false
323 323
      */
324 324
     public function checkVarDir(OutputInterface $output)
325 325
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
 use Symfony\Component\Console\Input\InputInterface;
21 21
 use Symfony\Component\Console\Input\InputOption;
22 22
 use Symfony\Component\Console\Output\ConsoleOutput;
23
-use Symfony\Component\Console\Output\NullOutput;
24 23
 use Symfony\Component\Console\Output\OutputInterface;
25 24
 use Symfony\Component\EventDispatcher\EventDispatcher;
26 25
 use UnexpectedValueException;
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/Url/ListCommand.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
      *
71 71
      * @param StoreManager $storeManager
72 72
      * @param Category $sitemapCategoryCollection
73
-     * @param Product $sitmapProductCollection
73
+     * @param Product $sitemapProductCollection
74 74
      * @param Page $sitemapPageCollection
75 75
      */
76 76
     public function inject(
@@ -146,7 +146,6 @@  discard block
 block discarded – undo
146 146
     }
147 147
 
148 148
     /**
149
-     * @param string $resourceModel
150 149
      * @param string $linkBaseUrl
151 150
      * @param string $storeId
152 151
      * @param array  $urls
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/SubCommand/CreateDatabase.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
      */
25 25
     public function execute()
26 26
     {
27
-        $this->notEmptyCallback = function ($input) {
27
+        $this->notEmptyCallback = function($input) {
28 28
             if (empty($input)) {
29 29
                 throw new \InvalidArgumentException('Please enter a value');
30 30
             }
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/SubCommand/InstallMagento.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
      */
24 24
     public function execute()
25 25
     {
26
-        $this->notEmptyCallback = function ($input) {
26
+        $this->notEmptyCallback = function($input) {
27 27
             if (empty($input)) {
28 28
                 throw new \InvalidArgumentException('Please enter a value');
29 29
             }
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
             $defaults['admin-email']
127 127
         );
128 128
 
129
-        $validateBaseUrl = function ($url) {
129
+        $validateBaseUrl = function($url) {
130 130
             if (!preg_match('|^http(s)?://[a-z0-9-]+(.[a-z0-9-]+)*(:[0-9]+)?(/.*)?$|i', $url)) {
131 131
                 throw new \InvalidArgumentException('Please enter a valid URL');
132 132
             }
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/SubCommand/DownloadMagento.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
 
62 62
             $process->setTimeout(86400);
63 63
             $process->start();
64
-            $process->wait(function ($type, $buffer) {
64
+            $process->wait(function($type, $buffer) {
65 65
                 $this->output->write($buffer, false, OutputInterface::OUTPUT_RAW);
66 66
             });
67 67
         } catch (\Exception $e) {
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
             $username = $dialog->askAndValidate(
138 138
                 $output,
139 139
                 '<comment>Please enter your public key: </comment>',
140
-                function ($value) {
140
+                function($value) {
141 141
                     if ('' === trim($value)) {
142 142
                         throw new \Exception('The private key (auth token) can not be empty');
143 143
                     }
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
             $password = $dialog->askHiddenResponseAndValidate(
153 153
                 $output,
154 154
                 '<comment>Please enter your private key: </comment>',
155
-                function ($value) {
155
+                function($value) {
156 156
                     if ('' === trim($value)) {
157 157
                         throw new \Exception('The private key (auth token) can not be empty');
158 158
                     }
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/SubCommand/SelectMagentoVersion.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
             $type = $this->getCommand()->getHelper('dialog')->askAndValidate(
35 35
                 $this->output,
36 36
                 $question,
37
-                function ($typeInput) use ($commandConfig) {
37
+                function($typeInput) use ($commandConfig) {
38 38
                     if (!in_array($typeInput, range(1, count($this->commandConfig['magento-packages'])))) {
39 39
                         throw new \InvalidArgumentException('Invalid type');
40 40
                     }
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
             } elseif ($this->input->getOption('magentoVersionByName')) {
51 51
                 foreach ($this->commandConfig['magento-packages'] as $key => $package) {
52 52
                     if ($package['name'] == $this->input->getOption('magentoVersionByName')) {
53
-                        $type = $key+1;
53
+                        $type = $key + 1;
54 54
                         break;
55 55
                     }
56 56
                 }
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/SubCommand/ChooseInstallationFolder.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
     public function execute()
13 13
     {
14 14
         $input = $this->input;
15
-        $validateInstallationFolder = function ($folderName) use ($input) {
15
+        $validateInstallationFolder = function($folderName) use ($input) {
16 16
             $folderName = rtrim(trim($folderName, ' '), '/');
17 17
             if (substr($folderName, 0, 1) == '.') {
18 18
                 $cwd = \getcwd();
Please login to merge, or discard this patch.
src/N98/Magento/Command/AbstractMagentoCommand.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
         if (!$silent) {
204 204
             $editionString = ($this->_magentoEnterprise ? ' (Enterprise Edition) ' : '');
205 205
             $output->writeln(
206
-                '<info>Found Magento '. $editionString . 'in folder "' . $this->_magentoRootFolder . '"</info>'
206
+                '<info>Found Magento ' . $editionString . 'in folder "' . $this->_magentoRootFolder . '"</info>'
207 207
             );
208 208
         }
209 209
 
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
         $preferSource = true
273 273
     ) {
274 274
         $dm = $this->getComposerDownloadManager($input, $output);
275
-        if (! $config instanceof PackageInterface) {
275
+        if (!$config instanceof PackageInterface) {
276 276
             $package = $this->createComposerPackageByConfig($config);
277 277
         } else {
278 278
             $package = $config;
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
                 escapeshellarg($targetFolder),
317 317
                 escapeshellarg($package->getSourceReference())
318 318
             );
319
-            $existingTag =  shell_exec($command);
319
+            $existingTag = shell_exec($command);
320 320
             if ($existingTag === $package->getSourceReference()) {
321 321
                 $command = sprintf('cd %s && hg pull', escapeshellarg($targetFolder));
322 322
                 shell_exec($command);
Please login to merge, or discard this patch.
Magento/Command/Developer/Module/Create/SubCommand/CreateModuleFolders.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -34,28 +34,28 @@
 block discarded – undo
34 34
         $config->setString('moduleDirectory', $moduleDir);
35 35
 
36 36
         mkdir($moduleDir, 0777, true);
37
-        $this->output->writeln('<info>Created directory: <comment>' .  $moduleDir .'<comment></info>');
37
+        $this->output->writeln('<info>Created directory: <comment>' . $moduleDir . '<comment></info>');
38 38
 
39 39
         // Add etc folder
40 40
         mkdir($moduleDir . '/etc');
41
-        $this->output->writeln('<info>Created directory: <comment>' .  $moduleDir .'/etc<comment></info>');
41
+        $this->output->writeln('<info>Created directory: <comment>' . $moduleDir . '/etc<comment></info>');
42 42
 
43 43
         // Add blocks folder
44 44
         if ($config->getBool('shouldAddBlocks')) {
45 45
             mkdir($moduleDir . '/Block');
46
-            $this->output->writeln('<info>Created directory: <comment>' .  $moduleDir . '/Block' .'<comment></info>');
46
+            $this->output->writeln('<info>Created directory: <comment>' . $moduleDir . '/Block' . '<comment></info>');
47 47
         }
48 48
 
49 49
         // Add helpers folder
50 50
         if ($config->getBool('shouldAddHelpers')) {
51 51
             mkdir($moduleDir . '/Helper');
52
-            $this->output->writeln('<info>Created directory: <comment>' .  $moduleDir . '/Helper' .'<comment></info>');
52
+            $this->output->writeln('<info>Created directory: <comment>' . $moduleDir . '/Helper' . '<comment></info>');
53 53
         }
54 54
 
55 55
         // Add models folder
56 56
         if ($config->getBool('shouldAddModels')) {
57 57
             mkdir($moduleDir . '/Model');
58
-            $this->output->writeln('<info>Created directory: <comment>' .  $moduleDir . '/Model' .'<comment></info>');
58
+            $this->output->writeln('<info>Created directory: <comment>' . $moduleDir . '/Model' . '<comment></info>');
59 59
         }
60 60
 
61 61
         // Create SQL and Data folder
Please login to merge, or discard this patch.