Completed
Pull Request — develop (#813)
by Robbie
04:26
created
src/N98/Magento/Command/System/Cron/AbstractCronCommand.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
     /**
56 56
      * Get job configuration from XML and database. Expression priority is given to the database.
57 57
      *
58
-     * @return Traversable|Mage_Core_Model_Config_Element[]
58
+     * @return AppendIterator
59 59
      */
60 60
     private function getJobConfigElements()
61 61
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
         $expr = null;
41 41
 
42 42
         if (isset($job->schedule->config_path)) {
43
-            $expr = Mage::getStoreConfig((string) $job->schedule->config_path);
43
+            $expr = Mage::getStoreConfig((string)$job->schedule->config_path);
44 44
         } elseif (isset($job->schedule->cron_expr)) {
45 45
             $expr = $job->schedule->cron_expr;
46 46
         }
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/Setup/AbstractSetupCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
         $resources      = \Mage::getConfig()->getNode('global/resources')->children();
27 27
 
28 28
         foreach ($resources as $resName => $resource) {
29
-            $modName = (string) $resource->setup->module;
29
+            $modName = (string)$resource->setup->module;
30 30
 
31 31
             if ($modName == $moduleName) {
32 32
                 $moduleSetups[$resName] = $resource;
Please login to merge, or discard this patch.
src/bootstrap.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@
 block discarded – undo
1 1
 <?php
2 2
 
3 3
 if (!class_exists('N98\MagerunBootstrap')) {
4
-    require_once __DIR__ . '/N98/MagerunBootstrap.php';
4
+    require_once __DIR__.'/N98/MagerunBootstrap.php';
5 5
 }
6 6
 
7 7
 try {
Please login to merge, or discard this patch.
src/N98/Magento/Application.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
 
258 258
         // Twig
259 259
         $twigBaseDirs = array(
260
-            __DIR__ . '/../../../res/twig'
260
+            __DIR__.'/../../../res/twig'
261 261
         );
262 262
         if (isset($this->config['twig']['baseDirs']) && is_array($this->config['twig']['baseDirs'])) {
263 263
             $twigBaseDirs = array_merge(array_reverse($this->config['twig']['baseDirs']), $twigBaseDirs);
@@ -409,7 +409,7 @@  discard block
 block discarded – undo
409 409
      */
410 410
     public function checkVarDir(OutputInterface $output)
411 411
     {
412
-        $tempVarDir = sys_get_temp_dir() . DIRECTORY_SEPARATOR . 'magento' . DIRECTORY_SEPARATOR . 'var';
412
+        $tempVarDir = sys_get_temp_dir().DIRECTORY_SEPARATOR.'magento'.DIRECTORY_SEPARATOR.'var';
413 413
         if (!OutputInterface::VERBOSITY_NORMAL <= $output->getVerbosity() && !is_dir($tempVarDir)) {
414 414
             return;
415 415
         }
@@ -417,7 +417,7 @@  discard block
 block discarded – undo
417 417
         $this->detectMagento(null, $output);
418 418
         /* If magento is not installed yet, don't check */
419 419
         if ($this->_magentoRootFolder === null
420
-            || !file_exists($this->_magentoRootFolder . '/app/etc/local.xml')
420
+            || !file_exists($this->_magentoRootFolder.'/app/etc/local.xml')
421 421
         ) {
422 422
             return;
423 423
         }
@@ -444,9 +444,9 @@  discard block
 block discarded – undo
444 444
             $output->writeln(array(
445 445
                 sprintf('<warning>Fallback folder %s is used in n98-magerun</warning>', $tempVarDir),
446 446
                 '',
447
-                'n98-magerun is using the fallback folder. If there is another folder configured for Magento, this ' .
447
+                'n98-magerun is using the fallback folder. If there is another folder configured for Magento, this '.
448 448
                 'can cause serious problems.',
449
-                'Please refer to https://github.com/netz98/n98-magerun/wiki/File-system-permissions ' .
449
+                'Please refer to https://github.com/netz98/n98-magerun/wiki/File-system-permissions '.
450 450
                 'for more information.',
451 451
                 '',
452 452
             ));
@@ -454,9 +454,9 @@  discard block
 block discarded – undo
454 454
             $output->writeln(array(
455 455
                 sprintf('<warning>Folder %s found, but not used in n98-magerun</warning>', $tempVarDir),
456 456
                 '',
457
-                "This might cause serious problems. n98-magerun is using the configured var-folder " .
457
+                "This might cause serious problems. n98-magerun is using the configured var-folder ".
458 458
                 "<comment>$currentVarDir</comment>",
459
-                'Please refer to https://github.com/netz98/n98-magerun/wiki/File-system-permissions ' .
459
+                'Please refer to https://github.com/netz98/n98-magerun/wiki/File-system-permissions '.
460 460
                 'for more information.',
461 461
                 '',
462 462
             ));
@@ -491,12 +491,12 @@  discard block
 block discarded – undo
491 491
      */
492 492
     public function getHelp()
493 493
     {
494
-        return self::$logo . parent::getHelp();
494
+        return self::$logo.parent::getHelp();
495 495
     }
496 496
 
497 497
     public function getLongVersion()
498 498
     {
499
-        return parent::getLongVersion() . ' by <info>netz98 new media GmbH</info>';
499
+        return parent::getLongVersion().' by <info>netz98 new media GmbH</info>';
500 500
     }
501 501
 
502 502
     /**
@@ -760,7 +760,7 @@  discard block
 block discarded – undo
760 760
 
761 761
         if (!empty($definedRootDir)) {
762 762
             if ($definedRootDir[0] == '~') {
763
-                $definedRootDir = OperatingSystem::getHomeDir() . substr($definedRootDir, 1);
763
+                $definedRootDir = OperatingSystem::getHomeDir().substr($definedRootDir, 1);
764 764
             }
765 765
 
766 766
             $folder = realpath($definedRootDir);
@@ -783,7 +783,7 @@  discard block
 block discarded – undo
783 783
             // Create a new AutoloadRestorer to capture currenjt auto-öpaders
784 784
             $restorer = new AutoloadRestorer();
785 785
             // require app/Mage.php from Magento in a function of it's own to have it's own variable scope
786
-            $this->requireOnce($this->_magentoRootFolder . '/app/Mage.php');
786
+            $this->requireOnce($this->_magentoRootFolder.'/app/Mage.php');
787 787
             // Restore auto-loaders that might be removed by extensions that overwrite Varien/Autoload
788 788
             $restorer->restore();
789 789
         }
Please login to merge, or discard this patch.
src/N98/Magento/Application/ConfigurationLoader.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
     protected function loadDistConfig($initConfig)
159 159
     {
160 160
         if ($this->_distConfig == null) {
161
-            $this->_distConfig = Yaml::parse(__DIR__ . '/../../../../config.yaml');
161
+            $this->_distConfig = Yaml::parse(__DIR__.'/../../../../config.yaml');
162 162
         }
163 163
         if (OutputInterface::VERBOSITY_DEBUG <= $this->_output->getVerbosity()) {
164 164
             $this->_output->writeln('<debug>Load dist config</debug>');
@@ -179,15 +179,15 @@  discard block
 block discarded – undo
179 179
     {
180 180
         if ($this->_systemConfig == null) {
181 181
             if (OperatingSystem::isWindows()) {
182
-                $systemWideConfigFile = getenv('WINDIR') . DIRECTORY_SEPARATOR . $this->_customConfigFilename;
182
+                $systemWideConfigFile = getenv('WINDIR').DIRECTORY_SEPARATOR.$this->_customConfigFilename;
183 183
             } else {
184
-                $systemWideConfigFile = '/etc/' . $this->_customConfigFilename;
184
+                $systemWideConfigFile = '/etc/'.$this->_customConfigFilename;
185 185
             }
186 186
 
187 187
             if ($systemWideConfigFile && file_exists($systemWideConfigFile)) {
188 188
                 if (OutputInterface::VERBOSITY_DEBUG <= $this->_output->getVerbosity()) {
189 189
                     $this->_output->writeln(
190
-                        '<debug>Load system config <comment>' . $systemWideConfigFile . '</comment></debug>'
190
+                        '<debug>Load system config <comment>'.$systemWideConfigFile.'</comment></debug>'
191 191
                     );
192 192
                 }
193 193
                 $this->_systemConfig = Yaml::parse($systemWideConfigFile);
@@ -217,12 +217,12 @@  discard block
 block discarded – undo
217 217
             $customFilename = $this->_customConfigFilename;
218 218
             $customName = pathinfo($customFilename, PATHINFO_FILENAME);
219 219
             if (OperatingSystem::isWindows()) {
220
-                $config['plugin']['folders'][] = getenv('WINDIR') . '/' . $customName . '/modules';
221
-                $config['plugin']['folders'][] = OperatingSystem::getHomeDir() . '/' . $customName . '/modules';
220
+                $config['plugin']['folders'][] = getenv('WINDIR').'/'.$customName.'/modules';
221
+                $config['plugin']['folders'][] = OperatingSystem::getHomeDir().'/'.$customName.'/modules';
222 222
             } else {
223
-                $config['plugin']['folders'][] = OperatingSystem::getHomeDir() . '/.' . $customName . '/modules';
223
+                $config['plugin']['folders'][] = OperatingSystem::getHomeDir().'/.'.$customName.'/modules';
224 224
             }
225
-            $config['plugin']['folders'][] = $magentoRootFolder . '/lib/' . $customName . '/modules';
225
+            $config['plugin']['folders'][] = $magentoRootFolder.'/lib/'.$customName.'/modules';
226 226
             foreach ($config['plugin']['folders'] as $folder) {
227 227
                 if (is_dir($folder)) {
228 228
                     $moduleBaseFolders[] = $folder;
@@ -305,9 +305,9 @@  discard block
 block discarded – undo
305 305
             $this->_userConfig = array();
306 306
             $homeDirectory = OperatingSystem::getHomeDir();
307 307
             if (OperatingSystem::isWindows()) {
308
-                $personalConfigFile = $homeDirectory . DIRECTORY_SEPARATOR . $this->_customConfigFilename;
308
+                $personalConfigFile = $homeDirectory.DIRECTORY_SEPARATOR.$this->_customConfigFilename;
309 309
             } else {
310
-                $personalConfigFile = $homeDirectory . DIRECTORY_SEPARATOR . '.' . $this->_customConfigFilename;
310
+                $personalConfigFile = $homeDirectory.DIRECTORY_SEPARATOR.'.'.$this->_customConfigFilename;
311 311
             }
312 312
 
313 313
             if ($homeDirectory && file_exists($personalConfigFile)) {
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
         if ($this->_projectConfig == null) {
338 338
             $this->_projectConfig = array();
339 339
 
340
-            $projectConfigFile = $magentoRootFolder . DIRECTORY_SEPARATOR . 'app/etc/' . $this->_customConfigFilename;
340
+            $projectConfigFile = $magentoRootFolder.DIRECTORY_SEPARATOR.'app/etc/'.$this->_customConfigFilename;
341 341
             if ($projectConfigFile && file_exists($projectConfigFile)) {
342 342
                 $projectConfig = $this->applyVariables(
343 343
                     \file_get_contents($projectConfigFile),
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
                 $this->_projectConfig = Yaml::parse($projectConfig);
348 348
             }
349 349
 
350
-            $stopFileConfigFile = $magerunStopFileFolder . DIRECTORY_SEPARATOR . '.' . $this->_customConfigFilename;
350
+            $stopFileConfigFile = $magerunStopFileFolder.DIRECTORY_SEPARATOR.'.'.$this->_customConfigFilename;
351 351
             if (!empty($magerunStopFileFolder) && file_exists($stopFileConfigFile)) {
352 352
                 $projectConfig = $this->applyVariables(
353 353
                     \file_get_contents($stopFileConfigFile),
@@ -388,7 +388,7 @@  discard block
 block discarded – undo
388 388
         }
389 389
 
390 390
         if (OutputInterface::VERBOSITY_DEBUG <= $this->_output->getVerbosity()) {
391
-            $this->_output->writeln('<debug>Load plugin config <comment>' . $path . '</comment></debug>');
391
+            $this->_output->writeln('<debug>Load plugin config <comment>'.$path.'</comment></debug>');
392 392
         }
393 393
 
394 394
         $localPluginConfig = \file_get_contents($path);
@@ -403,13 +403,13 @@  discard block
 block discarded – undo
403 403
     public function getVendorDir()
404 404
     {
405 405
         /* old vendor folder to give backward compatibility */
406
-        $vendorFolder = $this->getConfigurationLoaderDir() . '/../../../../vendor';
406
+        $vendorFolder = $this->getConfigurationLoaderDir().'/../../../../vendor';
407 407
         if (is_dir($vendorFolder)) {
408 408
             return $vendorFolder;
409 409
         }
410 410
 
411 411
         /* correct vendor folder for composer installations */
412
-        $vendorFolder = $this->getConfigurationLoaderDir() . '/../../../../../../../vendor';
412
+        $vendorFolder = $this->getConfigurationLoaderDir().'/../../../../../../../vendor';
413 413
         if (is_dir($vendorFolder)) {
414 414
             return $vendorFolder;
415 415
         }
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/InstallCommand.php 1 patch
Spacing   +72 added lines, -72 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
                 'noDownload',
87 87
                 null,
88 88
                 InputOption::VALUE_NONE,
89
-                'If set skips download step. Used when installationFolder is already a Magento installation that has ' .
89
+                'If set skips download step. Used when installationFolder is already a Magento installation that has '.
90 90
                 'to be installed on the given database.'
91 91
             )
92 92
             ->addOption(
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
 
201 201
         if (count($missingExtensions) > 0) {
202 202
             throw new RuntimeException(
203
-                'The following PHP extensions are required to start installation: ' . implode(',', $missingExtensions)
203
+                'The following PHP extensions are required to start installation: '.implode(',', $missingExtensions)
204 204
             );
205 205
         }
206 206
     }
@@ -216,8 +216,8 @@  discard block
 block discarded – undo
216 216
         if ($input->getOption('magentoVersion') == null && $input->getOption('magentoVersionByName') == null) {
217 217
             $question = array();
218 218
             foreach ($this->commandConfig['magento-packages'] as $key => $package) {
219
-                $question[] = '<comment>' . str_pad('[' . ($key + 1) . ']', 4, ' ') . '</comment> ' .
220
-                    $package['name'] . "\n";
219
+                $question[] = '<comment>'.str_pad('['.($key + 1).']', 4, ' ').'</comment> '.
220
+                    $package['name']."\n";
221 221
             }
222 222
             $question[] = "<question>Choose a magento version:</question> ";
223 223
 
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
             $package = $this->createComposerPackageByConfig($this->config['magentoVersionData']);
304 304
             $this->config['magentoPackage'] = $package;
305 305
 
306
-            if (file_exists($this->config['installationFolder'] . '/app/Mage.php')) {
306
+            if (file_exists($this->config['installationFolder'].'/app/Mage.php')) {
307 307
                 $output->writeln('<error>A magento installation already exists in this folder </error>');
308 308
 
309 309
                 return false;
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
             } else {
326 326
                 $filesystem = new \Composer\Util\Filesystem();
327 327
                 $filesystem->copyThenRemove(
328
-                    $this->config['installationFolder'] . '/_n98_magerun_download',
328
+                    $this->config['installationFolder'].'/_n98_magerun_download',
329 329
                     $this->config['installationFolder']
330 330
                 );
331 331
             }
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
                 $this->patchMagentoInstallerForPHP54($this->config['installationFolder']);
336 336
             }
337 337
         } catch (Exception $e) {
338
-            $output->writeln('<error>' . $e->getMessage() . '</error>');
338
+            $output->writeln('<error>'.$e->getMessage().'</error>');
339 339
 
340 340
             return false;
341 341
         }
@@ -431,7 +431,7 @@  discard block
 block discarded – undo
431 431
                 $dbHostDefault = $input->getOption('dbHost') ? $input->getOption('dbHost') : 'localhost';
432 432
                 $this->config['db_host'] = $dialog->askAndValidate(
433 433
                     $output,
434
-                    '<question>Please enter the database host</question> <comment>[' . $dbHostDefault . ']</comment>: ',
434
+                    '<question>Please enter the database host</question> <comment>['.$dbHostDefault.']</comment>: ',
435 435
                     $this->notEmptyCallback,
436 436
                     false,
437 437
                     $dbHostDefault
@@ -440,7 +440,7 @@  discard block
 block discarded – undo
440 440
                 $dbUserDefault = $input->getOption('dbUser') ? $input->getOption('dbUser') : 'root';
441 441
                 $this->config['db_user'] = $dialog->askAndValidate(
442 442
                     $output,
443
-                    '<question>Please enter the database username</question> <comment>[' . $dbUserDefault .
443
+                    '<question>Please enter the database username</question> <comment>['.$dbUserDefault.
444 444
                     ']</comment>: ',
445 445
                     $this->notEmptyCallback,
446 446
                     false,
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
                 $dbPassDefault = $input->getOption('dbPass') ? $input->getOption('dbPass') : '';
451 451
                 $this->config['db_pass'] = $dialog->ask(
452 452
                     $output,
453
-                    '<question>Please enter the database password</question> <comment>[' . $dbPassDefault .
453
+                    '<question>Please enter the database password</question> <comment>['.$dbPassDefault.
454 454
                     ']</comment>: ',
455 455
                     $dbPassDefault
456 456
                 );
@@ -458,7 +458,7 @@  discard block
 block discarded – undo
458 458
                 $dbNameDefault = $input->getOption('dbName') ? $input->getOption('dbName') : 'magento';
459 459
                 $this->config['db_name'] = $dialog->askAndValidate(
460 460
                     $output,
461
-                    '<question>Please enter the database name</question> <comment>[' . $dbNameDefault . ']</comment>: ',
461
+                    '<question>Please enter the database name</question> <comment>['.$dbNameDefault.']</comment>: ',
462 462
                     $this->notEmptyCallback,
463 463
                     false,
464 464
                     $dbNameDefault
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
                 $dbPortDefault = $input->getOption('dbPort') ? $input->getOption('dbPort') : 3306;
468 468
                 $this->config['db_port'] = $dialog->askAndValidate(
469 469
                     $output,
470
-                    '<question>Please enter the database port </question> <comment>[' . $dbPortDefault .
470
+                    '<question>Please enter the database port </question> <comment>['.$dbPortDefault.
471 471
                     ']</comment>: ',
472 472
                     $this->notEmptyCallback,
473 473
                     false,
@@ -477,7 +477,7 @@  discard block
 block discarded – undo
477 477
                 $dbPrefixDefault = $input->getOption('dbPrefix') ? $input->getOption('dbPrefix') : '';
478 478
                 $this->config['db_prefix'] = $dialog->ask(
479 479
                     $output,
480
-                    '<question>Please enter the table prefix</question> <comment>[' . $dbPrefixDefault . ']</comment>:',
480
+                    '<question>Please enter the table prefix</question> <comment>['.$dbPrefixDefault.']</comment>:',
481 481
                     $dbPrefixDefault
482 482
                 );
483 483
                 $db = $this->validateDatabaseSettings($output, $input);
@@ -498,10 +498,10 @@  discard block
 block discarded – undo
498 498
         try {
499 499
             $dsn = sprintf("mysql:host=%s;port=%s", $this->config['db_host'], $this->config['db_port']);
500 500
             $db = new PDO($dsn, $this->config['db_user'], $this->config['db_pass']);
501
-            if (!$db->query('USE ' . $this->config['db_name'])) {
502
-                $db->query("CREATE DATABASE `" . $this->config['db_name'] . "`");
503
-                $output->writeln('<info>Created database ' . $this->config['db_name'] . '</info>');
504
-                $db->query('USE ' . $this->config['db_name']);
501
+            if (!$db->query('USE '.$this->config['db_name'])) {
502
+                $db->query("CREATE DATABASE `".$this->config['db_name']."`");
503
+                $output->writeln('<info>Created database '.$this->config['db_name'].'</info>');
504
+                $db->query('USE '.$this->config['db_name']);
505 505
 
506 506
                 return $db;
507 507
             }
@@ -514,7 +514,7 @@  discard block
 block discarded – undo
514 514
 
515 515
             return $db;
516 516
         } catch (PDOException $e) {
517
-            $output->writeln('<error>' . $e->getMessage() . '</error>');
517
+            $output->writeln('<error>'.$e->getMessage().'</error>');
518 518
         }
519 519
 
520 520
         return false;
@@ -551,7 +551,7 @@  discard block
 block discarded – undo
551 551
                         $input,
552 552
                         $output,
553 553
                         $demoPackageData,
554
-                        $this->config['installationFolder'] . '/_temp_demo_data',
554
+                        $this->config['installationFolder'].'/_temp_demo_data',
555 555
                         false
556 556
                     );
557 557
 
@@ -569,39 +569,39 @@  discard block
 block discarded – undo
569 569
                     }
570 570
 
571 571
                     // Remove empty folder
572
-                    if (is_dir($this->config['installationFolder'] . '/vendor/composer')) {
573
-                        $filesystem->recursiveRemoveDirectory($this->config['installationFolder'] . '/vendor/composer');
572
+                    if (is_dir($this->config['installationFolder'].'/vendor/composer')) {
573
+                        $filesystem->recursiveRemoveDirectory($this->config['installationFolder'].'/vendor/composer');
574 574
                     }
575 575
 
576 576
                     // Install sample data
577 577
                     $sampleDataSqlFile = glob(
578
-                        $this->config['installationFolder'] . '/_temp_demo_data/magento_*sample_data*sql'
578
+                        $this->config['installationFolder'].'/_temp_demo_data/magento_*sample_data*sql'
579 579
                     );
580 580
                     $db = $this->config['db'];
581 581
                     /* @var $db PDO */
582 582
                     if (isset($sampleDataSqlFile[0])) {
583 583
                         if (OperatingSystem::isProgramInstalled('mysql')) {
584 584
                             $exec = 'mysql '
585
-                                . '-h' . escapeshellarg(strval($this->config['db_host']))
585
+                                . '-h'.escapeshellarg(strval($this->config['db_host']))
586 586
                                 . ' '
587
-                                . '-u' . escapeshellarg(strval($this->config['db_user']))
587
+                                . '-u'.escapeshellarg(strval($this->config['db_user']))
588 588
                                 . ' '
589 589
                                 . ($this->config['db_port'] != '3306'
590
-                                    ? '-P' . escapeshellarg($this->config['db_port']) . ' ' : '')
590
+                                    ? '-P'.escapeshellarg($this->config['db_port']).' ' : '')
591 591
                                 . (!strval($this->config['db_pass'] == '')
592
-                                    ? '-p' . escapeshellarg($this->config['db_pass']) . ' ' : '')
592
+                                    ? '-p'.escapeshellarg($this->config['db_pass']).' ' : '')
593 593
                                 . strval($this->config['db_name'])
594 594
                                 . ' < '
595 595
                                 . escapeshellarg($sampleDataSqlFile[0]);
596 596
                             $output->writeln(
597
-                                '<info>Importing <comment>' . $sampleDataSqlFile[0] .
597
+                                '<info>Importing <comment>'.$sampleDataSqlFile[0].
598 598
                                 '</comment> with mysql cli client</info>'
599 599
                             );
600 600
                             Exec::run($exec);
601 601
                             @unlink($sampleDataSqlFile[0]);
602 602
                         } else {
603 603
                             $output->writeln(
604
-                                '<info>Importing <comment>' . $sampleDataSqlFile[0] .
604
+                                '<info>Importing <comment>'.$sampleDataSqlFile[0].
605 605
                                 '</comment> with PDO driver</info>'
606 606
                             );
607 607
                             // Fallback -> Try to install dump file by PDO driver
@@ -612,8 +612,8 @@  discard block
 block discarded – undo
612 612
                 }
613 613
             }
614 614
 
615
-            if (is_dir($this->config['installationFolder'] . '/_temp_demo_data')) {
616
-                $filesystem->recursiveRemoveDirectory($this->config['installationFolder'] . '/_temp_demo_data');
615
+            if (is_dir($this->config['installationFolder'].'/_temp_demo_data')) {
616
+                $filesystem->recursiveRemoveDirectory($this->config['installationFolder'].'/_temp_demo_data');
617 617
             }
618 618
         }
619 619
     }
@@ -622,8 +622,8 @@  discard block
 block discarded – undo
622 622
     {
623 623
         $filesystem = new Filesystem();
624 624
         foreach (array('/_temp_demo_data/media' => '/media', '/_temp_demo_data/skin' => '/skin') as $wrong => $right) {
625
-            $wrongFolder = $this->config['installationFolder'] . $wrong;
626
-            $rightFolder = $this->config['installationFolder'] . $right;
625
+            $wrongFolder = $this->config['installationFolder'].$wrong;
626
+            $rightFolder = $this->config['installationFolder'].$right;
627 627
             if (is_dir($wrongFolder)) {
628 628
                 $filesystem->recursiveCopy(
629 629
                     $wrongFolder,
@@ -639,12 +639,12 @@  discard block
 block discarded – undo
639 639
      */
640 640
     protected function removeEmptyFolders()
641 641
     {
642
-        if (is_dir(getcwd() . '/vendor')) {
642
+        if (is_dir(getcwd().'/vendor')) {
643 643
             $finder = new Finder();
644
-            $finder->files()->depth(3)->in(getcwd() . '/vendor');
644
+            $finder->files()->depth(3)->in(getcwd().'/vendor');
645 645
             if ($finder->count() == 0) {
646 646
                 $filesystem = new Filesystem();
647
-                $filesystem->recursiveRemoveDirectory(getcwd() . '/vendor');
647
+                $filesystem->recursiveRemoveDirectory(getcwd().'/vendor');
648 648
             }
649 649
         }
650 650
     }
@@ -668,15 +668,15 @@  discard block
 block discarded – undo
668 668
 
669 669
         $sessionSave = $useDefaultConfigParams ? $defaults['session_save'] : $dialog->ask(
670 670
             $output,
671
-            '<question>Please enter the session save:</question> <comment>[' .
672
-            $defaults['session_save'] . ']</comment>: ',
671
+            '<question>Please enter the session save:</question> <comment>['.
672
+            $defaults['session_save'].']</comment>: ',
673 673
             $defaults['session_save']
674 674
         );
675 675
 
676 676
         $adminFrontname = $useDefaultConfigParams ? $defaults['admin_frontname'] : $dialog->askAndValidate(
677 677
             $output,
678
-            '<question>Please enter the admin frontname:</question> <comment>[' .
679
-            $defaults['admin_frontname'] . ']</comment> ',
678
+            '<question>Please enter the admin frontname:</question> <comment>['.
679
+            $defaults['admin_frontname'].']</comment> ',
680 680
             $this->notEmptyCallback,
681 681
             false,
682 682
             $defaults['admin_frontname']
@@ -684,8 +684,8 @@  discard block
 block discarded – undo
684 684
 
685 685
         $currency = $useDefaultConfigParams ? $defaults['currency'] : $dialog->askAndValidate(
686 686
             $output,
687
-            '<question>Please enter the default currency code:</question> <comment>[' .
688
-            $defaults['currency'] . ']</comment>: ',
687
+            '<question>Please enter the default currency code:</question> <comment>['.
688
+            $defaults['currency'].']</comment>: ',
689 689
             $this->notEmptyCallback,
690 690
             false,
691 691
             $defaults['currency']
@@ -693,7 +693,7 @@  discard block
 block discarded – undo
693 693
 
694 694
         $locale = $useDefaultConfigParams ? $defaults['locale'] : $dialog->askAndValidate(
695 695
             $output,
696
-            '<question>Please enter the locale code:</question> <comment>[' . $defaults['locale'] . ']</comment>: ',
696
+            '<question>Please enter the locale code:</question> <comment>['.$defaults['locale'].']</comment>: ',
697 697
             $this->notEmptyCallback,
698 698
             false,
699 699
             $defaults['locale']
@@ -701,7 +701,7 @@  discard block
 block discarded – undo
701 701
 
702 702
         $timezone = $useDefaultConfigParams ? $defaults['timezone'] : $dialog->askAndValidate(
703 703
             $output,
704
-            '<question>Please enter the timezone:</question> <comment>[' . $defaults['timezone'] . ']</comment>: ',
704
+            '<question>Please enter the timezone:</question> <comment>['.$defaults['timezone'].']</comment>: ',
705 705
             $this->notEmptyCallback,
706 706
             false,
707 707
             $defaults['timezone']
@@ -709,8 +709,8 @@  discard block
 block discarded – undo
709 709
 
710 710
         $adminUsername = $useDefaultConfigParams ? $defaults['admin_username'] : $dialog->askAndValidate(
711 711
             $output,
712
-            '<question>Please enter the admin username:</question> <comment>[' .
713
-            $defaults['admin_username'] . ']</comment>: ',
712
+            '<question>Please enter the admin username:</question> <comment>['.
713
+            $defaults['admin_username'].']</comment>: ',
714 714
             $this->notEmptyCallback,
715 715
             false,
716 716
             $defaults['admin_username']
@@ -718,8 +718,8 @@  discard block
 block discarded – undo
718 718
 
719 719
         $adminPassword = $useDefaultConfigParams ? $defaults['admin_password'] : $dialog->askAndValidate(
720 720
             $output,
721
-            '<question>Please enter the admin password:</question> <comment>[' .
722
-            $defaults['admin_password'] . ']</comment>: ',
721
+            '<question>Please enter the admin password:</question> <comment>['.
722
+            $defaults['admin_password'].']</comment>: ',
723 723
             $this->notEmptyCallback,
724 724
             false,
725 725
             $defaults['admin_password']
@@ -727,8 +727,8 @@  discard block
 block discarded – undo
727 727
 
728 728
         $adminFirstname = $useDefaultConfigParams ? $defaults['admin_firstname'] : $dialog->askAndValidate(
729 729
             $output,
730
-            '<question>Please enter the admin\'s firstname:</question> <comment>[' .
731
-            $defaults['admin_firstname'] . ']</comment>: ',
730
+            '<question>Please enter the admin\'s firstname:</question> <comment>['.
731
+            $defaults['admin_firstname'].']</comment>: ',
732 732
             $this->notEmptyCallback,
733 733
             false,
734 734
             $defaults['admin_firstname']
@@ -736,8 +736,8 @@  discard block
 block discarded – undo
736 736
 
737 737
         $adminLastname = $useDefaultConfigParams ? $defaults['admin_lastname'] : $dialog->askAndValidate(
738 738
             $output,
739
-            '<question>Please enter the admin\'s lastname:</question> <comment>[' .
740
-            $defaults['admin_lastname'] . ']</comment>: ',
739
+            '<question>Please enter the admin\'s lastname:</question> <comment>['.
740
+            $defaults['admin_lastname'].']</comment>: ',
741 741
             $this->notEmptyCallback,
742 742
             false,
743 743
             $defaults['admin_lastname']
@@ -745,8 +745,8 @@  discard block
 block discarded – undo
745 745
 
746 746
         $adminEmail = $useDefaultConfigParams ? $defaults['admin_email'] : $dialog->askAndValidate(
747 747
             $output,
748
-            '<question>Please enter the admin\'s email:</question> <comment>[' .
749
-            $defaults['admin_email'] . ']</comment>: ',
748
+            '<question>Please enter the admin\'s email:</question> <comment>['.
749
+            $defaults['admin_email'].']</comment>: ',
750 750
             $this->notEmptyCallback,
751 751
             false,
752 752
             $defaults['admin_email']
@@ -771,7 +771,7 @@  discard block
 block discarded – undo
771 771
             $validateBaseUrl,
772 772
             false
773 773
         );
774
-        $baseUrl = rtrim($baseUrl, '/') . '/'; // normalize baseUrl
774
+        $baseUrl = rtrim($baseUrl, '/').'/'; // normalize baseUrl
775 775
 
776 776
         /**
777 777
          * Correct session save (common mistake)
@@ -783,14 +783,14 @@  discard block
 block discarded – undo
783 783
         /**
784 784
          * Try to create session folder
785 785
          */
786
-        $defaultSessionFolder = $this->config['installationFolder'] . DIRECTORY_SEPARATOR . 'var/session';
786
+        $defaultSessionFolder = $this->config['installationFolder'].DIRECTORY_SEPARATOR.'var/session';
787 787
         if ($sessionSave == 'files' && !is_dir($defaultSessionFolder)) {
788 788
             @mkdir($defaultSessionFolder);
789 789
         }
790 790
 
791 791
         $dbHost = $this->config['db_host'];
792 792
         if ($this->config['db_port'] != 3306) {
793
-            $dbHost .= ':' . $this->config['db_port'];
793
+            $dbHost .= ':'.$this->config['db_port'];
794 794
         }
795 795
 
796 796
         $argv = array(
@@ -832,24 +832,24 @@  discard block
 block discarded – undo
832 832
         }
833 833
         $installArgs = '';
834 834
         foreach ($argv as $argName => $argValue) {
835
-            $installArgs .= '--' . $argName . ' ' . escapeshellarg($argValue) . ' ';
835
+            $installArgs .= '--'.$argName.' '.escapeshellarg($argValue).' ';
836 836
         }
837 837
 
838 838
         $output->writeln('<info>Start installation process.</info>');
839 839
 
840 840
         $phpExec = OperatingSystem::getPhpBinary();
841
-        $installCommand = $phpExec . ' -f ' . escapeshellarg($this->getInstallScriptPath()) . ' -- ' . $installArgs;
841
+        $installCommand = $phpExec.' -f '.escapeshellarg($this->getInstallScriptPath()).' -- '.$installArgs;
842 842
 
843 843
 
844
-        $output->writeln('<comment>' . $installCommand . '</comment>');
844
+        $output->writeln('<comment>'.$installCommand.'</comment>');
845 845
         Exec::run($installCommand, $installationOutput, $returnStatus);
846 846
         if ($returnStatus !== self::EXEC_STATUS_OK) {
847 847
             $this->getApplication()->setAutoExit(true);
848
-            throw new RuntimeException('Installation failed.' . $installationOutput, 1);
848
+            throw new RuntimeException('Installation failed.'.$installationOutput, 1);
849 849
         } else {
850 850
             $output->writeln('<info>Successfully installed Magento</info>');
851 851
             $encryptionKey = trim(substr($installationOutput, strpos($installationOutput, ':') + 1));
852
-            $output->writeln('<comment>Encryption Key:</comment> <info>' . $encryptionKey . '</info>');
852
+            $output->writeln('<comment>Encryption Key:</comment> <info>'.$encryptionKey.'</info>');
853 853
         }
854 854
 
855 855
         $dialog = $this->getHelperSet()->get('dialog');
@@ -891,8 +891,8 @@  discard block
 block discarded – undo
891 891
      */
892 892
     protected function getInstallScriptPath()
893 893
     {
894
-        $magento1InstallScriptPath = $this->config['installationFolder'] . '/install.php';
895
-        $magento2InstallScriptPath = $this->config['installationFolder'] . '/dev/shell/install.php';
894
+        $magento1InstallScriptPath = $this->config['installationFolder'].'/install.php';
895
+        $magento2InstallScriptPath = $this->config['installationFolder'].'/dev/shell/install.php';
896 896
         if (file_exists($magento2InstallScriptPath)) {
897 897
             return $magento2InstallScriptPath;
898 898
         }
@@ -905,13 +905,13 @@  discard block
 block discarded – undo
905 905
      */
906 906
     protected function replaceHtaccessFile($baseUrl)
907 907
     {
908
-        $content = file_get_contents($this->config['installationFolder'] . DIRECTORY_SEPARATOR . '.htaccess');
908
+        $content = file_get_contents($this->config['installationFolder'].DIRECTORY_SEPARATOR.'.htaccess');
909 909
         copy(
910
-            $this->config['installationFolder'] . DIRECTORY_SEPARATOR . '.htaccess',
911
-            $this->config['installationFolder'] . DIRECTORY_SEPARATOR . '.htaccess.dist'
910
+            $this->config['installationFolder'].DIRECTORY_SEPARATOR.'.htaccess',
911
+            $this->config['installationFolder'].DIRECTORY_SEPARATOR.'.htaccess.dist'
912 912
         );
913
-        $content = str_replace('#RewriteBase /magento/', 'RewriteBase ' . parse_url($baseUrl, PHP_URL_PATH), $content);
914
-        file_put_contents($this->config['installationFolder'] . DIRECTORY_SEPARATOR . '.htaccess', $content);
913
+        $content = str_replace('#RewriteBase /magento/', 'RewriteBase '.parse_url($baseUrl, PHP_URL_PATH), $content);
914
+        file_put_contents($this->config['installationFolder'].DIRECTORY_SEPARATOR.'.htaccess', $content);
915 915
     }
916 916
 
917 917
     /**
@@ -920,19 +920,19 @@  discard block
 block discarded – undo
920 920
     protected function setDirectoryPermissions($output)
921 921
     {
922 922
         try {
923
-            $varFolder = $this->config['installationFolder'] . DIRECTORY_SEPARATOR . 'var';
923
+            $varFolder = $this->config['installationFolder'].DIRECTORY_SEPARATOR.'var';
924 924
             if (!is_dir($varFolder)) {
925 925
                 @mkdir($varFolder);
926 926
             }
927 927
             @chmod($varFolder, 0777);
928 928
 
929
-            $varCacheFolder = $this->config['installationFolder'] . DIRECTORY_SEPARATOR . 'var/cache';
929
+            $varCacheFolder = $this->config['installationFolder'].DIRECTORY_SEPARATOR.'var/cache';
930 930
             if (!is_dir($varCacheFolder)) {
931 931
                 @mkdir($varCacheFolder);
932 932
             }
933 933
             @chmod($varCacheFolder, 0777);
934 934
 
935
-            $mediaFolder = $this->config['installationFolder'] . DIRECTORY_SEPARATOR . 'media';
935
+            $mediaFolder = $this->config['installationFolder'].DIRECTORY_SEPARATOR.'media';
936 936
             if (!is_dir($mediaFolder)) {
937 937
                 @mkdir($mediaFolder);
938 938
             }
@@ -946,7 +946,7 @@  discard block
 block discarded – undo
946 946
                 @chmod($dir->getRealpath(), 0777);
947 947
             }
948 948
         } catch (Exception $e) {
949
-            $output->writeln('<error>' . $e->getMessage() . '</error>');
949
+            $output->writeln('<error>'.$e->getMessage().'</error>');
950 950
         }
951 951
     }
952 952
 
Please login to merge, or discard this patch.
src/N98/Magento/Command/Installer/UninstallCommand.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -67,11 +67,11 @@
 block discarded – undo
67 67
             $input = new StringInput('db:drop --force');
68 68
             $this->getApplication()->run($input, $output);
69 69
             $fileSystem = new Filesystem();
70
-            $output->writeln('<info>Remove directory </info><comment>' . $this->_magentoRootFolder . '</comment>');
70
+            $output->writeln('<info>Remove directory </info><comment>'.$this->_magentoRootFolder.'</comment>');
71 71
             try {
72 72
                 $fileSystem->recursiveRemoveDirectory($this->_magentoRootFolder);
73 73
             } catch (Exception $e) {
74
-                $output->writeln('<error>' . $e->getMessage() . '</error>');
74
+                $output->writeln('<error>'.$e->getMessage().'</error>');
75 75
             }
76 76
             $output->writeln('<info>Done</info>');
77 77
         }
Please login to merge, or discard this patch.
src/N98/Magento/Command/Cms/Banner/ToggleCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
 
66 66
             $disabled = !$banner->getIsEnabled();
67 67
             $comment = '<comment>Banner</comment> '
68
-            . '<info>' . (!$disabled ? 'disabled' : 'enabled') . '</info>';
68
+            . '<info>'.(!$disabled ? 'disabled' : 'enabled').'</info>';
69 69
 
70 70
             $banner->setIsEnabled($disabled);
71 71
             $banner->save();
Please login to merge, or discard this patch.
src/N98/Magento/Command/AbstractMagentoCommand.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
         if (!$silent) {
180 180
             $editionString = ($this->_magentoEnterprise ? ' (Enterprise Edition) ' : '');
181 181
             $output->writeln(
182
-                '<info>Found Magento ' . $editionString . 'in folder "' . $this->_magentoRootFolder . '"</info>'
182
+                '<info>Found Magento '.$editionString.'in folder "'.$this->_magentoRootFolder.'"</info>'
183 183
             );
184 184
         }
185 185
 
@@ -353,7 +353,7 @@  discard block
 block discarded – undo
353 353
     {
354 354
         if (isset($this->_deprecatedAlias[$input->getArgument('command')])) {
355 355
             $output->writeln(
356
-                '<error>Deprecated:</error> <comment>' . $this->_deprecatedAlias[$input->getArgument('command')] .
356
+                '<error>Deprecated:</error> <comment>'.$this->_deprecatedAlias[$input->getArgument('command')].
357 357
                 '</comment>'
358 358
             );
359 359
         }
@@ -459,7 +459,7 @@  discard block
 block discarded – undo
459 459
             // resolve folder-name to current working directory if relative
460 460
             if (substr($folderName, 0, 1) == '.') {
461 461
                 $cwd = OperatingSystem::getCwd();
462
-                $folderName = $cwd . substr($folderName, 1);
462
+                $folderName = $cwd.substr($folderName, 1);
463 463
             }
464 464
 
465 465
             if (empty($folderName)) {
@@ -487,7 +487,7 @@  discard block
 block discarded – undo
487 487
                     );
488 488
                 }
489 489
 
490
-                $localXml = $folderName . '/app/etc/local.xml';
490
+                $localXml = $folderName.'/app/etc/local.xml';
491 491
                 if (file_exists($localXml)) {
492 492
                     throw new InvalidArgumentException(
493 493
                         sprintf(
@@ -504,7 +504,7 @@  discard block
 block discarded – undo
504 504
 
505 505
         if (($installationFolder = $input->getOption('installationFolder')) == null) {
506 506
             $defaultFolder = './magento';
507
-            $question[] = "<question>Enter installation folder:</question> [<comment>" . $defaultFolder . "</comment>]";
507
+            $question[] = "<question>Enter installation folder:</question> [<comment>".$defaultFolder."</comment>]";
508 508
 
509 509
             $installationFolder = $this->getHelper('dialog')->askAndValidate(
510 510
                 $output,
@@ -562,7 +562,7 @@  discard block
 block discarded – undo
562 562
     {
563 563
         $dialog = '';
564 564
         foreach ($entries as $key => $entry) {
565
-            $dialog .= '<comment>[' . ($key + 1) . ']</comment> ' . $entry . "\n";
565
+            $dialog .= '<comment>['.($key + 1).']</comment> '.$entry."\n";
566 566
         }
567 567
         $dialog .= "<question>{$question}</question> ";
568 568
 
Please login to merge, or discard this patch.