Completed
Pull Request — develop (#813)
by Robbie
04:26
created
src/N98/Magento/Command/LocalConfig/GenerateCommand.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     {
44 44
         $this->detectMagento($output);
45 45
         $configFile = $this->_getLocalConfigFilename();
46
-        $configFileTemplate = dirname($configFile) . '/local.xml.template';
46
+        $configFileTemplate = dirname($configFile).'/local.xml.template';
47 47
 
48 48
         if (file_exists($configFile)) {
49 49
             $output->writeln(
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
             } else {
126 126
                 $input->setArgument(
127 127
                     $argument,
128
-                    $this->getOrAskForArgument($argument, $input, $output, $messagePrefix . $options['prompt'])
128
+                    $this->getOrAskForArgument($argument, $input, $output, $messagePrefix.$options['prompt'])
129 129
                 );
130 130
             }
131 131
 
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
      */
141 141
     protected function _getLocalConfigFilename()
142 142
     {
143
-        $configFile = $this->_magentoRootFolder . '/app/etc/local.xml';
143
+        $configFile = $this->_magentoRootFolder.'/app/etc/local.xml';
144 144
         return $configFile;
145 145
     }
146 146
 
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
     protected function _wrapCData($string)
158 158
     {
159 159
         $buffer = strtr($string, array(']]>' => ']]>]]&gt;<![CDATA['));
160
-        $buffer = '<![CDATA[' . $buffer . ']]>';
160
+        $buffer = '<![CDATA['.$buffer.']]>';
161 161
         $buffer = strtr($buffer, array('<![CDATA[]]>' => ''));
162 162
 
163 163
         return $buffer;
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/Store/Config/BaseUrlListCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
                 'format',
20 20
                 null,
21 21
                 InputOption::VALUE_OPTIONAL,
22
-                'Output Format. One of [' . implode(',', RendererFactory::getFormats()) . ']'
22
+                'Output Format. One of ['.implode(',', RendererFactory::getFormats()).']'
23 23
             )
24 24
         ;
25 25
     }
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/Store/ListCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
                 'format',
25 25
                 null,
26 26
                 InputOption::VALUE_OPTIONAL,
27
-                'Output Format. One of [' . implode(',', RendererFactory::getFormats()) . ']'
27
+                'Output Format. One of ['.implode(',', RendererFactory::getFormats()).']'
28 28
             )
29 29
         ;
30 30
     }
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/Url/ListCommand.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 
115 115
                 $parts = parse_url($url);
116 116
                 foreach ($parts as $key => $value) {
117
-                    $line = str_replace('{' . $key . '}', $value, $line);
117
+                    $line = str_replace('{'.$key.'}', $value, $line);
118 118
                 }
119 119
 
120 120
                 // ... and output
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
         }
140 140
         foreach ($collection as $item) {
141 141
             /* @var $item \Varien_Object */
142
-            $urls[] = $linkBaseUrl . $item->getUrl();
142
+            $urls[] = $linkBaseUrl.$item->getUrl();
143 143
         }
144 144
         return $urls;
145 145
     }
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/CheckCommand.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
                 'format',
38 38
                 null,
39 39
                 InputOption::VALUE_OPTIONAL,
40
-                'Output Format. One of [' . implode(',', RendererFactory::getFormats()) . ']'
40
+                'Output Format. One of ['.implode(',', RendererFactory::getFormats()).']'
41 41
             )
42 42
         ;
43 43
 
@@ -122,13 +122,13 @@  discard block
 block discarded – undo
122 122
                 switch ($result->getStatus()) {
123 123
                     case Result::STATUS_WARNING:
124 124
                     case Result::STATUS_ERROR:
125
-                        $output->write('<error>' . Charset::convertInteger(Charset::UNICODE_CROSS_CHAR) . '</error> ');
125
+                        $output->write('<error>'.Charset::convertInteger(Charset::UNICODE_CROSS_CHAR).'</error> ');
126 126
                         break;
127 127
 
128 128
                     case Result::STATUS_OK:
129 129
                     default:
130 130
                         $output->write(
131
-                            '<info>' . Charset::convertInteger(Charset::UNICODE_CHECKMARK_CHAR) . '</info> '
131
+                            '<info>'.Charset::convertInteger(Charset::UNICODE_CHECKMARK_CHAR).'</info> '
132 132
                         );
133 133
                         break;
134 134
                 }
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
     {
192 192
         $result = $results->createResult();
193 193
         $result->setMessage(
194
-            '<error>No ' . $context . ' configured to run store check:</error> <comment>' . basename($checkGroupClass) .
194
+            '<error>No '.$context.' configured to run store check:</error> <comment>'.basename($checkGroupClass).
195 195
             '</comment>'
196 196
         );
197 197
         $result->setStatus($result::STATUS_WARNING);
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/Check/Filesystem/FilesCheck.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -33,13 +33,13 @@
 block discarded – undo
33 33
         foreach ($files as $file => $comment) {
34 34
             $result = $results->createResult();
35 35
 
36
-            if (file_exists($magentoRoot . DIRECTORY_SEPARATOR . $file)) {
36
+            if (file_exists($magentoRoot.DIRECTORY_SEPARATOR.$file)) {
37 37
                 $result->setStatus(Result::STATUS_OK);
38
-                $result->setMessage("<info>File <comment>" . $file . "</comment> found.</info>");
38
+                $result->setMessage("<info>File <comment>".$file."</comment> found.</info>");
39 39
             } else {
40 40
                 $result->setStatus(Result::STATUS_ERROR);
41 41
                 $result->setMessage(
42
-                    "<error>File " . $file . " not found!</error><comment> Usage: " . $comment . "</comment>"
42
+                    "<error>File ".$file." not found!</error><comment> Usage: ".$comment."</comment>"
43 43
                 );
44 44
             }
45 45
         }
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/Check/Filesystem/FoldersCheck.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -32,20 +32,20 @@
 block discarded – undo
32 32
 
33 33
         foreach ($folders as $folder => $comment) {
34 34
             $result = $results->createResult();
35
-            if (file_exists($magentoRoot . DIRECTORY_SEPARATOR . $folder)) {
35
+            if (file_exists($magentoRoot.DIRECTORY_SEPARATOR.$folder)) {
36 36
                 $result->setStatus(Result::STATUS_OK);
37
-                $result->setMessage("<info>Folder <comment>" . $folder . "</comment> found.</info>");
38
-                if (!is_writeable($magentoRoot . DIRECTORY_SEPARATOR . $folder)) {
37
+                $result->setMessage("<info>Folder <comment>".$folder."</comment> found.</info>");
38
+                if (!is_writeable($magentoRoot.DIRECTORY_SEPARATOR.$folder)) {
39 39
                     $result->setStatus(Result::STATUS_ERROR);
40 40
                     $result->setMessage(
41
-                        "<error>Folder " . $folder . " is not writeable!</error><comment> Usage: " . $comment .
41
+                        "<error>Folder ".$folder." is not writeable!</error><comment> Usage: ".$comment.
42 42
                         "</comment>"
43 43
                     );
44 44
                 }
45 45
             } else {
46 46
                 $result->setStatus(Result::STATUS_ERROR);
47 47
                 $result->setMessage(
48
-                    "<error>Folder " . $folder . " not found!</error><comment> Usage: " . $comment . "</comment>"
48
+                    "<error>Folder ".$folder." not found!</error><comment> Usage: ".$comment."</comment>"
49 49
                 );
50 50
             }
51 51
         }
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/Check/Settings/CookieDomainCheckAbstract.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
 
20 20
     public function initConfigPaths()
21 21
     {
22
-        $this->registerStoreConfigPath('baseUrl', 'web/' . $this->class . '/base_url');
22
+        $this->registerStoreConfigPath('baseUrl', 'web/'.$this->class.'/base_url');
23 23
         $this->registerStoreConfigPath('cookieDomain', 'web/cookie/cookie_domain');
24 24
     }
25 25
 
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
      */
32 32
     protected function checkSettings(Result $result, \Mage_Core_Model_Store $store, $baseUrl, $cookieDomain)
33 33
     {
34
-        $errorMessage = 'cookie-domain and ' . $this->class . ' base-URL do not match';
34
+        $errorMessage = 'cookie-domain and '.$this->class.' base-URL do not match';
35 35
 
36 36
         if (strlen($cookieDomain)) {
37 37
             $isValid = $this->validateCookieDomainAgainstUrl($cookieDomain, $baseUrl);
@@ -40,19 +40,19 @@  discard block
 block discarded – undo
40 40
 
41 41
             if ($isValid) {
42 42
                 $result->setMessage(
43
-                    '<info>Cookie Domain (' . $this->class . '): <comment>' . $cookieDomain .
44
-                    '</comment> of Store: <comment>' . $store->getCode() . '</comment> - OK</info>'
43
+                    '<info>Cookie Domain ('.$this->class.'): <comment>'.$cookieDomain.
44
+                    '</comment> of Store: <comment>'.$store->getCode().'</comment> - OK</info>'
45 45
                 );
46 46
             } else {
47 47
                 $result->setMessage(
48
-                    '<error>Cookie Domain (' . $this->class . '): <comment>' . $cookieDomain .
49
-                    '</comment> of Store: <comment>' . $store->getCode() . '</comment> - ERROR: ' . $errorMessage .
48
+                    '<error>Cookie Domain ('.$this->class.'): <comment>'.$cookieDomain.
49
+                    '</comment> of Store: <comment>'.$store->getCode().'</comment> - ERROR: '.$errorMessage.
50 50
                     '</error>'
51 51
                 );
52 52
             }
53 53
         } else {
54 54
             $result->setMessage(
55
-                '<info>Empty cookie Domain (' . $this->class . ') of Store: <comment>' . $store->getCode() .
55
+                '<info>Empty cookie Domain ('.$this->class.') of Store: <comment>'.$store->getCode().
56 56
                 '</comment> - OK</info>'
57 57
             );
58 58
         }
Please login to merge, or discard this patch.
src/N98/Magento/Command/System/Check/Settings/BaseUrlCheckAbstract.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 
21 21
     public function initConfigPaths()
22 22
     {
23
-        $this->registerStoreConfigPath('baseUrl', 'web/' . $this->class . '/base_url');
23
+        $this->registerStoreConfigPath('baseUrl', 'web/'.$this->class.'/base_url');
24 24
     }
25 25
 
26 26
     /**
@@ -33,17 +33,17 @@  discard block
 block discarded – undo
33 33
         $errorMessage = 'Wrong hostname configured. <info>Hostname must contain a dot</info>';
34 34
 
35 35
         $host    = parse_url($baseUrl, PHP_URL_HOST);
36
-        $isValid = (bool) strstr($host, '.');
36
+        $isValid = (bool)strstr($host, '.');
37 37
         $result->setStatus($isValid);
38 38
         if ($isValid) {
39 39
             $result->setMessage(
40
-                '<info>' . ucfirst($this->class) . ' BaseURL: <comment>' . $baseUrl . '</comment> of Store: <comment>' .
41
-                $store->getCode() . '</comment> - OK'
40
+                '<info>'.ucfirst($this->class).' BaseURL: <comment>'.$baseUrl.'</comment> of Store: <comment>'.
41
+                $store->getCode().'</comment> - OK'
42 42
             );
43 43
         } else {
44 44
             $result->setMessage(
45
-                '<error>Invalid ' . ucfirst($this->class) . ' BaseURL: <comment>' . $baseUrl .
46
-                '</comment> of Store: <comment>' . $store->getCode() . '</comment> ' . $errorMessage . '</error>'
45
+                '<error>Invalid '.ucfirst($this->class).' BaseURL: <comment>'.$baseUrl.
46
+                '</comment> of Store: <comment>'.$store->getCode().'</comment> '.$errorMessage.'</error>'
47 47
             );
48 48
         }
49 49
     }
Please login to merge, or discard this patch.