netresearch / kite

src/Console/Application.php

Unused Use Statements -1 removed lines

@@ -19,7 +19,6 @@
 use Netresearch\Kite\Exception;
 use Netresearch\Kite\Service\Config;
 use Netresearch\Kite\Console\Command\JobCommand;
-use Netresearch\Kite\Service\Factory;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;

Spacing +18 added lines, -18 removed lines

@@ -81,7 +81,7 @@ 
             list($dir, $file) = $dirAndFile;
             if (is_dir($dir)) {
                 $app = $appName;
-                $expectedFile = $dir . '/' . $file;
+                $expectedFile = $dir.'/'.$file;
                 break;
             }
         }
@@ -91,9 +91,9 @@ 
         } catch (\Exception $e) {
             if ($app) {
                 $message = [
-                    'You appear to be in a ' . $app . ' root directory but',
+                    'You appear to be in a '.$app.' root directory but',
                     'there is no kite config file at the expected',
-                    'location (' . $expectedFile . ').'
+                    'location ('.$expectedFile.').'
                 ];
             } else {
                 $message = [
@@ -103,9 +103,9 @@ 
                     'The config file path is expected to be:',
                 ];
                 foreach ($indicators as $appName => $dirAndFile) {
-                    $message[] = '  - "' . implode('/', $dirAndFile) . '" for ' . $appName . ' applications or';
+                    $message[] = '  - "'.implode('/', $dirAndFile).'" for '.$appName.' applications or';
                 }
-                $message[] = '  - "' . $expectedFile . '" for any other application';
+                $message[] = '  - "'.$expectedFile.'" for any other application';
             }
             $lMax = 0;
             foreach ($message as $line) {
@@ -113,12 +113,12 @@ 
                     $lMax = $l;
                 }
             }
-            $this->output->writeln('<warning>' . str_repeat(' ', $lMax + 4) . '</warning>');
+            $this->output->writeln('<warning>'.str_repeat(' ', $lMax + 4).'</warning>');
             foreach ($message as $line) {
                 $line = str_pad($line, $lMax + 2);
                 $this->output->writeln("<warning>  $line</warning>");
             }
-            $this->output->writeln('<warning>' . str_repeat(' ', $lMax + 4) . '</warning>');
+            $this->output->writeln('<warning>'.str_repeat(' ', $lMax + 4).'</warning>');
         }
     }
 
@@ -135,7 +135,7 @@ 
             . "| ' /| | __/ _ \\\n"
             . "| . \\| | |_| __/\n"
             . "|_|\\_|_|\\__\\___|\n\n"
-            . $this->getLongVersion() . "\n\n"
+            . $this->getLongVersion()."\n\n"
             . $this->getSelfPackage()->description;
 
         return $help;
@@ -153,7 +153,7 @@ 
         if (isset($package->source)) {
             $v .= " <comment>({$package->source->reference})</comment>";
         }
-        $v .= ' ' . $package->time;
+        $v .= ' '.$package->time;
         return $v;
     }
 
@@ -166,7 +166,7 @@ 
     {
         static $package = null;
         if (!$package) {
-            $files = [__DIR__ . '/../../../../composer/installed.json', __DIR__ . '/vendor/composer/installed.json'];
+            $files = [__DIR__.'/../../../../composer/installed.json', __DIR__.'/vendor/composer/installed.json'];
             foreach ($files as $file) {
                 if (file_exists($file)) {
                     $installed = json_decode(file_get_contents($file));
@@ -183,9 +183,9 @@ 
                 $process = new Process('git symbolic-ref -q --short HEAD || git describe --tags --exact-match; git rev-parse HEAD; git show -s --format=%ct HEAD', $kitePath);
                 $process->run();
                 if ($output = $process->getOutput()) {
-                    $package = json_decode(file_get_contents($kitePath . '/composer.json'));
+                    $package = json_decode(file_get_contents($kitePath.'/composer.json'));
                     list($name, $revision, $tstamp) = explode("\n", trim($output), 3);
-                    $package->version = preg_match('/^v?[0-9]+\.[0-9]+\.[0-9]+(-[a-z0-9]+)?$/i', $name) ? $name : 'dev-' . $name;
+                    $package->version = preg_match('/^v?[0-9]+\.[0-9]+\.[0-9]+(-[a-z0-9]+)?$/i', $name) ? $name : 'dev-'.$name;
                     $package->source = (object) ['reference' => $revision];
                     $package->time = date('Y-m-d H:i:s', $tstamp);
                 } else {
@@ -207,7 +207,7 @@ 
         $definition->addOption(new InputOption('workflow', null, InputOption::VALUE_OPTIONAL, 'Run a workflow on the fly'));
 
         if (isset($_SERVER['HOME']) && is_writable($_SERVER['HOME'])) {
-            $debugDir = $_SERVER['HOME'] . '/.kite/log';
+            $debugDir = $_SERVER['HOME'].'/.kite/log';
         } else {
             $debugDir = false;
         }
@@ -251,19 +251,19 @@ 
                 $strInput .= ' --help';
             }
             $workflow = $input->getParameterOption('--workflow');
-            $jobName = 'generic:workflow:' . $workflow;
+            $jobName = 'generic:workflow:'.$workflow;
             $this->config->configureJob($jobName, array('workflow' => $workflow));
             $command = new JobCommand($jobName, $this->config);
             $this->add($command);
 
-            $parameterOption = '--workflow=' . $workflow;
+            $parameterOption = '--workflow='.$workflow;
             $input = new StringInput(
                 rtrim(
-                    $jobName . ' ' .
+                    $jobName.' '.
                     str_replace(
                         array(
-                            $parameterOption . ' ',
-                            ' ' . $parameterOption,
+                            $parameterOption.' ',
+                            ' '.$parameterOption,
                             $parameterOption
                         ), '', $strInput
                     )

src/Console/Command/JobCommand.php

Unused Use Statements -1 removed lines

@@ -22,7 +22,6 @@
 use Netresearch\Kite\Service\Descriptor;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
-
 use Symfony\Component\Console\Output\ConsoleOutput;
 use Symfony\Component\Console\Output\OutputInterface;
 

Spacing +5 added lines, -5 removed lines

@@ -144,7 +144,7 @@ 
             . "from kite configuration:\n\n"
             . $this->getHelper('formatter')->formatBlock($this->getDescription(), 'fg=black;bg=green', true)
             . "\n\nThe canonicalized command is:\n\n"
-            . "  <info>php " . $_SERVER['PHP_SELF'] . ' ' . preg_replace('/^generic:([^:]+):([^ ]+)/', '--$1=$2', $this->getName()) . "</info>\n";
+            . "  <info>php ".$_SERVER['PHP_SELF'].' '.preg_replace('/^generic:([^:]+):([^ ]+)/', '--$1=$2', $this->getName())."</info>\n";
     }
 
     /**
@@ -178,13 +178,13 @@ 
         if (!$input->getOption('no-debug-file') && $debugDir = $input->getOption('debug-dir')) {
             $this->console->getFilesystem()->ensureDirectoryExists($debugDir);
             // keep max 20 logs
-            $files = glob($debugDir . '/*');
+            $files = glob($debugDir.'/*');
             while (count($files) > 19) {
                 $this->console->getFilesystem()->remove(array_shift($files));
             }
             $logFile = date('YmdHis');
             $debugOutput = new Output(
-                fopen(rtrim($debugDir, '\\/') . '/' . $logFile, 'w'),
+                fopen(rtrim($debugDir, '\\/').'/'.$logFile, 'w'),
                 Output::VERBOSITY_VERY_VERBOSE,
                 true
             );
@@ -193,7 +193,7 @@ 
             $debugOutput->writeln(
                 $this->getHelper('formatter')->formatBlock(
                     implode(' ', $_SERVER['argv']), 'fg=black;bg=white', true
-                ) . "\n"
+                )."\n"
             );
         }
     }
@@ -223,7 +223,7 @@ 
         } catch (\Exception $e) {
             if ($e instanceof ExitException && $e->getCode() === 0) {
                 if ($e->getMessage()) {
-                    $output->writeln('<info>' . $e->getMessage() . '</info>');
+                    $output->writeln('<info>'.$e->getMessage().'</info>');
                 }
                 return 0;
             }

src/Console/Output/ConsoleOutput.php

Doc Comments +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
     /**
      * ConsoleOutput constructor.
      *
-     * @param int|mixed                     $verbosity The verbosity
+     * @param integer                     $verbosity The verbosity
      * @param boolean                       $decorated If output should be decorated
      * @param OutputFormatterInterface|null $formatter Formatter
      */

src/Console/Output/Output.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 namespace Netresearch\Kite\Console\Output;
 use Symfony\Component\Console\Formatter\OutputFormatterInterface;
-
 use Symfony\Component\Console\Output\StreamOutput;
 use Symfony\Component\Console\Formatter\OutputFormatterStyle;
 

Spacing +2 added lines, -2 removed lines

@@ -149,10 +149,10 @@
                     $newline = true;
                 }
                 if ($this->previousWasNewLine && $l >= 0 && $message[0] !== "\n") {
-                    $message = $this->getIndention() . $message;
+                    $message = $this->getIndention().$message;
                 }
                 if (strpos($message, "\n") !== false) {
-                    $message = str_replace("\n", "\n" . $this->getIndention(), $message);
+                    $message = str_replace("\n", "\n".$this->getIndention(), $message);
                 }
 
                 // TODO: Indent wrapped lines - that's just not that easy because of the ANSI color escape codes

Doc Comments +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
     /**
      * Constructor.
      *
-     * @param mixed                         $stream    A stream resource
+     * @param resource                         $stream    A stream resource
      * @param int                           $verbosity The verbosity level (one of the VERBOSITY constants in OutputInterface)
      * @param bool|null                     $decorated Whether to decorate messages (null for auto-guessing)
      * @param OutputFormatterInterface|null $formatter Output formatter instance (null to use default OutputFormatter)
@@ -130,7 +130,7 @@ 
     /**
      * Write to output
      *
-     * @param array|string $messages Messages
+     * @param string $messages Messages
      * @param bool         $newline  Whether to append a newline
      * @param int          $type     The output type
      *

src/Service/Composer.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 namespace Netresearch\Kite\Service;
 use Netresearch\Kite\Job;
 use Netresearch\Kite\Service\Composer\Package;
-use Netresearch\Kite\Task;
 use Netresearch\Kite\Exception;
 use Netresearch\Kite\Tasks;
 

src/Service/Console.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 namespace Netresearch\Kite\Service;
 
 use Netresearch\Kite\Console\Output\Output;
-
 use Symfony\Component\Console\Application;
 use Symfony\Component\Console\Helper;
 use Symfony\Component\Console\Input\InputInterface;

src/Service/Descriptor.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
  */
 
 namespace Netresearch\Kite\Service;
-use Netresearch\Kite\Exception;
 use Netresearch\Kite\Task;
 
 /**

Spacing +2 added lines, -2 removed lines

@@ -44,11 +44,11 @@
                 $taskProperty = new \ReflectionProperty('Netresearch\\Kite\\Tasks', 'tasks');
                 $taskProperty->setAccessible(true);
                 foreach ($taskProperty->getValue($task) as $subTask) {
-                    $description .= "\n\n" . $this->describeTask($subTask);
+                    $description .= "\n\n".$this->describeTask($subTask);
                 }
                 $description = trim($description);
                 if (!$description) {
-                    $description = 'Generic ' . $reflection->getName();
+                    $description = 'Generic '.$reflection->getName();
                 }
             } elseif (preg_match_all('/^ \* ([^@ \n].+|)$/mU', $reflection->getDocComment(), $matches, PREG_PATTERN_ORDER)) {
                 $description = trim(implode("\n", $matches[1]));

src/Task/ComposerTask.php

Doc Comments +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
     /**
      * Run the task
      *
-     * @return mixed
+     * @return null|string
      */
     public function run()
     {

Spacing +5 added lines, -5 removed lines

@@ -57,7 +57,7 @@ 
     {
         if ($name === 'command') {
             parent::offsetSet('composerCommand', $value);
-            $value = 'composer ' .  $value;
+            $value = 'composer '.$value;
         }
         parent::offsetSet($name, $value);
     }
@@ -84,19 +84,19 @@ 
     protected function getCommand()
     {
         $cmd = $this->get('command');
-        $argv = substr(parent::getCommand(), strlen($cmd)) . ' ';
+        $argv = substr(parent::getCommand(), strlen($cmd)).' ';
         if (strpos($argv, ' --no-ansi ') === false
             && strpos($argv, ' --ansi ') === false
             && $this->console->getOutput()->isDecorated()
         ) {
-            $argv = ' --ansi' . $argv;
+            $argv = ' --ansi'.$argv;
         }
         if (!$this->shouldExecute()
             && strpos($argv, ' --dry-run ') === false
         ) {
-            $argv = ' --dry-run' . $argv;
+            $argv = ' --dry-run'.$argv;
         }
-        return $cmd . rtrim($argv);
+        return $cmd.rtrim($argv);
     }
 }
 ?>

src/Task/FsTask.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 namespace Netresearch\Kite\Task;
 
 
-use Netresearch\Kite\Exception;
 use Netresearch\Kite\Task;
 
 /**