View GitHub Repository NetgenEnhancedSelectionBundle

Schedule Inspection
Subscribe

GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Pull Request — master (#20)
by Mario
10:37
created
Status
Category
Toggle Patches
Core/FieldType/EnhancedSelection/SearchField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -15,7 +15,7 @@
 
 block discarded – undo
15 15 
      * @param \eZ\Publish\SPI\Persistence\Content\Field $field
16 16 
      * @param \eZ\Publish\SPI\Persistence\Content\Type\FieldDefinition $fieldDefinition
17 17 
      *
18 
-     * @return \eZ\Publish\SPI\Search\Field[]
18 
+     * @return Search\Field[]
19 19 
      */
20 20 
     public function getIndexData(Field $field, FieldDefinition $fieldDefinition)
21 21 
     {
Please login to merge, or discard this patch.
Core/FieldType/EnhancedSelection/Type.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -428,7 +428,7 @@
 
 block discarded – undo
428 428 
      *
429 429 
      * @param \eZ\Publish\Core\FieldType\Value $value
430 430 
      *
431 
-     * @return mixed
431 
+     * @return boolean
432 432 
      */
433 433 
     protected function getSortInfo(BaseValue $value)
434 434 
     {
Please login to merge, or discard this patch.
EnhancedSelection/EnhancedSelectionStorage/Gateway/LegacyStorage.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -161,7 +161,7 @@
 
 block discarded – undo
161 161 
         $rows = $statement->fetchAll(PDO::FETCH_ASSOC);
162 162
163 163 
         return array_map(
164 
-            function (array $row) {
164 
+            function(array $row) {
165 165 
                 return $row['identifier'];
166 166 
             },
167 167 
             $rows
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -130,7 +130,7 @@
 
 block discarded – undo
130 130 
      * Returns the data for the given $fieldId and $versionNo.
131 131 
      *
132 132 
      * @param mixed $fieldId
133 
-     * @param mixed $versionNo
133 
+     * @param integer $versionNo
134 134 
      *
135 135 
      * @return array
136 136 
      */
Please login to merge, or discard this patch.
Core/FieldType/EnhancedSelection/EnhancedSelectionStorage.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -53,7 +53,7 @@  discard block
 
 block discarded – undo
53 53 
      * @param array $fieldIds Array of field IDs
54 54 
      * @param array $context
55 55 
      *
56 
-     * @return bool
56 
+     * @return boolean|null
57 57 
      */
58 58 
     public function deleteFieldData(VersionInfo $versionInfo, array $fieldIds, array $context)
59 59 
     {
 
@@ -79,7 +79,7 @@  discard block
 
 block discarded – undo
79 79 
      * @param \eZ\Publish\SPI\Persistence\Content\Field $field
80 80 
      * @param array $context
81 81 
      *
82 
-     * @return \eZ\Publish\SPI\Search\Field[]
82 
+     * @return boolean
83 83 
      */
84 84 
     public function getIndexData(VersionInfo $versionInfo, Field $field, array $context)
85 85 
     {
Please login to merge, or discard this patch.
Form/FieldTypeHandler/EnhancedSelection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -45,7 +45,7 @@
 
 block discarded – undo
45 45 
      *
46 46 
      * @param mixed $data
47 47 
      *
48 
-     * @return mixed
48 
+     * @return EnhancedSelectionValue
49 49 
      */
50 50 
     public function convertFieldValueFromForm($data)
51 51 
     {
Please login to merge, or discard this patch.