netdudes / DataSourceryBundle

DataSource/DataSource.php

Doc Comments +1 added lines, -1 removed lines

@@ -84,7 +84,7 @@
     /**
      * Return list of data source fields available for the data source
      *
-     * @return FieldInterface
+     * @return Field[]
      */
     public function getFields()
     {

DataSource/Driver/Doctrine/DoctrineDriver.php

Doc Comments +2 added lines, -1 removed lines

@@ -66,7 +66,7 @@ 
      * @param DataSourceInterface $dataSource
      * @param QueryInterface      $query
      *
-     * @return \Doctrine\DBAL\Query\QueryBuilder|null
+     * @return QueryBuilder
      */
     public function getQueryBuilder(DataSourceInterface $dataSource, QueryInterface $query)
     {
@@ -122,6 +122,7 @@ 
      *
      * @param array                                                    $dataRow Plain array of data for a single row, from the database
      * @param \Netdudes\DataSourceryBundle\DataSource\Configuration\Field $dataSourceField
+     * @param \Netdudes\DataSourceryBundle\DataSource\Configuration\FieldInterface[] $fields
      *
      * @throws \Exception
      *

DataSource/Driver/Doctrine/QueryBuilder/Builder.php

Doc Comments +2 added lines, -1 removed lines

@@ -94,8 +94,9 @@
      * This function is cached, and will only be generated once per execution.
      *
      * @param Query $query
+     * @param string $entityClass
      *
-     * @return QueryBuilder|null
+     * @return QueryBuilder
      */
     public function buildQueryBuilder(Query $query, $entityClass)
     {

DataSource/Driver/Doctrine/QueryBuilder/JoinGenerator.php

Doc Comments +3 added lines, -3 removed lines

@@ -33,8 +33,8 @@ 
     private $joinCache = [];
 
     /**
-     * @param array                   $queryBuilderDataSourceFields
-     * @param                         $fromAlias
+     * @param \Netdudes\DataSourceryBundle\DataSource\Configuration\FieldInterface[]                   $queryBuilderDataSourceFields
+     * @param                         string $fromAlias
      * @param RequiredFieldsExtractor $requiredFieldsExtractor
      */
     public function __construct(array $queryBuilderDataSourceFields, $fromAlias, RequiredFieldsExtractor $requiredFieldsExtractor)
@@ -122,7 +122,7 @@ 
      * Walks a node of the dependency tree, recursively generating an ordered list on Joins
      * that is stored in the $this->joins cache.
      *
-     * @param       $parentUniqueIdentifier
+     * @param       string $parentUniqueIdentifier
      * @param       $node
      * @param       $descendants
      * @param array $completePath

Extension/Type/TableBundleFunctionExtension.php

Doc Comments +7 added lines, -2 removed lines

@@ -27,6 +27,11 @@ 
      */
     private $name;
 
+    /**
+     * @param string $name
+     * @param \Netdudes\DataSourceryBundle\Extension\BuiltInFunctionsExtension $instance
+     * @param string $method
+     */
     public function __construct($name, $instance, $method)
     {
         $this->instance = $instance;
@@ -43,7 +48,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getMethod()
     {
@@ -51,7 +56,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getName()
     {

Tests/DataSource/Driver/Doctrine/QueryBuilder/RequiredFieldsExtractorTest.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 namespace Netdudes\DataSourceryBundle\Tests\DataSource\Driver\Doctrine\QueryBuilder;
 
-use Netdudes\DataSourceryBundle\DataSource\Configuration\Entity\QueryBuilderDataSourceFieldsFromConfigurationGenerator;
 use Netdudes\DataSourceryBundle\DataSource\Configuration\Field;
 use Netdudes\DataSourceryBundle\DataSource\Driver\Doctrine\QueryBuilder\RequiredFieldsExtractor;
 use Netdudes\DataSourceryBundle\DataType\NumberDataType;

UQL/Exception/Semantic/UqlUnexpectedEndOfExpressionException.php

Doc Comments +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
     }
 
     /**
-     * @return \string[]
+     * @return string[]
      */
     public function getExpectedTokenCategories()
     {

UQL/Interpreter.php

Doc Comments +2 added lines, -2 removed lines

@@ -255,7 +255,7 @@ 
      *
      * @param $token
      *
-     * @return mixed
+     * @return integer
      * @throws \Exception
      */
     protected function translateLogic($token)
@@ -278,7 +278,7 @@ 
      *
      * @param $value
      *
-     * @return mixed
+     * @return string
      */
     protected function parseValue($value)
     {

UQL/Parser.php

Doc Comments +8 added lines, -5 removed lines

@@ -178,7 +178,7 @@ 
      * Tries to match the following tokens to an <assertion>.
      *
      * @throws Exception\UQLSyntaxError
-     * @return bool|ASTAssertion
+     * @return boolean
      */
     public function matchAssertion()
     {
@@ -224,7 +224,7 @@ 
     /**
      * Tries to match the next token to an <operator>.
      *
-     * @return bool
+     * @return boolean|null
      */
     public function matchOperator()
     {
@@ -325,7 +325,7 @@ 
     }
 
     /**
-     * @param mixed $tokenIndex
+     * @param integer $tokenIndex
      */
     public function setTokenIndex($tokenIndex)
     {
@@ -365,7 +365,7 @@ 
     /**
      * Helper method. Throws an Exception representing a Syntax Error.
      *
-     * @param $message
+     * @param string $message
      *
      * @throws \Exception
      */
@@ -387,6 +387,9 @@ 
         );
     }
 
+    /**
+     * @param string $message
+     */
     private function throwSyntaxError($message)
     {
         throw new UQLSyntaxError('Syntax error: ' . $message);
@@ -396,7 +399,7 @@ 
      * Transforms a literal subtype (e.g. T_LITERAL_FALSE) into a plain
      * literal match. Plain literals are unchanged.
      *
-     * @param $literal
+     * @param boolean $literal
      *
      * @return array
      */