ImagineFactory::make() - Code Metrics - Inspection of "Corrigido alguns testes" - naturalweb/nwlaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 01f74b...655878 )

by Renato

created 2019-07-03 19:10 UTC

ImagineFactory::make() A

↳ Parent: ImagineFactory

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
nc	2
nop	1
dl	0
loc	8
ccs	0
cts	4
cp	0
crap	12
rs	10
c	0
b	0
f	0

<?php

namespace NwLaravel\FileStorage;

use Intervention\Image\ImageManager;
use Intervention\Image\Image;

class ImagineFactory
{
    /**
     * @var ImageManager
     */
    protected $manager;

    /**
     * Construct
     *
     * @param ImageManager $manager
     */
    public function __construct(ImageManager $manager)
    {
        $this->manager = $manager;
    }

    /**
     * Factory
     *
     * @param string $path
     *
     * @return Imagine
     */
    public function make($path)
    {
        if (extension_loaded('imagick') && class_exists('Imagick')) {
            return new ImagineImagick($path, $this->manager);

        }

        return new ImagineGd($path, $this->manager);
    }
}


1		<?php
2
3		namespace NwLaravel\FileStorage;
4
5		use Intervention\Image\ImageManager;
6		use Intervention\Image\Image;
7
8		class ImagineFactory
9		{
10		/**
11		* @var ImageManager
12		*/
13		protected $manager;
14
15		/**
16		* Construct
17		*
18		* @param ImageManager $manager
19		*/
20	1	public function __construct(ImageManager $manager)
21		{
22	1	$this->manager = $manager;
23	1	}
24
25		/**
26		* Factory
27		*
28		* @param string $path
29		*
30		* @return Imagine
31		*/
32		public function make($path)
33		{
34		if (extension_loaded('imagick') && class_exists('Imagick')) {
35		return new ImagineImagick($path, $this->manager);
		0 ignored issues – show Unused Code introduced 2018-06-09 12:36 UTC by Report Bug Copy Issue Report The call to `ImagineImagick::__construct()` has too many arguments starting with `$this->manager`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
36		}
37
38		return new ImagineGd($path, $this->manager);
39		}
40		}
41

naturalweb / nwlaravel

Push — master ( 01f74b...655878 )

ImagineFactory::make() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like