NwLaravel\ActivityLog\Handlers\DefaultHandler

Complexity

Total Complexity

6

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	log()	0	26	4
A	cleanLog()	0	7	1

<?php
namespace NwLaravel\ActivityLog\Handlers;

use Illuminate\Http\Request;
use Illuminate\Contracts\Auth\Authenticatable;
use NwLaravel\ActivityLog\ActivityLog;
use Carbon\Carbon;

class DefaultHandler implements HandlerInterface
{
    /**
     * @var ActivityLog
     */
    protected $model;

    /**
     * Construct
     *
     * @param ActivityLog $model
     */
    public function __construct(ActivityLog $model)
    {
        $this->model = $model;
    }

    /**
     * Log activity
     *
     * @param string          $action
     * @param string          $description
     * @param \Eloquent       $content
     * @param Authenticatable $user
     * @param Request         $request
     *
     * @return bool
     */
    public function log($action, $description, $content = null, Authenticatable $user = null, Request $request = null)
    {
        $user_id = null;
        $user_type = null;
        $user_name = null;
        if ($user) {
            $user_id = $user->getAuthIdentifier();
            $user_type = get_class($user);
            $user_name = $user->getAuthIdentifierName();
        }
        
        $content_type = is_object($content) ? get_class($content) : null;
        $content_id = is_object($content) ? $content->id : null;
        $ip_address = $request->ip();

It seems like $request is not always an object, but can also be of type null. Maybe add an additional type check?

        return (bool) $this->model->create([

The method create() does not exist on NwLaravel\ActivityLog\ActivityLog. Did you maybe mean created()?

            'action' => $action,
            'user_id' => $user_id,
            'user_type' => $user_type,
            'user_name' => $user_name,
            'description' => $description,
            'ip_address' => $ip_address,
            'content_type' => $content_type,
            'content_id' => $content_id,
        ]);
    }

    /**
     * Clean old log records.
     *
     * @param int $maxAgeInMonths
     *
     * @return integer
     */
    public function cleanLog($maxAgeInMonths)
    {
        $maxAgeInMonths = 4;
        $date = Carbon::now()->subMonths($maxAgeInMonths);

        return $this->model->where('created_at', '<=', $date->format('Y-m-d'))->delete();

The method where does not exist on object<NwLaravel\ActivityLog\ActivityLog>? Since you implemented __call, maybe consider adding a @method annotation.

    }
}