Delete::delete() - Code Metrics - nark3d/LaravelZendSearch - Measure and Improve Code Quality continuously with Scrutinizer

Delete::delete() A
last analyzed 2017-02-20 22:23 UTC

↳ Parent: Delete

Complexity

Conditions	3
Paths	4

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	16
ccs	10
cts	10
cp	1
rs	9.4285
cc	3
eloc	8
nc	4
nop	3
crap	3

<?php

namespace BestServedCold\LaravelZendSearch\Lucene\Store;

use BestServedCold\LaravelZendSearch\Lucene\Index;
use BestServedCold\LaravelZendSearch\Lucene\Search;

/**
 * Class Delete
 *
 * @package BestServedCold\LaravelZendSearch\Lucene\Store
 */
class Delete
{
    /**
     * @var Search
     */
    private $search;

    /**
     * Delete constructor.
     *
     * @param Search $search
     */
    public function __construct(Search $search)
    {
        $this->search = $search;
        $this->search->path(config('search.index.path'));
    }

    /**
     * Delete
     *
     * @param  Index          $index
     * @param  integer $id
     * @param  string|boolean $uid
     * @return $this
     */
    public function delete(Index $index, $id, $uid = false)
    {
        $this->search->match((int) $id, 'xref_id');

        if ($uid) {
            $this->search->where(base64_encode($uid), 'uid');
        }

        foreach ($this->search->hits(false) as $hit) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $index->get()->delete($hit);
        }

        $index->get()->commit();
        
        return $this;
    }
}


1		<?php
2
3		namespace BestServedCold\LaravelZendSearch\Lucene\Store;
4
5		use BestServedCold\LaravelZendSearch\Lucene\Index;
6		use BestServedCold\LaravelZendSearch\Lucene\Search;
7
8		/**
9		* Class Delete
10		*
11		* @package BestServedCold\LaravelZendSearch\Lucene\Store
12		*/
13		class Delete
14		{
15		/**
16		* @var Search
17		*/
18		private $search;
19
20		/**
21		* Delete constructor.
22		*
23		* @param Search $search
24		*/
25	21	public function __construct(Search $search)
26		{
27	21	$this->search = $search;
28	21	$this->search->path(config('search.index.path'));
29	21	}
30
31		/**
32		* Delete
33		*
34		* @param Index $index
35		* @param integer $id
36		* @param string\|boolean $uid
37		* @return $this
38		*/
39	1	public function delete(Index $index, $id, $uid = false)
40		{
41	1	$this->search->match((int) $id, 'xref_id');
42
43	1	if ($uid) {
44	1	$this->search->where(base64_encode($uid), 'uid');
45	1	}
46
47	1	foreach ($this->search->hits(false) as $hit) {
		0 ignored issues – show Bug introduced 2017-02-10 15:13 UTC by Report Bug Copy Issue Report The expression `$this->search->hits(false)` of type `array\|object<ZendSearch\Lucene\Search\QueryHit>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
48	1	$index->get()->delete($hit);
49	1	}
50
51	1	$index->get()->commit();
52
53	1	return $this;
54		}
55		}
56

nark3d / LaravelZendSearch

Delete::delete() A last analyzed 2017-02-20 22:23 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Delete::delete() A
last analyzed 2017-02-20 22:23 UTC