BestServedCold\LaravelZendSearch\Lucene\Store\Delete

Complexity

Total Complexity

4

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	delete()	0	16	3

<?php

namespace BestServedCold\LaravelZendSearch\Lucene\Store;

use BestServedCold\LaravelZendSearch\Lucene\Index;
use BestServedCold\LaravelZendSearch\Lucene\Search;

/**
 * Class Delete
 *
 * @package BestServedCold\LaravelZendSearch\Lucene\Store
 */
class Delete
{
    /**
     * @var Search
     */
    private $search;

    /**
     * Delete constructor.
     *
     * @param Search $search
     */
    public function __construct(Search $search)
    {
        $this->search = $search;
        $this->search->path(config('search.index.path'));
    }

    /**
     * Delete
     *
     * @param  Index          $index
     * @param  integer $id
     * @param  string|boolean $uid
     * @return $this
     */
    public function delete(Index $index, $id, $uid = false)
    {
        $this->search->match((int) $id, 'xref_id');

        if ($uid) {
            $this->search->where(base64_encode($uid), 'uid');
        }

        foreach ($this->search->hits(false) as $hit) {

The expression $this->search->hits(false) of type array|object<ZendSearch\Lucene\Search\QueryHit> is not guaranteed to be traversable. How about adding an additional type check?

            $index->get()->delete($hit);
        }

        $index->get()->commit();
        
        return $this;
    }
}