BestServedCold\Benchmark\Output\Console

Complexity

Total Complexity

9

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	render()	0	4	1
A	output()	0	8	3
A	loopRows()	0	7	3
A	addRow()	0	9	2

<?php

namespace BestServedCold\Benchmark\Output;

use BestServedCold\Benchmark\Benchmark;
use BestServedCold\Benchmark\Dependency;
use BestServedCold\PhalueObjects\Metric;
use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Helper\TableSeparator;

/**
 * Class Console
 *
 * @package BestServedCold\Benchmark\Output
 */
class Console extends AbstractOutput implements OutputInterface
{
    /**
     * @codeCoverageIgnore impossible to test as writes to php://stdout
     */
    public function render()
    {
        $this->output->render();

The method render does only exist in BestServedCold\Benchmark\Output\Html, but not in Symfony\Component\Console\Output\OutputInterface.

    }
    
    /**
     * @param  Benchmark      $benchmark
     * @param  Table          $table
     * @param  TableSeparator $tableSeparator
     * @return string
     */
    public static function output(Benchmark $benchmark, Table $table = null, TableSeparator $tableSeparator = null)
    {
        $table          = $table          ?: Dependency::symfonyTable();
        $tableSeparator = $tableSeparator ?: Dependency::symfonyTableSeparator();
        $table->setHeaders(self::$headers);
        self::loopRows($table, $tableSeparator, $benchmark->getMarkers());
        return new static($table);
    }

    /**
     * @param Table          $table
     * @param TableSeparator $tableSeparator
     * @param array          $rows
     */
    protected static function loopRows(Table $table, TableSeparator $tableSeparator, array $rows)
    {
        foreach($rows as $name => $row) {
            $table = static::addRow($table, $row, $name);
            $row === end($rows) ?: $table->addRow($tableSeparator);
        }
    }

    /**
     * @param  Table       $table
     * @param  array       $metrics
     * @param  bool|string $name
     * @return Table
     */
    protected static function addRow(Table $table, array $metrics, $name)
    {
        /** @var Metric $metric */
        foreach ($metrics as $metric) {
            $table->addRow(parent::populateRow($metric, $name));

It seems like $name defined by parameter $name on line 60 can also be of type boolean; however, BestServedCold\Benchmark\Output\AbstractOutput::populateRow() does only seem to accept string, maybe add an additional type check?

It seems like you call parent on a different method (populateRow() instead of addRow()). Are you sure this is correct? If so, you might want to change this to $this->populateRow().

        }

        return $table;
    }
}