Console::addRow() - Code Metrics - Inspection of "Updating dependencies" - nark3d/Benchmark - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 997958...c1a544 )

by Adam

created 2017-03-12 13:10 UTC

Console::addRow() A

↳ Parent: Console

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	5
cts	5
cp	1
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	3
crap	2

<?php

namespace BestServedCold\Benchmark\Output;

use BestServedCold\Benchmark\Benchmark;
use BestServedCold\Benchmark\Dependency;
use BestServedCold\PhalueObjects\Metric;
use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Helper\TableSeparator;

/**
 * Class Console
 *
 * @package BestServedCold\Benchmark\Output
 */
class Console extends AbstractOutput implements OutputInterface
{
    /**
     * @codeCoverageIgnore impossible to test as writes to php://stdout
     */
    public function render()
    {
        $this->output->render();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
    
    /**
     * @param  Benchmark      $benchmark
     * @param  Table          $table
     * @param  TableSeparator $tableSeparator
     * @return string
     */
    public static function output(Benchmark $benchmark, Table $table = null, TableSeparator $tableSeparator = null)
    {
        $table          = $table          ?: Dependency::symfonyTable();
        $tableSeparator = $tableSeparator ?: Dependency::symfonyTableSeparator();
        $table->setHeaders(self::$headers);
        self::loopRows($table, $tableSeparator, $benchmark->getMarkers());
        return new static($table);
    }

    /**
     * @param Table          $table
     * @param TableSeparator $tableSeparator
     * @param array          $rows
     */
    protected static function loopRows(Table $table, TableSeparator $tableSeparator, array $rows)
    {
        foreach($rows as $name => $row) {
            $table = static::addRow($table, $row, $name);
            $row === end($rows) ?: $table->addRow($tableSeparator);
        }
    }

    /**
     * @param  Table       $table
     * @param  array       $metrics
     * @param  bool|string $name
     * @return Table
     */
    protected static function addRow(Table $table, array $metrics, $name)
    {
        /** @var Metric $metric */
        foreach ($metrics as $metric) {
            $table->addRow(parent::populateRow($metric, $name));
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        }

        return $table;
    }
}


1		<?php
2
3		namespace BestServedCold\Benchmark\Output;
4
5		use BestServedCold\Benchmark\Benchmark;
6		use BestServedCold\Benchmark\Dependency;
7		use BestServedCold\PhalueObjects\Metric;
8		use Symfony\Component\Console\Helper\Table;
9		use Symfony\Component\Console\Helper\TableSeparator;
10
11		/**
12		* Class Console
13		*
14		* @package BestServedCold\Benchmark\Output
15		*/
16		class Console extends AbstractOutput implements OutputInterface
17		{
18		/**
19		* @codeCoverageIgnore impossible to test as writes to php://stdout
20		*/
21		public function render()
22		{
23		$this->output->render();
		0 ignored issues – show Bug introduced 2017-03-11 17:54 UTC by Report Bug Copy Issue Report The method `render` does only exist in `BestServedCold\Benchmark\Output\Html`, but not in `Symfony\Component\Console\Output\OutputInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
24		}
25
26		/**
27		* @param Benchmark $benchmark
28		* @param Table $table
29		* @param TableSeparator $tableSeparator
30		* @return string
31		*/
32	1	public static function output(Benchmark $benchmark, Table $table = null, TableSeparator $tableSeparator = null)
33		{
34	1	$table = $table ?: Dependency::symfonyTable();
35	1	$tableSeparator = $tableSeparator ?: Dependency::symfonyTableSeparator();
36	1	$table->setHeaders(self::$headers);
37	1	self::loopRows($table, $tableSeparator, $benchmark->getMarkers());
38	1	return new static($table);
39		}
40
41		/**
42		* @param Table $table
43		* @param TableSeparator $tableSeparator
44		* @param array $rows
45		*/
46	1	protected static function loopRows(Table $table, TableSeparator $tableSeparator, array $rows)
47		{
48	1	foreach($rows as $name => $row) {
49	1	$table = static::addRow($table, $row, $name);
50	1	$row === end($rows) ?: $table->addRow($tableSeparator);
51	1	}
52	1	}
53
54		/**
55		* @param Table $table
56		* @param array $metrics
57		* @param bool\|string $name
58		* @return Table
59		*/
60	1	protected static function addRow(Table $table, array $metrics, $name)
61		{
62		/** @var Metric $metric */
63	1	foreach ($metrics as $metric) {
64	1	$table->addRow(parent::populateRow($metric, $name));
		0 ignored issues – show Bug introduced 2017-03-11 17:54 UTC by Report Bug Copy Issue Report It seems like `$name` defined by parameter `$name` on line 60 can also be of type `boolean`; however, `BestServedCold\Benchmark...ctOutput::populateRow()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history... Comprehensibility Bug introduced 2017-03-11 17:54 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`populateRow()` instead of `addRow()`). Are you sure this is correct? If so, you might want to change this to `$this->populateRow()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
65	1	}
66
67	1	return $table;
68		}
69		}
70

nark3d / Benchmark

Push — master ( 997958...c1a544 )

Console::addRow() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like