Completed
Pull Request — master (#697)
by
unknown
17:47
created
src/Commands/RequireCommand.php 3 patches
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -62,6 +62,9 @@  discard block
 block discarded – undo
62 62
         }
63 63
     }
64 64
 
65
+    /**
66
+     * @param string $path
67
+     */
65 68
     protected function getComposer($path)
66 69
     {
67 70
         return json_decode(file_get_contents($path), true);
@@ -97,6 +100,10 @@  discard block
 block discarded – undo
97 100
         $this->putComposer($moduleComposerPath, $moduleComposer);
98 101
     }
99 102
 
103
+    /**
104
+     * @param string $path
105
+     * @param Json $data
106
+     */
100 107
     protected function putComposer($path, $data)
101 108
     {
102 109
         file_put_contents($path, json_encode($data, JSON_UNESCAPED_SLASHES | JSON_PRETTY_PRINT));
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -6,8 +6,6 @@
 block discarded – undo
6 6
 use Nwidart\Modules\Json;
7 7
 use Nwidart\Modules\Process\Installer;
8 8
 use Nwidart\Modules\Traits\ModuleCommandTrait;
9
-use Symfony\Component\Console\Input\InputArgument;
10
-use Symfony\Component\Console\Input\InputOption;
11 9
 use Symfony\Component\Process\Process;
12 10
 
13 11
 class RequireCommand extends Command
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@
 block discarded – undo
84 84
         $requireKey = $this->option('dev') ? 'require-dev' : 'require';
85 85
         $requireOtherKey = $this->option('dev') ? 'require' : 'require-dev';
86 86
         [$newPackage, $newPackageVersion] = $this->getNewPackageInfo($composer, $requireKey);
87
-        $moduleComposerPath = $this->getModule()->getPath() . '/composer.json';
87
+        $moduleComposerPath = $this->getModule()->getPath().'/composer.json';
88 88
         $moduleComposer = $this->getComposer($moduleComposerPath);
89 89
         $moduleComposer = $this->setModuleComposer(
90 90
             $moduleComposer,
Please login to merge, or discard this patch.
src/Process/Installer.php 2 patches
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -133,7 +133,6 @@  discard block
 block discarded – undo
133 133
     /**
134 134
      * Run the installation process.
135 135
      *
136
-     * @param bool $dev
137 136
      * @return \Symfony\Component\Process\Process
138 137
      */
139 138
     public function run()
@@ -168,7 +167,6 @@  discard block
 block discarded – undo
168 167
     /**
169 168
      * Get process instance.
170 169
      *
171
-     * @param bool $dev
172 170
      * @return \Symfony\Component\Process\Process
173 171
      */
174 172
     public function getProcess()
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
         $process->setTimeout($this->timeout);
144 144
 
145 145
         if ($this->console instanceof Command) {
146
-            $process->run(function ($type, $line) {
146
+            $process->run(function($type, $line) {
147 147
                 $this->console->line($line);
148 148
             });
149 149
         }
@@ -266,11 +266,11 @@  discard block
 block discarded – undo
266 266
     public function getPackageName()
267 267
     {
268 268
         if (is_null($this->version)) {
269
-            return $this->name . ':dev-master';
269
+            return $this->name.':dev-master';
270 270
         } elseif (!$this->version) {
271 271
             return $this->name;
272 272
         } else {
273
-            return $this->name . ':' . $this->version;
273
+            return $this->name.':'.$this->version;
274 274
         }
275 275
     }
276 276
 
Please login to merge, or discard this patch.