Completed
Pull Request — master (#781)
by Nicolas
11:14 queued 08:30
created
src/Commands/SeedCommand.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
         $name = $module->getName();
98 98
         $config = $module->get('migration');
99 99
         if (is_array($config) && array_key_exists('seeds', $config)) {
100
-            foreach ((array)$config['seeds'] as $class) {
100
+            foreach ((array) $config['seeds'] as $class) {
101 101
                 if (class_exists($class)) {
102 102
                     $seeders[] = $class;
103 103
                 }
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
     protected function dbSeed($className)
132 132
     {
133 133
         if ($option = $this->option('class')) {
134
-            $params['--class'] = Str::finish(substr($className, 0, strrpos($className, '\\')), '\\') . $option;
134
+            $params['--class'] = Str::finish(substr($className, 0, strrpos($className, '\\')), '\\').$option;
135 135
         } else {
136 136
             $params = ['--class' => $className];
137 137
         }
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
         $seederPath = GenerateConfigReader::read('seeder');
163 163
         $seederPath = str_replace('/', '\\', $seederPath->getPath());
164 164
 
165
-        return $namespace . '\\' . $name . '\\' . $seederPath . '\\' . $name . 'DatabaseSeeder';
165
+        return $namespace.'\\'.$name.'\\'.$seederPath.'\\'.$name.'DatabaseSeeder';
166 166
     }
167 167
 
168 168
     /**
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
         $foundModules = [];
183 183
         foreach ($this->laravel['modules']->config('scan.paths') as $path) {
184 184
             $namespace = array_slice(explode('/', $path), -1)[0];
185
-            $foundModules[] = $namespace . '\\' . $name . '\\' . $seederPath . '\\' . $name . 'DatabaseSeeder';
185
+            $foundModules[] = $namespace.'\\'.$name.'\\'.$seederPath.'\\'.$name.'DatabaseSeeder';
186 186
         }
187 187
 
188 188
         return $foundModules;
Please login to merge, or discard this patch.
src/Commands/TestMakeCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
             $testPath = GenerateConfigReader::read('test');
81 81
         }
82 82
 
83
-        return $path . $testPath->getPath() . '/' . $this->getFileName() . '.php';
83
+        return $path.$testPath->getPath().'/'.$this->getFileName().'.php';
84 84
     }
85 85
 
86 86
     /**
Please login to merge, or discard this patch.
src/Commands/RouteProviderMakeCommand.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 
87 87
         $generatorPath = GenerateConfigReader::read('provider');
88 88
 
89
-        return $path . $generatorPath->getPath() . '/' . $this->getFileName() . '.php';
89
+        return $path.$generatorPath->getPath().'/'.$this->getFileName().'.php';
90 90
     }
91 91
 
92 92
     /**
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
      */
95 95
     protected function getWebRoutesPath()
96 96
     {
97
-        return '/' . $this->laravel['modules']->config('stubs.files.routes/web', 'Routes/web.php');
97
+        return '/'.$this->laravel['modules']->config('stubs.files.routes/web', 'Routes/web.php');
98 98
     }
99 99
 
100 100
     /**
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
      */
103 103
     protected function getApiRoutesPath()
104 104
     {
105
-        return '/' . $this->laravel['modules']->config('stubs.files.routes/api', 'Routes/api.php');
105
+        return '/'.$this->laravel['modules']->config('stubs.files.routes/api', 'Routes/api.php');
106 106
     }
107 107
 
108 108
     public function getDefaultNamespace() : string
Please login to merge, or discard this patch.
src/FileRepository.php 2 patches
Doc Comments   +3 added lines, -5 removed lines patch added patch discarded remove patch
@@ -126,9 +126,7 @@  discard block
 block discarded – undo
126 126
     /**
127 127
      * Creates a new Module instance
128 128
      *
129
-     * @param Container $app
130
-     * @param string $args
131
-     * @param string $path
129
+     * @param string[] $args
132 130
      * @return \Nwidart\Modules\Module
133 131
      */
134 132
     abstract protected function createModule(...$args);
@@ -448,7 +446,7 @@  discard block
 block discarded – undo
448 446
     /**
449 447
      * Get a specific config data from a configuration file.
450 448
      *
451
-     * @param $key
449
+     * @param string $key
452 450
      *
453 451
      * @param null $default
454 452
      * @return mixed
@@ -637,7 +635,7 @@  discard block
 block discarded – undo
637 635
     /**
638 636
      * Get stub path.
639 637
      *
640
-     * @return string|null
638
+     * @return string|boolean
641 639
      */
642 640
     public function getStubPath()
643 641
     {
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
             $paths = array_merge($paths, $this->config('scan.paths'));
117 117
         }
118 118
 
119
-        $paths = array_map(function ($path) {
119
+        $paths = array_map(function($path) {
120 120
             return Str::endsWith($path, '/*') ? $path : Str::finish($path, '/*');
121 121
         }, $paths);
122 122
 
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
      */
201 201
     public function getCached()
202 202
     {
203
-        return $this->cache->remember($this->config('cache.key'), $this->config('cache.lifetime'), function () {
203
+        return $this->cache->remember($this->config('cache.key'), $this->config('cache.lifetime'), function() {
204 204
             return $this->toCollection()->toArray();
205 205
         });
206 206
     }
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
288 288
     {
289 289
         $modules = $this->allEnabled();
290 290
 
291
-        uasort($modules, function (Module $a, Module $b) use ($direction) {
291
+        uasort($modules, function(Module $a, Module $b) use ($direction) {
292 292
             if ($a->order == $b->order) {
293 293
                 return 0;
294 294
             }
@@ -427,9 +427,9 @@  discard block
 block discarded – undo
427 427
     public function getModulePath($module)
428 428
     {
429 429
         try {
430
-            return $this->findOrFail($module)->getPath() . '/';
430
+            return $this->findOrFail($module)->getPath().'/';
431 431
         } catch (ModuleNotFoundException $e) {
432
-            return $this->getPath() . '/' . Str::studly($module) . '/';
432
+            return $this->getPath().'/'.Str::studly($module).'/';
433 433
         }
434 434
     }
435 435
 
@@ -442,7 +442,7 @@  discard block
 block discarded – undo
442 442
      */
443 443
     public function assetPath($module) : string
444 444
     {
445
-        return $this->config('paths.assets') . '/' . $module;
445
+        return $this->config('paths.assets').'/'.$module;
446 446
     }
447 447
 
448 448
     /**
@@ -455,7 +455,7 @@  discard block
 block discarded – undo
455 455
      */
456 456
     public function config($key, $default = null)
457 457
     {
458
-        return $this->config->get('modules.' . $key, $default);
458
+        return $this->config->get('modules.'.$key, $default);
459 459
     }
460 460
 
461 461
     /**
@@ -545,9 +545,9 @@  discard block
 block discarded – undo
545 545
         }
546 546
         list($name, $url) = explode(':', $asset);
547 547
 
548
-        $baseUrl = str_replace(public_path() . DIRECTORY_SEPARATOR, '', $this->getAssetsPath());
548
+        $baseUrl = str_replace(public_path().DIRECTORY_SEPARATOR, '', $this->getAssetsPath());
549 549
 
550
-        $url = $this->url->asset($baseUrl . "/{$name}/" . $url);
550
+        $url = $this->url->asset($baseUrl."/{$name}/".$url);
551 551
 
552 552
         return str_replace(['http://', 'https://'], '//', $url);
553 553
     }
Please login to merge, or discard this patch.
src/Commands/MigrateCommand.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         }
48 48
 
49 49
         foreach ($this->module->getOrdered($this->option('direction')) as $module) {
50
-            $this->line('Running for module: <info>' . $module->getName() . '</info>');
50
+            $this->line('Running for module: <info>'.$module->getName().'</info>');
51 51
 
52 52
             $this->migrate($module);
53 53
         }
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
         $path = str_replace(base_path(), '', (new Migrator($module, $this->getLaravel()))->getPath());
64 64
 
65 65
         if ($this->option('subpath')) {
66
-            $path = $path . "/" . $this->option("subpath");
66
+            $path = $path."/".$this->option("subpath");
67 67
         }
68 68
 
69 69
         $this->call('migrate', [
Please login to merge, or discard this patch.