Completed
Pull Request — master (#781)
by Nicolas
11:14 queued 08:30
created
src/Module.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
     /**
232 232
      * Get a specific data from composer.json file by given the key.
233 233
      *
234
-     * @param $key
234
+     * @param string $key
235 235
      * @param null $default
236 236
      *
237 237
      * @return mixed
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
     /**
307 307
      * Determine whether the given status same with the current module status.
308 308
      *
309
-     * @param $status
309
+     * @param integer $status
310 310
      *
311 311
      * @return bool
312 312
      */
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
     /**
339 339
      * Set active state for current module.
340 340
      *
341
-     * @param $active
341
+     * @param integer $active
342 342
      *
343 343
      * @return bool
344 344
      */
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
     {
198 198
         $lowerName = $this->getLowerName();
199 199
 
200
-        $langPath = $this->getPath() . '/Resources/lang';
200
+        $langPath = $this->getPath().'/Resources/lang';
201 201
 
202 202
         if (is_dir($langPath)) {
203 203
             $this->loadTranslationsFrom($langPath, $lowerName);
@@ -217,8 +217,8 @@  discard block
 block discarded – undo
217 217
             $file = 'module.json';
218 218
         }
219 219
 
220
-        return Arr::get($this->moduleJson, $file, function () use ($file) {
221
-            return $this->moduleJson[$file] = new Json($this->getPath() . '/' . $file, $this->files);
220
+        return Arr::get($this->moduleJson, $file, function() use ($file) {
221
+            return $this->moduleJson[$file] = new Json($this->getPath().'/'.$file, $this->files);
222 222
         });
223 223
     }
224 224
 
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
      */
272 272
     protected function fireEvent($event)
273 273
     {
274
-        $this->app['events']->dispatch(sprintf('modules.%s.' . $event, $this->getLowerName()), [$this]);
274
+        $this->app['events']->dispatch(sprintf('modules.%s.'.$event, $this->getLowerName()), [$this]);
275 275
     }
276 276
     /**
277 277
      * Register the aliases from this module.
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
     protected function registerFiles()
297 297
     {
298 298
         foreach ($this->get('files', []) as $file) {
299
-            include $this->path . '/' . $file;
299
+            include $this->path.'/'.$file;
300 300
         }
301 301
     }
302 302
 
@@ -399,7 +399,7 @@  discard block
 block discarded – undo
399 399
      */
400 400
     public function getExtraPath(string $path) : string
401 401
     {
402
-        return $this->getPath() . '/' . $path;
402
+        return $this->getPath().'/'.$path;
403 403
     }
404 404
 
405 405
     /**
Please login to merge, or discard this patch.
src/FileRepository.php 2 patches
Doc Comments   +3 added lines, -5 removed lines patch added patch discarded remove patch
@@ -126,9 +126,7 @@  discard block
 block discarded – undo
126 126
     /**
127 127
      * Creates a new Module instance
128 128
      *
129
-     * @param Container $app
130
-     * @param string $args
131
-     * @param string $path
129
+     * @param string[] $args
132 130
      * @return \Nwidart\Modules\Module
133 131
      */
134 132
     abstract protected function createModule(...$args);
@@ -448,7 +446,7 @@  discard block
 block discarded – undo
448 446
     /**
449 447
      * Get a specific config data from a configuration file.
450 448
      *
451
-     * @param $key
449
+     * @param string $key
452 450
      *
453 451
      * @param null $default
454 452
      * @return mixed
@@ -637,7 +635,7 @@  discard block
 block discarded – undo
637 635
     /**
638 636
      * Get stub path.
639 637
      *
640
-     * @return string|null
638
+     * @return string|boolean
641 639
      */
642 640
     public function getStubPath()
643 641
     {
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
             $paths = array_merge($paths, $this->config('scan.paths'));
117 117
         }
118 118
 
119
-        $paths = array_map(function ($path) {
119
+        $paths = array_map(function($path) {
120 120
             return Str::endsWith($path, '/*') ? $path : Str::finish($path, '/*');
121 121
         }, $paths);
122 122
 
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
      */
201 201
     public function getCached()
202 202
     {
203
-        return $this->cache->remember($this->config('cache.key'), $this->config('cache.lifetime'), function () {
203
+        return $this->cache->remember($this->config('cache.key'), $this->config('cache.lifetime'), function() {
204 204
             return $this->toCollection()->toArray();
205 205
         });
206 206
     }
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
288 288
     {
289 289
         $modules = $this->allEnabled();
290 290
 
291
-        uasort($modules, function (Module $a, Module $b) use ($direction) {
291
+        uasort($modules, function(Module $a, Module $b) use ($direction) {
292 292
             if ($a->order == $b->order) {
293 293
                 return 0;
294 294
             }
@@ -427,9 +427,9 @@  discard block
 block discarded – undo
427 427
     public function getModulePath($module)
428 428
     {
429 429
         try {
430
-            return $this->findOrFail($module)->getPath() . '/';
430
+            return $this->findOrFail($module)->getPath().'/';
431 431
         } catch (ModuleNotFoundException $e) {
432
-            return $this->getPath() . '/' . Str::studly($module) . '/';
432
+            return $this->getPath().'/'.Str::studly($module).'/';
433 433
         }
434 434
     }
435 435
 
@@ -442,7 +442,7 @@  discard block
 block discarded – undo
442 442
      */
443 443
     public function assetPath($module) : string
444 444
     {
445
-        return $this->config('paths.assets') . '/' . $module;
445
+        return $this->config('paths.assets').'/'.$module;
446 446
     }
447 447
 
448 448
     /**
@@ -455,7 +455,7 @@  discard block
 block discarded – undo
455 455
      */
456 456
     public function config($key, $default = null)
457 457
     {
458
-        return $this->config->get('modules.' . $key, $default);
458
+        return $this->config->get('modules.'.$key, $default);
459 459
     }
460 460
 
461 461
     /**
@@ -545,9 +545,9 @@  discard block
 block discarded – undo
545 545
         }
546 546
         list($name, $url) = explode(':', $asset);
547 547
 
548
-        $baseUrl = str_replace(public_path() . DIRECTORY_SEPARATOR, '', $this->getAssetsPath());
548
+        $baseUrl = str_replace(public_path().DIRECTORY_SEPARATOR, '', $this->getAssetsPath());
549 549
 
550
-        $url = $this->url->asset($baseUrl . "/{$name}/" . $url);
550
+        $url = $this->url->asset($baseUrl."/{$name}/".$url);
551 551
 
552 552
         return str_replace(['http://', 'https://'], '//', $url);
553 553
     }
Please login to merge, or discard this patch.
src/Commands/MigrateCommand.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         }
48 48
 
49 49
         foreach ($this->module->getOrdered($this->option('direction')) as $module) {
50
-            $this->line('Running for module: <info>' . $module->getName() . '</info>');
50
+            $this->line('Running for module: <info>'.$module->getName().'</info>');
51 51
 
52 52
             $this->migrate($module);
53 53
         }
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
         $path = str_replace(base_path(), '', (new Migrator($module, $this->getLaravel()))->getPath());
64 64
 
65 65
         if ($this->option('subpath')) {
66
-            $path = $path . "/" . $this->option("subpath");
66
+            $path = $path."/".$this->option("subpath");
67 67
         }
68 68
 
69 69
         $this->call('migrate', [
Please login to merge, or discard this patch.