Completed
Pull Request — master (#57)
by
unknown
01:32
created
src/MenuBuilder.php 1 patch
Doc Comments   +14 added lines, -12 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
     /**
224 224
      * Determine if the given name in the presenter style.
225 225
      *
226
-     * @param $name
226
+     * @param string|null $name
227 227
      *
228 228
      * @return bool
229 229
      */
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
      *
248 248
      * @param $name
249 249
      *
250
-     * @return mixed
250
+     * @return string
251 251
      */
252 252
     public function getStyle($name)
253 253
     {
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
     /**
260 260
      * Set new presenter class from given alias name.
261 261
      *
262
-     * @param $name
262
+     * @param string|null $name
263 263
      */
264 264
     public function setPresenterFromStyle($name)
265 265
     {
@@ -341,11 +341,11 @@  discard block
 block discarded – undo
341 341
     /**
342 342
      * Create new menu with dropdown.
343 343
      *
344
-     * @param $title
345
-     * @param callable $callback
344
+     * @param string $title
345
+     * @param \Closure $callback
346 346
      * @param array    $attributes
347 347
      *
348
-     * @return $this
348
+     * @return MenuItem
349 349
      */
350 350
     public function dropdown($title, \Closure $callback, $order = null, array $attributes = array())
351 351
     {
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
377 377
      * @param array $parameters
378 378
      * @param array $attributes
379 379
      *
380
-     * @return static
380
+     * @return MenuItem
381 381
      */
382 382
     public function route($route, $title, $parameters = array(), $order = null, $attributes = array())
383 383
     {
@@ -419,11 +419,11 @@  discard block
 block discarded – undo
419 419
     /**
420 420
      * Register new menu item using url.
421 421
      *
422
-     * @param $url
423
-     * @param $title
422
+     * @param string $url
423
+     * @param string $title
424 424
      * @param array $attributes
425 425
      *
426
-     * @return static
426
+     * @return MenuItem
427 427
      */
428 428
     public function url($url, $title, $order = 0, $attributes = array())
429 429
     {
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
      * Add new divider item.
451 451
      *
452 452
      * @param int $order
453
-     * @return \Nwidart\Menus\MenuItem
453
+     * @return MenuBuilder
454 454
      */
455 455
     public function addDivider($order = null)
456 456
     {
@@ -462,7 +462,8 @@  discard block
 block discarded – undo
462 462
     /**
463 463
      * Add new header item.
464 464
      *
465
-     * @return \Nwidart\Menus\MenuItem
465
+     * @param string $title
466
+     * @return MenuBuilder
466 467
      */
467 468
     public function addHeader($title, $order = null)
468 469
     {
@@ -546,6 +547,7 @@  discard block
 block discarded – undo
546 547
     /**
547 548
      * Render menu via view presenter.
548 549
      *
550
+     * @param string $presenter
549 551
      * @return \Illuminate\View\View
550 552
      */
551 553
     public function renderView($presenter = null)
Please login to merge, or discard this patch.
Tests/MenuTest.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
     /** @test */
21 21
     public function it_generates_an_empty_menu()
22 22
     {
23
-        $this->menu->create('test', function (MenuBuilder $menu) {
23
+        $this->menu->create('test', function(MenuBuilder $menu) {
24 24
         });
25 25
 
26 26
         $expected = <<<TEXT
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
     /** @test */
38 38
     public function it_makes_is_an_alias_for_create()
39 39
     {
40
-        $this->menu->make('test', function (MenuBuilder $menu) {
40
+        $this->menu->make('test', function(MenuBuilder $menu) {
41 41
         });
42 42
 
43 43
         $expected = <<<TEXT
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     /** @test */
55 55
     public function it_render_is_an_alias_of_get()
56 56
     {
57
-        $this->menu->make('test', function (MenuBuilder $menu) {
57
+        $this->menu->make('test', function(MenuBuilder $menu) {
58 58
         });
59 59
 
60 60
         $expected = <<<TEXT
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
     /** @test */
72 72
     public function it_can_get_the_instance_of_a_menu()
73 73
     {
74
-        $this->menu->create('test', function (MenuBuilder $menu) {
74
+        $this->menu->create('test', function(MenuBuilder $menu) {
75 75
         });
76 76
 
77 77
         $this->assertInstanceOf(MenuBuilder::class, $this->menu->instance('test'));
@@ -80,10 +80,10 @@  discard block
 block discarded – undo
80 80
     /** @test */
81 81
     public function it_can_modify_a_menu_instance()
82 82
     {
83
-        $this->menu->create('test', function (MenuBuilder $menu) {
83
+        $this->menu->create('test', function(MenuBuilder $menu) {
84 84
         });
85 85
 
86
-        $this->menu->modify('test', function (MenuBuilder $builder) {
86
+        $this->menu->modify('test', function(MenuBuilder $builder) {
87 87
             $builder->url('hello', 'world');
88 88
         });
89 89
 
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
     /** @test */
94 94
     public function it_gets_a_partial_for_dropdown_styles()
95 95
     {
96
-        $this->menu->create('test', function (MenuBuilder $menu) {
96
+        $this->menu->create('test', function(MenuBuilder $menu) {
97 97
         });
98 98
 
99 99
         $this->assertStringContainsString('.dropdown-submenu', $this->menu->style());
@@ -102,9 +102,9 @@  discard block
 block discarded – undo
102 102
     /** @test */
103 103
     public function it_can_get_all_menus()
104 104
     {
105
-        $this->menu->create('main', function (MenuBuilder $menu) {
105
+        $this->menu->create('main', function(MenuBuilder $menu) {
106 106
         });
107
-        $this->menu->create('footer', function (MenuBuilder $menu) {
107
+        $this->menu->create('footer', function(MenuBuilder $menu) {
108 108
         });
109 109
 
110 110
         $this->assertCount(2, $this->menu->all());
@@ -113,9 +113,9 @@  discard block
 block discarded – undo
113 113
     /** @test */
114 114
     public function it_can_count_menus()
115 115
     {
116
-        $this->menu->create('main', function (MenuBuilder $menu) {
116
+        $this->menu->create('main', function(MenuBuilder $menu) {
117 117
         });
118
-        $this->menu->create('footer', function (MenuBuilder $menu) {
118
+        $this->menu->create('footer', function(MenuBuilder $menu) {
119 119
         });
120 120
 
121 121
         $this->assertEquals(2, $this->menu->count());
@@ -124,9 +124,9 @@  discard block
 block discarded – undo
124 124
     /** @test */
125 125
     public function it_can_destroy_all_menus()
126 126
     {
127
-        $this->menu->create('main', function (MenuBuilder $menu) {
127
+        $this->menu->create('main', function(MenuBuilder $menu) {
128 128
         });
129
-        $this->menu->create('footer', function (MenuBuilder $menu) {
129
+        $this->menu->create('footer', function(MenuBuilder $menu) {
130 130
         });
131 131
 
132 132
         $this->assertCount(2, $this->menu->all());
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
     /** @test */
138 138
     public function it_still_generates_empty_menu_after_adding_dropdown()
139 139
     {
140
-        $this->menu->create('test', function (MenuBuilder $menu) {
140
+        $this->menu->create('test', function(MenuBuilder $menu) {
141 141
             $menu->dropdown('Test', function($sub) {
142 142
 
143 143
             })->hideWhen(function() {
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
     /** @test */
160 160
     public function it_still_generates_empty_menu_after_adding_item()
161 161
     {
162
-        $this->menu->create('test', function (MenuBuilder $menu) {
162
+        $this->menu->create('test', function(MenuBuilder $menu) {
163 163
             $menu->url('/', 'Test')
164 164
                 ->hideWhen(function() {
165 165
                     return true;
Please login to merge, or discard this patch.