Completed
Push — master ( a7eafe...12a2e2 )
by Nicolas
03:02
created
src/MenuItem.php 1 patch
Doc Comments   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -148,8 +148,8 @@  discard block
 block discarded – undo
148 148
     /**
149 149
      * Register new child menu with dropdown.
150 150
      *
151
-     * @param $title
152
-     * @param callable $callback
151
+     * @param string $title
152
+     * @param Closure $callback
153 153
      *
154 154
      * @return $this
155 155
      */
@@ -178,8 +178,8 @@  discard block
 block discarded – undo
178 178
     /**
179 179
      * Create new menu item and set the action to route.
180 180
      *
181
-     * @param $route
182
-     * @param $title
181
+     * @param string $route
182
+     * @param string $title
183 183
      * @param array $parameters
184 184
      * @param array $attributes
185 185
      *
@@ -205,8 +205,8 @@  discard block
 block discarded – undo
205 205
     /**
206 206
      * Create new menu item  and set the action to url.
207 207
      *
208
-     * @param $url
209
-     * @param $title
208
+     * @param string $url
209
+     * @param string $title
210 210
      * @param array $attributes
211 211
      *
212 212
      * @return MenuItem
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
     /**
291 291
      * Same with "addHeader" method.
292 292
      *
293
-     * @param $title
293
+     * @param string $title
294 294
      *
295 295
      * @return $this
296 296
      */
@@ -403,7 +403,7 @@  discard block
 block discarded – undo
403 403
     /**
404 404
      * Check is the current item divider.
405 405
      *
406
-     * @param $name
406
+     * @param string $name
407 407
      *
408 408
      * @return bool
409 409
      */
@@ -435,7 +435,7 @@  discard block
 block discarded – undo
435 435
     /**
436 436
      * Check the active state for current menu.
437 437
      *
438
-     * @return mixed
438
+     * @return boolean
439 439
      */
440 440
     public function hasActiveOnChild()
441 441
     {
@@ -587,7 +587,7 @@  discard block
 block discarded – undo
587 587
      * Set hide condition for current menu item.
588 588
      *
589 589
      * @param  Closure
590
-     * @return boolean
590
+     * @return MenuItem
591 591
      */
592 592
     public function hideWhen(Closure $callback)
593 593
     {
Please login to merge, or discard this patch.
src/MenusServiceProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
     {
41 41
         $this->registerHtmlPackage();
42 42
 
43
-        $this->app->singleton('menus', function ($app) {
43
+        $this->app->singleton('menus', function($app) {
44 44
             return new Menu($app['view'], $app['config']);
45 45
         });
46 46
     }
Please login to merge, or discard this patch.
Tests/MenuTest.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
     /** @test */
21 21
     public function it_generates_an_empty_menu()
22 22
     {
23
-        $this->menu->create('test', function (MenuBuilder $menu) {
23
+        $this->menu->create('test', function(MenuBuilder $menu) {
24 24
         });
25 25
 
26 26
         $expected = <<<TEXT
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
     /** @test */
38 38
     public function it_makes_is_an_alias_for_create()
39 39
     {
40
-        $this->menu->make('test', function (MenuBuilder $menu) {
40
+        $this->menu->make('test', function(MenuBuilder $menu) {
41 41
         });
42 42
 
43 43
         $expected = <<<TEXT
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     /** @test */
55 55
     public function it_render_is_an_alias_of_get()
56 56
     {
57
-        $this->menu->make('test', function (MenuBuilder $menu) {
57
+        $this->menu->make('test', function(MenuBuilder $menu) {
58 58
         });
59 59
 
60 60
         $expected = <<<TEXT
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
     /** @test */
72 72
     public function it_can_get_the_instance_of_a_menu()
73 73
     {
74
-        $this->menu->create('test', function (MenuBuilder $menu) {
74
+        $this->menu->create('test', function(MenuBuilder $menu) {
75 75
         });
76 76
 
77 77
         $this->assertInstanceOf(MenuBuilder::class, $this->menu->instance('test'));
@@ -80,10 +80,10 @@  discard block
 block discarded – undo
80 80
     /** @test */
81 81
     public function it_can_modify_a_menu_instance()
82 82
     {
83
-        $this->menu->create('test', function (MenuBuilder $menu) {
83
+        $this->menu->create('test', function(MenuBuilder $menu) {
84 84
         });
85 85
 
86
-        $this->menu->modify('test', function (MenuBuilder $builder) {
86
+        $this->menu->modify('test', function(MenuBuilder $builder) {
87 87
             $builder->url('hello', 'world');
88 88
         });
89 89
 
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
     /** @test */
94 94
     public function it_gets_a_partial_for_dropdown_styles()
95 95
     {
96
-        $this->menu->create('test', function (MenuBuilder $menu) {
96
+        $this->menu->create('test', function(MenuBuilder $menu) {
97 97
         });
98 98
 
99 99
         $this->assertContains('.dropdown-submenu', $this->menu->style());
@@ -102,9 +102,9 @@  discard block
 block discarded – undo
102 102
     /** @test */
103 103
     public function it_can_get_all_menus()
104 104
     {
105
-        $this->menu->create('main', function (MenuBuilder $menu) {
105
+        $this->menu->create('main', function(MenuBuilder $menu) {
106 106
         });
107
-        $this->menu->create('footer', function (MenuBuilder $menu) {
107
+        $this->menu->create('footer', function(MenuBuilder $menu) {
108 108
         });
109 109
 
110 110
         $this->assertCount(2, $this->menu->all());
@@ -113,9 +113,9 @@  discard block
 block discarded – undo
113 113
     /** @test */
114 114
     public function it_can_count_menus()
115 115
     {
116
-        $this->menu->create('main', function (MenuBuilder $menu) {
116
+        $this->menu->create('main', function(MenuBuilder $menu) {
117 117
         });
118
-        $this->menu->create('footer', function (MenuBuilder $menu) {
118
+        $this->menu->create('footer', function(MenuBuilder $menu) {
119 119
         });
120 120
 
121 121
         $this->assertEquals(2, $this->menu->count());
@@ -124,9 +124,9 @@  discard block
 block discarded – undo
124 124
     /** @test */
125 125
     public function it_can_destroy_all_menus()
126 126
     {
127
-        $this->menu->create('main', function (MenuBuilder $menu) {
127
+        $this->menu->create('main', function(MenuBuilder $menu) {
128 128
         });
129
-        $this->menu->create('footer', function (MenuBuilder $menu) {
129
+        $this->menu->create('footer', function(MenuBuilder $menu) {
130 130
         });
131 131
 
132 132
         $this->assertCount(2, $this->menu->all());
Please login to merge, or discard this patch.
Tests/MenuItemTest.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
     public function it_can_create_a_dropdown_menu_item()
106 106
     {
107 107
         $menuItem = MenuItem::make(['title' => 'Parent Item']);
108
-        $menuItem->dropdown('Dropdown item', function (MenuItem $sub) {
108
+        $menuItem->dropdown('Dropdown item', function(MenuItem $sub) {
109 109
             $sub->url('settings/account', 'Account');
110 110
             $sub->url('settings/password', 'Password');
111 111
         });
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
     public function it_can_make_a_simple_route_menu_item()
118 118
     {
119 119
         $menuItem = MenuItem::make(['title' => 'Parent Item']);
120
-        $menuItem->dropdown('Dropdown item', function (MenuItem $sub) {
120
+        $menuItem->dropdown('Dropdown item', function(MenuItem $sub) {
121 121
             $sub->route('settings.account', 'Account', ['user_id' => 1]);
122 122
         });
123 123
         $children = $menuItem->getChilds()[0]->getChilds();
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
     public function it_can_make_a_route_menu_item()
133 133
     {
134 134
         $menuItem = MenuItem::make(['title' => 'Parent Item']);
135
-        $menuItem->dropdown('Dropdown item', function (MenuItem $sub) {
135
+        $menuItem->dropdown('Dropdown item', function(MenuItem $sub) {
136 136
             $sub->route('settings.account', 'Account', ['user_id' => 1], 1, ['my-attr' => 'value']);
137 137
         });
138 138
         $children = $menuItem->getChilds()[0]->getChilds();
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
     public function it_can_make_a_simple_url_menu_item()
150 150
     {
151 151
         $menuItem = MenuItem::make(['title' => 'Parent Item']);
152
-        $menuItem->dropdown('Dropdown item', function (MenuItem $sub) {
152
+        $menuItem->dropdown('Dropdown item', function(MenuItem $sub) {
153 153
             $sub->url('settings/account', 'Account');
154 154
         });
155 155
         $children = $menuItem->getChilds()[0]->getChilds();
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
     public function it_can_make_a_url_menu_item()
165 165
     {
166 166
         $menuItem = MenuItem::make(['title' => 'Parent Item']);
167
-        $menuItem->dropdown('Dropdown item', function (MenuItem $sub) {
167
+        $menuItem->dropdown('Dropdown item', function(MenuItem $sub) {
168 168
             $sub->url('settings/account', 'Account', 1, ['my-attr' => 'value']);
169 169
         });
170 170
         $children = $menuItem->getChilds()[0]->getChilds();
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
     public function it_can_add_a_menu_item_divider()
182 182
     {
183 183
         $menuItem = MenuItem::make(['title' => 'Parent Item']);
184
-        $menuItem->dropdown('Dropdown item', function (MenuItem $sub) {
184
+        $menuItem->dropdown('Dropdown item', function(MenuItem $sub) {
185 185
             $sub->url('settings/account', 'Account');
186 186
             $sub->divider();
187 187
         });
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
     public function it_can_add_a_header_menu_item()
198 198
     {
199 199
         $menuItem = MenuItem::make(['title' => 'Parent Item']);
200
-        $menuItem->dropdown('Dropdown item', function (MenuItem $sub) {
200
+        $menuItem->dropdown('Dropdown item', function(MenuItem $sub) {
201 201
             $sub->header('User Stuff');
202 202
             $sub->url('settings/account', 'Account');
203 203
         });
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
     {
224 224
         $this->app['router']->get('settings/account', ['as' => 'settings.account']);
225 225
         $menuItem = MenuItem::make(['title' => 'Parent Item']);
226
-        $menuItem->dropdown('Dropdown item', function (MenuItem $sub) {
226
+        $menuItem->dropdown('Dropdown item', function(MenuItem $sub) {
227 227
             $sub->route('settings.account', 'Account');
228 228
         });
229 229
         $children = $menuItem->getChilds()[0]->getChilds();
Please login to merge, or discard this patch.