Completed
Pull Request — master (#1490)
by Sam
06:10
created
www/includes/test/utility_test.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,11 +12,11 @@
 block discarded – undo
12 12
 
13 13
 class UtilityTest extends UnitTestCase{
14 14
 
15
-  public function testVerpEnvelopeSenderCanCreateStandardSender() {
15
+    public function testVerpEnvelopeSenderCanCreateStandardSender() {
16 16
     $sender = twfy_verp_envelope_sender('[email protected]');
17 17
     $expected_sender = 'twfy+aperson=a.nother.dom@' + EMAILDOMAIN;
18 18
     $this->assertEqual($sender, $expected_sender, 'verp_envelope_sender can create a sender for a standard address');
19
-  }
19
+    }
20 20
 
21 21
 }
22 22
 
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,18 +3,18 @@
 block discarded – undo
3 3
  * SimpleTest tests for the functions in utility.php
4 4
  * $Id: utility_test.php,v 1.3 2009-06-25 12:23:58 louise Exp $
5 5
  */
6
-error_reporting (E_ALL);
6
+error_reporting(E_ALL);
7 7
 ini_set("display_errors", 1);
8 8
 include_once dirname(__FILE__) . '/../../../conf/general';
9 9
 include_once '../utility.php';
10 10
 include_once 'simpletest/unit_tester.php';
11 11
 include_once 'simpletest/reporter.php';
12 12
 
13
-class UtilityTest extends UnitTestCase{
13
+class UtilityTest extends UnitTestCase {
14 14
 
15 15
   public function testVerpEnvelopeSenderCanCreateStandardSender() {
16 16
     $sender = twfy_verp_envelope_sender('[email protected]');
17
-    $expected_sender = 'twfy+aperson=a.nother.dom@' + EMAILDOMAIN;
17
+    $expected_sender = 'twfy+aperson=a.nother.dom@' +EMAILDOMAIN;
18 18
     $this->assertEqual($sender, $expected_sender, 'verp_envelope_sender can create a sender for a standard address');
19 19
   }
20 20
 
Please login to merge, or discard this patch.
www/includes/easyparliament/init.php 3 patches
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,9 @@
 block discarded – undo
41 41
 twfy_debug_timestamp("after including utility.php");
42 42
 
43 43
 // Set the default timezone
44
-if(function_exists('date_default_timezone_set')) date_default_timezone_set(TIMEZONE);
44
+if(function_exists('date_default_timezone_set')) {
45
+    date_default_timezone_set(TIMEZONE);
46
+}
45 47
 
46 48
 // Only do clever things with errors if we're not testing, otherwise show as default
47 49
 
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@
 block discarded – undo
92 92
 include_once (INCLUDESPATH."easyparliament/user.php");
93 93
 
94 94
 // Test to see if this is a new-style template using the renderer class.
95
-if (! isset($new_style_template) OR $new_style_template !== TRUE) {
95
+if (! isset($new_style_template) or $new_style_template !== true) {
96 96
 
97 97
     // This is an old-style page. Use the old page classes.
98 98
     include_once (INCLUDESPATH."easyparliament/page.php");
Please login to merge, or discard this patch.
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 First some things to help make our PHP nicer and betterer
5 5
 ********************************************************************************/
6 6
 
7
-error_reporting (E_ALL);
7
+error_reporting(E_ALL);
8 8
 
9 9
 /********************************************************************************
10 10
 Now some constants that are the same for live and dev versions
@@ -12,21 +12,21 @@  discard block
 block discarded – undo
12 12
 ********************************************************************************/
13 13
 
14 14
 // In case we need to switch these off globally at some point...
15
-define ("ALLOWCOMMENTS", true);
15
+define("ALLOWCOMMENTS", true);
16 16
 
17 17
 // These variables are so we can keep date/time formats consistent across the site
18 18
 // and change them easily.
19 19
 // Formats here: http://www.php.net/manual/en/function.date.php
20
-define ("LONGERDATEFORMAT",		"l, j F Y");// Monday, 31 December 2003
21
-define ("LONGDATEFORMAT", 		"j F Y"); 	// 31 December 2003
22
-define ("SHORTDATEFORMAT", 		"j M Y");	// 31 Dec 2003
23
-define ("TIMEFORMAT", 			"g:i a");	// 11:59 pm
20
+define("LONGERDATEFORMAT", "l, j F Y"); // Monday, 31 December 2003
21
+define("LONGDATEFORMAT", "j F Y"); // 31 December 2003
22
+define("SHORTDATEFORMAT", "j M Y"); // 31 Dec 2003
23
+define("TIMEFORMAT", "g:i a"); // 11:59 pm
24 24
 
25
-define ("SHORTDATEFORMAT_SQL",	"%e %b %Y"); // 31 Dec 2003
26
-define ("TIMEFORMAT_SQL", 		"%l:%i %p"); // 11:59 PM
25
+define("SHORTDATEFORMAT_SQL", "%e %b %Y"); // 31 Dec 2003
26
+define("TIMEFORMAT_SQL", "%l:%i %p"); // 11:59 PM
27 27
 
28 28
 // Where we store the postcode of users if they search for an MP by postcode.
29
-define ('POSTCODE_COOKIE', 		'eppc');
29
+define('POSTCODE_COOKIE', 'eppc');
30 30
 
31 31
 /********************************************************************************
32 32
 And now all the files we'll include on every page.
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 twfy_debug_timestamp("after including utility.php");
41 41
 
42 42
 // Set the default timezone
43
-if(function_exists('date_default_timezone_set')) date_default_timezone_set(TIMEZONE);
43
+if (function_exists('date_default_timezone_set')) date_default_timezone_set(TIMEZONE);
44 44
 
45 45
 // Only do clever things with errors if we're not testing, otherwise show as default
46 46
 
@@ -69,39 +69,39 @@  discard block
 block discarded – undo
69 69
 
70 70
 // The time the page starts, so we can display the total at the end.
71 71
 // getmicrotime() is in utiltity.php.
72
-define ("STARTTIME", getmicrotime());
72
+define("STARTTIME", getmicrotime());
73 73
 if (!isset($_SERVER['WINDIR'])) {
74 74
     $rusage = getrusage();
75
-    define ('STARTTIMES', $rusage['ru_stime.tv_sec']*1000000 + $rusage['ru_stime.tv_usec']);
76
-    define ('STARTTIMEU', $rusage['ru_utime.tv_sec']*1000000 + $rusage['ru_utime.tv_usec']);
75
+    define('STARTTIMES', $rusage['ru_stime.tv_sec'] * 1000000 + $rusage['ru_stime.tv_usec']);
76
+    define('STARTTIMEU', $rusage['ru_utime.tv_sec'] * 1000000 + $rusage['ru_utime.tv_usec']);
77 77
 }
78 78
 
79 79
 $DATA = new \MySociety\TheyWorkForYou\Data;
80 80
 
81 81
 class ParlDB extends \MySociety\TheyWorkForYou\Db\Connection {
82 82
     public function __construct() {
83
-        $this->init (OPTION_TWFY_DB_HOST, OPTION_TWFY_DB_USER, OPTION_TWFY_DB_PASS, OPTION_TWFY_DB_NAME);
83
+        $this->init(OPTION_TWFY_DB_HOST, OPTION_TWFY_DB_USER, OPTION_TWFY_DB_PASS, OPTION_TWFY_DB_NAME);
84 84
     }
85 85
 }
86 86
 
87 87
 $filter = new \MySociety\TheyWorkForYou\Utility\LibFilter;
88 88
 
89
-include_once (INCLUDESPATH."easyparliament/user.php");
89
+include_once (INCLUDESPATH . "easyparliament/user.php");
90 90
 
91 91
 // Test to see if this is a new-style template using the renderer class.
92
-if (! isset($new_style_template) OR $new_style_template !== TRUE) {
92
+if (!isset($new_style_template) OR $new_style_template !== TRUE) {
93 93
 
94 94
     // This is an old-style page. Use the old page classes.
95
-    include_once (INCLUDESPATH."easyparliament/page.php");
95
+    include_once (INCLUDESPATH . "easyparliament/page.php");
96 96
 
97 97
 }
98 98
 
99
-include_once (INCLUDESPATH."easyparliament/hansardlist.php");
100
-include_once (INCLUDESPATH."dbtypes.php");
101
-include_once (INCLUDESPATH."easyparliament/commentlist.php");
102
-include_once (INCLUDESPATH."easyparliament/comment.php");
99
+include_once (INCLUDESPATH . "easyparliament/hansardlist.php");
100
+include_once (INCLUDESPATH . "dbtypes.php");
101
+include_once (INCLUDESPATH . "easyparliament/commentlist.php");
102
+include_once (INCLUDESPATH . "easyparliament/comment.php");
103 103
 
104 104
 // Added in as new module by Richard Allan MP
105
-include_once (INCLUDESPATH."easyparliament/alert.php");
105
+include_once (INCLUDESPATH . "easyparliament/alert.php");
106 106
 
107 107
 twfy_debug_timestamp("at end of init.php");
Please login to merge, or discard this patch.
www/includes/easyparliament/metadata.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -530,7 +530,7 @@  discard block
 block discarded – undo
530 530
         'url'			=> 'peer/'
531 531
     ),
532 532
     'peers' => array (
533
-         'menu'			=> array (
533
+            'menu'			=> array (
534 534
             'text'			=> 'Lords',
535 535
             'title'			=> "List of all Lords"
536 536
         ),
@@ -539,7 +539,7 @@  discard block
 block discarded – undo
539 539
         'url'			=> 'peers/'
540 540
     ),
541 541
 'overview' => array (
542
-     'menu'			=> array (
542
+        'menu'			=> array (
543 543
         'text'			=> 'Overview',
544 544
         'title'			=> "Overview of the UK Parliament"
545 545
     ),
@@ -591,7 +591,7 @@  discard block
 block discarded – undo
591 591
         'url'			=> 'rss/mp/'
592 592
     ),
593 593
     'mps' => array (
594
-         'menu'			=> array (
594
+            'menu'			=> array (
595 595
             'text'			=> 'MPs',
596 596
             'title'			=> "List of all Members of Parliament (MPs)"
597 597
         ),
Please login to merge, or discard this patch.
Spacing   +245 added lines, -245 removed lines patch added patch discarded remove patch
@@ -65,10 +65,10 @@  discard block
 block discarded – undo
65 65
 
66 66
 */
67 67
 
68
-$this->page = array (
68
+$this->page = array(
69 69
 
70 70
 // Things used on EVERY page, unless overridden for a page:
71
-    'default' => array (
71
+    'default' => array(
72 72
         'parent'	=> '',
73 73
         'session_vars' => array('super_debug'),
74 74
         'sitetitle'		=> 'TheyWorkForYou',
@@ -78,122 +78,122 @@  discard block
 block discarded – undo
78 78
 
79 79
 // KEEP THE PAGES IN ALPHABETICAL ORDER! TA.
80 80
 
81
-    'about' => array (
81
+    'about' => array(
82 82
         'title'			=> 'About us',
83 83
         'url'			=> 'about/'
84 84
     ),
85
-    'parliaments' => array (
85
+    'parliaments' => array(
86 86
         'title' 	=> 'Parliaments and assemblies',
87 87
         'url'       => 'parliaments/'
88 88
     ),
89 89
 
90
-    'alert_stats' => array (
90
+    'alert_stats' => array(
91 91
         'title'			=> 'Email alerts statistics',
92 92
         'parent'		=> 'admin',
93 93
         'url'			=> 'admin/alert_stats.php',
94 94
     ),
95
-    'admin_badusers' => array (
95
+    'admin_badusers' => array(
96 96
         'title'			=> 'Bad users',
97 97
         'parent'		=> 'admin',
98 98
         'url'			=> 'admin/badusers.php'
99 99
     ),
100
-    'admin_home' => array (
100
+    'admin_home' => array(
101 101
         'title'			=> 'Home',
102 102
         'parent'		=> 'admin',
103 103
         'url'			=> 'admin/'
104 104
     ),
105
-    'admin_comments' => array (
105
+    'admin_comments' => array(
106 106
         'title'			=> 'Recent comments',
107 107
         'parent'		=> 'admin',
108 108
         'url'			=> 'admin/comments.php'
109 109
     ),
110
-    'admin_commentreport' => array (
110
+    'admin_commentreport' => array(
111 111
         'title'			=> 'Processing a comment report',
112 112
         'parent'		=> 'admin',
113 113
         'url'			=> 'admin/report.php',
114
-        'session_vars'	=> array ('rid', 'cid')
114
+        'session_vars'	=> array('rid', 'cid')
115 115
     ),
116
-    'admin_commentreports' => array (
116
+    'admin_commentreports' => array(
117 117
         'title'			=> 'Outstanding comment reports',
118 118
         'parent'		=> 'admin',
119 119
         'url'			=> 'admin/reports.php'
120 120
     ),
121
-    'admin_failedsearches' => array (
121
+    'admin_failedsearches' => array(
122 122
         'title'			=> 'Failed searches',
123 123
         'parent'		=> 'admin',
124 124
         'url'			=> 'admin/failedsearches.php'
125 125
     ),
126
-    'admin_glossary' => array (
126
+    'admin_glossary' => array(
127 127
         'title'			=> 'Manage glossary entries',
128 128
         'parent'		=> 'admin',
129 129
         'url'			=> 'admin/glossary.php'
130 130
     ),
131
-    'admin_glossary_pending' => array (
131
+    'admin_glossary_pending' => array(
132 132
         'title'			=> 'Review pending glossary entries',
133 133
         'parent'		=> 'admin',
134 134
         'url'			=> 'admin/glossary_pending.php'
135 135
     ),
136
-    'admin_searchlogs' => array (
136
+    'admin_searchlogs' => array(
137 137
         'title'			=> 'Recent searches',
138 138
         'parent'		=> 'admin',
139 139
         'url'			=> 'admin/searchlogs.php'
140 140
     ),
141
-    'admin_popularsearches' => array (
141
+    'admin_popularsearches' => array(
142 142
         'title'			=> 'Popular searches in last 30 days (first 1000)',
143 143
         'parent'		=> 'admin',
144 144
         'url'			=> 'admin/popularsearches.php'
145 145
     ),
146
-    'admin_statistics' => array (
146
+    'admin_statistics' => array(
147 147
         'title'			=> 'General statistics',
148 148
         'parent'		=> 'admin',
149 149
         'url'			=> 'admin/statistics.php'
150 150
     ),
151
-    'admin_reportstats' => array (
151
+    'admin_reportstats' => array(
152 152
         'title'			=> 'Reporting statistics',
153 153
         'parent'		=> 'admin',
154 154
         'url'			=> 'admin/reporting_stats.php'
155 155
     ),
156
-    'admin_photos' => array (
156
+    'admin_photos' => array(
157 157
         'title'			=> 'Photo upload/attribution',
158 158
         'parent'		=> 'admin',
159 159
         'url'			=> 'admin/photos.php',
160 160
     ),
161
-    'admin_profile_message' => array (
161
+    'admin_profile_message' => array(
162 162
         'title'			=> 'Profile message banner',
163 163
         'parent'		=> 'admin',
164 164
         'url'			=> 'admin/profile-message.php',
165 165
     ),
166
-    'admin_mpurls' => array (
166
+    'admin_mpurls' => array(
167 167
         'title'			=> 'MP Websites',
168 168
         'parent'		=> 'admin',
169 169
         'url'			=> 'admin/websites.php',
170 170
     ),
171
-    'admin_policies' => array (
171
+    'admin_policies' => array(
172 172
         'title'			=> 'MP Policy details',
173 173
         'parent'		=> 'admin',
174 174
         'url'			=> 'admin/policies.php',
175 175
     ),
176
-    'admin_banner' => array (
176
+    'admin_banner' => array(
177 177
         'title'			=> 'Edit Banner',
178 178
         'parent'		=> 'admin',
179 179
         'url'			=> 'admin/banner.php',
180 180
     ),
181
-    'admin_featured' => array (
181
+    'admin_featured' => array(
182 182
         'title'			=> 'Featured debates',
183 183
         'parent'		=> 'admin',
184 184
         'url'			=> 'admin/featured.php',
185 185
     ),
186
-    'admin_topics' => array (
186
+    'admin_topics' => array(
187 187
         'title'			=> 'Topics',
188 188
         'parent'		=> 'admin',
189 189
         'url'			=> 'admin/topics.php',
190 190
     ),
191
-    'admin_edittopics' => array (
191
+    'admin_edittopics' => array(
192 192
         'title'			=> 'Edit Topic',
193 193
         'parent'		=> 'admin_topics',
194 194
         'url'			=> 'admin/edittopic.php',
195 195
     ),
196
-    'admin_wikipedia' => array (
196
+    'admin_wikipedia' => array(
197 197
         'title' => 'Wikipedia links',
198 198
         'parent' => 'admin',
199 199
         'url' => 'admin/wikipedia.php',
@@ -201,8 +201,8 @@  discard block
 block discarded – undo
201 201
 
202 202
 // Added by Richard Allan for email alert functions
203 203
 
204
-    'alert' => array (
205
-        'menu'			=> array (
204
+    'alert' => array(
205
+        'menu'			=> array(
206 206
             'text'			=> 'Email Alerts',
207 207
             'title'			=> "Set up alerts for updates on an MP or Peer by email",
208 208
             'sidebar'		=> 'alert'
@@ -211,30 +211,30 @@  discard block
 block discarded – undo
211 211
         'title'			=> 'TheyWorkForYou Email Alerts',
212 212
         'url'			=> 'alert/',
213 213
     ),
214
-    'alertwelcome' => array (
214
+    'alertwelcome' => array(
215 215
         'title'			=> 'Email Alerts',
216 216
         'url'			=> 'alert/',
217 217
     ),
218 218
 
219 219
 // End of ALERTS additions
220 220
 
221
-    'api_front'		=> array (
222
-        'menu'			=> array (
221
+    'api_front'		=> array(
222
+        'menu'			=> array(
223 223
             'text'			=> 'API',
224 224
             'title'			=> 'Access our data'
225 225
         ),
226 226
         'title'			=> 'TheyWorkForYou API',
227 227
         'url'			=> 'api/'
228 228
     ),
229
-    'api_doc_front'		=> array (
230
-        'menu'			=> array (
229
+    'api_doc_front'		=> array(
230
+        'menu'			=> array(
231 231
             'text'			=> 'API',
232 232
             'title'			=> 'Access our data'
233 233
         ),
234 234
         'parent'		=> 'api_front',
235 235
         'url'			=> 'api/'
236 236
     ),
237
-    'api_key'		=> array (
237
+    'api_key'		=> array(
238 238
         'title'			=> 'Plan and keys',
239 239
         'parent'		=> 'api_front',
240 240
         'url'			=> 'api/key'
@@ -245,69 +245,69 @@  discard block
 block discarded – undo
245 245
         'url' => 'boundaries/',
246 246
     ),
247 247
 
248
-    'calendar_summary' => array (
249
-        'menu'			=> array (
248
+    'calendar_summary' => array(
249
+        'menu'			=> array(
250 250
             'text'			=> 'Upcoming',
251 251
             'title'			=> '',
252 252
         ),
253 253
         'parent'		=> 'hansard',
254 254
         'url'			=> 'calendar/'
255 255
     ),
256
-    'calendar_future_head' => array (
256
+    'calendar_future_head' => array(
257 257
         'parent'		=> 'calendar_summary',
258 258
         'title'			=> 'Upcoming business',
259 259
         'url'			=> 'calendar/'
260 260
     ),
261
-    'calendar_future' => array (
261
+    'calendar_future' => array(
262 262
         'parent'		=> 'calendar_future_head',
263 263
         'url'			=> 'calendar/'
264 264
     ),
265
-    'calendar_today_head' => array (
265
+    'calendar_today_head' => array(
266 266
         'parent'		=> 'calendar_summary',
267 267
         'title'			=> 'Today’s business',
268 268
         'url'			=> 'calendar/'
269 269
     ),
270
-    'calendar_today' => array (
270
+    'calendar_today' => array(
271 271
         'parent'		=> 'calendar_today_head',
272 272
         'url'			=> 'calendar/'
273 273
     ),
274
-    'calendar_past_head' => array (
274
+    'calendar_past_head' => array(
275 275
         'parent'		=> 'calendar_summary',
276 276
         'title'			=> 'Previous business',
277 277
         'url'			=> 'calendar/'
278 278
     ),
279
-    'calendar_past' => array (
279
+    'calendar_past' => array(
280 280
         'parent'		=> 'calendar_past_head',
281 281
         'url'			=> 'calendar/'
282 282
     ),
283 283
 
284
-    'cards' => array (
284
+    'cards' => array(
285 285
         'title'			=> 'MP Stats Cards',
286 286
         'url'			=> 'cards/'
287 287
     ),
288 288
 
289
-    'campaign_foi' => array (
289
+    'campaign_foi' => array(
290 290
         'title'			=> 'Freedom of Information (Parliament) Order 2009',
291 291
         'url'			=> 'foiorder2009/'
292 292
     ),
293
-    'campaign' => array (
293
+    'campaign' => array(
294 294
         'title'			=> '', #Free Our Bills!',
295 295
         'url'			=> 'freeourbills/'
296 296
     ),
297
-    'campaign_edm' => array (
297
+    'campaign_edm' => array(
298 298
         'title'			=> 'Early Day Motion',
299 299
         'parent'		=> 'campaign',
300 300
         'url'			=> 'freeourbills/'
301 301
     ),
302 302
 
303
-    'commentreport' => array (
303
+    'commentreport' => array(
304 304
         'title'			=> 'Reporting a comment',
305 305
         'url'			=> 'report/',
306
-        'session_vars'	=> array ('id')
306
+        'session_vars'	=> array('id')
307 307
     ),
308 308
 
309
-    'comments_recent' => array (
310
-        'menu'			=> array (
309
+    'comments_recent' => array(
310
+        'menu'			=> array(
311 311
             'text'			=> 'Recent comments',
312 312
             'title'			=> "Recently posted comments"
313 313
         ),
@@ -316,8 +316,8 @@  discard block
 block discarded – undo
316 316
         'url'			=> 'comments/recent/'
317 317
     ),
318 318
 
319
-    'contact' => array (
320
-        'menu'			=> array (
319
+    'contact' => array(
320
+        'menu'			=> array(
321 321
             'text'			=> 'Contact',
322 322
             'title'			=> '',
323 323
         ),
@@ -328,23 +328,23 @@  discard block
 block discarded – undo
328 328
         'title' => 'News',
329 329
         'url' => 'https://www.mysociety.org/category/projects/theyworkforyou/'
330 330
     ),
331
-    'debate'  => array (
331
+    'debate'  => array(
332 332
         'parent'		=> 'debatesfront',
333 333
         'url'			=> 'debates/',
334
-        'session_vars'	=> array ('id'),
334
+        'session_vars'	=> array('id'),
335 335
     ),
336
-    'debates'  => array (
336
+    'debates'  => array(
337 337
         'parent'		=> 'debatesfront',
338 338
         'url'			=> 'debates/',
339
-        'session_vars'	=> array ('id'),
339
+        'session_vars'	=> array('id'),
340 340
     ),
341
-    'debatesday' => array (
341
+    'debatesday' => array(
342 342
         'parent'		=> 'debatesfront',
343
-        'session_vars'	=> array ('d'),
343
+        'session_vars'	=> array('d'),
344 344
         'url'			=> 'debates/',
345 345
     ),
346
-    'alldebatesfront' => array (
347
-        'menu'			=> array (
346
+    'alldebatesfront' => array(
347
+        'menu'			=> array(
348 348
             'text'			=> 'Debates',
349 349
             'title'			=> "Debates in the House of Commons, Westminster Hall, and the House of Lords"
350 350
         ),
@@ -353,8 +353,8 @@  discard block
 block discarded – undo
353 353
         'rss'			=> 'rss/debates.rss',
354 354
         'url'			=> 'debates/'
355 355
     ),
356
-    'debatesfront' => array (
357
-        'menu'			=> array (
356
+    'debatesfront' => array(
357
+        'menu'			=> array(
358 358
             'text'			=> 'Commons debates',
359 359
             'title'			=> "Debates in the House of Commons"
360 360
         ),
@@ -363,12 +363,12 @@  discard block
 block discarded – undo
363 363
         'rss'			=> 'rss/debates.rss',
364 364
         'url'			=> 'debates/'
365 365
     ),
366
-    'debatesyear' => array (
366
+    'debatesyear' => array(
367 367
         'parent'		=> 'debatesfront',
368 368
         'url'			=> 'debates/'
369 369
     ),
370
-    'divisions_recent' => array (
371
-        'menu'			=> array (
370
+    'divisions_recent' => array(
371
+        'menu'			=> array(
372 372
             'text'			=> 'Recent Votes',
373 373
             'title'			=> ''
374 374
         ),
@@ -376,13 +376,13 @@  discard block
 block discarded – undo
376 376
         'title'			=> 'Recent Votes',
377 377
         'url'			=> 'divisions/'
378 378
     ),
379
-    'divisions_vote' => array (
379
+    'divisions_vote' => array(
380 380
         'parent'		=> 'divisions_recent',
381 381
         'title'			=> 'Vote',
382 382
         'url'			=> 'divisions/division.php',
383 383
         'session_vars'	=> array('vote'),
384 384
     ),
385
-    'epvote' => array (
385
+    'epvote' => array(
386 386
         'url'			=> 'vote/'
387 387
     ),
388 388
 
@@ -391,19 +391,19 @@  discard block
 block discarded – undo
391 391
         'title'			=> 'TheyWorkForYou Google gadget',
392 392
     ),
393 393
 
394
-    'glossary' => array (
394
+    'glossary' => array(
395 395
         'heading'		=> 'Glossary',
396 396
         'parent'		=> 'help_us_out',
397 397
         'url'			=> 'glossary/'
398 398
     ),
399
-    'glossary_item' => array (
399
+    'glossary_item' => array(
400 400
         'heading'		=> 'Glossary heading',
401 401
         'parent'		=> 'help_us_out',
402 402
         'url'			=> 'glossary/',
403
-        'session_vars'	=> array ('g')
403
+        'session_vars'	=> array('g')
404 404
     ),
405
-    'hansard' => array (
406
-        'menu'			=> array (
405
+    'hansard' => array(
406
+        'menu'			=> array(
407 407
             'text'			=> 'UK Parliament',
408 408
             'title'			=> "Houses of Parliament debates, Written Answers, Statements, Westminster Hall debates, and Bill Committees"
409 409
         ),
@@ -411,16 +411,16 @@  discard block
 block discarded – undo
411 411
         'url'			=> ''
412 412
     ),
413 413
         // Hansard landing page
414
-        'hansard_landing' => array (
414
+        'hansard_landing' => array(
415 415
                 'title'                 => 'Hansard',
416 416
                 'url'                   => 'search-hansard/',
417 417
         ),
418
-    'help' => array (
418
+    'help' => array(
419 419
         'title'			=> 'Help - Frequently Asked Questions',
420 420
         'url'			=> 'help/'
421 421
     ),
422
-    'help_us_out' => array (
423
-        'menu'			=> array (
422
+    'help_us_out' => array(
423
+        'menu'			=> array(
424 424
             'text'			=> 'Glossary',
425 425
             'title'			=> "Parliament's jargon explained"
426 426
         ),
@@ -429,88 +429,88 @@  discard block
 block discarded – undo
429 429
         'url'			=> 'addterm/',
430 430
         'sidebar'		=> 'glossary_add'
431 431
     ),
432
-    'home' => array (
432
+    'home' => array(
433 433
         'title'			=> "UK Parliament",
434 434
         'rss'			=> 'news/index.rdf',
435 435
         'url'			=> ''
436 436
     ),
437
-    'houserules' => array (
437
+    'houserules' => array(
438 438
         'title'			=> 'House rules',
439 439
         'url'			=> 'houserules/'
440 440
     ),
441 441
 
442
-    'linktous' => array (
442
+    'linktous' => array(
443 443
         'title'			=> 'Link to us',
444 444
         'heading'		=> 'How to link to us',
445 445
         'url'			=> 'help/linktous/'
446 446
     ),
447
-    'api' => array (
447
+    'api' => array(
448 448
         'title'			=> 'API',
449 449
         'heading'		=> 'API - Query the TheyWorkForYou database',
450 450
         'url'			=> 'api/'
451 451
     ),
452
-    'data' => array (
452
+    'data' => array(
453 453
         'title'			=> 'Raw Data',
454 454
         'heading'		=> 'Raw data (XML) - the data behind TheyWorkForYou and Public Whip',
455 455
         'url'			=> 'http://parser.theyworkforyou.com'
456 456
     ),
457
-    'pombola' => array (
457
+    'pombola' => array(
458 458
         'title'			=> 'Pombola',
459 459
         'heading'		=> 'mySociety\'s platform for running a Parliamentary monitoring site like this',
460 460
         'url'			=> 'https://www.mysociety.org/projects/parliamentarymonitoring/pombola'
461 461
     ),
462
-    'devmailinglist' => array (
462
+    'devmailinglist' => array(
463 463
         'title'			=> 'Developer mailing list',
464 464
         'heading'		=> 'Developer mailing list',
465 465
         'url'			=> 'https://groups.google.com/a/mysociety.org/forum/#!forum/theyworkforyou'
466 466
     ),
467
-    'code' => array (
467
+    'code' => array(
468 468
         'title'			=> 'Source code',
469 469
         'heading'		=> 'TheyWorkForYou Source code',
470 470
         'url'			=> 'https://github.com/mysociety/theyworkforyou'
471 471
     ),
472
-    'irc' => array (
472
+    'irc' => array(
473 473
         'title'			=> 'IRC chat channel',
474 474
         'heading'		=> 'IRC chat channel',
475 475
         'url'			=> 'http://www.irc.mysociety.org/'
476 476
     ),
477
-    'newzealand' => array (
477
+    'newzealand' => array(
478 478
         'title'			=> 'New Zealand',
479 479
         'heading'		=> 'They Work For You - New Zealand',
480 480
         'url'			=> 'http://www.theyworkforyou.co.nz/'
481 481
     ),
482
-    'australia' => array (
482
+    'australia' => array(
483 483
         'title'			=> 'Australia',
484 484
         'heading'		=> 'Open Australia',
485 485
         'url'			=> 'http://www.openaustralia.org/'
486 486
     ),
487
-    'ireland' => array (
487
+    'ireland' => array(
488 488
         'title'			=> 'Ireland',
489 489
         'heading'		=> 'TheyWorkForYou for the Houses of the Oireachtas',
490 490
         'url'			=> 'http://www.kildarestreet.com/'
491 491
     ),
492
-    'mzalendo' => array (
492
+    'mzalendo' => array(
493 493
         'title'			=> 'Mzalendo',
494 494
         'heading'		=> 'Keeping an eye on the Kenyan Parliament',
495 495
         'url'			=> 'http://info.mzalendo.com/'
496 496
     ),
497
-    'lordsdebate'  => array (
497
+    'lordsdebate'  => array(
498 498
         'parent'		=> 'lordsdebatesfront',
499 499
         'url'			=> 'lords/',
500
-        'session_vars'	=> array ('id'),
500
+        'session_vars'	=> array('id'),
501 501
     ),
502
-    'lordsdebates'  => array (
502
+    'lordsdebates'  => array(
503 503
         'parent'		=> 'lordsdebatesfront',
504 504
         'url'			=> 'lords/',
505
-        'session_vars'	=> array ('id'),
505
+        'session_vars'	=> array('id'),
506 506
     ),
507
-    'lordsdebatesday' => array (
507
+    'lordsdebatesday' => array(
508 508
         'parent'		=> 'lordsdebatesfront',
509
-        'session_vars'	=> array ('d'),
509
+        'session_vars'	=> array('d'),
510 510
         'url'			=> 'lords/',
511 511
     ),
512
-    'lordsdebatesfront' => array (
513
-        'menu'			=> array (
512
+    'lordsdebatesfront' => array(
513
+        'menu'			=> array(
514 514
             'text'			=> 'Lords debates',
515 515
             'title'			=> "House of Lords debates"
516 516
         ),
@@ -519,24 +519,24 @@  discard block
 block discarded – undo
519 519
         'rss'			=> 'rss/lords.rss',
520 520
         'url'			=> 'lords/'
521 521
     ),
522
-    'lordsdebatesyear' => array (
522
+    'lordsdebatesyear' => array(
523 523
         'parent'		=> 'lordsdebatesfront',
524 524
         'url'			=> 'lords/'
525 525
     ),
526 526
 
527 527
         // Parliament landing page
528
-        'parliament_landing' => array (
528
+        'parliament_landing' => array(
529 529
                 'title'                 => 'Parliament',
530 530
                 'url'                   => 'parliament/',
531 531
         ),
532 532
 
533
-    'peer' => array (
533
+    'peer' => array(
534 534
         'parent'		=> 'peers',
535 535
         'title'			=> 'Peer',
536 536
         'url'			=> 'peer/'
537 537
     ),
538
-    'peers' => array (
539
-         'menu'			=> array (
538
+    'peers' => array(
539
+         'menu'			=> array(
540 540
             'text'			=> 'Lords',
541 541
             'title'			=> "List of all Lords"
542 542
         ),
@@ -544,8 +544,8 @@  discard block
 block discarded – undo
544 544
         'title'			=> '',
545 545
         'url'			=> 'peers/'
546 546
     ),
547
-'overview' => array (
548
-     'menu'			=> array (
547
+'overview' => array(
548
+     'menu'			=> array(
549 549
         'text'			=> 'Overview',
550 550
         'title'			=> "Overview of the UK Parliament"
551 551
     ),
@@ -554,50 +554,50 @@  discard block
 block discarded – undo
554 554
     'rss'			=> 'news/index.rdf',
555 555
     'url'			=> ''
556 556
 ),
557
-    'mla' => array (
557
+    'mla' => array(
558 558
         'parent'		=> 'mlas',
559 559
         'title'			=> 'Find your MLA',
560 560
         'url'			=> 'mla/'
561 561
     ),
562
-    'mlas' => array (
562
+    'mlas' => array(
563 563
         'parent'		=> 'ni_home',
564
-        'menu'			=> array (
564
+        'menu'			=> array(
565 565
             'text'			=> 'MLAs',
566 566
             'title'			=> "List of all Members of the Northern Ireland Assembly (MLAs)"
567 567
         ),
568 568
         'title'			=> '',
569 569
         'url'			=> 'mlas/'
570 570
     ),
571
-    'msps' => array (
571
+    'msps' => array(
572 572
         'parent'		=> 'sp_home',
573
-        'menu'			=> array (
573
+        'menu'			=> array(
574 574
             'text'			=> 'MSPs',
575 575
             'title'			=> "List of Members of the Scottish Parliament (MSPs)"
576 576
         ),
577 577
         'title'			=> '',
578 578
         'url'			=> 'msps/'
579 579
     ),
580
-    'msp' => array (
580
+    'msp' => array(
581 581
         'parent'		=> 'msps',
582 582
         'title'			=> 'Find your MSP',
583 583
         'url'			=> 'msp/'
584 584
     ),
585 585
     /* Not 'Your MP', whose name is 'yourmp'... */
586
-    'mp' => array (
586
+    'mp' => array(
587 587
         'parent'			=> 'mps',
588 588
         'title'			=> 'Find your MP',
589 589
         'url'			=> 'mp/'
590 590
     ),
591
-    'emailfriend' => array (
591
+    'emailfriend' => array(
592 592
         'title'			=> 'Send this page to a friend',
593 593
         'url'			=> 'email/'
594 594
     ),
595 595
     // The directory MPs' RSS feeds are stored in.
596
-    'mp_rss' => array (
596
+    'mp_rss' => array(
597 597
         'url'			=> 'rss/mp/'
598 598
     ),
599
-    'mps' => array (
600
-         'menu'			=> array (
599
+    'mps' => array(
600
+         'menu'			=> array(
601 601
             'text'			=> 'MPs',
602 602
             'title'			=> "List of all Members of Parliament (MPs)"
603 603
         ),
@@ -608,16 +608,16 @@  discard block
 block discarded – undo
608 608
 
609 609
     /* Northern Ireland Assembly */
610 610
     'ni_home' => array(
611
-        'menu'			=> array (
611
+        'menu'			=> array(
612 612
             'text'			=> 'Northern Ireland Assembly',
613 613
             'title'			=> 'Full authority over <em>transferred matters</em>, which include agriculture, education, employment, the environment and health'
614 614
         ),
615 615
         'title'			=> 'Northern Ireland Assembly',
616 616
         'url'			=> 'ni/'
617 617
     ),
618
-    'nioverview' => array (
618
+    'nioverview' => array(
619 619
         'parent'		=> 'ni_home',
620
-        'menu'			=> array (
620
+        'menu'			=> array(
621 621
             'text'			=> 'Debates',
622 622
             'title'			=> "Overview of the Northern Ireland Assembly debates"
623 623
         ),
@@ -625,23 +625,23 @@  discard block
 block discarded – undo
625 625
         'rss'			=> 'rss/ni.rss',
626 626
         'url'			=> 'ni/'
627 627
     ),
628
-    'nidebate'  => array (
628
+    'nidebate'  => array(
629 629
         'parent'		=> 'nidebatesfront',
630 630
         'url'			=> 'ni/',
631
-        'session_vars'	=> array ('id'),
631
+        'session_vars'	=> array('id'),
632 632
     ),
633
-    'nidebates'  => array (
633
+    'nidebates'  => array(
634 634
         'parent'		=> 'nidebatesfront',
635 635
         'url'			=> 'ni/',
636
-        'session_vars'	=> array ('id'),
636
+        'session_vars'	=> array('id'),
637 637
     ),
638
-    'nidebatesday' => array (
638
+    'nidebatesday' => array(
639 639
         'parent'		=> 'nidebatesfront',
640
-        'session_vars'	=> array ('d'),
640
+        'session_vars'	=> array('d'),
641 641
         'url'			=> 'ni/',
642 642
     ),
643
-    'nidebatesfront' => array (
644
-        'menu'			=> array (
643
+    'nidebatesfront' => array(
644
+        'menu'			=> array(
645 645
             'text'			=> 'Debates',
646 646
             'title'			=> "Northern Ireland Assembly debates"
647 647
         ),
@@ -650,7 +650,7 @@  discard block
 block discarded – undo
650 650
         'rss'			=> 'rss/ni.rss',
651 651
         'url'			=> 'ni/'
652 652
     ),
653
-    'nidebatesyear' => array (
653
+    'nidebatesyear' => array(
654 654
         'parent'		=> 'nidebatesfront',
655 655
         'url'			=> 'ni/'
656 656
     ),
@@ -658,7 +658,7 @@  discard block
 block discarded – undo
658 658
     /* London Assembly */
659 659
 
660 660
     'london_home' => array(
661
-        'menu'          => array (
661
+        'menu'          => array(
662 662
             'text'      => 'London Assembly',
663 663
             'title'     => 'Members of the London Assembly, answers from the Mayor of London'
664 664
         ),
@@ -666,9 +666,9 @@  discard block
 block discarded – undo
666 666
         'url'           => 'london/'
667 667
     ),
668 668
 
669
-    'london-assembly-members' => array (
669
+    'london-assembly-members' => array(
670 670
         'parent'        => 'london_home',
671
-        'menu'          => array (
671
+        'menu'          => array(
672 672
             'text'      => 'London Assembly Members',
673 673
             'title'     => "List of Members of the London Assembly)"
674 674
         ),
@@ -676,48 +676,48 @@  discard block
 block discarded – undo
676 676
         'url'           => 'london-assembly-members/'
677 677
     ),
678 678
 
679
-    'london-assembly-member' => array (
679
+    'london-assembly-member' => array(
680 680
         'parent'        => 'london-assembly-members',
681 681
         'title'         => 'Find your London Assembly Member',
682 682
         'url'           => 'london-assembly-member/'
683 683
     ),
684 684
 
685
-    'lmqs' => array (
685
+    'lmqs' => array(
686 686
         'parent'		=> 'london_home',
687 687
         'url'			=> 'london/',
688
-        'session_vars'	=> array ('id')
688
+        'session_vars'	=> array('id')
689 689
     ),
690
-    'lmqsday'  => array (
690
+    'lmqsday'  => array(
691 691
         'parent'		=> 'london_home',
692 692
         'url'			=> 'london/',
693 693
     ),
694
-    'lmqsfront' => array (
694
+    'lmqsfront' => array(
695 695
         'parent'		=> 'london_home',
696
-        'menu'			=> array (
696
+        'menu'			=> array(
697 697
             'text'			=> 'Questions to the Mayor of London',
698 698
             'title'			=> "Questions to the Mayor of London"
699 699
         ),
700 700
         'title'			=> 'questions to the Mayor of London',
701 701
         'url'			=> 'london/',
702 702
     ),
703
-    'lmqsyear' => array (
703
+    'lmqsyear' => array(
704 704
         'parent'		=> 'london_home',
705 705
         'url'			=> 'london/',
706 706
     ),
707 707
 
708
-    'otheruseredit' => array (
708
+    'otheruseredit' => array(
709 709
         'pg'			=> 'editother',
710 710
         'title'			=> "Editing a user's data",
711 711
         'url'			=> 'user/'
712 712
     ),
713
-    'privacy' => array (
713
+    'privacy' => array(
714 714
         'title'			=> 'Privacy Policy',
715 715
         'url'			=> 'privacy/'
716 716
     ),
717 717
 
718 718
     /* Public bill committees */
719
-    'pbc_front' => array (
720
-        'menu'			=> array (
719
+    'pbc_front' => array(
720
+        'menu'			=> array(
721 721
             'text'			=> 'Bill Committees',
722 722
             'title'			=> "Public Bill Committees (formerly Standing Committees) debates"
723 723
         ),
@@ -735,17 +735,17 @@  discard block
 block discarded – undo
735 735
         'title' => '',
736 736
         'url' => 'pbc/',
737 737
         'parent' => 'pbc_front',
738
-        'session_vars'	=> array ('bill'),
738
+        'session_vars'	=> array('bill'),
739 739
     ),
740 740
     'pbc_clause' => array(
741 741
         'parent'		=> 'pbc_front',
742 742
         'url'			=> 'pbc/',
743
-        'session_vars'	=> array ('id'),
743
+        'session_vars'	=> array('id'),
744 744
     ),
745 745
     'pbc_speech' => array(
746 746
         'parent'		=> 'pbc_front',
747 747
         'url'			=> 'pbc/',
748
-        'session_vars'	=> array ('id'),
748
+        'session_vars'	=> array('id'),
749 749
     ),
750 750
 
751 751
     'people' => array(
@@ -757,62 +757,62 @@  discard block
 block discarded – undo
757 757
         'url'			=> '',
758 758
     ),
759 759
 
760
-    'raw' => array (
760
+    'raw' => array(
761 761
         'title'			=> 'Raw data',
762 762
         'url'			=> 'raw/'
763 763
     ),
764 764
 
765
-    'regmem' => array (
765
+    'regmem' => array(
766 766
         'title'			=> 'Changes to the Register of Members\' Interests',
767 767
         'url'			=> 'regmem/'
768 768
     ),
769 769
 
770
-    'regmem_date' => array (
770
+    'regmem_date' => array(
771 771
         'url'			=> 'regmem/',
772 772
         'parent'		=> 'regmem'
773 773
     ),
774 774
 
775
-    'regmem_mp' => array (
775
+    'regmem_mp' => array(
776 776
         'url'			=> 'regmem/',
777 777
         'parent'		=> 'regmem'
778 778
     ),
779 779
 
780
-    'regmem_diff' => array (
780
+    'regmem_diff' => array(
781 781
         'url'			=> 'regmem/',
782 782
         'parent'		=> 'regmem'
783 783
     ),
784 784
 
785
-    'royal' => array (
785
+    'royal' => array(
786 786
         'parent'        => 'hansard',
787 787
         'title'         => 'Royal',
788 788
         'url'           => 'royal/',
789 789
     ),
790 790
 
791
-    'topic' => array (
791
+    'topic' => array(
792 792
         'parent'        => 'topics',
793 793
         'url'           => 'topic/topic.php',
794 794
     ),
795 795
 
796
-    'topics' => array (
796
+    'topics' => array(
797 797
         'title'        => 'Topics',
798 798
         'url'          => 'topic/',
799 799
     ),
800 800
 
801
-    'search'		=> array (
801
+    'search'		=> array(
802 802
         'sidebar'		=> 'search',
803 803
         'url'			=> 'search/',
804 804
         'robots'		=> 'noindex, nofollow',
805 805
         'heading'		=> '',
806
-        'session_vars'	=> array ('q', 's', 'pid', 'o', 'pop')
806
+        'session_vars'	=> array('q', 's', 'pid', 'o', 'pop')
807 807
     ),
808
-    'search_help'		=> array (
808
+    'search_help'		=> array(
809 809
         'sidebar'		=> 'search',
810 810
         'title'			=> 'Help with searching',
811 811
         'url'			=> 'search/'
812 812
     ),
813 813
 
814
-    'sitenews'		=> array (
815
-        'menu'			=> array (
814
+    'sitenews'		=> array(
815
+        'menu'			=> array(
816 816
             'text'			=> 'TheyWorkForYou news',
817 817
             'title'			=> "News about changes to this website"
818 818
         ),
@@ -822,68 +822,68 @@  discard block
 block discarded – undo
822 822
         'title'			=> 'TheyWorkForYou news',
823 823
         'url'			=> 'news/'
824 824
     ),
825
-    'sitenews_archive'		=> array (
825
+    'sitenews_archive'		=> array(
826 826
         'parent'		=> 'sitenews',
827 827
         'rss'			=> 'news/index.rdf',
828 828
         'sidebar'		=> 'sitenews',
829 829
         'title'			=> 'Archive',
830 830
         'url'			=> 'news/archives/'
831 831
     ),
832
-    'sitenews_atom' 	=> array (
832
+    'sitenews_atom' 	=> array(
833 833
         'url'			=> 'news/atom.xml'
834 834
     ),
835
-    'sitenews_date'	=> array (
835
+    'sitenews_date'	=> array(
836 836
         'parent'		=> 'sitenews',
837 837
         'rss'			=> 'news/index.rdf',
838 838
         'sidebar'		=> 'sitenews'
839 839
     ),
840
-    'sitenews_individual'	=> array (
840
+    'sitenews_individual'	=> array(
841 841
         'parent'		=> 'sitenews',
842 842
         'rss'			=> 'news/index.rdf',
843 843
         'sidebar'		=> 'sitenews',
844 844
     ),
845
-    'sitenews_rss1' 	=> array (
845
+    'sitenews_rss1' 	=> array(
846 846
         'url'			=> 'news/index.rdf'
847 847
     ),
848
-    'sitenews_rss2' 	=> array (
848
+    'sitenews_rss2' 	=> array(
849 849
         'url'			=> 'news/index.xml'
850 850
     ),
851 851
 
852 852
     /* Scottish Parliament */
853 853
     'sp_home' => array(
854
-        'menu'			=> array (
854
+        'menu'			=> array(
855 855
             'text'			=> 'Scottish Parliament',
856 856
             'title'			=> 'Scottish education, health, agriculture, justice, prisons and other devolved areas. Some tax-varying powers'
857 857
         ),
858 858
         'title'			=> 'Scottish Parliament',
859 859
         'url'			=> 'scotland/'
860 860
     ),
861
-    'spoverview' => array (
861
+    'spoverview' => array(
862 862
         'parent'		=> 'sp_home',
863
-        'menu'			=> array (
863
+        'menu'			=> array(
864 864
             'text'			=> 'Overview',
865 865
             'title'			=> "Overview of the Scottish Parliament"
866 866
         ),
867 867
         'title'			=> '',
868 868
         'url'			=> 'scotland/'
869 869
     ),
870
-    'spdebate'  => array (
870
+    'spdebate'  => array(
871 871
         'parent'		=> 'spdebatesfront',
872 872
         'url'			=> 'sp/',
873
-        'session_vars'	=> array ('id'),
873
+        'session_vars'	=> array('id'),
874 874
     ),
875
-    'spdebates'  => array (
875
+    'spdebates'  => array(
876 876
         'parent'		=> 'spdebatesfront',
877 877
         'url'			=> 'sp/',
878
-        'session_vars'	=> array ('id'),
878
+        'session_vars'	=> array('id'),
879 879
     ),
880
-    'spdebatesday' => array (
880
+    'spdebatesday' => array(
881 881
         'parent'		=> 'spdebatesfront',
882
-        'session_vars'	=> array ('d'),
882
+        'session_vars'	=> array('d'),
883 883
         'url'			=> 'sp/',
884 884
     ),
885
-    'spdebatesfront' => array (
886
-        'menu'			=> array (
885
+    'spdebatesfront' => array(
886
+        'menu'			=> array(
887 887
             'text'			=> 'Debates',
888 888
             'title'			=> ''
889 889
         ),
@@ -892,21 +892,21 @@  discard block
 block discarded – undo
892 892
         'url'			=> 'sp/'
893 893
     ),
894 894
 
895
-    'spdebatesyear' => array (
895
+    'spdebatesyear' => array(
896 896
         'parent'		=> 'spdebatesfront',
897 897
         'url'			=> 'sp/'
898 898
     ),
899
-    'spwrans'  => array (
899
+    'spwrans'  => array(
900 900
         'parent'		=> 'spwransfront',
901 901
         'url'			=> 'spwrans/',
902 902
         #'session_vars'	=> array ('id'),
903 903
     ),
904
-    'spwransday'  => array (
904
+    'spwransday'  => array(
905 905
         'parent'		=> 'spwransfront',
906 906
         'url'			=> 'spwrans/'
907 907
     ),
908
-    'spwransfront'  => array (
909
-        'menu'			=> array (
908
+    'spwransfront'  => array(
909
+        'menu'			=> array(
910 910
             'text'			=> 'Written Answers',
911 911
             'title'			=> ''
912 912
         ),
@@ -919,31 +919,31 @@  discard block
 block discarded – undo
919 919
         'title'			=> 'For questions asked by ',
920 920
         'url'			=> 'spwrans/'
921 921
     ),
922
-    'spwransyear' => array (
922
+    'spwransyear' => array(
923 923
         'parent'		=> 'spwransfront',
924 924
         'url'			=> 'spwrans/'
925 925
     ),
926 926
 
927 927
     // Topic pages
928 928
 
929
-    'topic' => array (
929
+    'topic' => array(
930 930
         'url'           => 'topic/',
931 931
         'title'         => 'Topics'
932 932
     ),
933 933
 
934
-    'topicbenefits' => array (
934
+    'topicbenefits' => array(
935 935
         'url'           => 'topic/benefits',
936 936
         'parent'        => 'topic',
937 937
         'title'         => 'Benefits'
938 938
     ),
939 939
 
940
-    'topiccrimestats' => array (
940
+    'topiccrimestats' => array(
941 941
         'url'           => 'topic/crime-stats',
942 942
         'parent'        => 'topic',
943 943
         'title'         => 'Crime Statistics'
944 944
     ),
945 945
 
946
-    'topicnhs' => array (
946
+    'topicnhs' => array(
947 947
         'url'           => 'topic/nhs',
948 948
         'parent'        => 'topic',
949 949
         'title'         => 'NHS'
@@ -958,29 +958,29 @@  discard block
 block discarded – undo
958 958
         'url'			=> 'user/alerts/',
959 959
         'parent'		=> 'userviewself'
960 960
     ),
961
-    'userchangepc' => array (
961
+    'userchangepc' => array(
962 962
         'title'			=> 'Change your postcode',
963 963
         'url'			=> 'user/changepc/'
964 964
     ),
965
-    'userconfirm' => array (
965
+    'userconfirm' => array(
966 966
         'url'			=> 'user/confirm/'
967 967
     ),
968
-    'userconfirmed' => array (
968
+    'userconfirmed' => array(
969 969
         'sidebar'		=> 'userconfirmed',
970 970
         'title'			=> 'Welcome to TheyWorkForYou!',
971 971
         'url'			=> 'user/confirm/'
972 972
     ),
973
-    'userconfirmfailed' => array (
973
+    'userconfirmfailed' => array(
974 974
         'title'			=> 'Oops!',
975 975
         'url'			=> 'user/confirm/'
976 976
     ),
977
-    'useredit' => array (
977
+    'useredit' => array(
978 978
         'pg'			=> 'edit',
979 979
         'title'			=> 'Edit your details',
980 980
         'url'			=> 'user/'
981 981
     ),
982
-    'userjoin' => array (
983
-                'menu'                  => array (
982
+    'userjoin' => array(
983
+                'menu'                  => array(
984 984
                         'text'                  => 'Join',
985 985
                         'title'                 => "Joining is free and allows you to annotate speeches"
986 986
                 ),
@@ -989,8 +989,8 @@  discard block
 block discarded – undo
989 989
                 'title'                 => 'Join TheyWorkForYou',
990 990
                 'url'                   => 'user/'
991 991
         ),
992
-    'getinvolved' => array (
993
-        'menu'			=> array (
992
+    'getinvolved' => array(
993
+        'menu'			=> array(
994 994
             'text'			=> 'Get involved',
995 995
             'title'			=> "Contribute to TheyWorkForYou"
996 996
         ),
@@ -999,8 +999,8 @@  discard block
 block discarded – undo
999 999
         'title'			=> 'Contribute to TheyWorkForYou',
1000 1000
         'url'			=> 'getinvolved/'
1001 1001
     ),
1002
-    'userlogin' => array (
1003
-        'menu'			=> array (
1002
+    'userlogin' => array(
1003
+        'menu'			=> array(
1004 1004
             'text'			=> 'Sign in',
1005 1005
             'title'			=> "If you've already joined , sign in to add annotations"
1006 1006
         ),
@@ -1009,33 +1009,33 @@  discard block
 block discarded – undo
1009 1009
         'url'			=> 'user/login/'
1010 1010
     ),
1011 1011
 
1012
-    'userlogout' => array (
1013
-        'menu'			=> array (
1012
+    'userlogout' => array(
1013
+        'menu'			=> array(
1014 1014
             'text'			=> 'Sign out',
1015 1015
             'title'			=> "Sign out"
1016 1016
         ),
1017 1017
         'url'			=> 'user/logout/'
1018 1018
     ),
1019
-    'userpassword' => array (
1019
+    'userpassword' => array(
1020 1020
         'title'			=> 'Change password',
1021 1021
         'url'			=> 'user/password/'
1022 1022
     ),
1023
-    'userprompt' => array (
1023
+    'userprompt' => array(
1024 1024
         'title'			=> 'Please sign in',
1025 1025
         'url'			=> 'user/prompt/'
1026 1026
     ),
1027
-    'userview' => array (
1027
+    'userview' => array(
1028 1028
         'session_vars'	=> array('u'),
1029 1029
         'url'			=> 'user/'
1030 1030
     ),
1031
-    'userviewself' => array (
1032
-        'menu'			=> array (
1031
+    'userviewself' => array(
1032
+        'menu'			=> array(
1033 1033
             'text'			=> 'Your details',
1034 1034
             'title'			=> "View and edit your details"
1035 1035
         ),
1036 1036
         'url'			=> 'user/'
1037 1037
     ),
1038
-    'userwelcome' => array (
1038
+    'userwelcome' => array(
1039 1039
         'title'			=> 'Welcome!',
1040 1040
         'url'			=> 'user/'
1041 1041
     ),
@@ -1063,23 +1063,23 @@  discard block
 block discarded – undo
1063 1063
     ),
1064 1064
 
1065 1065
     /* Westminster Hall */
1066
-    'whall'  => array (
1066
+    'whall'  => array(
1067 1067
         'parent'		=> 'whallfront',
1068 1068
         'url'			=> 'whall/',
1069
-        'session_vars'	=> array ('id'),
1069
+        'session_vars'	=> array('id'),
1070 1070
     ),
1071
-    'whalls'  => array (
1071
+    'whalls'  => array(
1072 1072
         'parent'		=> 'whallfront',
1073 1073
         'url'			=> 'whall/',
1074
-        'session_vars'	=> array ('id'),
1074
+        'session_vars'	=> array('id'),
1075 1075
     ),
1076
-    'whallday' => array (
1076
+    'whallday' => array(
1077 1077
         'parent'		=> 'whallfront',
1078
-        'session_vars'	=> array ('d'),
1078
+        'session_vars'	=> array('d'),
1079 1079
         'url'			=> 'whall/',
1080 1080
     ),
1081
-    'whallfront' => array (
1082
-        'menu'			=> array (
1081
+    'whallfront' => array(
1082
+        'menu'			=> array(
1083 1083
             'text'			=> 'Westminster Hall',
1084 1084
             'title'			=> "Westminster Hall debates"
1085 1085
         ),
@@ -1088,23 +1088,23 @@  discard block
 block discarded – undo
1088 1088
         'rss'			=> 'rss/whall.rss',
1089 1089
         'url'			=> 'whall/'
1090 1090
     ),
1091
-    'whallyear' => array (
1091
+    'whallyear' => array(
1092 1092
         'parent'		=> 'whallfront',
1093 1093
         'url'			=> 'whall/'
1094 1094
     ),
1095 1095
 
1096
-    'wms' => array (
1096
+    'wms' => array(
1097 1097
         'parent'		=> 'wranswmsfront',
1098 1098
         'url'			=> 'wms/',
1099 1099
         'session_vars'	=> array('id')
1100 1100
     ),
1101
-    'wmsday' => array (
1101
+    'wmsday' => array(
1102 1102
         'parent'		=> 'wmsfront',
1103 1103
         'session_vars'	=> array('d'),
1104 1104
         'url'			=> 'wms/'
1105 1105
     ),
1106
-    'wmsfront' => array (
1107
-        'menu'			=> array (
1106
+    'wmsfront' => array(
1107
+        'menu'			=> array(
1108 1108
             'text'			=> 'Written Ministerial Statements',
1109 1109
             'title'			=> ''
1110 1110
         ),
@@ -1113,22 +1113,22 @@  discard block
 block discarded – undo
1113 1113
         'rss'			=> 'rss/wms.rss',
1114 1114
         'url'			=> 'wms/'
1115 1115
     ),
1116
-    'wmsyear' => array (
1116
+    'wmsyear' => array(
1117 1117
         'parent'		=> 'wmsfront',
1118 1118
         'url'			=> 'wms/'
1119 1119
     ),
1120 1120
 
1121
-    'wrans'  => array (
1121
+    'wrans'  => array(
1122 1122
         'parent'		=> 'wranswmsfront',
1123 1123
         'url'			=> 'wrans/',
1124
-        'session_vars'	=> array ('id')
1124
+        'session_vars'	=> array('id')
1125 1125
     ),
1126
-    'wransday'  => array (
1126
+    'wransday'  => array(
1127 1127
         'parent'		=> 'wransfront',
1128 1128
         'url'			=> 'wrans/'
1129 1129
     ),
1130
-    'wransfront'  => array (
1131
-        'menu'			=> array (
1130
+    'wransfront'  => array(
1131
+        'menu'			=> array(
1132 1132
             'text'			=> 'Written Answers',
1133 1133
             'title'			=> "Written Answers"
1134 1134
         ),
@@ -1141,13 +1141,13 @@  discard block
 block discarded – undo
1141 1141
         'title'			=> 'For questions asked by ',
1142 1142
         'url'			=> 'wrans/'
1143 1143
     ),
1144
-    'wransyear' => array (
1144
+    'wransyear' => array(
1145 1145
         'parent'		=> 'wransfront',
1146 1146
         'url'			=> 'wrans/'
1147 1147
     ),
1148 1148
 
1149
-    'wranswmsfront'  => array (
1150
-        'menu'			=> array (
1149
+    'wranswmsfront'  => array(
1150
+        'menu'			=> array(
1151 1151
             'text'			=> 'Written Answers',
1152 1152
             'title'			=> 'Written Answers and Statements',
1153 1153
         ),
@@ -1164,8 +1164,8 @@  discard block
 block discarded – undo
1164 1164
         'title' => 'Your representative',
1165 1165
         'url' => 'your/',
1166 1166
     ),
1167
-    'yourmp' => array (
1168
-        'menu'			=> array (
1167
+    'yourmp' => array(
1168
+        'menu'			=> array(
1169 1169
             'text'			=> 'Your MP',
1170 1170
             'title'			=> "Find out about your Member of Parliament"
1171 1171
         ),
@@ -1174,8 +1174,8 @@  discard block
 block discarded – undo
1174 1174
         'url'			=> 'mp/',
1175 1175
         'parent'			=> 'mps',
1176 1176
     ),
1177
-    'yourmp_recent' => array (
1178
-        'menu'			=> array (
1177
+    'yourmp_recent' => array(
1178
+        'menu'			=> array(
1179 1179
             'text'			=> 'Recent appearances',
1180 1180
             'title'			=> "Recent speeches and written answers by this MP"
1181 1181
         ),
@@ -1183,8 +1183,8 @@  discard block
 block discarded – undo
1183 1183
         'title'			=> "Your MP's recent appearances in parliament",
1184 1184
         'url'			=> 'mp/?recent=1'
1185 1185
     ),
1186
-    'yourmsp' => array (
1187
-        'menu'			=> array (
1186
+    'yourmsp' => array(
1187
+        'menu'			=> array(
1188 1188
             'text'			=> 'Your MSPs',
1189 1189
             'title'			=> "Find out about your Members of the Scottish Parliament"
1190 1190
         ),
@@ -1193,8 +1193,8 @@  discard block
 block discarded – undo
1193 1193
         'title'			=> 'Your MSPs',
1194 1194
         'url'			=> 'msp/'
1195 1195
     ),
1196
-    'yourmla' => array (
1197
-        'menu'			=> array (
1196
+    'yourmla' => array(
1197
+        'menu'			=> array(
1198 1198
             'text'			=> 'Your MLAs',
1199 1199
             'title'			=> "Find out about your Members of the Legislative Assembly"
1200 1200
         ),
@@ -1210,38 +1210,38 @@  discard block
 block discarded – undo
1210 1210
 // The text displayed on the page itself will also be this,
1211 1211
 // UNLESS the section has a 'heading', in which case that's used instead.
1212 1212
 
1213
-$this->section = array (
1213
+$this->section = array(
1214 1214
 
1215 1215
 
1216
-    'about' => array (
1216
+    'about' => array(
1217 1217
         'title' 	=> 'About Us'
1218 1218
     ),
1219
-    'admin' => array (
1219
+    'admin' => array(
1220 1220
         'title'		=> 'Admin'
1221 1221
     ),
1222
-    'debates' => array (
1222
+    'debates' => array(
1223 1223
         'title' 	=> 'Debates',
1224 1224
         'heading'	=> 'House of Commons Debates'
1225 1225
     ),
1226
-    'help_us_out' => array (
1226
+    'help_us_out' => array(
1227 1227
         'title' 	=> 'Help Us Out'
1228 1228
     ),
1229
-    'hansard' => array (
1229
+    'hansard' => array(
1230 1230
         'title' 	=> 'Hansard'
1231 1231
     ),
1232
-    'home' => array (
1232
+    'home' => array(
1233 1233
         'title' 	=> 'Home'
1234 1234
     ),
1235
-    'mp' => array (
1235
+    'mp' => array(
1236 1236
         'title' 	=> 'Your MP'
1237 1237
     ),
1238
-    'search' => array (
1238
+    'search' => array(
1239 1239
         'title' 	=> 'Search'
1240 1240
     ),
1241
-    'sitenews' => array (
1241
+    'sitenews' => array(
1242 1242
         'title' 	=> 'TheyWorkForYou news'
1243 1243
     ),
1244
-    'wrans' => array (
1244
+    'wrans' => array(
1245 1245
         'title' 	=> 'Written Answers'
1246 1246
     )
1247 1247
 
Please login to merge, or discard this patch.
www/includes/easyparliament/commentlist.php 3 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
         return $data;
319 319
     }
320 320
 
321
-  public function _get_data_by_dates($args) {
321
+    public function _get_data_by_dates($args) {
322 322
     // $args should contain start_date and end_date
323 323
 
324 324
         twfy_debug (get_class($this), "getting data by recent");
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
         $commentsdata = $this->_get_comment_data($input);
339 339
         $data['comments'] = $commentsdata;
340 340
         return $data;
341
-  }
341
+    }
342 342
 
343 343
     public function _get_data_by_search($args) {
344 344
         // $args should contain 'num', indicating how many to get.
Please login to merge, or discard this patch.
Upper-Lower-Casing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -542,11 +542,11 @@
 block discarded – undo
542 542
         }
543 543
         if ($limit != '') {
544 544
             # Can't use parameter as >1 argument
545
-            $limit = "LIMIT $limit";
545
+            $limit = "limit $limit";
546 546
         }
547 547
 
548 548
         // Finally, do the query!
549
-        $q = $this->db->query ("SELECT $fields
549
+        $q = $this->db->query ("select $fields
550 550
                         FROM 	comments
551 551
                         $join
552 552
                         WHERE $where
Please login to merge, or discard this patch.
Spacing   +39 added lines, -39 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
     }
43 43
 
44 44
 
45
-    public function display ($view, $args=array(), $format='html') {
45
+    public function display($view, $args = array(), $format = 'html') {
46 46
         // $view is what we're viewing by:
47 47
         //	'ep' is all the comments attached to an epobject.
48 48
         //	'user' is all the comments written by a user.
@@ -60,13 +60,13 @@  discard block
 block discarded – undo
60 60
 
61 61
         if ($view == 'ep' || $view == 'user' || $view == 'recent' || $view == 'search' || $view == 'dates') {
62 62
             // What function do we call for this view?
63
-            $function = '_get_data_by_'.$view;
63
+            $function = '_get_data_by_' . $view;
64 64
             // Get all the dta that's to be rendered.
65 65
             $data = $this->$function($args);
66 66
 
67 67
         } else {
68 68
             // Don't have a valid $view;
69
-            $PAGE->error_message ("You haven't specified a view type.");
69
+            $PAGE->error_message("You haven't specified a view type.");
70 70
             return false;
71 71
         }
72 72
 
@@ -85,29 +85,29 @@  discard block
 block discarded – undo
85 85
         return true;
86 86
     }
87 87
 
88
-    public function render($data, $format='html', $template='comments') {
89
-        include (INCLUDESPATH."easyparliament/templates/$format/$template.php");
88
+    public function render($data, $format = 'html', $template = 'comments') {
89
+        include (INCLUDESPATH . "easyparliament/templates/$format/$template.php");
90 90
     }
91 91
 
92 92
     public function _get_data_by_ep($args) {
93 93
         // Get all the data attached to an epobject.
94 94
         global $PAGE;
95 95
 
96
-        twfy_debug (get_class($this), "getting data by epobject");
96
+        twfy_debug(get_class($this), "getting data by epobject");
97 97
 
98 98
         // What we return.
99 99
         $data = array();
100 100
         if (!is_numeric($args['epobject_id'])) {
101
-            $PAGE->error_message ("Sorry, we don't have a valid epobject id");
101
+            $PAGE->error_message("Sorry, we don't have a valid epobject id");
102 102
             return $data;
103 103
         }
104 104
 
105 105
         // For getting the data.
106
-        $input = array (
107
-            'amount' => array (
106
+        $input = array(
107
+            'amount' => array(
108 108
                 'user' => true
109 109
             ),
110
-            'where' => array (
110
+            'where' => array(
111 111
                 'comments.epobject_id=' => $args['epobject_id'],
112 112
                 #'visible=' => '1'
113 113
             ),
@@ -135,13 +135,13 @@  discard block
 block discarded – undo
135 135
         // comments by things in $args?
136 136
         global $PAGE;
137 137
 
138
-        twfy_debug (get_class($this), "getting data by user");
138
+        twfy_debug(get_class($this), "getting data by user");
139 139
 
140 140
         // What we return.
141 141
         $data = array();
142 142
 
143 143
         if (!is_numeric($args['user_id'])) {
144
-            $PAGE->error_message ("Sorry, we don't have a valid user id");
144
+            $PAGE->error_message("Sorry, we don't have a valid user id");
145 145
             return $data;
146 146
         }
147 147
 
@@ -151,13 +151,13 @@  discard block
 block discarded – undo
151 151
             $num = 10;
152 152
         }
153 153
 
154
-        if (isset($args['page']) && is_numeric($args['page']) && $args['page']>1) {
154
+        if (isset($args['page']) && is_numeric($args['page']) && $args['page'] > 1) {
155 155
             $page = $args['page'];
156 156
         } else {
157 157
             $page = 1;
158 158
         }
159 159
 
160
-        $limit = $num*($page-1) . ',' . $num;
160
+        $limit = $num * ($page - 1) . ',' . $num;
161 161
 
162 162
         // We're getting the most recent comments posted to epobjects.
163 163
         // We're grouping them by epobject so we can just link to each hansard thing once.
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
                 // This does rely on both this and the previous query returning
239 239
                 // stuff in the same order...
240 240
                 foreach ($comments as $n => $commentdata) {
241
-                    $comments[$n]['body'] = $commentbodies[ $comments[$n]['comment_id'] ];
241
+                    $comments[$n]['body'] = $commentbodies[$comments[$n]['comment_id']];
242 242
                 }
243 243
             }
244 244
         }
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
         // $args should contain 'num', indicating how many to get.
259 259
         // and perhaps pid too, for a particular person
260 260
 
261
-        twfy_debug (get_class($this), "getting data by recent");
261
+        twfy_debug(get_class($this), "getting data by recent");
262 262
 
263 263
         // What we return.
264 264
         $data = array();
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
             $page = 1;
276 276
         }
277 277
 
278
-        $limit = $num*($page-1) . ',' . $num;
278
+        $limit = $num * ($page - 1) . ',' . $num;
279 279
 
280 280
         $where = array(
281 281
             'visible=' => '1'
@@ -283,8 +283,8 @@  discard block
 block discarded – undo
283 283
         if (isset($args['pid']) && is_numeric($args['pid'])) {
284 284
             $where['person_id='] = $args['pid'];
285 285
         }
286
-        $input = array (
287
-            'amount' => array (
286
+        $input = array(
287
+            'amount' => array(
288 288
                 'user' => true
289 289
             ),
290 290
             'where'  => $where,
@@ -316,15 +316,15 @@  discard block
 block discarded – undo
316 316
   public function _get_data_by_dates($args) {
317 317
     // $args should contain start_date and end_date
318 318
 
319
-        twfy_debug (get_class($this), "getting data by recent");
319
+        twfy_debug(get_class($this), "getting data by recent");
320 320
         $data = array();
321 321
         $where = array(
322 322
             'visible=' => '1',
323 323
             'date(posted)>=' => $args['start_date'],
324 324
             'date(posted)<=' => $args['end_date']
325 325
         );
326
-        $input = array (
327
-            'amount' => array (
326
+        $input = array(
327
+            'amount' => array(
328 328
                 'user' => true
329 329
             ),
330 330
             'where'  => $where,
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
     public function _get_data_by_search($args) {
339 339
         // $args should contain 'num', indicating how many to get.
340 340
 
341
-        twfy_debug (get_class($this), "getting data by search");
341
+        twfy_debug(get_class($this), "getting data by search");
342 342
 
343 343
         // What we return.
344 344
         $data = array();
@@ -355,13 +355,13 @@  discard block
 block discarded – undo
355 355
             $page = 1;
356 356
         }
357 357
 
358
-        $limit = $num*($page-1) . ',' . $num;
358
+        $limit = $num * ($page - 1) . ',' . $num;
359 359
 
360
-        $input = array (
361
-            'amount' => array (
360
+        $input = array(
361
+            'amount' => array(
362 362
                 'user'=> true
363 363
             ),
364
-            'where'  => array (
364
+            'where'  => array(
365 365
                 'comments.body LIKE' => "%$args[s]%"
366 366
             ),
367 367
             'order' => 'posted DESC',
@@ -388,7 +388,7 @@  discard block
 block discarded – undo
388 388
         // It returns the URL for the comment.
389 389
 
390 390
         $major 		= $urldata['major'];
391
-        $gid 		= $urldata['gid'];
391
+        $gid = $urldata['gid'];
392 392
         $comment_id = $urldata['comment_id'];
393 393
         $user_id = isset($urldata['user_id']) ? $urldata['user_id'] : false;
394 394
 
@@ -402,7 +402,7 @@  discard block
 block discarded – undo
402 402
         $URL = new \MySociety\TheyWorkForYou\Url($page);
403 403
 
404 404
         $gid = fix_gid_from_db($gid); // In includes/utility.php
405
-        $URL->insert(array('id' => $gid ));
405
+        $URL->insert(array('id' => $gid));
406 406
         if ($user_id) {
407 407
             $URL->insert(array('u' => $user_id));
408 408
         }
@@ -480,9 +480,9 @@  discard block
 block discarded – undo
480 480
         $limit = isset($input['limit']) ? $input['limit'] : '';
481 481
 
482 482
         // The fields to fetch from db. 'table' => array ('field1', 'field2').
483
-        $fieldsarr = array (
484
-            'comments' => array ('comment_id', 'user_id', 'epobject_id', 'body', 'posted', 'modflagged', 'visible'),
485
-            'hansard' => array ('major', 'gid')
483
+        $fieldsarr = array(
484
+            'comments' => array('comment_id', 'user_id', 'epobject_id', 'body', 'posted', 'modflagged', 'visible'),
485
+            'hansard' => array('major', 'gid')
486 486
         );
487 487
 
488 488
         // Yes, we need the gid of a comment's associated hansard object
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
 
494 494
         // Add on the stuff for getting a user's details.
495 495
         if (isset($amount['user']) && $amount['user'] == true) {
496
-            $fieldsarr['users'] = array ('firstname', 'lastname', 'user_id');
496
+            $fieldsarr['users'] = array('firstname', 'lastname', 'user_id');
497 497
             // Like doing "FROM comments, users" but it's easier to add
498 498
             // an "INNER JOIN..." automatically to the query.
499 499
             $join .= ' INNER JOIN users ON comments.user_id = users.user_id ';
@@ -504,7 +504,7 @@  discard block
 block discarded – undo
504 504
             $fieldsarr['epobject'] = array('body');
505 505
         }
506 506
 
507
-        $fieldsarr2 = array ();
507
+        $fieldsarr2 = array();
508 508
         // Construct the $fields clause.
509 509
         foreach ($fieldsarr as $table => $tablesfields) {
510 510
             foreach ($tablesfields as $n => $field) {
@@ -515,13 +515,13 @@  discard block
 block discarded – undo
515 515
                 if ($table == 'epobject' && $field == 'body') {
516 516
                     $field .= ' AS hbody';
517 517
                 }
518
-                $fieldsarr2[] = $table.'.'.$field;
518
+                $fieldsarr2[] = $table . '.' . $field;
519 519
             }
520 520
         }
521 521
         $fields = implode(', ', $fieldsarr2);
522 522
 
523 523
 
524
-        $wherearr2 = array ();
524
+        $wherearr2 = array();
525 525
         $params = array();
526 526
         $i = 0;
527 527
         // Construct the $where clause.
@@ -530,7 +530,7 @@  discard block
 block discarded – undo
530 530
             $params[":where$i"] = $val;
531 531
             $i++;
532 532
         }
533
-        $where = implode (" AND ", $wherearr2);
533
+        $where = implode(" AND ", $wherearr2);
534 534
 
535 535
         if ($order != '') {
536 536
             $order = "ORDER BY $order";
@@ -541,7 +541,7 @@  discard block
 block discarded – undo
541 541
         }
542 542
 
543 543
         // Finally, do the query!
544
-        $q = $this->db->query ("SELECT $fields
544
+        $q = $this->db->query("SELECT $fields
545 545
                         FROM 	comments
546 546
                         $join
547 547
                         WHERE $where
@@ -550,7 +550,7 @@  discard block
 block discarded – undo
550 550
                         ", $params);
551 551
 
552 552
         // Format the data into an array for returning.
553
-        $data = array ();
553
+        $data = array();
554 554
 
555 555
         // If you change stuff here, you might have to change it in
556 556
         // $COMMENT->_set_url() too...
Please login to merge, or discard this patch.
www/includes/easyparliament/searchengine.php 4 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
     }
334 334
 
335 335
     public function get_spelling_correction() {
336
-         if (!defined('XAPIANDB') || !XAPIANDB)
336
+            if (!defined('XAPIANDB') || !XAPIANDB)
337 337
             return null;
338 338
 
339 339
         $qd = $this->queryparser->get_corrected_query_string();
@@ -559,7 +559,7 @@  discard block
 block discarded – undo
559 559
             {
560 560
                 $wordpos = strpos( $lcbody, $matches[0] );
561 561
                 if ($wordpos) {
562
-                   if ( ($wordpos < $pos) || ($pos==-1) ) {
562
+                    if ( ($wordpos < $pos) || ($pos==-1) ) {
563 563
                         $pos = $wordpos;
564 564
                     }
565 565
                 }
Please login to merge, or discard this patch.
Upper-Lower-Casing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 
26 26
 */
27 27
 
28
-if (defined('XAPIANDB') AND XAPIANDB != '') {
28
+if (defined('XAPIANDB') and XAPIANDB != '') {
29 29
     if (file_exists('/usr/share/php/xapian.php')) {
30 30
         include_once '/usr/share/php/xapian.php';
31 31
     } else {
@@ -275,15 +275,15 @@  discard block
 block discarded – undo
275 275
         foreach ($merged as $row) {
276 276
             $from_id = str_replace('uk.org.publicwhip/person/', '', $row['gid_from']);
277 277
             $to_id = str_replace('uk.org.publicwhip/person/', '', $row['gid_to']);
278
-            $qd = str_replace("(S$from_id OR S$to_id)", "S$to_id", $qd);
279
-            $qd = str_replace("S$from_id OR S$to_id", "S$to_id", $qd);
278
+            $qd = str_replace("(S$from_id OR S$to_id)", "s$to_id", $qd);
279
+            $qd = str_replace("s$from_id OR S$to_id", "s$to_id", $qd);
280 280
         }
281 281
 
282 282
         preg_match_all('#S(\d+)#', $qd, $m);
283 283
         foreach ($m[1] as $mm) {
284 284
             $member = new MEMBER(array('person_id' => $mm));
285 285
             $name = $member->full_name();
286
-            $qd = str_replace("S$mm", "speaker:$name", $qd);
286
+            $qd = str_replace("s$mm", "speaker:$name", $qd);
287 287
         }
288 288
 
289 289
         # Simplify display of excluded words
Please login to merge, or discard this patch.
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -96,10 +96,10 @@  discard block
 block discarded – undo
96 96
         // Split words up into individual words, and quoted phrases
97 97
         preg_match_all('/(' .
98 98
             '"|' . # match either a quote, or...
99
-            '(?:(?<![' .$this->wordchars. '])-)?' . # optionally a - (exclude)
99
+            '(?:(?<![' . $this->wordchars . '])-)?' . # optionally a - (exclude)
100 100
             # if at start of word (i.e. not preceded by a word character, in
101 101
             # which case it is probably a hyphenated-word)
102
-            '['.$this->wordchars.']+' . # followed by a string of word-characters
102
+            '[' . $this->wordchars . ']+' . # followed by a string of word-characters
103 103
             ')/', $this->query, $all_words);
104 104
         if ($all_words) {
105 105
             $all_words = $all_words[0];
@@ -124,8 +124,8 @@  discard block
 block discarded – undo
124 124
             if (strpos($word, ':') !== false) {
125 125
                 $items = explode(":", strtolower($word));
126 126
                 $type = $items[0];
127
-                if (substr($type, 0, 1)=='-') $type = substr($type, 1);
128
-                $value = strtolower(join(":", array_slice($items,1)));
127
+                if (substr($type, 0, 1) == '-') $type = substr($type, 1);
128
+                $value = strtolower(join(":", array_slice($items, 1)));
129 129
                 if ($type == 'section') {
130 130
                     $newv = $value;
131 131
                     if ($value == 'debates' || $value == 'debate') $newv = 1;
@@ -138,8 +138,8 @@  discard block
 block discarded – undo
138 138
                     elseif ($value == 'sp') $newv = 7;
139 139
                     elseif ($value == 'spwrans' || $value == 'spwran') $newv = 8;
140 140
                     elseif ($value == 'lmqs') $newv = 9;
141
-                    elseif ($value == 'uk') $newv = array(1,2,3,4,6,101);
142
-                    elseif ($value == 'scotland') $newv = array(7,8);
141
+                    elseif ($value == 'uk') $newv = array(1, 2, 3, 4, 6, 101);
142
+                    elseif ($value == 'scotland') $newv = array(7, 8);
143 143
                     elseif ($value == 'future') $newv = 'F';
144 144
                     if (is_array($newv)) {
145 145
                         $newv = 'major:' . join(' major:', $newv);
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
             $this->query .= " $from..$to";
174 174
         } elseif ($from) {
175 175
             $this->query = str_ireplace("from:$from", '', $this->query);
176
-            $this->query .= " $from..".date('Ymd');
176
+            $this->query .= " $from.." . date('Ymd');
177 177
         } elseif ($to) {
178 178
             $this->query = str_ireplace("to:$to", '', $this->query);
179 179
             $this->query .= " 19990101..$to";
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
 
191 191
         twfy_debug("SEARCH", "prefixed: " . var_export($this->prefixed, true));
192 192
 
193
-        twfy_debug("SEARCH", "query -- ". $this->query);
193
+        twfy_debug("SEARCH", "query -- " . $this->query);
194 194
         $flags = XapianQueryParser::FLAG_BOOLEAN | XapianQueryParser::FLAG_LOVEHATE |
195 195
             XapianQueryParser::FLAG_WILDCARD | XapianQueryParser::FLAG_SPELLING_CORRECTION;
196 196
         $flags = $flags | XapianQueryParser::FLAG_PHRASE;
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
         foreach ($m[1] as $phrase) {
222 222
             $phrase_new = preg_replace('# PHRASE \d+#', '', $phrase);
223 223
             #$this->phrases[] = preg_split('#\s+#', $phrase_new);
224
-            $qd = str_replace("($phrase)", '"'.$phrase_new.'"', $qd);
224
+            $qd = str_replace("($phrase)", '"' . $phrase_new . '"', $qd);
225 225
         }
226 226
         preg_match_all('#\(([^(]*? NEAR [^(]*?)\)#', $qd, $m);
227 227
         foreach ($m[1] as $mm) {
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
     }
353 353
 
354 354
     // Perform partial query to get a count of number of matches
355
-    public function run_count($first_result, $results_per_page, $sort_order='relevance') {
355
+    public function run_count($first_result, $results_per_page, $sort_order = 'relevance') {
356 356
         if (!defined('XAPIANDB') || !XAPIANDB)
357 357
             return null;
358 358
 
@@ -425,13 +425,13 @@  discard block
 block discarded – undo
425 425
         #}
426 426
 
427 427
         $duration = getmicrotime() - $start;
428
-        twfy_debug ("SEARCH", "Search count took $duration seconds.");
428
+        twfy_debug("SEARCH", "Search count took $duration seconds.");
429 429
 
430 430
         return $count;
431 431
     }
432 432
 
433 433
     // Perform the full search...
434
-    public function run_search($first_result, $results_per_page, $sort_order='relevance') {
434
+    public function run_search($first_result, $results_per_page, $sort_order = 'relevance') {
435 435
         $start = getmicrotime();
436 436
 
437 437
         #$matches = $this->enquire->get_mset($first_result, $results_per_page);
@@ -452,13 +452,13 @@  discard block
 block discarded – undo
452 452
                 array_push($this->created, join('', unpack('N', $doc->get_value(2)))); # XXX Needs fixing
453 453
             }
454 454
             twfy_debug("SEARCH", "gid: $gid relevancy: $relevancy% weight: $weight");
455
-            array_push($this->gids, "uk.org.publicwhip/".$gid);
455
+            array_push($this->gids, "uk.org.publicwhip/" . $gid);
456 456
             array_push($this->collapsed, $collapsed);
457 457
             array_push($this->relevances, $relevancy);
458 458
             $iter->next();
459 459
         }
460 460
         $duration = getmicrotime() - $start;
461
-        twfy_debug ("SEARCH", "Run search took $duration seconds.");
461
+        twfy_debug("SEARCH", "Run search took $duration seconds.");
462 462
     }
463 463
     // ... use these to get the results
464 464
     public function get_gids() {
@@ -499,7 +499,7 @@  discard block
 block discarded – undo
499 499
         $body = str_replace($this->specialchars, $this->specialchars_upper, $body);
500 500
         $body = mb_convert_encoding($body, "UTF-8", "HTML-ENTITIES");
501 501
         $body = str_replace($this->specialchars_upper, $this->specialchars, $body);
502
-        $splitextract = preg_split('/(<[^>]*>|[0-9,.]+|['.$this->wordcharsnodigit.']+)/', $body, -1, PREG_SPLIT_DELIM_CAPTURE);
502
+        $splitextract = preg_split('/(<[^>]*>|[0-9,.]+|[' . $this->wordcharsnodigit . ']+)/', $body, -1, PREG_SPLIT_DELIM_CAPTURE);
503 503
         $hlextract = "";
504 504
         foreach ($splitextract as $extractword) {
505 505
             if (preg_match('/^<[^>]*>$/', $extractword)) {
@@ -547,7 +547,7 @@  discard block
 block discarded – undo
547 547
         */
548 548
 
549 549
         foreach ($this->phrases as $phrase) {
550
-            $phrasematch = join($phrase, '[^'.$this->wordchars.']+');
550
+            $phrasematch = join($phrase, '[^' . $this->wordchars . ']+');
551 551
             array_push($findwords, "/\b($phrasematch)\b(?!(?>[^<>]*>))/i");
552 552
             $replacewords[] = "<span class=\"hi\">\\1</span>";
553 553
         }
@@ -565,12 +565,12 @@  discard block
 block discarded – undo
565 565
 
566 566
         // look for phrases
567 567
         foreach ($this->phrases as $phrase) {
568
-            $phrasematch = join($phrase, '[^'.$this->wordchars.']+');
569
-            if (preg_match('/([^'.$this->wordchars.']' . $phrasematch . '[^A-Za-z0-9])/', $lcbody, $matches))
568
+            $phrasematch = join($phrase, '[^' . $this->wordchars . ']+');
569
+            if (preg_match('/([^' . $this->wordchars . ']' . $phrasematch . '[^A-Za-z0-9])/', $lcbody, $matches))
570 570
             {
571
-                $wordpos = strpos( $lcbody, $matches[0] );
571
+                $wordpos = strpos($lcbody, $matches[0]);
572 572
                 if ($wordpos) {
573
-                   if ( ($wordpos < $pos) || ($pos==-1) ) {
573
+                   if (($wordpos < $pos) || ($pos == -1)) {
574 574
                         $pos = $wordpos;
575 575
                     }
576 576
                 }
@@ -578,7 +578,7 @@  discard block
 block discarded – undo
578 578
         }
579 579
         if ($pos != -1) return $pos;
580 580
 
581
-        $splitextract = preg_split('/([0-9,.]+|['.$this->wordcharsnodigit.']+)/', $lcbody, -1, PREG_SPLIT_DELIM_CAPTURE);
581
+        $splitextract = preg_split('/([0-9,.]+|[' . $this->wordcharsnodigit . ']+)/', $lcbody, -1, PREG_SPLIT_DELIM_CAPTURE);
582 582
         $stemmed_words = array_map(array($this, 'stem'), $this->words);
583 583
         foreach ($splitextract as $extractword) {
584 584
             $extractword = preg_replace('/&$/', '', $extractword);
@@ -588,7 +588,7 @@  discard block
 block discarded – undo
588 588
             foreach ($stemmed_words as $word) {
589 589
                 if ($word == '') continue;
590 590
                 $matchword = $this->stem($extractword);
591
-                if ($matchword == $word && ($wordpos < $pos || $pos==-1)) {
591
+                if ($matchword == $word && ($wordpos < $pos || $pos == -1)) {
592 592
                     $pos = $wordpos;
593 593
                 }
594 594
             }
@@ -597,11 +597,11 @@  discard block
 block discarded – undo
597 597
         if ($pos != -1) return $pos;
598 598
 
599 599
         foreach ($this->words as $word) {
600
-            if (ctype_digit($word)) $word = '(?:'.$word.'|'.number_format($word).')';
601
-            if (preg_match('/([^'.$this->wordchars.']' . $word . '[^'.$this->wordchars. '])/', $lcbody, $matches)) {
602
-                $wordpos = strpos( $lcbody, $matches[0] );
600
+            if (ctype_digit($word)) $word = '(?:' . $word . '|' . number_format($word) . ')';
601
+            if (preg_match('/([^' . $this->wordchars . ']' . $word . '[^' . $this->wordchars . '])/', $lcbody, $matches)) {
602
+                $wordpos = strpos($lcbody, $matches[0]);
603 603
                 if ($wordpos) {
604
-                    if ( ($wordpos < $pos) || ($pos==-1) ) {
604
+                    if (($wordpos < $pos) || ($pos == -1)) {
605 605
                         $pos = $wordpos;
606 606
                     }
607 607
                 }
@@ -611,11 +611,11 @@  discard block
 block discarded – undo
611 611
         if ($pos != -1) return $pos;
612 612
 
613 613
         foreach ($this->words as $word) {
614
-            if (ctype_digit($word)) $word = '(?:'.$word.'|'.number_format($word).')';
614
+            if (ctype_digit($word)) $word = '(?:' . $word . '|' . number_format($word) . ')';
615 615
             if (preg_match('/(' . $word . ')/', $lcbody, $matches)) {
616
-                $wordpos = strpos( $lcbody, $matches[0] );
616
+                $wordpos = strpos($lcbody, $matches[0]);
617 617
                 if ($wordpos) {
618
-                    if ( ($wordpos < $pos) || ($pos==-1) ) {
618
+                    if (($wordpos < $pos) || ($pos == -1)) {
619 619
                         $pos = $wordpos;
620 620
                     }
621 621
                 }
Please login to merge, or discard this patch.
Braces   +102 added lines, -49 removed lines patch added patch discarded remove patch
@@ -38,8 +38,9 @@  discard block
 block discarded – undo
38 38
     public $error;
39 39
 
40 40
     public function __construct($query) {
41
-        if (!defined('XAPIANDB') || !XAPIANDB)
42
-            return null;
41
+        if (!defined('XAPIANDB') || !XAPIANDB) {
42
+                    return null;
43
+        }
43 44
 
44 45
         global $xapiandb, $PAGE;
45 46
         if (!$xapiandb) {
@@ -54,8 +55,12 @@  discard block
 block discarded – undo
54 55
             }
55 56
         }
56 57
         $this->query = $query;
57
-        if (!isset($this->stemmer)) $this->stemmer = new XapianStem('english');
58
-        if (!isset($this->enquire)) $this->enquire = new XapianEnquire($xapiandb);
58
+        if (!isset($this->stemmer)) {
59
+            $this->stemmer = new XapianStem('english');
60
+        }
61
+        if (!isset($this->enquire)) {
62
+            $this->enquire = new XapianEnquire($xapiandb);
63
+        }
59 64
         if (!isset($this->queryparser)) {
60 65
             $this->queryparser = new XapianQueryParser();
61 66
             $this->datevaluerange = new XapianDateValueRangeProcessor(1);
@@ -111,7 +116,9 @@  discard block
 block discarded – undo
111 116
         foreach ($all_words as $word) {
112 117
             if ($word == '"') {
113 118
                 $in_quote = !$in_quote;
114
-                if ($in_quote) array_push($this->phrases, array());
119
+                if ($in_quote) {
120
+                    array_push($this->phrases, array());
121
+                }
115 122
                 if (!$in_quote && !count($this->phrases[count($this->phrases) - 1])) {
116 123
                     array_pop($this->phrases);
117 124
                 }
@@ -124,23 +131,39 @@  discard block
 block discarded – undo
124 131
             if (strpos($word, ':') !== false) {
125 132
                 $items = explode(":", strtolower($word));
126 133
                 $type = $items[0];
127
-                if (substr($type, 0, 1)=='-') $type = substr($type, 1);
134
+                if (substr($type, 0, 1)=='-') {
135
+                    $type = substr($type, 1);
136
+                }
128 137
                 $value = strtolower(join(":", array_slice($items,1)));
129 138
                 if ($type == 'section') {
130 139
                     $newv = $value;
131
-                    if ($value == 'debates' || $value == 'debate') $newv = 1;
132
-                    elseif ($value == 'whall' || $value == 'westminster' || $value == 'westminhall') $newv = 2;
133
-                    elseif ($value == 'wrans' || $value == 'wran') $newv = 3;
134
-                    elseif ($value == 'wms' || $value == 'statements' || $value == 'statement') $newv = 4;
135
-                    elseif ($value == 'lordsdebates' || $value == 'lords') $newv = 101;
136
-                    elseif ($value == 'ni' || $value == 'nidebates') $newv = 5;
137
-                    elseif ($value == 'pbc' || $value == 'standing') $newv = 6;
138
-                    elseif ($value == 'sp') $newv = 7;
139
-                    elseif ($value == 'spwrans' || $value == 'spwran') $newv = 8;
140
-                    elseif ($value == 'lmqs') $newv = 9;
141
-                    elseif ($value == 'uk') $newv = array(1,2,3,4,6,101);
142
-                    elseif ($value == 'scotland') $newv = array(7,8);
143
-                    elseif ($value == 'future') $newv = 'F';
140
+                    if ($value == 'debates' || $value == 'debate') {
141
+                        $newv = 1;
142
+                    } elseif ($value == 'whall' || $value == 'westminster' || $value == 'westminhall') {
143
+                        $newv = 2;
144
+                    } elseif ($value == 'wrans' || $value == 'wran') {
145
+                        $newv = 3;
146
+                    } elseif ($value == 'wms' || $value == 'statements' || $value == 'statement') {
147
+                        $newv = 4;
148
+                    } elseif ($value == 'lordsdebates' || $value == 'lords') {
149
+                        $newv = 101;
150
+                    } elseif ($value == 'ni' || $value == 'nidebates') {
151
+                        $newv = 5;
152
+                    } elseif ($value == 'pbc' || $value == 'standing') {
153
+                        $newv = 6;
154
+                    } elseif ($value == 'sp') {
155
+                        $newv = 7;
156
+                    } elseif ($value == 'spwrans' || $value == 'spwran') {
157
+                        $newv = 8;
158
+                    } elseif ($value == 'lmqs') {
159
+                        $newv = 9;
160
+                    } elseif ($value == 'uk') {
161
+                        $newv = array(1,2,3,4,6,101);
162
+                    } elseif ($value == 'scotland') {
163
+                        $newv = array(7,8);
164
+                    } elseif ($value == 'future') {
165
+                        $newv = 'F';
166
+                    }
144 167
                     if (is_array($newv)) {
145 168
                         $newv = 'major:' . join(' major:', $newv);
146 169
                     } else {
@@ -149,8 +172,12 @@  discard block
 block discarded – undo
149 172
                     $this->query = str_ireplace("$type:$value", $newv, $this->query);
150 173
                 } elseif ($type == 'groupby') {
151 174
                     $newv = $value;
152
-                    if ($value == 'debates' || $value == 'debate') $newv = 'debate';
153
-                    if ($value == 'speech' || $value == 'speeches') $newv = 'speech';
175
+                    if ($value == 'debates' || $value == 'debate') {
176
+                        $newv = 'debate';
177
+                    }
178
+                    if ($value == 'speech' || $value == 'speeches') {
179
+                        $newv = 'speech';
180
+                    }
154 181
                     $this->query = str_ireplace("$type:$value", '', $this->query);
155 182
                     array_push($this->prefixed, array($type, $newv));
156 183
                 } elseif ($type == 'from') {
@@ -265,7 +292,9 @@  discard block
 block discarded – undo
265 292
             $end = $this->queryparser->unstem_end($mm);
266 293
             while (!$iter->equals($end)) {
267 294
                 $tt = $iter->get_term();
268
-                if (!in_array($tt, $used)) break;
295
+                if (!in_array($tt, $used)) {
296
+                    break;
297
+                }
269 298
                 $iter->next();
270 299
             }
271 300
             $used[] = $tt;
@@ -344,8 +373,9 @@  discard block
 block discarded – undo
344 373
     }
345 374
 
346 375
     public function get_spelling_correction() {
347
-         if (!defined('XAPIANDB') || !XAPIANDB)
348
-            return null;
376
+         if (!defined('XAPIANDB') || !XAPIANDB) {
377
+                     return null;
378
+         }
349 379
 
350 380
         $qd = $this->queryparser->get_corrected_query_string();
351 381
         return $qd;
@@ -353,8 +383,9 @@  discard block
 block discarded – undo
353 383
 
354 384
     // Perform partial query to get a count of number of matches
355 385
     public function run_count($first_result, $results_per_page, $sort_order='relevance') {
356
-        if (!defined('XAPIANDB') || !XAPIANDB)
357
-            return null;
386
+        if (!defined('XAPIANDB') || !XAPIANDB) {
387
+                    return null;
388
+        }
358 389
 
359 390
         $start = getmicrotime();
360 391
 
@@ -384,16 +415,18 @@  discard block
 block discarded – undo
384 415
                 $collapsed = true;
385 416
                 if ($items[1] == 'speech')
386 417
                     ; // no collapse key
387
-                elseif ($items[1] == 'debate')
388
-                    $this->enquire->set_collapse_key(3);
389
-                else
390
-                    $PAGE->error_message("Unknown group by '$items[1]' ignored");
418
+                elseif ($items[1] == 'debate') {
419
+                                    $this->enquire->set_collapse_key(3);
420
+                } else {
421
+                                    $PAGE->error_message("Unknown group by '$items[1]' ignored");
422
+                }
391 423
             }
392 424
         }
393 425
 
394 426
         // default to grouping by subdebate, i.e. by page
395
-        if (!$collapsed)
396
-            $this->enquire->set_collapse_key(3);
427
+        if (!$collapsed) {
428
+                    $this->enquire->set_collapse_key(3);
429
+        }
397 430
 
398 431
         /*
399 432
         XXX Helping to debug possible Xapian bug
@@ -473,8 +506,9 @@  discard block
 block discarded – undo
473 506
 
474 507
     // Puts HTML highlighting round all the matching words in the text
475 508
     public function highlight($body) {
476
-        if (!defined('XAPIANDB') || !XAPIANDB)
477
-            return $body;
509
+        if (!defined('XAPIANDB') || !XAPIANDB) {
510
+                    return $body;
511
+        }
478 512
 
479 513
         $stemmed_words = array_map(array($this, 'stem'), $this->words);
480 514
         if (is_array($body)) {
@@ -492,8 +526,9 @@  discard block
 block discarded – undo
492 526
     private $specialchars_upper = array('&LT;', '&GT;', '&QUOT;', '&AMP;');
493 527
 
494 528
     public function highlight_internal($body, $stemmed_words) {
495
-        if (!defined('XAPIANDB') || !XAPIANDB)
496
-            return $body;
529
+        if (!defined('XAPIANDB') || !XAPIANDB) {
530
+                    return $body;
531
+        }
497 532
 
498 533
         # Does html_entity_decode without the htmlspecialchars
499 534
         $body = str_replace($this->specialchars, $this->specialchars_upper, $body);
@@ -514,7 +549,9 @@  discard block
 block discarded – undo
514 549
             $hl = false;
515 550
             $matchword = $this->stem($extractword);
516 551
             foreach ($stemmed_words as $word) {
517
-                if ($word == '') continue;
552
+                if ($word == '') {
553
+                    continue;
554
+                }
518 555
                 if ($matchword == $word) {
519 556
                     $hl = true;
520 557
                     break;
@@ -566,8 +603,7 @@  discard block
 block discarded – undo
566 603
         // look for phrases
567 604
         foreach ($this->phrases as $phrase) {
568 605
             $phrasematch = join($phrase, '[^'.$this->wordchars.']+');
569
-            if (preg_match('/([^'.$this->wordchars.']' . $phrasematch . '[^A-Za-z0-9])/', $lcbody, $matches))
570
-            {
606
+            if (preg_match('/([^'.$this->wordchars.']' . $phrasematch . '[^A-Za-z0-9])/', $lcbody, $matches)) {
571 607
                 $wordpos = strpos( $lcbody, $matches[0] );
572 608
                 if ($wordpos) {
573 609
                    if ( ($wordpos < $pos) || ($pos==-1) ) {
@@ -576,17 +612,25 @@  discard block
 block discarded – undo
576 612
                 }
577 613
             }
578 614
         }
579
-        if ($pos != -1) return $pos;
615
+        if ($pos != -1) {
616
+            return $pos;
617
+        }
580 618
 
581 619
         $splitextract = preg_split('/([0-9,.]+|['.$this->wordcharsnodigit.']+)/', $lcbody, -1, PREG_SPLIT_DELIM_CAPTURE);
582 620
         $stemmed_words = array_map(array($this, 'stem'), $this->words);
583 621
         foreach ($splitextract as $extractword) {
584 622
             $extractword = preg_replace('/&$/', '', $extractword);
585
-            if (!$extractword) continue;
623
+            if (!$extractword) {
624
+                continue;
625
+            }
586 626
             $wordpos = strpos($lcbody, $extractword);
587
-            if (!$wordpos) continue;
627
+            if (!$wordpos) {
628
+                continue;
629
+            }
588 630
             foreach ($stemmed_words as $word) {
589
-                if ($word == '') continue;
631
+                if ($word == '') {
632
+                    continue;
633
+                }
590 634
                 $matchword = $this->stem($extractword);
591 635
                 if ($matchword == $word && ($wordpos < $pos || $pos==-1)) {
592 636
                     $pos = $wordpos;
@@ -594,10 +638,14 @@  discard block
 block discarded – undo
594 638
             }
595 639
         }
596 640
         // only look for earlier words if phrases weren't found
597
-        if ($pos != -1) return $pos;
641
+        if ($pos != -1) {
642
+            return $pos;
643
+        }
598 644
 
599 645
         foreach ($this->words as $word) {
600
-            if (ctype_digit($word)) $word = '(?:'.$word.'|'.number_format($word).')';
646
+            if (ctype_digit($word)) {
647
+                $word = '(?:'.$word.'|'.number_format($word).')';
648
+            }
601 649
             if (preg_match('/([^'.$this->wordchars.']' . $word . '[^'.$this->wordchars. '])/', $lcbody, $matches)) {
602 650
                 $wordpos = strpos( $lcbody, $matches[0] );
603 651
                 if ($wordpos) {
@@ -608,10 +656,14 @@  discard block
 block discarded – undo
608 656
             }
609 657
         }
610 658
         // only look for something containing the word (ie. something stemmed, but doesn't work all the time) if no whole word was found
611
-        if ($pos != -1) return $pos;
659
+        if ($pos != -1) {
660
+            return $pos;
661
+        }
612 662
 
613 663
         foreach ($this->words as $word) {
614
-            if (ctype_digit($word)) $word = '(?:'.$word.'|'.number_format($word).')';
664
+            if (ctype_digit($word)) {
665
+                $word = '(?:'.$word.'|'.number_format($word).')';
666
+            }
615 667
             if (preg_match('/(' . $word . ')/', $lcbody, $matches)) {
616 668
                 $wordpos = strpos( $lcbody, $matches[0] );
617 669
                 if ($wordpos) {
@@ -622,8 +674,9 @@  discard block
 block discarded – undo
622 674
             }
623 675
         }
624 676
 
625
-        if ($pos == -1)
626
-            $pos = 0;
677
+        if ($pos == -1) {
678
+                    $pos = 0;
679
+        }
627 680
 
628 681
         return $pos;
629 682
     }
Please login to merge, or discard this patch.
www/includes/easyparliament/glossary.php 2 patches
Braces   +14 added lines, -15 removed lines patch added patch discarded remove patch
@@ -107,19 +107,19 @@  discard block
 block discarded – undo
107 107
             if (isset($args['glossary_id']) && ($args['glossary_id'] != "")) {
108 108
                 $next = 0; $first_term = null;
109 109
                 foreach ($this->terms as $term) {
110
-                    if (!$first_term) $first_term = $term;
110
+                    if (!$first_term) {
111
+                        $first_term = $term;
112
+                    }
111 113
                     $last_term = $term;
112 114
                     if ($next == 1) {
113 115
                         $this->next_term = $term;
114 116
                         break;
115
-                    }
116
-                    elseif ($term['glossary_id'] == $args['glossary_id']) {
117
+                    } elseif ($term['glossary_id'] == $args['glossary_id']) {
117 118
                         $this->glossary_id = $args['glossary_id'];
118 119
                         $this->current_term = $term;
119 120
                         $next = 1;
120 121
 
121
-                    }
122
-                    else {
122
+                    } else {
123 123
                         $this->previous_term = $term;
124 124
                     }
125 125
                 }
@@ -134,8 +134,7 @@  discard block
 block discarded – undo
134 134
             }
135 135
 
136 136
             return ($this->num_terms);
137
-        }
138
-        else {
137
+        } else {
139 138
             return false;
140 139
         }
141 140
     }
@@ -278,8 +277,9 @@  discard block
 block discarded – undo
278 277
 
279 278
         // check for any glossary terms to replace
280 279
         foreach ($this->replace_order as $glossary_id => $count) {
281
-            if ($glossary_id == $this->glossary_id)
282
-                continue;
280
+            if ($glossary_id == $this->glossary_id) {
281
+                            continue;
282
+            }
283 283
 
284 284
             $term_body = $this->terms[$glossary_id]['body'];
285 285
             $term_title = $this->terms[$glossary_id]['title'];
@@ -290,12 +290,10 @@  discard block
 block discarded – undo
290 290
             // catch glossary terms within their own definitions
291 291
             if ($glossary_id == $this->glossary_id) {
292 292
                 $replacewords[] = "<strong>\\1</strong>";
293
-            }
294
-            else {
293
+            } else {
295 294
                 if ($this_page == "admin_glossary") {
296 295
                     $link_url = "#gl".$glossary_id;
297
-                }
298
-                else {
296
+                } else {
299 297
                     $link_url = $URL->generate('url');
300 298
                 }
301 299
                 $title = _htmlentities(trim_characters($term_body, 0, 80));
@@ -304,8 +302,9 @@  discard block
 block discarded – undo
304 302
         }
305 303
         // Highlight all occurrences of another glossary term in the definition.
306 304
         $body = preg_replace($findwords, $replacewords, $body, 1);
307
-        if (isset($this->glossary_id))
308
-            $body = preg_replace("/(?<![>\.\'\/])\b(" . $this->terms[$this->glossary_id]['title'] . ")\b(?![<\'])/i", '<strong>\\1</strong>', $body, 1);
305
+        if (isset($this->glossary_id)) {
306
+                    $body = preg_replace("/(?<![>\.\'\/])\b(" . $this->terms[$this->glossary_id]['title'] . ")\b(?![<\'])/i", '<strong>\\1</strong>', $body, 1);
307
+        }
309 308
 
310 309
         // Replace any phrases in wikipedia
311 310
         // TODO: Merge this code into above, so our gloss and wikipedia
Please login to merge, or discard this patch.
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -21,20 +21,20 @@  discard block
 block discarded – undo
21 21
 */
22 22
 
23 23
 // This handles basic insertion and approval functions for all epobjects
24
-include_once INCLUDESPATH."easyparliament/searchengine.php";
24
+include_once INCLUDESPATH . "easyparliament/searchengine.php";
25 25
 
26 26
 class GLOSSARY {
27 27
 
28
-    public $num_terms;			// how many glossary entries do we have
28
+    public $num_terms; // how many glossary entries do we have
29 29
                             // (changes depending on how GLOSSARY is called
30
-    public $hansard_count;		// how many times does the phrase appear in hansard?
31
-    public $query;				// search term
32
-    public $glossary_id;		// if this is set then we only have 1 glossary term
33
-    public $current_term;		// will only be set if we have a valid epobject_id
30
+    public $hansard_count; // how many times does the phrase appear in hansard?
31
+    public $query; // search term
32
+    public $glossary_id; // if this is set then we only have 1 glossary term
33
+    public $current_term; // will only be set if we have a valid epobject_id
34 34
     public $current_letter;
35 35
 
36 36
     // constructor...
37
-    public function __construct($args=array()) {
37
+    public function __construct($args = array()) {
38 38
     // We can optionally start the glossary with one of several arguments
39 39
     //		1. glossary_id - treat the glossary as a single term
40 40
     //		2. glossary_term - search within glossary for a term
@@ -73,16 +73,16 @@  discard block
 block discarded – undo
73 73
 
74 74
             // These stop stupid submissions.
75 75
             // everything should be lowercase.
76
-            $this->stopwords = array( "the", "of", "to", "and", "for", "in", "a", "on", "is", "that", "will", "secretary", "are", "ask", "state", "have", "be", "has", "by", "with", "i", "not", "what", "as", "it", "hon", "he", "which", "from", "if", "been", "this", "s", "we", "at", "government", "was", "my", "an", "department", "there", "make", "or", "made", "their", "all", "but", "they", "how", "debate" );
76
+            $this->stopwords = array("the", "of", "to", "and", "for", "in", "a", "on", "is", "that", "will", "secretary", "are", "ask", "state", "have", "be", "has", "by", "with", "i", "not", "what", "as", "it", "hon", "he", "which", "from", "if", "been", "this", "s", "we", "at", "government", "was", "my", "an", "department", "there", "make", "or", "made", "their", "all", "but", "they", "how", "debate");
77 77
 
78 78
     }
79 79
 
80
-    public function get_glossary_item($args=array()) {
80
+    public function get_glossary_item($args = array()) {
81 81
         // Search for and fetch glossary item with title or glossary_id
82 82
         // We could also search glossary text that contains the title text, for cross references
83 83
 
84 84
         $this->alphabet = array();
85
-        foreach (range ("A", "Z") as $letter) {
85
+        foreach (range("A", "Z") as $letter) {
86 86
             $this->alphabet[$letter] = array();
87 87
         }
88 88
 
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
         }
139 139
     }
140 140
 
141
-    public function search_glossary($args=array()) {
141
+    public function search_glossary($args = array()) {
142 142
         // Search for and fetch glossary item with a title
143 143
         // Useful for the search page, and nowhere else (so far)
144 144
 
@@ -190,12 +190,12 @@  discard block
 block discarded – undo
190 190
         global $THEUSER;
191 191
 
192 192
         if ($data['title'] == '') {
193
-            error ("Sorry, you can't define a term without a title");
193
+            error("Sorry, you can't define a term without a title");
194 194
             return false;
195 195
         }
196 196
 
197 197
         if ($data['body'] == '') {
198
-            error ("You haven't entered a definition!");
198
+            error("You haven't entered a definition!");
199 199
             return false;
200 200
         }
201 201
 
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
         }
249 249
     }
250 250
 
251
-    public function glossarise($body, $tokenize=0, $urlize=0) {
251
+    public function glossarise($body, $tokenize = 0, $urlize = 0) {
252 252
     // Turn a body of text into a link-up wonderland of glossary joy
253 253
 
254 254
         global $this_page;
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
             }
292 292
             else {
293 293
                 if ($this_page == "admin_glossary") {
294
-                    $link_url = "#gl".$glossary_id;
294
+                    $link_url = "#gl" . $glossary_id;
295 295
                 }
296 296
                 else {
297 297
                     $link_url = $URL->generate('url');
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/mp/error.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@
 block discarded – undo
6 6
 
7 7
             <p><?= $error ?></p>
8 8
 
9
-        <?php if ( $rep_search_url ) { ?>
9
+        <?php if ($rep_search_url) { ?>
10 10
         </div>
11 11
 
12 12
         <div class="full-page__unit">
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/mp/votes.php 4 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
                               <?php foreach ($segment['votes']->positions as $key_vote) {
61 61
 
62 62
                                 if (isset($policy_last_update[$key_vote['policy_id']]) && $policy_last_update[$key_vote['policy_id']] > $most_recent) {
63
-                                  $most_recent = $policy_last_update[$key_vote['policy_id']];
63
+                                    $most_recent = $policy_last_update[$key_vote['policy_id']];
64 64
                                 }
65 65
 
66 66
                                 if ( $key_vote['has_strong'] || $key_vote['position'] == 'has never voted on' ) {
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 
82 82
                                 include '_vote_description.php';
83 83
 
84
-                              } ?>
84
+                                } ?>
85 85
                             </ul>
86 86
 
87 87
                             <div class="share-vote-descriptions">
Please login to merge, or discard this patch.
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -110,13 +110,16 @@
 block discarded – undo
110 110
 
111 111
                         <?php endif; ?>
112 112
 
113
-                    <?php else: ?>
113
+                    <?php else {
114
+    : ?>
114 115
 
115 116
                         <div class="panel">
116 117
                             <p>This person has not voted on any of the key issues which we keep track of.</p>
117 118
                         </div>
118 119
 
119
-                    <?php endif; ?>
120
+                    <?php endif;
121
+}
122
+?>
120 123
 
121 124
                 <?php endif; ?>
122 125
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
                                   $most_recent = $policy_last_update[$key_vote['policy_id']];
64 64
                                 }
65 65
 
66
-                                if ( $key_vote['has_strong'] || $key_vote['position'] == 'has never voted on' ) {
66
+                                if ($key_vote['has_strong'] || $key_vote['position'] == 'has never voted on') {
67 67
                                     $description = ucfirst($key_vote['desc']);
68 68
                                 } else {
69 69
                                     $description = sprintf(
Please login to merge, or discard this patch.
Upper-Lower-Casing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 
49 49
                 <?php if ($has_voting_record): ?>
50 50
 
51
-                    <?php $displayed_votes = FALSE; ?>
51
+                    <?php $displayed_votes = false; ?>
52 52
 
53 53
                     <?php foreach ($key_votes_segments as $segment): ?>
54 54
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 
106 106
                         </div>
107 107
 
108
-                            <?php $displayed_votes = TRUE; ?>
108
+                            <?php $displayed_votes = true; ?>
109 109
 
110 110
                         <?php endif; ?>
111 111
 
Please login to merge, or discard this patch.
www/includes/easyparliament/templates/html/mp/recent.php 3 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -38,11 +38,11 @@  discard block
 block discarded – undo
38 38
                 if ( isset($divisions) && $divisions ) {
39 39
                     if ($has_voting_record) {
40 40
                         foreach ($divisions as $division) {
41
-                          $displayed_votes = TRUE;
41
+                            $displayed_votes = TRUE;
42 42
 
43
-                          if ($current_date != $division['date']) {
43
+                            if ($current_date != $division['date']) {
44 44
                             if ($current_date != '' ) {
45
-                              print('</ul></div>');
45
+                                print('</ul></div>');
46 46
                             }
47 47
                             $current_date = $division['date'];
48 48
                             $sidebar_links[] = $division['date'];
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
                             <h2><?= strftime('%e %b %Y', strtotime($division['date'])) ?></h2>
52 52
                              <ul class="vote-descriptions policy-votes">
53 53
                           <?php }
54
-                          include('_division_description.php');
54
+                            include('_division_description.php');
55 55
                         }
56 56
                         echo('</div>');
57 57
                     }
Please login to merge, or discard this patch.
Upper-Lower-Casing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,15 +30,15 @@
 block discarded – undo
30 30
 
31 31
                 <?php
32 32
 
33
-                $displayed_votes = FALSE;
34
-                $show_all = TRUE;
33
+                $displayed_votes = false;
34
+                $show_all = true;
35 35
                 $current_date = '';
36 36
                 $sidebar_links = array();
37 37
 
38 38
                 if ( isset($divisions) && $divisions ) {
39 39
                     if ($has_voting_record) {
40 40
                         foreach ($divisions as $division) {
41
-                          $displayed_votes = TRUE;
41
+                          $displayed_votes = true;
42 42
 
43 43
                           if ($current_date != $division['date']) {
44 44
                             if ($current_date != '' ) {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -35,13 +35,13 @@  discard block
 block discarded – undo
35 35
                 $current_date = '';
36 36
                 $sidebar_links = array();
37 37
 
38
-                if ( isset($divisions) && $divisions ) {
38
+                if (isset($divisions) && $divisions) {
39 39
                     if ($has_voting_record) {
40 40
                         foreach ($divisions as $division) {
41 41
                           $displayed_votes = TRUE;
42 42
 
43 43
                           if ($current_date != $division['date']) {
44
-                            if ($current_date != '' ) {
44
+                            if ($current_date != '') {
45 45
                               print('</ul></div>');
46 46
                             }
47 47
                             $current_date = $division['date'];
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
             <div class="sidebar__unit in-page-nav">
69 69
                 <ul data-magellan-expedition="fixed">
70
-                  <?php foreach($sidebar_links as $date) { ?>
70
+                  <?php foreach ($sidebar_links as $date) { ?>
71 71
                     <li data-magellan-arrival="<?= strftime('%Y-%m-%d', strtotime($date)) ?>">
72 72
                         <a href="#<?= strftime('%Y-%m-%d', strtotime($date)) ?>">
73 73
                             <?= strftime('%e %b %Y', strtotime($date)) ?>
Please login to merge, or discard this patch.