mysociety / theyworkforyou

www/includes/easyparliament/templates/html/mp/votes.php

Indentation +4 added lines, -4 removed lines

@@ -131,8 +131,8 @@ 
 
                     <ul class="vote-descriptions">
                               <?php foreach ($sig_diff_policy->policy_pairs as $policy_pair) {
-                                  include '_vote_description.php';
-                              } ?>
+                                    include '_vote_description.php';
+                                } ?>
                             </ul>
 
                     <?php } ?>
@@ -165,9 +165,9 @@ 
                             <ul class="vote-descriptions">
                               <?php foreach ($segment->policy_pairs as $policy_pair) {
 
-                                  include '_vote_description.php';
+                                    include '_vote_description.php';
 
-                              } ?>
+                                } ?>
                             </ul>
 
                             <p class="voting-information-provenance">

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
 
                 <h3 class="browse-content">Comparison periods</h3>
                     <ul> 
-                    <?php foreach($available_periods as $period) { ?>
+                    <?php foreach ($available_periods as $period) { ?>
                         <li class="active"><a href="?comparison_period=<?= $period->lslug() ?>"><?= $period->description ?></a></li>
                     <?php } ?>
                     </ul>

classes/PolicyDistributionCollection.php

Spacing +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
             $group_name = $policies->getSetDescriptions()[$set_slug];
             $group_slug = $set_slug;
             $comparison_period_slug = $period_slug;
-            $policy_pairs = array_filter($pairs, function ($pair) use ($policy_ids) {
+            $policy_pairs = array_filter($pairs, function($pair) use ($policy_ids) {
                 return in_array($pair->getPolicyID(), $policy_ids) && !$pair->member_distribution->noDataAvailable();
             });
             $collection = new PolicyDistributionCollection($group_slug, $group_name, $comparison_period_slug, $person_id, $party_slug, $policy_pairs);

www/docs/mp/index.php

Spacing +6 added lines, -6 removed lines

@@ -615,7 +615,7 @@ 
 function person_error_page($message) {
     global $this_page;
     $SEARCHURL = '';
-    switch($this_page) {
+    switch ($this_page) {
         case 'peer':
             $people = new MySociety\TheyWorkForYou\People\Peers();
             $MPSURL = new \MySociety\TheyWorkForYou\Url('peers');
@@ -801,7 +801,7 @@ 
         $SEARCHENGINE = new \SEARCHENGINE($searchstring);
 
         $hansard = new MySociety\TheyWorkForYou\Hansard();
-        $args =  [
+        $args = [
             's' => $searchstring,
             'p' => 1,
             'num' => 3,
@@ -1017,7 +1017,7 @@ 
 
     $lang = LANGUAGE;
 
-    $reg = ['chamber_registers' => [] ];
+    $reg = ['chamber_registers' => []];
 
     foreach ($valid_chambers as $chamber) {
         $key = 'person_regmem_' . $chamber . '_' . $lang;
@@ -1032,7 +1032,7 @@ 
     }
 
     // sort chamber registers by published_date
-    uasort($reg['chamber_registers'], function ($a, $b) {
+    uasort($reg['chamber_registers'], function($a, $b) {
         return $a->published_date <=> $b->published_date;
     });
 
@@ -1126,8 +1126,8 @@ 
         }
     }
 
-    foreach($mreg as $reg) {
-        $data['members'][] =  [
+    foreach ($mreg as $reg) {
+        $data['members'][] = [
             'url' => '/' . $rep_type . '/?p=' . $reg['person_id'],
             'name' => $reg['given_name'] . ' ' . $reg['family_name'],
         ];

tests/DivisionsTest.php

Spacing +3 added lines, -3 removed lines

@@ -13,12 +13,12 @@ 
     }
 
     private function fetch_mp_recent_page() {
-        $vars = [ 'pagetype' => 'recent', 'pid' => 2, 'url' => '/mp/2/test_current-mp/test_westminster_constituency/recent' ];
+        $vars = ['pagetype' => 'recent', 'pid' => 2, 'url' => '/mp/2/test_current-mp/test_westminster_constituency/recent'];
         return $this->base_fetch_page($vars, 'mp', 'index.php', '/mp/recent.php');
     }
 
     private function fetch_recent_page() {
-        return $this->base_fetch_page(['url' => '/divisions' ], 'divisions', 'index.php', '/divisions/index.php');
+        return $this->base_fetch_page(['url' => '/divisions'], 'divisions', 'index.php', '/divisions/index.php');
     }
 
 
@@ -54,7 +54,7 @@ 
     }
 
     public function testSingleDivision() {
-        $page = $this->base_fetch_page(['url' => '/divisions/division.php', 'vote' => 'pw-3012-01-01-1-commons' ], 'divisions', 'division.php', '/divisions/division.php');
+        $page = $this->base_fetch_page(['url' => '/divisions/division.php', 'vote' => 'pw-3012-01-01-1-commons'], 'divisions', 'division.php', '/divisions/division.php');
         $this->assertStringContainsString('A majority of MPs  <b>voted in favour</b> of a thing', $page);
         $this->assertStringContainsString('Aye: 200', $page);
         $this->assertStringNotContainsString('No:', $page); # Summary 100, but no actual votes. In reality, summary can only be <= actual.

tests/PartyTest.php

Spacing +3 added lines, -3 removed lines

@@ -108,7 +108,7 @@ 
 
 
     private function getMemberFromPersonId($person_id) {
-        return new MySociety\TheyWorkForYou\Member([ "person_id" => $person_id ]);
+        return new MySociety\TheyWorkForYou\Member(["person_id" => $person_id]);
     }
 
     public function testMPPartyPolicyTextWhenDiffersVotes() {
@@ -139,7 +139,7 @@ 
         // this is a single person party i think - so no party comparison?
         // need to check what votes would actually produce
 
-        $page = $this->fetch_page(['pid' => 4, 'pagetype' => 'votes','url' => '/mp/4/test_mp_d/test_westminster_constituency/votes']);
+        $page = $this->fetch_page(['pid' => 4, 'pagetype' => 'votes', 'url' => '/mp/4/test_mp_d/test_westminster_constituency/votes']);
         $this->assertStringContainsString('Test MP D', $page);
         $this->assertStringContainsString('<li class="vote-description"', $page);
         $this->assertStringNotContainsString('comparable B Party MPs voted', $page);
@@ -150,7 +150,7 @@ 
 
         // this is just a boring, person aligned with party example
 
-        $page = $this->fetch_page(['pagetype' => 'votes', 'pid' => 16,  'url' => '/mp/16/test_mp_g_party_2/test_westminster_constituency/votes']);
+        $page = $this->fetch_page(['pagetype' => 'votes', 'pid' => 16, 'url' => '/mp/16/test_mp_g_party_2/test_westminster_constituency/votes']);
         $this->assertStringContainsString('Test MP G Party 2', $page);
 
         $this->assertStringNotContainsString('sometimes <b>differs</b> from their party colleagues', $page);