MySociety\TheyWorkForYou\Memcache

Complexity

Total Complexity

8

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Test Coverage

Coverage

76.19%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	set()	0	5	2
A	get()	0	12	3
A	__construct()	0	8	3

<?php

/**
 * Memcache wrapper
 *
 * @package TheyWorkForYou
 */

namespace MySociety\TheyWorkForYou;

class Memcache {

    static $memcache;

    public function __construct() {
        if (!self::$memcache) {
            if (class_exists('\Memcached')) {
                self::$memcache = new \Memcached;
                self::$memcache->addServer('localhost', 11211);
            } else {
                self::$memcache = new \Memcache;
                self::$memcache->connect('localhost', 11211);
            }
        }
    }

    public function set($key, $value, $timeout = 3600) {
        if (class_exists('\Memcached')) {
            self::$memcache->set(OPTION_TWFY_DB_NAME.':'.$key, $value, $timeout);
        } else {
            self::$memcache->set(OPTION_TWFY_DB_NAME.':'.$key, $value, MEMCACHE_COMPRESSED, $timeout);
        }
    }

    public function get($key) {
        // see http://php.net/manual/en/memcache.get.php#112056 for explanation of this
        $was_found = false;
        if (class_exists('\Memcached')) {
            $value = self::$memcache->get(OPTION_TWFY_DB_NAME.':'.$key, null, $was_found);
        } else {
            $value = self::$memcache->get(OPTION_TWFY_DB_NAME.':'.$key, $was_found);
        }
        if ($was_found === false) {

The condition $was_found === false is always true.

            return false; // mmmmm
        } else {
            return $value;
        }
    }
}