Memcache::set() - Code Metrics - Inspection of "PHP7 Code Changes" - mysociety/theyworkforyou - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1428)

by Nick

created 2019-04-29 11:37 UTC

Memcache::set() A

↳ Parent: Memcache

Complexity

Conditions	2
Paths	2

Size

Total Lines	5
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.0625

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	3
dl	0
loc	5
ccs	3
cts	4
cp	0.75
crap	2.0625
rs	10
c	0
b	0
f	0

<?php

/**
 * Memcache wrapper
 *
 * @package TheyWorkForYou
 */

namespace MySociety\TheyWorkForYou;

class Memcache {

    static $memcache;

    public function __construct() {
        if (!self::$memcache) {
            if (class_exists('\Memcached')) {
                self::$memcache = new \Memcached;
                self::$memcache->addServer('localhost', 11211);
            } else {
                self::$memcache = new \Memcache;
                self::$memcache->connect('localhost', 11211);
            }
        }
    }

    public function set($key, $value, $timeout = 3600) {
        if (class_exists('\Memcached')) {
            self::$memcache->set(OPTION_TWFY_DB_NAME.':'.$key, $value, $timeout);
        } else {
            self::$memcache->set(OPTION_TWFY_DB_NAME.':'.$key, $value, MEMCACHE_COMPRESSED, $timeout);
        }
    }

    public function get($key) {
        // see http://php.net/manual/en/memcache.get.php#112056 for explanation of this
        $was_found = false;
        if (class_exists('\Memcached')) {
            $value = self::$memcache->get(OPTION_TWFY_DB_NAME.':'.$key, null, $was_found);
        } else {
            $value = self::$memcache->get(OPTION_TWFY_DB_NAME.':'.$key, $was_found);
        }
        if ($was_found === false) {

            return false; // mmmmm
        } else {
            return $value;
        }
    }
}


1		<?php
2
3		/**
4		* Memcache wrapper
5		*
6		* @package TheyWorkForYou
7		*/
8
9		namespace MySociety\TheyWorkForYou;
10
11		class Memcache {
12
13		static $memcache;
14
15	2	public function __construct() {
16	2	if (!self::$memcache) {
17	1	if (class_exists('\Memcached')) {
18	1	self::$memcache = new \Memcached;
19	1	self::$memcache->addServer('localhost', 11211);
20		} else {
21		self::$memcache = new \Memcache;
22		self::$memcache->connect('localhost', 11211);
23		}
24		}
25	2	}
26
27	2	public function set($key, $value, $timeout = 3600) {
28	2	if (class_exists('\Memcached')) {
29	2	self::$memcache->set(OPTION_TWFY_DB_NAME.':'.$key, $value, $timeout);
30		} else {
31		self::$memcache->set(OPTION_TWFY_DB_NAME.':'.$key, $value, MEMCACHE_COMPRESSED, $timeout);
32		}
33	2	}
34
35	1	public function get($key) {
36		// see http://php.net/manual/en/memcache.get.php#112056 for explanation of this
37	1	$was_found = false;
38	1	if (class_exists('\Memcached')) {
39	1	$value = self::$memcache->get(OPTION_TWFY_DB_NAME.':'.$key, null, $was_found);
40		} else {
41		$value = self::$memcache->get(OPTION_TWFY_DB_NAME.':'.$key, $was_found);
42		}
43	1	if ($was_found === false) {
		0 ignored issues – show introduced 2018-10-30 10:15 UTC by Report Bug Copy Issue Report The condition `$was_found === false` is always `true`. Loading history...
44	1	return false; // mmmmm
45		} else {
46		return $value;
47		}
48		}
49		}
50

mysociety / theyworkforyou

Pull Request — master (#1428)

Memcache::set() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like