MySociety\TheyWorkForYou\Hansard::search()

Complexity

Conditions	3
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function search($searchstring, $args) {

The parameter $searchstring is not used and could be removed.

        if (!defined('FRONT_END_SEARCH') || !FRONT_END_SEARCH) {
            throw new \Exception('FRONT_END_SEARCH is not defined or is false.');
        }

        // throw exceptions rather than emit PAGE->error
        $args['exceptions'] = true;
        $list = new \HANSARDLIST();
        return $list->display('search', $args, 'none');

The expression return $list->display('search', $args, 'none') could also return false which is incompatible with the documented return type array. Did you maybe forget to handle an error condition?