MySociety\TheyWorkForYou\Hansard

Complexity

Total Complexity

3

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	search()	0	10	3

<?php

namespace MySociety\TheyWorkForYou;

/**
 * Hansard
 */

class Hansard extends \HANSARDLIST {
    /**
     * Search
     *
     * Performs a search of Hansard.
     *
     * @param string $searchstring The string to initialise SEARCHENGINE with.
     * @param array  $args         An array of arguments to restrict search results.
     *
     * @return array An array of search results.
     */

    public function search($searchstring, $args) {

The parameter $searchstring is not used and could be removed.

        if (!defined('FRONT_END_SEARCH') || !FRONT_END_SEARCH) {
            throw new \Exception('FRONT_END_SEARCH is not defined or is false.');
        }

        // throw exceptions rather than emit PAGE->error
        $args['exceptions'] = true;
        $list = new \HANSARDLIST();
        return $list->display('search', $args, 'none');

The expression return $list->display('search', $args, 'none') could also return false which is incompatible with the documented return type array. Did you maybe forget to handle an error condition?

    }

}