| @@ -169,7 +169,7 @@ discard block | ||
| 169 | 169 | } | 
| 170 | 170 | |
| 171 | 171 |          foreach (Settings::get('alert.macros.group', []) as $macro => $value) { | 
| 172 | - $value = str_replace(['%', '&&', '||'], ['', 'AND', 'OR'], $value); // this might need something more complex | |
| 172 | + $value = str_replace(['%', '&&', '||'], ['', 'AND', 'OR'], $value); // this might need something more complex | |
| 173 | 173 |              if (!str_contains($macro, ' ')) { | 
| 174 | 174 |                  $pattern = str_replace('macros.'.$macro, '('.$value.')', $pattern); | 
| 175 | 175 | } | 
| @@ -224,7 +224,7 @@ discard block | ||
| 224 | 224 | } | 
| 225 | 225 | |
| 226 | 226 | // fill in parameters | 
| 227 | -        foreach ((array)$this->params as $value) { | |
| 227 | +        foreach ((array) $this->params as $value) { | |
| 228 | 228 |              if (!is_numeric($value) && !starts_with($value, "'")) { | 
| 229 | 229 | $value = "'".$value."'"; | 
| 230 | 230 | } | 
| @@ -251,7 +251,7 @@ discard block | ||
| 251 | 251 |          $related = $this->getRelation('deviceCountRelation')->first(); | 
| 252 | 252 | |
| 253 | 253 | // then return the count directly | 
| 254 | - return ($related) ? (int)$related->count : 0; | |
| 254 | + return ($related) ? (int) $related->count : 0; | |
| 255 | 255 | } | 
| 256 | 256 | |
| 257 | 257 | /** | 
| @@ -123,7 +123,8 @@ discard block | ||
| 123 | 123 | // can't build sql | 
| 124 | 124 | return []; | 
| 125 | 125 | } | 
| 126 | -            } else { | |
| 126 | + } | |
| 127 | +            else { | |
| 127 | 128 | $params = $this->params; | 
| 128 | 129 | } | 
| 129 | 130 | } | 
| @@ -134,7 +135,8 @@ discard block | ||
| 134 | 135 | $query = null; | 
| 135 | 136 |          if (count($tables) == 1) { | 
| 136 | 137 |              $query = DB::table($tables[0])->select('device_id')->distinct(); | 
| 137 | -        } else { | |
| 138 | + } | |
| 139 | +        else { | |
| 138 | 140 |              $query = DB::table('devices')->select('devices.device_id')->distinct(); | 
| 139 | 141 | |
| 140 | 142 |              foreach ($tables as $table) { | 
| @@ -150,7 +152,8 @@ discard block | ||
| 150 | 152 | // match the device ids | 
| 151 | 153 |          if (is_null($params)) { | 
| 152 | 154 |              return $query->whereRaw($statement)->pluck('device_id'); | 
| 153 | -        } else { | |
| 155 | + } | |
| 156 | +        else { | |
| 154 | 157 |              return $query->whereRaw($statement, $params)->pluck('device_id'); | 
| 155 | 158 | } | 
| 156 | 159 | } | 
| @@ -178,7 +181,8 @@ discard block | ||
| 178 | 181 |          if (str_contains($pattern, 'macros.')) { | 
| 179 | 182 |              if (++$x < 30) { | 
| 180 | 183 | $pattern = self::applyGroupMacros($pattern, $x); | 
| 181 | -            } else { | |
| 184 | + } | |
| 185 | +            else { | |
| 182 | 186 | return false; | 
| 183 | 187 | } | 
| 184 | 188 | } | 
| @@ -309,7 +313,8 @@ discard block | ||
| 309 | 313 |              if (starts_with($cur, '%')) { | 
| 310 | 314 | // table and column or macro | 
| 311 | 315 | $out .= substr($cur, 1).' '; | 
| 312 | -            } elseif (substr($cur, -1) == '~') { | |
| 316 | + } | |
| 317 | +            elseif (substr($cur, -1) == '~') { | |
| 313 | 318 | // like operator | 
| 314 | 319 | $content = $parts[++$i]; // grab the content so we can format it | 
| 315 | 320 | |
| @@ -320,14 +325,18 @@ discard block | ||
| 320 | 325 | |
| 321 | 326 |                  $out .= "LIKE('".$this->convertRegexToLike($content)."') "; | 
| 322 | 327 | |
| 323 | -            } elseif ($cur == '&&') { | |
| 328 | + } | |
| 329 | +            elseif ($cur == '&&') { | |
| 324 | 330 | $out .= 'AND '; | 
| 325 | -            } elseif ($cur == '||') { | |
| 331 | + } | |
| 332 | +            elseif ($cur == '||') { | |
| 326 | 333 | $out .= 'OR '; | 
| 327 | -            } elseif (in_array($cur, $ops)) { | |
| 334 | + } | |
| 335 | +            elseif (in_array($cur, $ops)) { | |
| 328 | 336 | // pass-through operators | 
| 329 | 337 | $out .= $cur.' '; | 
| 330 | -            } else { | |
| 338 | + } | |
| 339 | +            else { | |
| 331 | 340 | // user supplied input | 
| 332 | 341 | $out .= "'".trim($cur, '"\'')."' "; // TODO: remove trim, only needed with invalid input | 
| 333 | 342 | } | 
| @@ -360,7 +369,8 @@ discard block | ||
| 360 | 369 | // add ends appropriately | 
| 361 | 370 |          if ($startAnchor && !$endAnchor) { | 
| 362 | 371 | $pattern .= '%'; | 
| 363 | -        } elseif (!$startAnchor && $endAnchor) { | |
| 372 | + } | |
| 373 | +        elseif (!$startAnchor && $endAnchor) { | |
| 364 | 374 | $pattern = '%'.$pattern; | 
| 365 | 375 | } | 
| 366 | 376 | |