murrant / librenmsv2

app/DataTables/DeviceDataTable.php

Unused Use Statements -1 removed lines

@@ -25,7 +25,6 @@
 
 namespace App\DataTables;
 
-use App\Models\DeviceGroup;
 use App\Models\Device;
 
 class DeviceDataTable extends BaseDataTable

app/Http/Controllers/DeviceController.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace App\Http\Controllers;
 
 use App\DataTables\DeviceDataTable;
-use App\DataTables\DeviceGroupDataTable;
 use App\Models\DeviceGroup;
 use Dingo\Api\Http;
 use Dingo\Api\Routing\Helpers;

app/Http/Controllers/DeviceGroupController.php

Doc Comments +4 added lines, -4 removed lines

@@ -58,7 +58,7 @@ 
      * Store a newly created resource in storage.
      *
      * @param  \Illuminate\Http\Request $request
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function store(DeviceGroupRequest $request)
     {
@@ -71,7 +71,7 @@ 
      * Display the specified resource.
      *
      * @param  int $id
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function show($id)
     {
@@ -95,7 +95,7 @@ 
      *
      * @param  \Illuminate\Http\Request $request
      * @param  int $id
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function update(DeviceGroupRequest $request, $id)
     {
@@ -110,7 +110,7 @@ 
      *
      * @param \Illuminate\Http\Request $request
      * @param  int $id
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      * @throws \Exception
      */
     public function destroy(AdminOnlyRequest $request, $id)

app/Models/DeviceGroup.php

Doc Comments +1 added lines, -1 removed lines

@@ -203,7 +203,7 @@
      * Convert a v1 device group pattern to v2 style
      *
      * @param $pattern
-     * @return array
+     * @return string
      */
     private function convertV1Pattern($pattern)
     {

app/QueryBuilderFilter.php

Doc Comments +3 added lines

@@ -38,6 +38,9 @@
         return json_encode(self::generateMacroFilter('alert.macros.rule', self::generateTableFilter()));
     }
 
+    /**
+     * @param string $setting
+     */
     private static function generateMacroFilter($setting, $filter = [])
     {
         foreach (Settings::get($setting, []) as $key => $value) {