Multidimensional\Cakephpify\Shell\Helper\TableHelper::output()

Complexity

Conditions	8
Paths	16

Size

Total Lines	28
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	72

Importance

Changes

0

<?php
    public function output($data, $columns = 10, $terminalWidth = 80)
    {
        while ((count($data) % $columns != 0) && ($columns > 5)) {
            $columns--;
        }

        $maxLength = max(array_map('strlen', $data));

        while (((($columns * ($maxLength + 3)) + 3) > $terminalWidth) && ($columns >= 1)) {
            $columns--;
        }

        $this->_io->out(' ' . str_repeat('+-' . str_repeat('-', $maxLength) . '-', $columns) . '+ ');

        for ($i = 0; $i < count($data);) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $output = " ";
            $j = $i;

Avoid variables with short names like $j. Configured minimum length is 3.

            for ($k = $i; $k < ($columns + $j); $k++) {
                if (!isset($data[$i])) {
                    $data[$i] = '';
                }
                $output .= '| ' . str_repeat(' ', floor(($maxLength - strlen($data[$i])) / 2)) . $data[$i] . str_repeat(' ', ceil(($maxLength - strlen($data[$i])) / 2)) . ' ';
                $i++;
            }
            $this->_io->out($output . '|');
            $this->_io->out(' ' . str_repeat('+-' . str_repeat('-', $maxLength) . '-', $columns) . '+ ');
        }
    }
}