Multidimensional\Cakephpify\Shell\Helper\TableHelper

Complexity

Total Complexity

8

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
C	output()	0	28	8

<?php
/**
 * CakePHPify : CakePHP Plugin for Shopify API Authentication
 * Copyright (c) Multidimension.al (http://multidimension.al)
 * Github : https://github.com/multidimension-al/cakephpify
 *
 * Licensed under The MIT License
 * For full copyright and license information, please see the LICENSE file
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright     (c) Multidimension.al (http://multidimension.al)
 * @link          https://github.com/multidimension-al/cakephpify CakePHPify Github
 * @license       http://www.opensource.org/licenses/mit-license.php MIT License
 */

namespace Multidimensional\Cakephpify\Shell\Helper;

use Cake\Console\Shell;
use Cake\Console\Helper;

class TableHelper extends Helper
{

    public function output($data, $columns = 10, $terminalWidth = 80)
    {
        while ((count($data) % $columns != 0) && ($columns > 5)) {
            $columns--;
        }

        $maxLength = max(array_map('strlen', $data));

        while (((($columns * ($maxLength + 3)) + 3) > $terminalWidth) && ($columns >= 1)) {
            $columns--;
        }

        $this->_io->out(' ' . str_repeat('+-' . str_repeat('-', $maxLength) . '-', $columns) . '+ ');

        for ($i = 0; $i < count($data);) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $output = " ";
            $j = $i;

Avoid variables with short names like $j. Configured minimum length is 3.

            for ($k = $i; $k < ($columns + $j); $k++) {
                if (!isset($data[$i])) {
                    $data[$i] = '';
                }
                $output .= '| ' . str_repeat(' ', floor(($maxLength - strlen($data[$i])) / 2)) . $data[$i] . str_repeat(' ', ceil(($maxLength - strlen($data[$i])) / 2)) . ' ';
                $i++;
            }
            $this->_io->out($output . '|');
            $this->_io->out(' ' . str_repeat('+-' . str_repeat('-', $maxLength) . '-', $columns) . '+ ');
        }
    }
}