WebSocketController::__construct() - Code Metrics - mshamaseen/laravel-ratchet - Measure and Improve Code Quality continuously with Scrutinizer

WebSocketController::__construct() A
last analyzed 2020-02-06 23:00 UTC

↳ Parent: WebSocketController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php
/**
 * Created by PhpStorm.
 * User: shanmaseen
 * Date: 24/03/19
 * Time: 07:43 م
 */

namespace Shamaseen\Laravel\Ratchet\Controllers;


use Illuminate\Support\Collection;
use Ratchet\ConnectionInterface;
use Shamaseen\Laravel\Ratchet\Objects\Clients\Client;
use Shamaseen\Laravel\Ratchet\Objects\Rooms\Room;
use Shamaseen\Laravel\Ratchet\Receiver;
use Shamaseen\Laravel\Ratchet\Traits\Validation;
use Shamaseen\Laravel\Ratchet\Traits\WebSocketMessagesManager;

/**
 * Class WebSocketController
 * @package App\WebSockets\Controllers
 */
class WebSocketController
{
    use WebSocketMessagesManager,Validation;

    /**
     * @var Client[]
     */
    public $clients;

    /**
     * Auth to resourceId mapper
     * @var array
     */
    public $userAuthSocketMapper;

    /**
     * Ratchet ConnectionInterface
     * @var ConnectionInterface
     */
    public $conn;

    /**
     * The main receiver of websocket event, here we can change property for all connection.
     * @var Receiver
     */
    public $receiver;

    /**
     * The rooms array
     * @var Room[]
     */
    public $rooms;

    /**
     * @var Collection
     */
    public $request;

    /**
     * @var array
     */
    public $route;

    public function __construct()
    {

    }

    /**
     * @desc return the client class
     * @return Client
     */
    function getClient()

    {
        return $this->clients[$this->conn->resourceId];
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: shanmaseen
5			* Date: 24/03/19
6			* Time: 07:43 م
7			*/
8
9			namespace Shamaseen\Laravel\Ratchet\Controllers;
10
11
12			use Illuminate\Support\Collection;
13			use Ratchet\ConnectionInterface;
14			use Shamaseen\Laravel\Ratchet\Objects\Clients\Client;
15			use Shamaseen\Laravel\Ratchet\Objects\Rooms\Room;
16			use Shamaseen\Laravel\Ratchet\Receiver;
17			use Shamaseen\Laravel\Ratchet\Traits\Validation;
18			use Shamaseen\Laravel\Ratchet\Traits\WebSocketMessagesManager;
19
20			/**
21			* Class WebSocketController
22			* @package App\WebSockets\Controllers
23			*/
24			class WebSocketController
25			{
26			use WebSocketMessagesManager,Validation;
27
28			/**
29			* @var Client[]
30			*/
31			public $clients;
32
33			/**
34			* Auth to resourceId mapper
35			* @var array
36			*/
37			public $userAuthSocketMapper;
38
39			/**
40			* Ratchet ConnectionInterface
41			* @var ConnectionInterface
42			*/
43			public $conn;
44
45			/**
46			* The main receiver of websocket event, here we can change property for all connection.
47			* @var Receiver
48			*/
49			public $receiver;
50
51			/**
52			* The rooms array
53			* @var Room[]
54			*/
55			public $rooms;
56
57			/**
58			* @var Collection
59			*/
60			public $request;
61
62			/**
63			* @var array
64			*/
65			public $route;
66
67			public function __construct()
68			{
69
70			}
71
72			/**
73			* @desc return the client class
74			* @return Client
75			*/
76			function getClient()
			0 ignored issues – show Best Practice introduced 2019-11-18 02:15 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
77			{
78			return $this->clients[$this->conn->resourceId];
			0 ignored issues – show Bug introduced 2019-11-18 02:15 UTC by Report Bug Copy Issue Report Accessing `resourceId` on the interface `Ratchet\ConnectionInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
79			}
80			}
81

mshamaseen / laravel-ratchet

WebSocketController::__construct() A last analyzed 2020-02-06 23:00 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

WebSocketController::__construct() A
last analyzed 2020-02-06 23:00 UTC