Shamaseen\Laravel\Ratchet\Controllers\WebSocketController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getClient()	0	4	1

<?php
/**
 * Created by PhpStorm.
 * User: shanmaseen
 * Date: 24/03/19
 * Time: 07:43 م
 */

namespace Shamaseen\Laravel\Ratchet\Controllers;


use Illuminate\Support\Collection;
use Ratchet\ConnectionInterface;
use Shamaseen\Laravel\Ratchet\Objects\Clients\Client;
use Shamaseen\Laravel\Ratchet\Objects\Rooms\Room;
use Shamaseen\Laravel\Ratchet\Receiver;
use Shamaseen\Laravel\Ratchet\Traits\Validation;
use Shamaseen\Laravel\Ratchet\Traits\WebSocketMessagesManager;

/**
 * Class WebSocketController
 * @package App\WebSockets\Controllers
 */
class WebSocketController
{
    use WebSocketMessagesManager,Validation;

    /**
     * @var Client[]
     */
    public $clients;

    /**
     * Auth to resourceId mapper
     * @var array
     */
    public $userAuthSocketMapper;

    /**
     * Ratchet ConnectionInterface
     * @var ConnectionInterface
     */
    public $conn;

    /**
     * The main receiver of websocket event, here we can change property for all connection.
     * @var Receiver
     */
    public $receiver;

    /**
     * The rooms array
     * @var Room[]
     */
    public $rooms;

    /**
     * @var Collection
     */
    public $request;

    /**
     * @var array
     */
    public $route;

    public function __construct()
    {

    }

    /**
     * @desc return the client class
     * @return Client
     */
    function getClient()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->clients[$this->conn->resourceId];

Accessing resourceId on the interface Ratchet\ConnectionInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }
}