mschindler83 / fints-hbci-php

lib/Fhp/Dialog/Dialog.php

Doc Comments +4 added lines, -4 removed lines

@@ -186,7 +186,7 @@ 
     /**
      * Gets the dialog ID.
      *
-     * @return int|string
+     * @return integer
      */
     public function getDialogId()
     {
@@ -256,7 +256,7 @@ 
     /**
      * Initializes a dialog.
      *
-     * @return int|null
+     * @return string|null
      * @throws AdapterException
      * @throws CurlException
      * @throws FailedRequestException
@@ -294,7 +294,7 @@ 
     /**
      * Sends sync request.
      *
-     * @return mixed
+     * @return string
      * @throws AdapterException
      * @throws CurlException
      * @throws FailedRequestException
@@ -350,7 +350,7 @@ 
     /**
      * Ends a previous started dialog.
      *
-     * @return mixed
+     * @return string
      * @throws AdapterException
      * @throws CurlException
      * @throws FailedRequestException

lib/Fhp/Model/StatementOfAccount/Statement.php

Doc Comments +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
     /**
      * Get creditDebit
      *
-     * @return mixed
+     * @return string
      */
     public function getCreditDebit()
     {

lib/Fhp/Parser/MT940.php

Doc Comments +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
     /**
      * MT940 constructor.
      *
-     * @param $rawData
+     * @param string $rawData
      */
     public function __construct($rawData)
     {

lib/Fhp/Response/Response.php

Doc Comments +2 added lines, -2 removed lines

@@ -26,7 +26,7 @@ 
     /**
      * Response constructor.
      *
-     * @param $rawResponse
+     * @param string $rawResponse
      */
     public function __construct($rawResponse)
     {
@@ -242,7 +242,7 @@ 
 
     /**
      * @param bool $translateCodes
-     * @return mixed
+     * @return string
      */
     public function humanReadable($translateCodes = false)
     {

Spacing +1 added lines, -1 removed lines

@@ -117,7 +117,7 @@
         foreach ($segments as $segment) {
             $segment = $this->splitSegment($segment);
             array_shift($segment);
-            foreach($segment as $seg) {
+            foreach ($segment as $seg) {
                 list($id, $msg) = explode('::', $seg, 2);
                 if ("3920" == $id) {
                     if (preg_match_all('/\d{3}/', $msg, $matches)) {

lib/Tests/Fhp/Message/MessageTest.php

Unused Use Statements -2 removed lines

@@ -2,7 +2,6 @@ 
 
 namespace Fhp\Message;
 
-use Fhp\DataElementGroups\SecurityProfile;
 use Fhp\DataTypes\Kik;
 use Fhp\DataTypes\Ktv;
 use Fhp\Segment\AbstractSegment;
@@ -12,7 +11,6 @@ 
 use Fhp\Segment\HNSHK;
 use Fhp\Segment\HNVSD;
 use Fhp\Segment\HNVSK;
-use Fhp\Segment\SegmentInterface;
 
 class MessageTest extends \PHPUnit_Framework_TestCase
 {

Samples/statement_of_account.php

Spacing +4 added lines, -4 removed lines

@@ -11,11 +11,11 @@
 use Fhp\Model\StatementOfAccount\Statement;
 use Fhp\Model\StatementOfAccount\Transaction;
 
-define('FHP_BANK_URL', '');                # HBCI / FinTS Url can be found here: https://www.hbci-zka.de/institute/institut_auswahl.htm (use the PIN/TAN URL)
-define('FHP_BANK_PORT', 443);              # HBCI / FinTS Port can be found here: https://www.hbci-zka.de/institute/institut_auswahl.htm
-define('FHP_BANK_CODE', '');               # Your bank code / Bankleitzahl
+define('FHP_BANK_URL', ''); # HBCI / FinTS Url can be found here: https://www.hbci-zka.de/institute/institut_auswahl.htm (use the PIN/TAN URL)
+define('FHP_BANK_PORT', 443); # HBCI / FinTS Port can be found here: https://www.hbci-zka.de/institute/institut_auswahl.htm
+define('FHP_BANK_CODE', ''); # Your bank code / Bankleitzahl
 define('FHP_ONLINE_BANKING_USERNAME', ''); # Your online banking username / alias
-define('FHP_ONLINE_BANKING_PIN', '');      # Your online banking PIN (NOT! the pin of your bank card!)
+define('FHP_ONLINE_BANKING_PIN', ''); # Your online banking PIN (NOT! the pin of your bank card!)
 
 $fints = new FinTs(
     FHP_BANK_URL,

Samples/saldo.php

Spacing +5 added lines, -5 removed lines

@@ -10,11 +10,11 @@
 use Fhp\Model\StatementOfAccount\Statement;
 use Fhp\Model\StatementOfAccount\Transaction;
 
-define('FHP_BANK_URL', '');                 # HBCI / FinTS Url can be found here: https://www.hbci-zka.de/institute/institut_auswahl.htm (use the PIN/TAN URL)
-define('FHP_BANK_PORT', 443);               # HBCI / FinTS Port can be found here: https://www.hbci-zka.de/institute/institut_auswahl.htm
-define('FHP_BANK_CODE', '');                # Your bank code / Bankleitzahl
-define('FHP_ONLINE_BANKING_USERNAME', '');  # Your online banking username / alias
-define('FHP_ONLINE_BANKING_PIN', '');       # Your online banking PIN (NOT! the pin of your bank card!)
+define('FHP_BANK_URL', ''); # HBCI / FinTS Url can be found here: https://www.hbci-zka.de/institute/institut_auswahl.htm (use the PIN/TAN URL)
+define('FHP_BANK_PORT', 443); # HBCI / FinTS Port can be found here: https://www.hbci-zka.de/institute/institut_auswahl.htm
+define('FHP_BANK_CODE', ''); # Your bank code / Bankleitzahl
+define('FHP_ONLINE_BANKING_USERNAME', ''); # Your online banking username / alias
+define('FHP_ONLINE_BANKING_PIN', ''); # Your online banking PIN (NOT! the pin of your bank card!)
 
 $fints = new FinTs(
     FHP_BANK_URL,

lib/Tests/TestInit.php

Spacing +1 added lines, -1 removed lines

@@ -7,7 +7,7 @@
 // register silently failing autoloader
 spl_autoload_register(function($class) {
     if (0 === strpos($class, 'Fhp\Tests\\')) {
-        $path = __DIR__.'/../../'.strtr($class, '\\', '/').'.php';
+        $path = __DIR__ . '/../../' . strtr($class, '\\', '/') . '.php';
         if (is_file($path) && is_readable($path)) {
             require_once $path;
 

lib/Fhp/Message/Message.php

Spacing +2 added lines, -2 removed lines

@@ -112,7 +112,7 @@ 
             }
         }
 
-        $signatureHead  = $this->buildSignatureHead();
+        $signatureHead = $this->buildSignatureHead();
         $hnvsk = $this->buildEncryptionHead();
 
         $this->addSegment($hnvsk);
@@ -128,7 +128,7 @@ 
 
         $curCount = count($encryptedSegments) + 3;
 
-        $signatureEnd   = new HNSHA($curCount, $this->securityReference, $this->pin);
+        $signatureEnd = new HNSHA($curCount, $this->securityReference, $this->pin);
         $this->addEncryptedSegment($signatureEnd);
         $this->addSegment(new HNHBS($curCount + 1, $this->messageNumber));
     }