mpyw / co

examples/intro/intro-php55.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 require __DIR__ . '/../vendor/autoload.php';
 
 use mpyw\Co\Co;
-use mpyw\Co\CURLException;
 
 function curl_init_with($url, array $options = [CURLOPT_RETURNTRANSFER => true]) {
     $ch = curl_init($url);

Spacing +2 added lines, -2 removed lines

@@ -18,10 +18,10 @@
 
 var_dump(Co::wait([
     "google.com HTML" => curl_init_with("https://google.com"),
-    "Content-Length of github.com" => function () {
+    "Content-Length of github.com" => function() {
         yield Co::RETURN_WITH => strlen(yield curl_init_with("https://github.com"));
     },
-    "Save mpyw's Gravatar Image URL to local" => function () {
+    "Save mpyw's Gravatar Image URL to local" => function() {
         $xpath = (yield get_xpath_async('https://github.com/mpyw'));
         yield curl_init_with(
             $xpath->evaluate('string(//img[contains(@class,"avatar")]/@src)'),

examples/intro/intro-php7.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 require __DIR__ . '/../vendor/autoload.php';
 
 use mpyw\Co\Co;
-use mpyw\Co\CURLException;
 
 function curl_init_with($url, array $options = [CURLOPT_RETURNTRANSFER => true]) {
     $ch = curl_init($url);

Spacing +2 added lines, -2 removed lines

@@ -18,10 +18,10 @@
 
 var_dump(Co::wait([
     "google.com HTML" => curl_init_with("https://google.com"),
-    "Content-Length of github.com" => function () {
+    "Content-Length of github.com" => function() {
         return strlen(yield curl_init_with("https://github.com"));
     },
-    "Save mpyw's Gravatar Image URL to local" => function () {
+    "Save mpyw's Gravatar Image URL to local" => function() {
         yield curl_init_with(
             (yield get_xpath_async('https://github.com/mpyw'))
                 ->evaluate('string(//img[contains(@class,"avatar")]/@src)'),

examples/localhost/server.php

Doc Comments +9 added lines

@@ -12,6 +12,10 @@ 
         throw new \RuntimeException($error['message']);
     }
 }
+/**
+ * @param integer $status
+ * @param string $message
+ */
 function respond_rest($con, $status, $message, $content) {
     try {
         $length = strlen($content);
@@ -24,6 +28,11 @@ 
     }
     fclose($con);
 }
+/**
+ * @param Closure $tick_function
+ * @param integer $tick
+ * @param integer $times
+ */
 function respond_streaming($con, $tick_function, $tick, $times) {
     try {
         fsend($con, "HTTP/1.1 200 OK\r\n");

Spacing +4 added lines, -4 removed lines

@@ -68,21 +68,21 @@
             continue;
         }
         $endpoints = array(
-            '/rest' => function ($con, $q) {
+            '/rest' => function($con, $q) {
                 $sleep = isset($q['sleep']) ? (int)$q['sleep'] : 0;
                 sleep($sleep);
                 $id = isset($q['id']) ? (int)$q['id'] : '?';
                 respond_rest($con, 200, 'OK', "Rest response #$id (sleep: $sleep sec)\n");
             },
-            '/streaming' => function ($con, $q) {
+            '/streaming' => function($con, $q) {
                 $tick = isset($q['tick']) ? (int)$q['tick'] : 1;
                 $id = isset($q['id']) ? (int)$q['id'] : '?';
                 $times = isset($q['times']) ? (int)$q['times'] : 10;
-                respond_streaming($con, function ($i) use ($id, $times) {
+                respond_streaming($con, function($i) use ($id, $times) {
                     return "Rest response #$id ($i / $times, tick: $tick sec)\n";
                 }, $tick, $times);
             },
-            '' => function ($con, $q) {
+            '' => function($con, $q) {
                 respond_rest($con, 404, 'Not Found', "Undefined path\n");
             },
         );

Braces +6 added lines, -3 removed lines

@@ -55,8 +55,9 @@ 
         $con = @stream_socket_accept($socket, -1);
         if (!$con) {
             $err = error_get_last(); // どーなんだこれ strerror(EINTR)
-            if (strpos($err["message"], "Interrupted system call") !== false)
-                continue;
+            if (strpos($err["message"], "Interrupted system call") !== false) {
+                            continue;
+            }
             fwrite(STDERR, "[Server] " . $err["message"] . "\n");
             exit(1);
         }
@@ -91,7 +92,9 @@ 
         parse_str(isset($parsed['query']) ? $parsed['query'] : '', $q);
         foreach ($endpoints as $endpoint => $action) {
             if ($parsed['path'] === $endpoint || $endpoint === '') {
-                if ($endpoint === '') $endpoint = '[Undefined]';
+                if ($endpoint === '') {
+                    $endpoint = '[Undefined]';
+                }
                 fwrite(STDERR, "Request: $parts[1]\n");
                 $action($con, $q);
                 exit(0);

src/Co.php

Doc Comments +2 added lines, -3 removed lines

@@ -62,7 +62,6 @@ 
      *
      * @access public
      * @static
-     * @param int $concurrency
      * @param bool $throw
      */
     public static function setDefaultThrow($throw)
@@ -451,7 +450,7 @@ 
      *
      * @access private
      * @param Generator $value
-     * @return bool
+     * @return boolean|null
      */
     private function canThrow(\Generator $value)
     {
@@ -514,7 +513,7 @@ 
      * @access private
      * @static
      * @param int|float|string $interval
-     * @return int
+     * @return double
      */
     private static function validateInterval($interval)
     {

Spacing +10 added lines, -10 removed lines

@@ -45,17 +45,17 @@
      *   - "wait" (Co::wait calls)
      *   - "async" (Co::async calls)
      */
-    private $mh;                          // curl_multi_init()
-    private $count = 0;                   // count(curl_multi_add_handle called)
-    private $concurrency = 6;             // Limit of TCP connections
-    private $interval = 1.0;              // curl_multi_select() timeout
-    private $throw = true;                // Throw CURLExceptions?
-    private $queue = array();             // cURL resources over concurrency limits are temporalily stored here
-    private $tree = array();              // array<*Stack ID*, mixed>
-    private $values = array();            // array<*Stack ID*|*cURL ID*, Generator|resource<cURL>>
-    private $value_to_parent = array();   // array<*Stack ID*|*cURL ID*, *Stack ID*>
+    private $mh; // curl_multi_init()
+    private $count = 0; // count(curl_multi_add_handle called)
+    private $concurrency = 6; // Limit of TCP connections
+    private $interval = 1.0; // curl_multi_select() timeout
+    private $throw = true; // Throw CURLExceptions?
+    private $queue = array(); // cURL resources over concurrency limits are temporalily stored here
+    private $tree = array(); // array<*Stack ID*, mixed>
+    private $values = array(); // array<*Stack ID*|*cURL ID*, Generator|resource<cURL>>
+    private $value_to_parent = array(); // array<*Stack ID*|*cURL ID*, *Stack ID*>
     private $value_to_children = array(); // array<*Stack ID*, array<*Stack ID*|*cURL ID*, true>>
-    private $value_to_keylist = array();  // array<*Stack ID*|*cURL ID*, array<mixed>>
+    private $value_to_keylist = array(); // array<*Stack ID*|*cURL ID*, array<mixed>>
 
     /**
      * Override or get default settings.

Braces +3 added lines, -1 removed lines

@@ -323,8 +323,10 @@
             // NOTE: DO NOT call curl_multi_remove_handle
             //       or curl_multi_add_handle while looping curl_multi_info_read!
             $entries = array();
-            do if ($entry = curl_multi_info_read($this->mh, $remains)) {
+            do {
+                if ($entry = curl_multi_info_read($this->mh, $remains)) {
                 $entries[] = $entry;
+            }
             } while ($remains);
             // Remove done and consume queue.
             foreach ($entries as $entry) {

examples/localhost/client-init.php

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
     $ch = curl_init();
     curl_setopt_array($ch, array(
         CURLOPT_URL => "http://localhost:8080$path?" . http_build_query($q, '', '&'),
-        CURLOPT_WRITEFUNCTION => function ($ch, $buf) use ($callback) {
+        CURLOPT_WRITEFUNCTION => function($ch, $buf) use ($callback) {
             $callback($buf);
             return strlen($buf);
         },

examples/localhost/client-basic.php

Spacing +4 added lines, -4 removed lines

@@ -7,7 +7,7 @@ 
 
 // Wait 7 sec
 print_time();
-$result = Co::wait([curl('/rest', ['id' => 1, 'sleep' => 7]), function () {
+$result = Co::wait([curl('/rest', ['id' => 1, 'sleep' => 7]), function() {
     // Wait 4 sec
     print_r(yield [
         curl('/rest', ['id' => 2, 'sleep' => 3]),
@@ -16,13 +16,13 @@ 
     print_time();
     // Wait 2 sec
     print_r(yield [
-        function () {
+        function() {
             // Wait 1 sec
             echo yield curl('/rest', ['id' => 4, 'sleep' => 1]), "\n";
             print_time();
             return curl('/rest', ['id' => 5, 'sleep' => 1]);
         },
-        function () {
+        function() {
             // Wait 0 sec
             echo (yield CO::SAFE => curl_init('invaild'))->getMessage(), "\n";
             print_time();
@@ -33,7 +33,7 @@ 
                 echo $e->getMessage(), "\n";
                 print_time();
             }
-            return ['x' => ['y' => function () {
+            return ['x' => ['y' => function() {
                 return curl('/rest', ['id' => 6, 'sleep' => 2]);
             }]];
         }

examples/twitter/userstream.php

Spacing +2 added lines, -2 removed lines

@@ -15,7 +15,7 @@ 
 define('FAVORITE_REGEX', '/' . trim(fgets(STDIN)) . '/');
 
 // Listen Twitter UserStreaming on 2 different accounts
-Co::wait(array_map(function ($to) {
+Co::wait(array_map(function($to) {
     // You have to install (Go)mpyw/twhelp-go or (PHP)mpyw/twhelp.
     // - Go: https://github.com/mpyw/twhelp-go
     // - PHP: https://github.com/mpyw/twhelp
@@ -24,7 +24,7 @@ 
         exit(1);
     }
     eval(implode($r));
-    return $to->curlStreaming('user', function ($status) use ($to) {
+    return $to->curlStreaming('user', function($status) use ($to) {
         if (isset($status->text)) {
             if (preg_match(FAVORITE_REGEX, htmlspecialchars_decode($status->text, ENT_NOQUOTES))) {
                 Co::async($to->curlPost('favorites/create', array(