Inspection of "Merge pull request #31 from mprins/reformatting" - mprins/dokuwiki-plugin-backlinks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c434e2...36ed08 )

by Mark

created 2021-04-15 09:29 UTC

Status

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
         global $conf;
         $conf['allowdebug'] = 1;
 
-        TestUtils::rcopy(TMP_DIR, dirname(__FILE__) . '/data/');
+        TestUtils::rcopy(TMP_DIR, dirname(__FILE__).'/data/');
 
         dbglog("\nset up class syntax_plugin_backlinks_test");
     }
@@ -52,12 +52,12 @@  discard block
 block discarded – undo
 
         $verbose = false;
         $force   = false;
-        foreach($data as $val) {
+        foreach ($data as $val) {
             idx_addPage($val['id'], $verbose, $force);
         }
 
-        if($conf['allowdebug']) {
-            touch(DOKU_TMP_DATA . 'cache/debug.log');
+        if ($conf['allowdebug']) {
+            touch(DOKU_TMP_DATA.'cache/debug.log');
         }
     }
 
@@ -66,10 +66,10 @@  discard block
 block discarded – undo
 
         global $conf;
         // try to get the debug log after running the test, print and clear
-        if($conf['allowdebug']) {
+        if ($conf['allowdebug']) {
             print "\n";
-            readfile(DOKU_TMP_DATA . 'cache/debug.log');
-            unlink(DOKU_TMP_DATA . 'cache/debug.log');
+            readfile(DOKU_TMP_DATA.'cache/debug.log');
+            unlink(DOKU_TMP_DATA.'cache/debug.log');
         }
     }
 

Please login to merge, or discard this patch.

_test/general.test.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@
 block discarded – undo
      * Simple test to make sure the plugin.info.txt is in correct format
      */
     public function test_plugininfo(): void {
-        $file = __DIR__ . '/../plugin.info.txt';
+        $file = __DIR__.'/../plugin.info.txt';
         $this->assertFileExists($file);
 
         $info = confToHash($file);

Please login to merge, or discard this patch.

_test/syntax.test.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
         global $conf;
         $conf['allowdebug'] = 1;
 
-        TestUtils::rcopy(TMP_DIR, dirname(__FILE__) . '/data/');
+        TestUtils::rcopy(TMP_DIR, dirname(__FILE__).'/data/');
 
         dbglog("\nset up class syntax_plugin_backlinks_test");
     }
@@ -52,14 +52,14 @@  discard block
 block discarded – undo
 
         $verbose = false;
         $force   = false;
-        foreach($data as $val) {
+        foreach ($data as $val) {
             idx_addPage($val['id'], $verbose, $force);
         }
         //idx_addPage('bob_ross_says', $verbose, $force);
         //idx_addPage('link', $verbose, $force);
         //idx_addPage('backlinks_syntax', $verbose, $force);
-        if($conf['allowdebug']) {
-            touch(DOKU_TMP_DATA . 'cache/debug.log');
+        if ($conf['allowdebug']) {
+            touch(DOKU_TMP_DATA.'cache/debug.log');
         }
     }
 
@@ -68,10 +68,10 @@  discard block
 block discarded – undo
 
         global $conf;
         // try to get the debug log after running the test, print and clear
-        if($conf['allowdebug']) {
+        if ($conf['allowdebug']) {
             print "\n";
-            readfile(DOKU_TMP_DATA . 'cache/debug.log');
-            unlink(DOKU_TMP_DATA . 'cache/debug.log');
+            readfile(DOKU_TMP_DATA.'cache/debug.log');
+            unlink(DOKU_TMP_DATA.'cache/debug.log');
         }
     }
 

Please login to merge, or discard this patch.

syntax.php 1 patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -63,7 +63,7 @@  discard block
 block discarded – undo
         $match = substr($match, 12, -2);
 
         $includeNS = '';
-        if(strstr($match, "#")) {
+        if (strstr($match, "#")) {
             $includeNS = substr(strstr($match, "#", false), 1);
             $match     = strstr($match, "#", true);
         }
@@ -83,38 +83,38 @@  discard block
 block discarded – undo
 
         $id = $ID;
         // If it's a sidebar, get the original id.
-        if($INFO != null) {
+        if ($INFO != null) {
             $id = $INFO['id'];
         }
         $match = $data[0];
         $match = ($match == '.') ? $id : $match;
-        if(strstr($match, ".:")) {
+        if (strstr($match, ".:")) {
             resolve_pageid(getNS($id), $match, $exists);
         }
 
-        if($mode == 'xhtml') {
+        if ($mode == 'xhtml') {
             $renderer->info['cache'] = false;
 
             $backlinks = ft_backlinks($match);
 
             dbglog($backlinks, "backlinks: all backlinks to: $match");
 
-            $renderer->doc .= '<div id="plugin__backlinks">' . "\n";
+            $renderer->doc .= '<div id="plugin__backlinks">'."\n";
 
             $filterNS = $data[1];
-            if(!empty($backlinks) && !empty($filterNS)) {
-                if(stripos($filterNS, "!", 0) === 0) {
+            if (!empty($backlinks) && !empty($filterNS)) {
+                if (stripos($filterNS, "!", 0) === 0) {
                     $filterNS = substr($filterNS, 1);
                     dbglog($filterNS, "backlinks: exluding all of namespace: $filterNS");
                     $backlinks = array_filter(
-                        $backlinks, function ($ns) use ($filterNS) {
+                        $backlinks, function($ns) use ($filterNS) {
                         return stripos($ns, $filterNS, 0) !== 0;
                     }
                     );
                 } else {
                     dbglog($filterNS, "backlinks: including namespace: $filterNS only");
                     $backlinks = array_filter(
-                        $backlinks, function ($ns) use ($filterNS) {
+                        $backlinks, function($ns) use ($filterNS) {
                         return stripos($ns, $filterNS, 0) === 0;
                     }
                     );
@@ -123,26 +123,26 @@  discard block
 block discarded – undo
 
             dbglog($backlinks, "backlinks: all backlinks to be rendered");
 
-            if(!empty($backlinks)) {
+            if (!empty($backlinks)) {
 
                 $renderer->doc .= '<ul class="idx">';
 
-                foreach($backlinks as $backlink) {
+                foreach ($backlinks as $backlink) {
                     $name = p_get_metadata($backlink, 'title');
-                    if(empty($name)) {
+                    if (empty($name)) {
                         $name = $backlink;
                     }
                     $renderer->doc .= '<li><div class="li">';
-                    $renderer->doc .= html_wikilink(':' . $backlink, $name);
-                    $renderer->doc .= '</div></li>' . "\n";
+                    $renderer->doc .= html_wikilink(':'.$backlink, $name);
+                    $renderer->doc .= '</div></li>'."\n";
                 }
 
-                $renderer->doc .= '</ul>' . "\n";
+                $renderer->doc .= '</ul>'."\n";
             } else {
-                $renderer->doc .= "<strong>Plugin Backlinks: " . $lang['nothingfound'] . "</strong>" . "\n";
+                $renderer->doc .= "<strong>Plugin Backlinks: ".$lang['nothingfound']."</strong>"."\n";
             }
 
-            $renderer->doc .= '</div>' . "\n";
+            $renderer->doc .= '</div>'."\n";
 
             return true;
         }

Please login to merge, or discard this patch.

_test/syntax_exclude.test.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
         global $conf;
         $conf['allowdebug'] = 1;
 
-        TestUtils::rcopy(TMP_DIR, dirname(__FILE__) . '/data/');
+        TestUtils::rcopy(TMP_DIR, dirname(__FILE__).'/data/');
 
         dbglog("\nset up class syntax_plugin_backlinks_test");
     }
@@ -52,12 +52,12 @@  discard block
 block discarded – undo
 
         $verbose = false;
         $force   = false;
-        foreach($data as $val) {
+        foreach ($data as $val) {
             idx_addPage($val['id'], $verbose, $force);
         }
 
-        if($conf['allowdebug']) {
-            touch(DOKU_TMP_DATA . 'cache/debug.log');
+        if ($conf['allowdebug']) {
+            touch(DOKU_TMP_DATA.'cache/debug.log');
         }
     }
 
@@ -66,10 +66,10 @@  discard block
 block discarded – undo
 
         global $conf;
         // try to get the debug log after running the test, print and clear
-        if($conf['allowdebug']) {
+        if ($conf['allowdebug']) {
             print "\n";
-            readfile(DOKU_TMP_DATA . 'cache/debug.log');
-            unlink(DOKU_TMP_DATA . 'cache/debug.log');
+            readfile(DOKU_TMP_DATA.'cache/debug.log');
+            unlink(DOKU_TMP_DATA.'cache/debug.log');
         }
     }
 

Please login to merge, or discard this patch.

_test/syntax_include.test.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
         global $conf;
         $conf['allowdebug'] = 1;
 
-        TestUtils::rcopy(TMP_DIR, dirname(__FILE__) . '/data/');
+        TestUtils::rcopy(TMP_DIR, dirname(__FILE__).'/data/');
 
         dbglog("\nset up class syntax_plugin_backlinks_test");
     }
@@ -52,12 +52,12 @@  discard block
 block discarded – undo
 
         $verbose = false;
         $force   = false;
-        foreach($data as $val) {
+        foreach ($data as $val) {
             idx_addPage($val['id'], $verbose, $force);
         }
 
-        if($conf['allowdebug']) {
-            touch(DOKU_TMP_DATA . 'cache/debug.log');
+        if ($conf['allowdebug']) {
+            touch(DOKU_TMP_DATA.'cache/debug.log');
         }
     }
 
@@ -66,10 +66,10 @@  discard block
 block discarded – undo
 
         global $conf;
         // try to get the debug log after running the test, print and clear
-        if($conf['allowdebug']) {
+        if ($conf['allowdebug']) {
             print "\n";
-            readfile(DOKU_TMP_DATA . 'cache/debug.log');
-            unlink(DOKU_TMP_DATA . 'cache/debug.log');
+            readfile(DOKU_TMP_DATA.'cache/debug.log');
+            unlink(DOKU_TMP_DATA.'cache/debug.log');
         }
     }
 

Please login to merge, or discard this patch.

		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33	global $conf;
34	34	$conf['allowdebug'] = 1;
35	35
36		- TestUtils::rcopy(TMP_DIR, dirname(__FILE__) . '/data/');
	36	+ TestUtils::rcopy(TMP_DIR, dirname(__FILE__).'/data/');
37	37
38	38	dbglog("\nset up class syntax_plugin_backlinks_test");
39	39	}
		@@ -52,14 +52,14 @@ discard block
		block discarded – undo
52	52
53	53	$verbose = false;
54	54	$force = false;
55		- foreach($data as $val) {
	55	+ foreach ($data as $val) {
56	56	idx_addPage($val['id'], $verbose, $force);
57	57	}
58	58	//idx_addPage('bob_ross_says', $verbose, $force);
59	59	//idx_addPage('link', $verbose, $force);
60	60	//idx_addPage('backlinks_syntax', $verbose, $force);
61		- if($conf['allowdebug']) {
62		- touch(DOKU_TMP_DATA . 'cache/debug.log');
	61	+ if ($conf['allowdebug']) {
	62	+ touch(DOKU_TMP_DATA.'cache/debug.log');
63	63	}
64	64	}
65	65
		@@ -68,10 +68,10 @@ discard block
		block discarded – undo
68	68
69	69	global $conf;
70	70	// try to get the debug log after running the test, print and clear
71		- if($conf['allowdebug']) {
	71	+ if ($conf['allowdebug']) {
72	72	print "\n";
73		- readfile(DOKU_TMP_DATA . 'cache/debug.log');
74		- unlink(DOKU_TMP_DATA . 'cache/debug.log');
	73	+ readfile(DOKU_TMP_DATA.'cache/debug.log');
	74	+ unlink(DOKU_TMP_DATA.'cache/debug.log');
75	75	}
76	76	}
77	77

		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	$match = substr($match, 12, -2);
64	64
65	65	$includeNS = '';
66		- if(strstr($match, "#")) {
	66	+ if (strstr($match, "#")) {
67	67	$includeNS = substr(strstr($match, "#", false), 1);
68	68	$match = strstr($match, "#", true);
69	69	}
		@@ -83,38 +83,38 @@ discard block
		block discarded – undo
83	83
84	84	$id = $ID;
85	85	// If it's a sidebar, get the original id.
86		- if($INFO != null) {
	86	+ if ($INFO != null) {
87	87	$id = $INFO['id'];
88	88	}
89	89	$match = $data[0];
90	90	$match = ($match == '.') ? $id : $match;
91		- if(strstr($match, ".:")) {
	91	+ if (strstr($match, ".:")) {
92	92	resolve_pageid(getNS($id), $match, $exists);
93	93	}
94	94
95		- if($mode == 'xhtml') {
	95	+ if ($mode == 'xhtml') {
96	96	$renderer->info['cache'] = false;
97	97
98	98	$backlinks = ft_backlinks($match);
99	99
100	100	dbglog($backlinks, "backlinks: all backlinks to: $match");
101	101
102		- $renderer->doc .= '<div id="plugin__backlinks">' . "\n";
	102	+ $renderer->doc .= '<div id="plugin__backlinks">'."\n";
103	103
104	104	$filterNS = $data[1];
105		- if(!empty($backlinks) && !empty($filterNS)) {
106		- if(stripos($filterNS, "!", 0) === 0) {
	105	+ if (!empty($backlinks) && !empty($filterNS)) {
	106	+ if (stripos($filterNS, "!", 0) === 0) {
107	107	$filterNS = substr($filterNS, 1);
108	108	dbglog($filterNS, "backlinks: exluding all of namespace: $filterNS");
109	109	$backlinks = array_filter(
110		- $backlinks, function ($ns) use ($filterNS) {
	110	+ $backlinks, function($ns) use ($filterNS) {
111	111	return stripos($ns, $filterNS, 0) !== 0;
112	112	}
113	113	);
114	114	} else {
115	115	dbglog($filterNS, "backlinks: including namespace: $filterNS only");
116	116	$backlinks = array_filter(
117		- $backlinks, function ($ns) use ($filterNS) {
	117	+ $backlinks, function($ns) use ($filterNS) {
118	118	return stripos($ns, $filterNS, 0) === 0;
119	119	}
120	120	);
		@@ -123,26 +123,26 @@ discard block
		block discarded – undo
123	123
124	124	dbglog($backlinks, "backlinks: all backlinks to be rendered");
125	125
126		- if(!empty($backlinks)) {
	126	+ if (!empty($backlinks)) {
127	127
128	128	$renderer->doc .= '<ul class="idx">';
129	129
130		- foreach($backlinks as $backlink) {
	130	+ foreach ($backlinks as $backlink) {
131	131	$name = p_get_metadata($backlink, 'title');
132		- if(empty($name)) {
	132	+ if (empty($name)) {
133	133	$name = $backlink;
134	134	}
135	135	$renderer->doc .= '<li><div class="li">';
136		- $renderer->doc .= html_wikilink(':' . $backlink, $name);
137		- $renderer->doc .= '</div></li>' . "\n";
	136	+ $renderer->doc .= html_wikilink(':'.$backlink, $name);
	137	+ $renderer->doc .= '</div></li>'."\n";
138	138	}
139	139
140		- $renderer->doc .= '</ul>' . "\n";
	140	+ $renderer->doc .= '</ul>'."\n";
141	141	} else {
142		- $renderer->doc .= "<strong>Plugin Backlinks: " . $lang['nothingfound'] . "</strong>" . "\n";
	142	+ $renderer->doc .= "<strong>Plugin Backlinks: ".$lang['nothingfound']."</strong>"."\n";
143	143	}
144	144
145		- $renderer->doc .= '</div>' . "\n";
	145	+ $renderer->doc .= '</div>'."\n";
146	146
147	147	return true;
148	148	}

		@@ -29,7 +29,7 @@
		block discarded – undo
29	29	* Simple test to make sure the plugin.info.txt is in correct format
30	30	*/
31	31	public function test_plugininfo(): void {
32		- $file = __DIR__ . '/../plugin.info.txt';
	32	+ $file = __DIR__.'/../plugin.info.txt';
33	33	$this->assertFileExists($file);
34	34
35	35	$info = confToHash($file);

mprins / dokuwiki-plugin-backlinks

Push — master ( c434e2...36ed08 )

Status

Category

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch