Completed
Pull Request — master (#102)
by Max
06:40
created
src/controllers/Controller.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
         $valid_company = false;
52 52
         if ($request->has('vat_number')) {
53 53
             $valid_company = $this->validateVATID($request->get('vat_number'));
54
-            $valid_company = $valid_company['is_valid'];
54
+            $valid_company = $valid_company[ 'is_valid' ];
55 55
             $valid_vat_id = $valid_company;
56 56
         }
57 57
 
Please login to merge, or discard this patch.
src/Mpociot/VatCalculator/Validators/VatCalculatorValidatorExtension.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Mpociot\VatCalculator\Validators;
4 4
 
5
-use Illuminate\Validation\Validator;
6 5
 use Mpociot\VatCalculator\Exceptions\VATCheckUnavailableException;
7 6
 use Mpociot\VatCalculator\Facades\VatCalculator;
8 7
 
Please login to merge, or discard this patch.
src/Mpociot/VatCalculator/VatCalculator.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -454,7 +454,7 @@  discard block
 block discarded – undo
454 454
     }
455 455
 
456 456
     /**
457
-     * @param mixed $countryCode
457
+     * @param string $countryCode
458 458
      */
459 459
     public function setCountryCode($countryCode)
460 460
     {
@@ -470,7 +470,7 @@  discard block
 block discarded – undo
470 470
     }
471 471
 
472 472
     /**
473
-     * @param mixed $postalCode
473
+     * @param string $postalCode
474 474
      */
475 475
     public function setPostalCode($postalCode)
476 476
     {
@@ -571,7 +571,7 @@  discard block
 block discarded – undo
571 571
     }
572 572
 
573 573
     /**
574
-     * @param $vatNumber
574
+     * @param string $vatNumber
575 575
      *
576 576
      * @throws VATCheckUnavailableException
577 577
      *
Please login to merge, or discard this patch.
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -402,10 +402,10 @@  discard block
 block discarded – undo
402 402
      */
403 403
     private function getClientIP()
404 404
     {
405
-        if (isset($_SERVER['HTTP_X_FORWARDED_FOR']) && $_SERVER['HTTP_X_FORWARDED_FOR']) {
406
-            $clientIpAddress = $_SERVER['HTTP_X_FORWARDED_FOR'];
407
-        } elseif (isset($_SERVER['REMOTE_ADDR']) && $_SERVER['REMOTE_ADDR']) {
408
-            $clientIpAddress = $_SERVER['REMOTE_ADDR'];
405
+        if (isset($_SERVER[ 'HTTP_X_FORWARDED_FOR' ]) && $_SERVER[ 'HTTP_X_FORWARDED_FOR' ]) {
406
+            $clientIpAddress = $_SERVER[ 'HTTP_X_FORWARDED_FOR' ];
407
+        } elseif (isset($_SERVER[ 'REMOTE_ADDR' ]) && $_SERVER[ 'REMOTE_ADDR' ]) {
408
+            $clientIpAddress = $_SERVER[ 'REMOTE_ADDR' ];
409 409
         } else {
410 410
             $clientIpAddress = '';
411 411
         }
@@ -425,11 +425,11 @@  discard block
 block discarded – undo
425 425
         $ip = $this->getClientIP();
426 426
         $url = self::GEOCODE_SERVICE_URL.$ip;
427 427
         $result = file_get_contents($url);
428
-        switch ($result[0]) {
428
+        switch ($result[ 0 ]) {
429 429
             case '1':
430 430
                 $data = explode(';', $result);
431 431
 
432
-                return $data[1];
432
+                return $data[ 1 ];
433 433
                 break;
434 434
             default:
435 435
                 return false;
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
447 447
     {
448 448
         $taxKey = 'vat_calculator.rules.'.strtoupper($countryCode);
449 449
 
450
-        return isset($this->taxRules[strtoupper($countryCode)]) || (isset($this->config) && $this->config->has($taxKey));
450
+        return isset($this->taxRules[ strtoupper($countryCode) ]) || (isset($this->config) && $this->config->has($taxKey));
451 451
     }
452 452
 
453 453
     /**
@@ -622,24 +622,24 @@  discard block
 block discarded – undo
622 622
             return $this->config->get($taxKey, 0);
623 623
         }
624 624
 
625
-        if (isset($this->postalCodeExceptions[$countryCode]) && $postalCode !== null) {
626
-            foreach ($this->postalCodeExceptions[$countryCode] as $postalCodeException) {
627
-                if (!preg_match($postalCodeException['postalCode'], $postalCode)) {
625
+        if (isset($this->postalCodeExceptions[ $countryCode ]) && $postalCode !== null) {
626
+            foreach ($this->postalCodeExceptions[ $countryCode ] as $postalCodeException) {
627
+                if (!preg_match($postalCodeException[ 'postalCode' ], $postalCode)) {
628 628
                     continue;
629 629
                 }
630
-                if (isset($postalCodeException['name'])) {
631
-                    return $this->taxRules[$postalCodeException['code']]['exceptions'][$postalCodeException['name']];
630
+                if (isset($postalCodeException[ 'name' ])) {
631
+                    return $this->taxRules[ $postalCodeException[ 'code' ] ][ 'exceptions' ][ $postalCodeException[ 'name' ] ];
632 632
                 }
633 633
 
634
-                return $this->taxRules[$postalCodeException['code']]['rate'];
634
+                return $this->taxRules[ $postalCodeException[ 'code' ] ][ 'rate' ];
635 635
             }
636 636
         }
637 637
 
638 638
         if ($type !== null) {
639
-            return isset($this->taxRules[strtoupper($countryCode)]['rates'][$type]) ? $this->taxRules[strtoupper($countryCode)]['rates'][$type] : 0;
639
+            return isset($this->taxRules[ strtoupper($countryCode) ][ 'rates' ][ $type ]) ? $this->taxRules[ strtoupper($countryCode) ][ 'rates' ][ $type ] : 0;
640 640
         }
641 641
 
642
-        return isset($this->taxRules[strtoupper($countryCode)]['rate']) ? $this->taxRules[strtoupper($countryCode)]['rate'] : 0;
642
+        return isset($this->taxRules[ strtoupper($countryCode) ][ 'rate' ]) ? $this->taxRules[ strtoupper($countryCode) ][ 'rate' ] : 0;
643 643
     }
644 644
 
645 645
     /**
@@ -677,7 +677,7 @@  discard block
 block discarded – undo
677 677
      */
678 678
     public function getVATDetails($vatNumber)
679 679
     {
680
-        $vatNumber = str_replace([' ', "\xC2\xA0", "\xA0", '-', '.', ','], '', trim($vatNumber));
680
+        $vatNumber = str_replace([ ' ', "\xC2\xA0", "\xA0", '-', '.', ',' ], '', trim($vatNumber));
681 681
         $countryCode = substr($vatNumber, 0, 2);
682 682
         $vatNumber = substr($vatNumber, 2);
683 683
         $this->initSoapClient();
Please login to merge, or discard this patch.
src/Mpociot/VatCalculator/VatCalculatorServiceProvider.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
  * @package Teamwork
10 10
  */
11 11
 
12
-use Illuminate\Support\Facades\Validator;
13 12
 use Illuminate\Support\ServiceProvider;
14 13
 use Mpociot\VatCalculator\Facades\VatCalculator;
15 14
 
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
     {
72 72
         $this->app->bind('vatcalculator', \Mpociot\VatCalculator\VatCalculator::class);
73 73
 
74
-        $this->app->bind(\Mpociot\VatCalculator\VatCalculator::class, function ($app) {
74
+        $this->app->bind(\Mpociot\VatCalculator\VatCalculator::class, function($app) {
75 75
             $config = $app->make('Illuminate\Contracts\Config\Repository');
76 76
 
77 77
             return new \Mpociot\VatCalculator\VatCalculator($config);
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
      */
86 86
     public function registerFacade()
87 87
     {
88
-        $this->app->booting(function () {
88
+        $this->app->booting(function() {
89 89
             $loader = \Illuminate\Foundation\AliasLoader::getInstance();
90 90
             $loader->alias('VatCalculator', 'Mpociot\VatCalculator\Facades\VatCalculator');
91 91
         });
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
             'vatnumber-validator'
111 111
         );
112 112
 
113
-        $this->app['validator']->extend('vat_number',
113
+        $this->app[ 'validator' ]->extend('vat_number',
114 114
             'Mpociot\VatCalculator\Validators\VatCalculatorValidatorExtension@validateVatNumber');
115 115
     }
116 116
 
Please login to merge, or discard this patch.