Mostafaznv\Larupload\Concerns\Storage\Attachment\QueueAttachment::initializeFFMpegQueue()

Complexity

Conditions	6
Paths	15

Size

Total Lines	49
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function initializeFFMpegQueue(int $id, string $class, bool $standalone = false): void
    {
        $maxQueueNum = $this->ffmpegMaxQueueNum;
        $flag = false;

        if ($maxQueueNum == 0) {
            $flag = true;
        }
        else {
            $availableQueues = DB::table(Larupload::FFMPEG_QUEUE_TABLE)
                ->where('status', 0)
                ->count();

            if ($availableQueues < $maxQueueNum) {
                $flag = true;
            }
        }


        if ($flag) {
            // save a copy of original file to use it on process ffmpeg queue, then delete it
            if ($this->driverIsNotLocal()) {
                $path = $this->getBasePath($id, Larupload::ORIGINAL_FOLDER);

It seems like getBasePath() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                Storage::disk($this->localDisk)->putFileAs($path, $this->file, $this->output['name']);
            }

            $queueId = DB::table(Larupload::FFMPEG_QUEUE_TABLE)->insertGetId([
                'record_id'    => $id,
                'record_class' => $class,
                'created_at'   => now(),
            ]);

            $serializedClass = null;

            if ($standalone) {
                unset($this->file);
                unset($this->cover);
                unset($this->image);
                unset($this->ffmpeg);

                $serializedClass = base64_encode(serialize($this));
            }


            ProcessFFMpeg::dispatch($queueId, $id, $this->name, $class, $serializedClass);
        }
        else {
            throw new HttpResponseException(redirect(URL::previous())->withErrors([

It seems like redirect(Illuminate\Support\Facades\URL::previous())->withErrors(array('ffmpeg_queue_max_num' => trans('larupload::messages.max-queue-num-exceeded'))) can also be of type Illuminate\Routing\Redirector; however, parameter $response of Illuminate\Http\Exceptions\HttpResponseException::__construct() does only seem to accept Symfony\Component\HttpFoundation\Response, maybe add an additional type check?

                'ffmpeg_queue_max_num' => trans('larupload::messages.max-queue-num-exceeded')
            ]));