Mostafaznv\Larupload\Concerns\Storage\Attachment\QueueAttachment

Complexity

Total Complexity

12

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	handleFFMpegQueue()	0	10	4
A	prepareFileForFFMpegProcess()	0	9	2
B	initializeFFMpegQueue()	0	49	6

<?php

namespace Mostafaznv\Larupload\Concerns\Storage\Attachment;


use Illuminate\Http\Exceptions\HttpResponseException;
use Illuminate\Http\UploadedFile;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Storage;
use Illuminate\Support\Facades\URL;
use Mostafaznv\Larupload\Actions\GuessLaruploadFileTypeAction;
use Mostafaznv\Larupload\Jobs\ProcessFFMpeg;
use Mostafaznv\Larupload\Larupload;

trait QueueAttachment
{
    /**
     * Handle FFMpeg queue on running ffmpeg queue:work
     */
    public function handleFFMpegQueue(bool $isLastOne = false, bool $standalone = false): void
    {
        $this->file = $this->prepareFileForFFMpegProcess();

The property file does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->type = GuessLaruploadFileTypeAction::make($this->file)->calc();

The property type does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->handleVideoStyles($this->id);

It seems like handleVideoStyles() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($this->driverIsNotLocal() and $isLastOne) {

It seems like driverIsNotLocal() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            Storage::disk($this->localDisk)->deleteDirectory(
                $standalone ? "$this->name" : "$this->folder/$this->id"
            );
        }
    }

    protected function initializeFFMpegQueue(int $id, string $class, bool $standalone = false): void
    {
        $maxQueueNum = $this->ffmpegMaxQueueNum;
        $flag = false;

        if ($maxQueueNum == 0) {
            $flag = true;
        }
        else {
            $availableQueues = DB::table(Larupload::FFMPEG_QUEUE_TABLE)
                ->where('status', 0)
                ->count();

            if ($availableQueues < $maxQueueNum) {
                $flag = true;
            }
        }


        if ($flag) {
            // save a copy of original file to use it on process ffmpeg queue, then delete it
            if ($this->driverIsNotLocal()) {
                $path = $this->getBasePath($id, Larupload::ORIGINAL_FOLDER);

It seems like getBasePath() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                Storage::disk($this->localDisk)->putFileAs($path, $this->file, $this->output['name']);
            }

            $queueId = DB::table(Larupload::FFMPEG_QUEUE_TABLE)->insertGetId([
                'record_id'    => $id,
                'record_class' => $class,
                'created_at'   => now(),
            ]);

            $serializedClass = null;

            if ($standalone) {
                unset($this->file);
                unset($this->cover);
                unset($this->image);
                unset($this->ffmpeg);

                $serializedClass = base64_encode(serialize($this));
            }


            ProcessFFMpeg::dispatch($queueId, $id, $this->name, $class, $serializedClass);
        }
        else {
            throw new HttpResponseException(redirect(URL::previous())->withErrors([

It seems like redirect(Illuminate\Support\Facades\URL::previous())->withErrors(array('ffmpeg_queue_max_num' => trans('larupload::messages.max-queue-num-exceeded'))) can also be of type Illuminate\Routing\Redirector; however, parameter $response of Illuminate\Http\Exceptions\HttpResponseException::__construct() does only seem to accept Symfony\Component\HttpFoundation\Response, maybe add an additional type check?

                'ffmpeg_queue_max_num' => trans('larupload::messages.max-queue-num-exceeded')
            ]));
        }
    }

    private function prepareFileForFFMpegProcess(): UploadedFile
    {
        $basePath = $this->getBasePath($this->id, Larupload::ORIGINAL_FOLDER);
        $path = $basePath . '/' . $this->output['name'];
        $disk = $this->driverIsLocal() ? $this->disk : $this->localDisk;

It seems like driverIsLocal() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $path = Storage::disk($disk)->path($path);

        return new UploadedFile($path, $this->output['name'], null, null, true);
    }
}