marvin_general_actions

Complexity

Total Complexity

11

Size/Duplication

Total Lines	76
Duplicated Lines	23.68 %

Test Coverage

Coverage

58.06%

Importance

Changes

0

3 Functions

Rating	Name	Duplication	Size	Complexity
A	getAllGeneralActions()	0	6	1
B	getString()	18	18	6
A	marvinMorning()	0	29	4

#! /usr/bin/env python3
# -*- coding: utf-8 -*-

"""
Make general actions for Marvin, one function for each action.
"""
import datetime
import json
import random

# Load all strings from file
with open("marvin_strings.json", encoding="utf-8") as f:
    STRINGS = json.load(f)

lastDateGreeted = None


def getString(key, key1=None):

This code seems to be duplicated in your project.

    """
    Get a string from the string database.
    """
    data = STRINGS[key]
    if isinstance(data, list):
        res = data[random.randint(0, len(data) - 1)]
    elif isinstance(data, dict):
        if key1 is None:
            res = data
        else:
            res = data[key1]
            if isinstance(res, list):
                res = res[random.randint(0, len(res) - 1)]
    elif isinstance(data, str):
        res = data

    return res

The variable res does not seem to be defined for all execution paths.

def getAllGeneralActions():
    """
    Return all general actions as an array.
    """
    return [
        marvinMorning
    ]


def marvinMorning(row):
    """
    Marvin says Good morning after someone else says it
    """
    msg = None
    phrases = [
        "morgon",
        "godmorgon",
        "god morgon",
        "morrn",
        "morn"
    ]

    morning_phrases = [
        "Godmorgon! :-)",
        "Morgon allesammans",
        "Morgon gott folk",
        "Guten morgen",
        "Morgon"
    ]

    global lastDateGreeted

    for phrase in phrases:
        if phrase in row:
            if lastDateGreeted != datetime.date.today():
                lastDateGreeted = datetime.date.today()
                msg = random.choice(morning_phrases)
    return msg