marvin_general_actions.getString() - Code Metrics - Inspection of "Add missing test for Commit action" - mosbth/irc2phpbb - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 4510b5...1b94f8 )

by Mikael

created 2024-10-15 07:58 UTC

marvin_general_actions.getString() B

↳ Parent: marvin_general_actions

Complexity

Conditions

Size

Total Lines	18
Code Lines	13

Duplication

Lines	18
Ratio	100 %

Code Coverage

Tests	1
CRAP Score	34.317

Importance

Changes

Metric	Value
cc	6
eloc	13
nop	2
dl	18
loc	18
ccs	1
cts	13
cp	0.0769
crap	34.317
rs	8.6666
c	0
b	0
f	0

#! /usr/bin/env python3
# -*- coding: utf-8 -*-

"""
Make general actions for Marvin, one function for each action.
"""
import datetime
import json
import random

# Load all strings from file
with open("marvin_strings.json", encoding="utf-8") as f:
    STRINGS = json.load(f)

lastDateGreeted = None


def getString(key, key1=None):

    """
    Get a string from the string database.
    """
    data = STRINGS[key]
    if isinstance(data, list):
        res = data[random.randint(0, len(data) - 1)]
    elif isinstance(data, dict):
        if key1 is None:
            res = data
        else:
            res = data[key1]
            if isinstance(res, list):
                res = res[random.randint(0, len(res) - 1)]
    elif isinstance(data, str):
        res = data

    return res



def getAllGeneralActions():
    """
    Return all general actions as an array.
    """
    return [
        marvinMorning
    ]


def marvinMorning(row):
    """
    Marvin says Good morning after someone else says it
    """
    msg = None
    phrases = [
        "morgon",
        "godmorgon",
        "god morgon",
        "morrn",
        "morn"
    ]

    morning_phrases = [
        "Godmorgon! :-)",
        "Morgon allesammans",
        "Morgon gott folk",
        "Guten morgen",
        "Morgon"
    ]

    global lastDateGreeted

    for phrase in phrases:
        if phrase in row:
            if lastDateGreeted != datetime.date.today():
                lastDateGreeted = datetime.date.today()
                msg = random.choice(morning_phrases)
    return msg


1			#! /usr/bin/env python3
2			# -- coding: utf-8 --
3
4			"""
5			Make general actions for Marvin, one function for each action.
6			"""
7	1		import datetime
8	1		import json
9	1		import random
10
11			# Load all strings from file
12	1		with open("marvin_strings.json", encoding="utf-8") as f:
13	1		STRINGS = json.load(f)
14
15	1		lastDateGreeted = None
16
17
18	1	View Code Duplication	def getString(key, key1=None):
			0 ignored issues – show Duplication introduced 2024-10-03 21:47 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
19			"""
20			Get a string from the string database.
21			"""
22			data = STRINGS[key]
23			if isinstance(data, list):
24			res = data[random.randint(0, len(data) - 1)]
25			elif isinstance(data, dict):
26			if key1 is None:
27			res = data
28			else:
29			res = data[key1]
30			if isinstance(res, list):
31			res = res[random.randint(0, len(res) - 1)]
32			elif isinstance(data, str):
33			res = data
34
35			return res
			0 ignored issues – show introduced 2024-10-03 21:47 UTC by Report Bug Copy Issue Report The variable `res` does not seem to be defined for all execution paths. Loading history...
36
37
38	1		def getAllGeneralActions():
39			"""
40			Return all general actions as an array.
41			"""
42			return [
43			marvinMorning
44			]
45
46
47	1		def marvinMorning(row):
48			"""
49			Marvin says Good morning after someone else says it
50			"""
51	1		msg = None
52	1		phrases = [
53			"morgon",
54			"godmorgon",
55			"god morgon",
56			"morrn",
57			"morn"
58			]
59
60	1		morning_phrases = [
61			"Godmorgon! :-)",
62			"Morgon allesammans",
63			"Morgon gott folk",
64			"Guten morgen",
65			"Morgon"
66			]
67
68			global lastDateGreeted
69
70	1		for phrase in phrases:
71	1		if phrase in row:
72	1		if lastDateGreeted != datetime.date.today():
73	1		lastDateGreeted = datetime.date.today()
74	1		msg = random.choice(morning_phrases)
75			return msg
76

mosbth / irc2phpbb

Push — master ( 4510b5...1b94f8 )

marvin_general_actions.getString() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like