morphatic / laravel-auto-deploy

src/AutoDeployServiceProvider.php

Spacing +2 added lines, -2 removed lines

@@ -36,11 +36,11 @@
 
     private function registerDeployCommands()
     {
-        $this->app->singleton('command.morphatic.deployinit', function ($app) {
+        $this->app->singleton('command.morphatic.deployinit', function($app) {
             return $app['Morphatic\AutoDeploy\Commands\DeployInitCommand'];
         });
 
-        $this->app->singleton('command.morphatic.deployinfo', function ($app) {
+        $this->app->singleton('command.morphatic.deployinfo', function($app) {
             return $app['Morphatic\AutoDeploy\Commands\DeployInfoCommand'];
         });
 

src/Middleware/VerifyDeployRequest.php

Doc Comments -1 removed lines

@@ -45,7 +45,6 @@
     /**
      * Determine the origin of a deploy request.
      *
-     * @param Illuminate\Http\Request $request The Request object.
      *
      * @return \Morphatic\AutoDeploy\Origins\OriginInterface An object corresponding to the origin type or null.
      */

src/Origins/Github.php

Doc Comments +1 added lines, -6 removed lines

@@ -14,7 +14,6 @@ 
     /**
      * Determines whether or not the Request originated from Github.
      *
-     * @param Illuminate\Http\Request $this->request The Request object
      *
      * @return bool Returns true if the request originated from Github. False otherwise.
      */
@@ -36,9 +35,8 @@ 
      *
      * Follows the procedure described here: https://developer.github.com/webhooks/securing/
      *
-     * @param Illuminate\Http\Request $this->request The Request object
      *
-     * @return bool Returns true if the request is authentic. False otherwise.
+     * @return null|boolean Returns true if the request is authentic. False otherwise.
      */
     public function verify()
     {
@@ -55,7 +53,6 @@ 
     /**
      * Gets the event the triggered the webhook request.
      *
-     * @param Illuminate\Http\Request $this->request The Request object
      *
      * @return string The name of the event, e.g. push, release, create, etc.
      */
@@ -67,7 +64,6 @@ 
     /**
      * Gets the URL to be cloned from.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The URL of the repo.
      */
@@ -79,7 +75,6 @@ 
     /**
      * Gets the ID of the commit that is to be cloned.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The commit ID.
      */

src/Origins/OriginInterface.php

Doc Comments -5 removed lines

@@ -7,7 +7,6 @@ 
     /**
      * Determines whether or not the Request originated from the webhook origin.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return bool Returns true if the request originated from this origin. False otherwise.
      */
@@ -16,7 +15,6 @@ 
     /**
      * Verifies the authenticity of a webhook request from the origin.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return bool Returns true if the request is authentic. False otherwise.
      */
@@ -25,7 +23,6 @@ 
     /**
      * Gets the event the triggered the webhook request.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The name of the event, e.g. push, release, create, etc.
      */
@@ -34,7 +31,6 @@ 
     /**
      * Gets the URL to be cloned from.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The URL of the repo.
      */
@@ -43,7 +39,6 @@ 
     /**
      * Gets the ID of the commit that is to be cloned.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The commit ID.
      */

src/Controllers/DeployController.php

Doc Comments +3 added lines, -3 removed lines

@@ -75,8 +75,8 @@ 
     /**
      * Create a new DeployController instance.
      *
-     * @param Morphatic\AutoDeploy\Origins\OriginInterface $origin The origin of the webhook
-     * @param AdamBrett\ShellWrapper\Runners\Exec          $exec   The shell command execution class
+     * @param OriginInterface $origin The origin of the webhook
+     * @param Exec          $exec   The shell command execution class
      */
     public function __construct(OriginInterface $origin, Exec $exec)
     {
@@ -131,7 +131,7 @@ 
     /**
      * Runs a shell command, logs, and handles the result.
      *
-     * @param AdamBrett\ShellWrapper\CommandInterface $cmd The text of the command to be run
+     * @param CommandInterface $cmd The text of the command to be run
      *
      * @return bool True if the command was successful, false on error
      */

Unused Use Statements +4 added lines, -5 removed lines

@@ -2,16 +2,15 @@
 
 namespace Morphatic\AutoDeploy\Controllers;
 
-use Log;
-use Mail;
-use Monolog\Logger;
-use Illuminate\Http\Request;
-use Illuminate\Routing\Controller;
 use AdamBrett\ShellWrapper\Command\Builder as Command;
 use AdamBrett\ShellWrapper\Command\CommandInterface;
 use AdamBrett\ShellWrapper\Runners\Exec;
+use Illuminate\Routing\Controller;
+use Log;
+use Mail;
 use Monolog\Formatter\HtmlFormatter;
 use Monolog\Handler\SwiftMailerHandler;
+use Monolog\Logger;
 use Morphatic\AutoDeploy\Origins\OriginInterface;
 
 class DeployController extends Controller

Spacing +1 added lines, -1 removed lines

@@ -117,7 +117,7 @@
             'Timestamp' => date('r'),
             'output' => '',
         ];
-        $whitelist = ['backupDatabase','pull','composer','npm','migrate','seed','deploy'];
+        $whitelist = ['backupDatabase', 'pull', 'composer', 'npm', 'migrate', 'seed', 'deploy'];
         foreach ($steps as $step) {
             if (in_array($step, $whitelist) && !$this->{$step}()) {
                 $this->log->error('Deploy failed.', $this->result);

src/Origins/AbstractOrigin.php

Doc Comments -5 removed lines

@@ -7,7 +7,6 @@ 
     /**
      * Determines whether or not the Request originated from the webhook origin.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return bool Returns true if the request originated from this origin. False otherwise.
      */
@@ -16,7 +15,6 @@ 
     /**
      * Verifies the authenticity of a webhook request from the origin.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return bool Returns true if the request is authentic. False otherwise.
      */
@@ -25,7 +23,6 @@ 
     /**
      * Gets the event the triggered the webhook request.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The name of the event, e.g. push, release, create, etc.
      */
@@ -34,7 +31,6 @@ 
     /**
      * Gets the URL to be cloned from.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The URL of the repo.
      */
@@ -43,7 +39,6 @@ 
     /**
      * Gets the ID of the commit that is to be cloned.
      *
-     * @param Illuminate\Http\Request $request The Request object
      *
      * @return string The commit ID.
      */

src/Commands/DeployInitCommand.php

Indentation +3 added lines, -3 removed lines

@@ -32,9 +32,9 @@
         $path = base_path('.env');
         $url = parse_url(config('app.url'), PHP_URL_HOST);
         $msg = "Here is the information you'll need to set up your webhooks:\n\n".
-               "  Payload URL: <comment>https://$url/%s</comment>\n".
-               "  Secret Key:  <comment>%s</comment>\n\n".
-               "You can display this information again by running `php artisan deploy:info`\n";
+                "  Payload URL: <comment>https://$url/%s</comment>\n".
+                "  Secret Key:  <comment>%s</comment>\n\n".
+                "You can display this information again by running `php artisan deploy:info`\n";
         $conf = 'Are you sure you want to overwrite the existing keys?';
         $show = $this->option('show');
         $over = $this->option('force');