MonsieurBizSyliusSalesReportsPlugin::getContainerExtension()

Complexity

Conditions	5
Paths	4

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getContainerExtension(): ?ExtensionInterface
    {
        if (null === $this->containerExtension) {
            $extension = $this->createContainerExtension();

            if (null !== $extension) {
                if (!$extension instanceof ExtensionInterface) {

$extension is always a sub-type of Symfony\Component\DependencyInjection\Extension\ExtensionInterface.

                    throw new \LogicException(sprintf('Extension %s must implement %s.', get_class($extension), ExtensionInterface::class));
                }
                $this->containerExtension = $extension;
            } else {
                $this->containerExtension = false;
            }
        }
        return $this->containerExtension ?: null;

The expression return $this->containerExtension ?: null could return the type true which is incompatible with the type-hinted return Symfony\Component\DependencyInjection\Extension\ExtensionInterface|null. Consider adding an additional type-check to rule them out.

    }