MonsieurBiz\SyliusSalesReportsPlugin\MonsieurBizSyliusSalesReportsPlugin

Complexity

Total Complexity

5

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getContainerExtension()	0	15	5

<?php

declare(strict_types=1);

namespace MonsieurBiz\SyliusSalesReportsPlugin;

use Sylius\Bundle\CoreBundle\Application\SyliusPluginTrait;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\HttpKernel\Bundle\Bundle;

final class MonsieurBizSyliusSalesReportsPlugin extends Bundle
{
    use SyliusPluginTrait;

    /**
     * Returns the plugin's container extension.
     *
     * @return ExtensionInterface|null The container extension
     *
     * @throws \LogicException
     */
    public function getContainerExtension(): ?ExtensionInterface
    {
        if (null === $this->containerExtension) {
            $extension = $this->createContainerExtension();

            if (null !== $extension) {
                if (!$extension instanceof ExtensionInterface) {

$extension is always a sub-type of Symfony\Component\DependencyInjection\Extension\ExtensionInterface.

                    throw new \LogicException(sprintf('Extension %s must implement %s.', get_class($extension), ExtensionInterface::class));
                }
                $this->containerExtension = $extension;
            } else {
                $this->containerExtension = false;
            }
        }
        return $this->containerExtension ?: null;

The expression return $this->containerExtension ?: null could return the type true which is incompatible with the type-hinted return Symfony\Component\DependencyInjection\Extension\ExtensionInterface|null. Consider adding an additional type-check to rule them out.

    }
}