Test Setup Failed
Pull Request — master (#456)
by Mohamed
06:04
created
app/Http/Controllers/ExaminationStudentsController.php 1 patch
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
         $this->grade = $grade;
31 31
         $this->student = new Security_user();
32 32
         $this->examination_student = new Examination_student();
33
-        $this->academic_period =  Academic_period::where('code', '=', $this->year)->first();
33
+        $this->academic_period = Academic_period::where('code', '=', $this->year)->first();
34 34
         $this->education_grade = Education_grade::where('code', '=', $this->grade)->first();
35 35
         $this->output = new \Symfony\Component\Console\Output\ConsoleOutput();
36 36
     }
@@ -72,10 +72,10 @@  discard block
 block discarded – undo
72 72
                     );
73 73
                     Session::flash('message', 'File upload successfully!');
74 74
                     // Redirect to index
75
-                } else {
75
+                }else {
76 76
                     Session::flash('message', 'File too large. File must be less than 20MB.');
77 77
                 }
78
-            } else {
78
+            }else {
79 79
                 Session::flash('message', 'Invalid File Extension.');
80 80
             }
81 81
         }
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
             $import->import($excelFile, 'local', \Maatwebsite\Excel\Excel::CSV);
98 98
             if ($import->failures()->count() > 0) {
99 99
                 $errors = $import->failures();
100
-                $columns =  [
100
+                $columns = [
101 101
                     'remarks',
102 102
                     'st_no',
103 103
                     'stu_no',
@@ -118,10 +118,10 @@  discard block
 block discarded – undo
118 118
                 Storage::put($file, implode(',', $columns));
119 119
 
120 120
                 foreach ($errors as $error) {
121
-                    Storage::append($file, implode(':', $error->errors()) . ',' . implode(',', $error->values()));
121
+                    Storage::append($file, implode(':', $error->errors()).','.implode(',', $error->values()));
122 122
                 }
123 123
             }
124
-        } catch (\Maatwebsite\Excel\Validators\ValidationException $e) {
124
+        }catch (\Maatwebsite\Excel\Validators\ValidationException $e) {
125 125
         }
126 126
     }
127 127
 
@@ -135,9 +135,9 @@  discard block
 block discarded – undo
135 135
         $students = [];
136 136
         switch ($mode) {
137 137
             case 'duplicate':
138
-                $students =  DB::table('examination_students as es')
138
+                $students = DB::table('examination_students as es')
139 139
                     ->select(DB::raw('count(*) as total'), 'e2.*')
140
-                    ->join('examination_students as e2', 'es.nsid','e2.nsid')
140
+                    ->join('examination_students as e2', 'es.nsid', 'e2.nsid')
141 141
                     ->having('total', '>', 1)
142 142
                     ->groupBy('e2.st_no')
143 143
                     ->orderBy('e2.st_no')
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
                     ->limit($limit)
146 146
                     ->get()->toArray();
147 147
                 $students = (array) json_decode(json_encode($students));
148
-                $this->output->writeln(count($students) . 'students remaining duplicate');
148
+                $this->output->writeln(count($students).'students remaining duplicate');
149 149
                 array_walk($students, array($this, 'clone'));
150 150
                 $this->output->writeln('All are generated');
151 151
                 break;
@@ -156,24 +156,24 @@  discard block
 block discarded – undo
156 156
                     ->limit($limit)
157 157
                     ->get()->toArray();
158 158
                 $students = (array) json_decode(json_encode($students));
159
-                $this->output->writeln(count($students) . 'students remaining empty');
159
+                $this->output->writeln(count($students).'students remaining empty');
160 160
                 array_walk($students, array($this, 'clone'));
161 161
                 $this->output->writeln('All are generated');
162 162
                 break;
163 163
             case 'count':
164 164
                 $count = Examination_student::select('nsid')
165
-                ->where('nsid','!=',)
165
+                ->where('nsid', '!=',)
166 166
                 ->groupeBy('nsid')
167 167
                 ->count();
168 168
                 $all = Examination_student::select('nsid')
169 169
                     ->count();
170
-                $this->output->writeln( $all. 'Total Unique nsid are: ' .$count);
170
+                $this->output->writeln($all.'Total Unique nsid are: '.$count);
171 171
             default:
172 172
                 $students = Examination_student::offset($offset)
173 173
                     ->limit($limit)
174 174
                     ->get()->toArray();
175 175
                 $students = (array) json_decode(json_encode($students));
176
-                $this->output->writeln(count($students) . 'students remaining empty');
176
+                $this->output->writeln(count($students).'students remaining empty');
177 177
                 array_walk($students, array($this, 'clone'));
178 178
                 $this->output->writeln('All are generated');
179 179
         }
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
      */
220 220
     public function clone($student)
221 221
     {
222
-        $student = (array)json_decode(json_encode($student));
222
+        $student = (array) json_decode(json_encode($student));
223 223
         //get student matching with same dob and gender
224 224
 
225 225
         $matchedStudent = $this->getMatchingStudents($student);
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
 
253 253
                 //TODO implement insert student to admission table
254 254
                 $student['id'] = $sis_student['id'];
255
-                $sis_student['student_id'] =  $student['id'];
255
+                $sis_student['student_id'] = $student['id'];
256 256
 
257 257
                 $student = $this->setIsTakingExam($student);
258 258
                 if (count($institutionClass) == 1) {
@@ -260,13 +260,13 @@  discard block
 block discarded – undo
260 260
                     Institution_student::createExaminationData($student, $admissionInfo);
261 261
                     Institution_student_admission::createExaminationData($student, $admissionInfo);
262 262
                     Institution_class_student::createExaminationData($student, $admissionInfo);
263
-                } else {
263
+                }else {
264 264
                     Institution_student_admission::createExaminationData($student, $admissionInfo);
265 265
                     Institution_student::createExaminationData($student, $admissionInfo);
266 266
                 }
267 267
                 $this->updateStudentId($student, $sis_student);
268 268
                 // update the matched student's data    
269
-            } else {
269
+            }else {
270 270
                 $student = $this->setIsTakingExam($student);
271 271
                 $studentData = $this->student->updateExaminationStudent($student, $matchedStudent);
272 272
                 $matchedStudent = array_merge((array) $student, $matchedStudent);
@@ -274,9 +274,9 @@  discard block
 block discarded – undo
274 274
                 Institution_student::updateExaminationData($studentData, $admissionInfo);
275 275
                 $this->updateStudentId($student, $studentData);
276 276
             }
277
-        } else {
277
+        }else {
278 278
 
279
-            $this->output->writeln('Student ' . $student['st_no'] . ' not imorted' . $student['f_name']);
279
+            $this->output->writeln('Student '.$student['st_no'].' not imorted'.$student['f_name']);
280 280
         }
281 281
     }
282 282
 
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
         $count = $this->student->getStudentCount($student);
295 295
 
296 296
         $studentData = [];
297
-        $sis_users  = (array) json_decode(json_encode($sis_student), true);
297
+        $sis_users = (array) json_decode(json_encode($sis_student), true);
298 298
         // if the same gender same DOE has more than one 
299 299
         $studentData = $this->searchSimilarName($student, $sis_users);
300 300
         return $studentData;
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
     public function updateStudentId($student, $sis_student)
351 351
     {
352 352
         try {
353
-            $student['nsid'] =  $sis_student['openemis_no'];
353
+            $student['nsid'] = $sis_student['openemis_no'];
354 354
             // add new NSID to the examinations data set
355 355
             unset($student['id']);
356 356
             unset($student['taking_g5_exam']);
@@ -359,8 +359,8 @@  discard block
 block discarded – undo
359 359
             unset($student['total']);
360 360
             $this->examination_student->where('st_no', $student['st_no'])->update($student);
361 361
             unset($student['st_no']);
362
-            $this->output->writeln('Updated  to NSID' . $sis_student['openemis_no']);
363
-        } catch (\Exception $th) {
362
+            $this->output->writeln('Updated  to NSID'.$sis_student['openemis_no']);
363
+        }catch (\Exception $th) {
364 364
             dd($th);
365 365
             $this->output->writeln('error');
366 366
             Log::error($th);
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
         try {
379 379
             (new ExaminationStudentsExport)->store('examination/student_data_with_nsid.csv');
380 380
             (new ExportReady($adminUser));
381
-        } catch (\Throwable $th) {
381
+        }catch (\Throwable $th) {
382 382
             //throw $th;
383 383
             dd($th);
384 384
         }
@@ -388,13 +388,13 @@  discard block
 block discarded – undo
388 388
     public function downloadErrors()
389 389
     {
390 390
 
391
-        $file_path = storage_path() . '/app/examination/errors.csv';
391
+        $file_path = storage_path().'/app/examination/errors.csv';
392 392
         return Response::download($file_path);
393 393
     }
394 394
 
395 395
     public function downloadProcessedFile()
396 396
     {
397
-        $file_path = storage_path() . '/app/examination/student_data_with_nsid.csv';
397
+        $file_path = storage_path().'/app/examination/student_data_with_nsid.csv';
398 398
         return Response::download($file_path);
399 399
     }
400 400
 }
Please login to merge, or discard this patch.
app/Console/Commands/ExaminationCheck.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
             ->orWhere('nsid', '!=', '')
45 45
             ->get()->toArray();
46 46
         $students = array_chunk($students, 10000);
47
-        $this->output->writeln(count($students) . 'entries found');
47
+        $this->output->writeln(count($students).'entries found');
48 48
         array_walk($students, array($this, 'process'));
49 49
         $this->output->writeln('All are cleaned');
50 50
     }
@@ -57,10 +57,10 @@  discard block
 block discarded – undo
57 57
 
58 58
     public function deleteDuplication($students)
59 59
     {
60
-        $count =  Examination_student::where('nsid', $students['nsid'])->count();
60
+        $count = Examination_student::where('nsid', $students['nsid'])->count();
61 61
         if ($count > 1) {
62 62
             Examination_student::where('st_no', $students['st_no'])->update(['nsid' => '']);
63
-            $this->output->writeln($students['st_no'] . 'removed');
63
+            $this->output->writeln($students['st_no'].'removed');
64 64
         }
65 65
     }
66 66
 }
Please login to merge, or discard this patch.