moe-lk / bulk-upload

app/Http/Controllers/ExaminationStudentsController.php

Spacing +20 added lines, -20 removed lines

@@ -30,7 +30,7 @@ 
         $this->grade = $grade;
         $this->student = new Security_user();
         $this->examination_student = new Examination_student();
-        $this->academic_period =  Academic_period::where('code', '=', $this->year)->first();
+        $this->academic_period = Academic_period::where('code', '=', $this->year)->first();
         $this->education_grade = Education_grade::where('code', '=', $this->grade)->first();
         $this->output = new \Symfony\Component\Console\Output\ConsoleOutput();
     }
@@ -72,10 +72,10 @@ 
                     );
                     Session::flash('message', 'File upload successfully!');
                     // Redirect to index
-                } else {
+                }else {
                     Session::flash('message', 'File too large. File must be less than 20MB.');
                 }
-            } else {
+            }else {
                 Session::flash('message', 'Invalid File Extension.');
             }
         }
@@ -97,7 +97,7 @@ 
             $import->import($excelFile, 'local', \Maatwebsite\Excel\Excel::CSV);
             if ($import->failures()->count() > 0) {
                 $errors = $import->failures();
-                $columns =  [
+                $columns = [
                     'remarks',
                     'st_no',
                     'stu_no',
@@ -118,10 +118,10 @@ 
                 Storage::put($file, implode(',', $columns));
 
                 foreach ($errors as $error) {
-                    Storage::append($file, implode(':', $error->errors()) . ',' . implode(',', $error->values()));
+                    Storage::append($file, implode(':', $error->errors()).','.implode(',', $error->values()));
                 }
             }
-        } catch (\Maatwebsite\Excel\Validators\ValidationException $e) {
+        }catch (\Maatwebsite\Excel\Validators\ValidationException $e) {
         }
     }
 
@@ -139,9 +139,9 @@ 
             ->get()
             ->toArray();
         if (!empty($students)) {
-            $this->output->writeln(count($students) . 'students remaining');
+            $this->output->writeln(count($students).'students remaining');
             array_walk($students, array($this, 'clone'));
-        } else {
+        }else {
             $this->output->writeln('All are generated');
             // exit;
         }
@@ -219,7 +219,7 @@ 
 
                 //TODO implement insert student to admission table
                 $student['id'] = $sis_student['id'];
-                $sis_student['student_id'] =  $student['id'];
+                $sis_student['student_id'] = $student['id'];
 
                 $student = $this->setIsTakingExam($student);
                 if (count($institutionClass) == 1) {
@@ -227,13 +227,13 @@ 
                     Institution_student::createExaminationData($student, $admissionInfo);
                     Institution_student_admission::createExaminationData($student, $admissionInfo);
                     Institution_class_student::createExaminationData($student, $admissionInfo);
-                } else {
+                }else {
                     Institution_student_admission::createExaminationData($student, $admissionInfo);
                     Institution_student::createExaminationData($student, $admissionInfo);
                 }
                 $this->updateStudentId($student, $sis_student);
                 // update the matched student's data    
-            } else {
+            }else {
                 $student = $this->setIsTakingExam($student);
                 $studentData = $this->student->updateExaminationStudent($student, $matchedStudent);
                 $matchedStudent = array_merge((array) $student, $matchedStudent);
@@ -241,9 +241,9 @@ 
                 Institution_student::updateExaminationData($studentData, $admissionInfo);
                 $this->updateStudentId($student, $studentData);
             }
-        } else {
+        }else {
 
-            $this->output->writeln('Student ' . $student['st_no'] . ' not imorted' . $student['f_name']);
+            $this->output->writeln('Student '.$student['st_no'].' not imorted'.$student['f_name']);
             // $sis_student = $this->student->insertExaminationStudent($student);
             // $institionId = Institution::insert(['name' => $student['schoolid'], 'code' => $student['schoolid']]);
             // $institution = Institution::where('code', '=', $student['schoolid'])->first();
@@ -288,7 +288,7 @@ 
         // if the same gender same DOE has more than one 
         if (!is_null($sis_users) && (count($sis_users) > 1)) {
             $studentData = $this->searchSimilarName($student, $sis_users);
-        } else if (!is_null($sis_users) && (count($sis_users) == 1)) {
+        }else if (!is_null($sis_users) && (count($sis_users) == 1)) {
             $studentData = $sis_users[0];
         }
         return $studentData;
@@ -349,15 +349,15 @@ 
     public function updateStudentId($student, $sis_student)
     {
         try {
-            $student['nsid'] =  $sis_student['openemis_no'];
+            $student['nsid'] = $sis_student['openemis_no'];
             // add new NSID to the examinations data set
             unset($student['id']);
             unset($student['taking_g5_exam']);
             unset($student['taking_al_exam']);
             unset($student['taking_ol_exam']);
             $this->examination_student->where('st_no', $student['st_no'])->update($student);
-            $this->output->writeln('Updated ' . $sis_student['student_id'] . ' to NSID' . $sis_student['openemis_no']);
-        } catch (\Exception $th) {
+            $this->output->writeln('Updated '.$sis_student['student_id'].' to NSID'.$sis_student['openemis_no']);
+        }catch (\Exception $th) {
             Log::error($th);
         }
     }
@@ -373,7 +373,7 @@ 
         try {
             (new ExaminationStudentsExport)->store('examination/student_data_with_nsid.csv');
             (new ExportReady($adminUser));
-        } catch (\Throwable $th) {
+        }catch (\Throwable $th) {
             //throw $th;
             dd($th);
         }
@@ -383,13 +383,13 @@ 
     public function downloadErrors()
     {
 
-        $file_path = storage_path() . '/app/examination/errors.csv';
+        $file_path = storage_path().'/app/examination/errors.csv';
         return Response::download($file_path);
     }
 
     public function downloadProcessedFile()
     {
-        $file_path = storage_path() . '/app/examination/student_data_with_nsid.csv';
+        $file_path = storage_path().'/app/examination/student_data_with_nsid.csv';
         return Response::download($file_path);
     }
 }

app/Console/Commands/ExaminationStudentMigrate.php

Spacing +2 added lines, -2 removed lines

@@ -41,8 +41,8 @@
     {
         $output = new \Symfony\Component\Console\Output\ConsoleOutput();
         $output->writeln('###########################################------Inserting file records------###########################################');
-        $this->examinationController = new ExaminationStudentsController($this->argument('year'),$this->argument('grade'));
-        $this->examinationController->doMatch($this->argument('offset'),$this->argument('limit'));
+        $this->examinationController = new ExaminationStudentsController($this->argument('year'), $this->argument('grade'));
+        $this->examinationController->doMatch($this->argument('offset'), $this->argument('limit'));
         $this->examinationController->export();
         $output->writeln('###########################################------Finished inserting file records------###########################################');
     }