moe-lk / bulk-upload

app/Http/Controllers/CloneController.php

Spacing +58 added lines, -58 removed lines

@@ -28,17 +28,17 @@ 
         $this->academic_period = new Academic_period();
         $this->institution_classes = new Institution_class();
         $this->institution_class_subjects = new Institution_class_subject();
-        $this->institution_subjects =  new Institution_subject();
-        $this->education_grade_subjects =  new Education_grades_subject();
+        $this->institution_subjects = new Institution_subject();
+        $this->education_grade_subjects = new Education_grades_subject();
         $this->output = new \Symfony\Component\Console\Output\ConsoleOutput();
     }
 
 
-    public function array_walk($shift,$count,$params){
-        array_walk($shift,array($this,'process'),$params);
+    public function array_walk($shift, $count, $params) {
+        array_walk($shift, array($this, 'process'), $params);
     }
 
-    public function cleanConfig($params){
+    public function cleanConfig($params) {
         $academicPeriod = $params['academic_period'];
         $this->shifts->where(['academic_period_id' => $academicPeriod->id])->delete();
         $this->output->writeln('cleaned shifts');
@@ -46,32 +46,32 @@ 
         $this->shifts->where(['cloned' => $academicPeriod->code])->update(['cloned' => $academicPeriod->code - 1]);
         $this->output->writeln('updated shifts');
 
-        $classIds =  $this->institution_classes->select('id')->where(['academic_period_id' => $academicPeriod->id])->get()->toArray();
+        $classIds = $this->institution_classes->select('id')->where(['academic_period_id' => $academicPeriod->id])->get()->toArray();
         $this->institution_classes->where(['academic_period_id' => $academicPeriod->id])->delete();
         $this->output->writeln('cleaned classes');
 
-        $this->institution_class_subjects->whereNotIn( 'institution_class_id' , $classIds)->delete();
+        $this->institution_class_subjects->whereNotIn('institution_class_id', $classIds)->delete();
         $this->output->writeln('cleaned subjects');
 
-        do{
-          $deleted =  $this->institution_subjects->where('academic_period_id',$academicPeriod->id)->limit(100000)->delete();
+        do {
+          $deleted = $this->institution_subjects->where('academic_period_id', $academicPeriod->id)->limit(100000)->delete();
           $this->output->writeln('100000 institutions cleaned shifts');
-        }while($deleted > 0);
+        } while ($deleted > 0);
     }
 
-    public function process($shift,$count,$params){
-        echo('['.getmypid().']This Process executed at'.date("F d, Y h:i:s A")."\n") ;
+    public function process($shift, $count, $params) {
+        echo('['.getmypid().']This Process executed at'.date("F d, Y h:i:s A")."\n");
         $year = $params['year'];
         $academicPeriod = $params['academic_period'];
         $previousAcademicPeriod = $params['previous_academic_period'];
-        try{
+        try {
             $shiftId = $this->updateShifts($year, $shift);
             $institutionClasses = $this->institution_classes->getShiftClasses($shift['id']);
-            $institutionSubjects = $this->institution_subjects->getInstitutionSubjects($shift['institution_id'],$previousAcademicPeriod->id);
-            array_walk($institutionSubjects , array($this,'insertInstitutionSubjects'),$academicPeriod);
-            if (!empty($institutionClasses) && !is_null($shiftId) && !is_null($academicPeriod) ) {
+            $institutionSubjects = $this->institution_subjects->getInstitutionSubjects($shift['institution_id'], $previousAcademicPeriod->id);
+            array_walk($institutionSubjects, array($this, 'insertInstitutionSubjects'), $academicPeriod);
+            if (!empty($institutionClasses) && !is_null($shiftId) && !is_null($academicPeriod)) {
 
-                $newInstitutionClasses = $this->generateNewClass($institutionClasses,$shiftId,$academicPeriod->id);
+                $newInstitutionClasses = $this->generateNewClass($institutionClasses, $shiftId, $academicPeriod->id);
 
                 $params = [
                     'previous_academic_period_id' => $previousAcademicPeriod->id,
@@ -79,21 +79,21 @@ 
                     'shift_id' =>$shiftId
                 ];
 
-                try{
-                    array_walk($newInstitutionClasses,array($this,'insertInstitutionClasses'),$params);
+                try {
+                    array_walk($newInstitutionClasses, array($this, 'insertInstitutionClasses'), $params);
                     $newInstitutionClasses = $this->institution_classes->getShiftClasses($shiftId);
                     $this->output->writeln('##########################################################################################################################');
-                    $this->output->writeln('updating from '. $shiftId);
+                    $this->output->writeln('updating from '.$shiftId);
 
-                }catch (\Exception $e){
+                }catch (\Exception $e) {
                     dd($e);
-                     Log::error($e->getMessage(),[$e]);
+                     Log::error($e->getMessage(), [$e]);
                 }
             }
 //            DB::commit();
-        }catch (\Exception $e){
+        }catch (\Exception $e) {
 //            DB::rollBack();
-             Log::error($e->getMessage(),[$e]);
+             Log::error($e->getMessage(), [$e]);
         }
     }
 
@@ -103,31 +103,31 @@ 
      * @param $count
      * @param $academicPeriod
      */
-    public function insertInstitutionSubjects($subjects, $count,$academicPeriod){
-       try{
+    public function insertInstitutionSubjects($subjects, $count, $academicPeriod) {
+       try {
            $subjects['academic_period_id'] = $academicPeriod->id;
            $subjects['created'] = now();
            unset($subjects['total_male_students']);
            unset($subjects['total_female_students']);
            unset($subjects['id']);
            $this->institution_subjects->create($subjects);
-       }catch (\Exception $e){
-            Log::error($e->getMessage(),[$e]);
+       }catch (\Exception $e) {
+            Log::error($e->getMessage(), [$e]);
        }
     }
 
 
-    public function  insertInstitutionClasses($class,$count,$param){
-            try{
+    public function  insertInstitutionClasses($class, $count, $param) {
+            try {
 
                 $academicPeriod = $param['academic_period_id'];
                 $educationGrdae = $class['education_grade_id'];
 
                 $classId = $class['id'];
                 unset($class['id']);
-                $institutionSubjects = Institution_subject::query()->where('education_grade_id',$class['education_grade_id'])
-                    ->where('institution_id',$class['institution_id'])
-                    ->where('academic_period_id',$academicPeriod)->get()->toArray();
+                $institutionSubjects = Institution_subject::query()->where('education_grade_id', $class['education_grade_id'])
+                    ->where('institution_id', $class['institution_id'])
+                    ->where('academic_period_id', $academicPeriod)->get()->toArray();
                 $params = [
                     'class'=>$class,
                     'subjects'=>$institutionSubjects,
@@ -140,39 +140,39 @@ 
                 $class['no_of_students'] = $noOfStudents;
                 $class['created'] = now();
                 $class['institution_shift_id'] = $param['shift_id'];
-                $this->output->writeln('Create class:'. $class['name']);
+                $this->output->writeln('Create class:'.$class['name']);
                 $class = Institution_class::create($class);
                 $institutionClassGrdaeObj['institution_class_id'] = $class->id;
                 $institutionClassGrdaeObj['education_grade_id'] = $educationGrdae;
                 Institution_class_grade::create($institutionClassGrdaeObj);
-                $institutionSubjects = Institution_subject::query()->where('education_grade_id',$educationGrdae)
-                    ->where('institution_id',$class->institution_id)
-                    ->where('academic_period_id',$academicPeriod)
+                $institutionSubjects = Institution_subject::query()->where('education_grade_id', $educationGrdae)
+                    ->where('institution_id', $class->institution_id)
+                    ->where('academic_period_id', $academicPeriod)
                     ->groupBy('education_subject_id')
                     ->get()
                     ->toArray();
                 $params['class'] = $class;
-                $this->insertInstitutionClassSubjects($institutionSubjects,$class);
+                $this->insertInstitutionClassSubjects($institutionSubjects, $class);
 //                array_walk($classSubjects,array($this,'insertInstitutionClassSubjects'),$params);
-            }catch (\Exception $e){
-                 Log::error($e->getMessage(),[$e]);
+            }catch (\Exception $e) {
+                 Log::error($e->getMessage(), [$e]);
             }
     }
 
-    public function insertInstitutionClassSubjects($subjects,$class){
-        if(!empty($subjects)){
-            try{
-                array_walk($subjects,array($this,'insertClassSubjects'),$class);
-                $this->output->writeln('updating subjects '. $class->name);
-            }catch (\Exception $e){
-                 Log::error($e->getMessage(),[$e]);
+    public function insertInstitutionClassSubjects($subjects, $class) {
+        if (!empty($subjects)) {
+            try {
+                array_walk($subjects, array($this, 'insertClassSubjects'), $class);
+                $this->output->writeln('updating subjects '.$class->name);
+            }catch (\Exception $e) {
+                 Log::error($e->getMessage(), [$e]);
             }
         };
     }
 
   
-    public function insertClassSubjects($subject,$count,$newClassId){
-        try{
+    public function insertClassSubjects($subject, $count, $newClassId) {
+        try {
             $subjectobj['status'] = 1;
             $subjectobj['created_user_id'] = 1;
             $subjectobj['created'] = now();
@@ -180,11 +180,11 @@ 
             $subjectobj['institution_class_id'] = $newClassId->id;
             $subjectobj['institution_subject_id'] = $subject['id'];
 
-            if(!$this->institution_class_subjects->isDuplicated($subjectobj)){
+            if (!$this->institution_class_subjects->isDuplicated($subjectobj)) {
                 $this->institution_class_subjects->create($subjectobj);
             }
-        }catch (\Exception $e){
-             Log::error($e->getMessage(),[$e]);
+        }catch (\Exception $e) {
+             Log::error($e->getMessage(), [$e]);
         }
     }
 
@@ -196,15 +196,15 @@ 
      * @param $academicPeriod
      * @return array
      */
-    public function generateNewClass($classes,$shiftId,$academicPeriod){
+    public function generateNewClass($classes, $shiftId, $academicPeriod) {
         $newClasses = [];
-        foreach ( $classes as $class) {
+        foreach ($classes as $class) {
             $noOfStudents = $class['no_of_students'] == 0 ? 40 : $class['no_of_students'];
             $class['academic_period_id'] = $academicPeriod;
             $class['no_of_students'] = $noOfStudents;
             $class['created'] = now();
             $class['institution_shift_id'] = $shiftId;
-            array_push($newClasses,$class);
+            array_push($newClasses, $class);
         }
         return $newClasses;
     }
@@ -215,11 +215,11 @@ 
      * @param $shift
      * @return mixed
      */
-    public function updateShifts($year,$shift){
+    public function updateShifts($year, $shift) {
         $academicPeriod = $this->academic_period->getAcademicPeriod($year);
-        $this->shifts->where('id',$shift['id'])->update(['cloned' => $year]);
+        $this->shifts->where('id', $shift['id'])->update(['cloned' => $year]);
         $shift['academic_period_id'] = $academicPeriod->id;
         $exist = $this->shifts->shiftExists($shift);
-        return $this->shifts->create((array)$shift)->id;
+        return $this->shifts->create((array) $shift)->id;
     }
 }

app/Console/Commands/UpdateStudentsCount.php

Spacing +22 added lines, -22 removed lines

@@ -48,36 +48,36 @@ 
     public function handle()
     {
         $this->output->writeln('#########################################');
-        if($this->argument('entity') == 'class'){
+        if ($this->argument('entity') == 'class') {
             $classes = Institution_class::get()->toArray();
-            $func = array($this,'updateCount');
-            array_walk($subjects,array($this,'process'));
-            $this->output->writeln('start updating:'. count($classes));
-        }elseif($this->argument('entity') == 'subject'){
+            $func = array($this, 'updateCount');
+            array_walk($subjects, array($this, 'process'));
+            $this->output->writeln('start updating:'.count($classes));
+        }elseif ($this->argument('entity') == 'subject') {
             $subjects = Institution_subject::get()->toArray(); 
-            $subjects = array_chunk($subjects,10000);
-            $this->output->writeln('start updating:'. count($subjects));
-            array_walk($subjects,array($this,'process'));
+            $subjects = array_chunk($subjects, 10000);
+            $this->output->writeln('start updating:'.count($subjects));
+            array_walk($subjects, array($this, 'process'));
             $this->output->writeln('#########################################');
         }
        
     }
 
-    public function process($data){
-        if($this->argument('entity') == 'class'){
-            $func = array($this,'updateCount');
-            processParallel($func,$data,$this->argument('max'));
-            $this->output->writeln('start updating calss count:'. count($data));
-        }elseif($this->argument('entity') == 'subject'){
-            $this->output->writeln('start updating subject count:'. count($data));
-            $func_subject = array($this,'updateSubjectCount');
-            processParallel($func_subject,$data,$this->argument('max'));
+    public function process($data) {
+        if ($this->argument('entity') == 'class') {
+            $func = array($this, 'updateCount');
+            processParallel($func, $data, $this->argument('max'));
+            $this->output->writeln('start updating calss count:'.count($data));
+        }elseif ($this->argument('entity') == 'subject') {
+            $this->output->writeln('start updating subject count:'.count($data));
+            $func_subject = array($this, 'updateSubjectCount');
+            processParallel($func_subject, $data, $this->argument('max'));
         }
     }
 
-    public function updateCount($class){
-        $this->output->writeln('updating class:'. $class['id']);
-        $totalStudents =  Institution_class_student::getStudentsCount($class['id']);
+    public function updateCount($class) {
+        $this->output->writeln('updating class:'.$class['id']);
+        $totalStudents = Institution_class_student::getStudentsCount($class['id']);
         Institution_class::where('id', '=', $class['id'])
         ->update([
             'total_male_students' => $totalStudents['total_male_students'],
@@ -85,8 +85,8 @@ 
         ]);
     }
 
-    public function updateSubjectCount($subject){
-        $this->output->writeln('updating subject:'. $subject['id']);
+    public function updateSubjectCount($subject) {
+        $this->output->writeln('updating subject:'.$subject['id']);
         $totalStudents = Institution_subject_student::getStudentsCount($subject['id']);
         Institution_subject::where(['id' => $subject['id']])
             ->update([

Braces +2 added lines, -2 removed lines

@@ -53,7 +53,7 @@ 
             $func = array($this,'updateCount');
             array_walk($subjects,array($this,'process'));
             $this->output->writeln('start updating:'. count($classes));
-        }elseif($this->argument('entity') == 'subject'){
+        } elseif($this->argument('entity') == 'subject'){
             $subjects = Institution_subject::get()->toArray(); 
             $subjects = array_chunk($subjects,10000);
             $this->output->writeln('start updating:'. count($subjects));
@@ -68,7 +68,7 @@ 
             $func = array($this,'updateCount');
             processParallel($func,$data,$this->argument('max'));
             $this->output->writeln('start updating calss count:'. count($data));
-        }elseif($this->argument('entity') == 'subject'){
+        } elseif($this->argument('entity') == 'subject'){
             $this->output->writeln('start updating subject count:'. count($data));
             $func_subject = array($this,'updateSubjectCount');
             processParallel($func_subject,$data,$this->argument('max'));

app/Console/Commands/ImportStudents.php

Indentation +1 added lines, -1 removed lines

@@ -138,7 +138,7 @@
             ->join('contact_types', 'user_contacts.contact_type_id', '=', 'contact_types.id')
             //only for UAT
             //  ->where('contact_types.contact_option_id', '=', 5)
-           ->where('contact_types.contact_option_id', '!=', 5)
+            ->where('contact_types.contact_option_id', '!=', 5)
             //  ->where('contact_types.name', '=', 'TestEmail')
             ->limit(1)
             ->get()->toArray();

app/Console/Commands/CloneConfigData.php

Spacing +2 added lines, -2 removed lines

@@ -61,12 +61,12 @@
         // dd($shift);
         $function = array($this->clone, 'process');
         // array_walk($shift,$function,$params);
-        processParallel($function,$shift, $this->argument('max'),$params);
+        processParallel($function, $shift, $this->argument('max'), $params);
         $this->end_time = microtime(TRUE);
 
 
         $this->output->writeln('$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$');
-        $this->output->writeln('The cook took ' . ($this->end_time - $this->start_time) . ' seconds to complete');
+        $this->output->writeln('The cook took '.($this->end_time - $this->start_time).' seconds to complete');
         $this->output->writeln('$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$');
     }  
 }

app/Console/Commands/CleanExamData.php

Indentation +3 added lines, -3 removed lines

@@ -85,11 +85,11 @@
 
     public function process($students){
         $type = $this->argument('type');
-       if($type == 'duplication'){
+        if($type == 'duplication'){
         array_walk($students,array($this,'cleanData'));
-       }elseif($type == 'invalid' || 'all'){
+        }elseif($type == 'invalid' || 'all'){
         array_walk($students,array($this,'cleanInvalidData'));
-       }
+        }
     }
 
 

Spacing +17 added lines, -17 removed lines

@@ -48,12 +48,12 @@ 
     {
         $type = $this->argument('type');
         $students = array();
-        if($type == 'invalid'){
+        if ($type == 'invalid') {
             $students = DB::table('examination_students as es')
             ->whereRaw('CHAR_LENGTH(nsid) > 11')
             ->get()
             ->toArray();
-        }elseif($type == 'duplicate'){
+        }elseif ($type == 'duplicate') {
             $students = DB::table('institution_students as is')
             ->join('security_users as su', 'su.id', 'is.student_id')
             ->where('is.updated_from', 'doe')
@@ -63,39 +63,39 @@ 
             ->get()
             ->toArray();
             
-        }elseif('all'){
+        }elseif ('all') {
             $students = DB::table('examination_students')
-            ->where('nsid','<>','')
+            ->where('nsid', '<>', '')
             ->whereNotNull('nsid')
             ->get()
             ->toArray();
         }
 
         $this->output->writeln('###########################################------Start cleanning exam records------###########################################');    
-        if(count($students) > 0){
-            $this->output->writeln('Total students to clean: '.  count($students));
+        if (count($students) > 0) {
+            $this->output->writeln('Total students to clean: '.count($students));
             $students = array_chunk($students, $this->argument('chunk'));
             $function = array($this, 'process');
-            processParallel($function,$students, $this->argument('max'));
-        }else{
+            processParallel($function, $students, $this->argument('max'));
+        }else {
             $this->output->writeln('nothing to process, all are cleaned');
         }   
         $this->output->writeln('###########################################------Finished cleaning exam records------###########################################');
     }
 
-    public function process($students){
+    public function process($students) {
         $type = $this->argument('type');
-       if($type == 'duplication'){
-        array_walk($students,array($this,'cleanData'));
-       }elseif($type == 'invalid' || 'all'){
-        array_walk($students,array($this,'cleanInvalidData'));
+       if ($type == 'duplication') {
+        array_walk($students, array($this, 'cleanData'));
+       }elseif ($type == 'invalid' || 'all') {
+        array_walk($students, array($this, 'cleanInvalidData'));
        }
     }
 
 
     public function cleanData($Student)
     {
-        $exist = Examination_student::where('nsid','=',  $Student->openemis_no)->count();
+        $exist = Examination_student::where('nsid', '=', $Student->openemis_no)->count();
 
         if (!$exist) {
             Institution_student::where('student_id', $Student->student_id)->delete();
@@ -108,12 +108,12 @@ 
     public function cleanInvalidData($Student)
     {
         $Student = (array) $Student;
-        $exist = Examination_student::where('nsid',$Student['nsid'])->count();
+        $exist = Examination_student::where('nsid', $Student['nsid'])->count();
         
         $this->uniqueUId = new UniqueUid();
 
-        $nsid = ltrim(rtrim($Student['nsid'],'-'),'-');
-        if(!$this->uniqueUId::isValidUniqueId('DBY-898-3J2')){
+        $nsid = ltrim(rtrim($Student['nsid'], '-'), '-');
+        if (!$this->uniqueUId::isValidUniqueId('DBY-898-3J2')) {
         }
     }
 }

Braces +4 added lines, -4 removed lines

@@ -53,7 +53,7 @@ 
             ->whereRaw('CHAR_LENGTH(nsid) > 11')
             ->get()
             ->toArray();
-        }elseif($type == 'duplicate'){
+        } elseif($type == 'duplicate'){
             $students = DB::table('institution_students as is')
             ->join('security_users as su', 'su.id', 'is.student_id')
             ->where('is.updated_from', 'doe')
@@ -63,7 +63,7 @@ 
             ->get()
             ->toArray();
             
-        }elseif('all'){
+        } elseif('all'){
             $students = DB::table('examination_students')
             ->where('nsid','<>','')
             ->whereNotNull('nsid')
@@ -77,7 +77,7 @@ 
             $students = array_chunk($students, $this->argument('chunk'));
             $function = array($this, 'process');
             processParallel($function,$students, $this->argument('max'));
-        }else{
+        } else{
             $this->output->writeln('nothing to process, all are cleaned');
         }   
         $this->output->writeln('###########################################------Finished cleaning exam records------###########################################');
@@ -87,7 +87,7 @@ 
         $type = $this->argument('type');
        if($type == 'duplication'){
         array_walk($students,array($this,'cleanData'));
-       }elseif($type == 'invalid' || 'all'){
+       } elseif($type == 'invalid' || 'all'){
         array_walk($students,array($this,'cleanInvalidData'));
        }
     }

app/Console/Commands/StudentsIdGen.php

Spacing +9 added lines, -9 removed lines

@@ -36,7 +36,7 @@ 
         $this->output = new \Symfony\Component\Console\Output\ConsoleOutput();
         $this->students = new Security_user();
         $this->uniqueUId = new UniqueUid();
-        $this->max  = 0;
+        $this->max = 0;
         $this->child = 0;
         parent::__construct();
     }
@@ -60,19 +60,19 @@ 
     public function processParallel(array $arr, $procs = 4)
     {
         // Break array up into $procs chunks.
-        $chunks   = array_chunk($arr, ceil((count($arr) / $procs)));
+        $chunks   = array_chunk($arr, ceil((count($arr)/$procs)));
         $pid      = -1;
         $children = array();
         foreach ($chunks as $items) {
             $pid = pcntl_fork();
             if ($pid === -1) {
                 die('could not fork');
-            } else if ($pid === 0) {
-                $this->output->writeln('started processes: ' . count($children));
+            }else if ($pid === 0) {
+                $this->output->writeln('started processes: '.count($children));
                 // We are the child process. Pass a chunk of items to process.
                 array_walk($items, array($this, 'process'));
                 exit(0);
-            } else {
+            }else {
                 // We are the parent.
                 $children[] = $pid;
             }
@@ -104,17 +104,17 @@ 
 
                 $newId = $this->uniqueUId::getUniqueAlphanumeric();
                 $student['openemis_no'] = $newId;
-                $student =  $this->uniqueUserId->updateOrInsertRecord($student);
+                $student = $this->uniqueUserId->updateOrInsertRecord($student);
                 // $this->output->writeln('New NSID generated for :' . $student['id']);
                 Security_user::query()->where('id', $student['id'])
                     ->update(['openemis_no' => $newId, 'username' => str_replace('-', '', $newId)]);
-            } catch (\Exception $e) {
+            }catch (\Exception $e) {
             }
-        } else {
+        }else {
             try {
                 // $this->output->writeln('Updating student:' . $student['id']);
                 $this->uniqueUserId->updateOrInsertRecord($student);
-            } catch (\Exception $e) {
+            }catch (\Exception $e) {
                 dd($e);
             }
         }

app/Models/Unique_user_id.php

Indentation +5 added lines, -5 removed lines

@@ -54,7 +54,7 @@ 
 
     public  function updateOrInsertRecord($user)
     {
-       try {
+        try {
             // regenerate unique id if it's not available
         $uniqueId =  $this->uniqueUserId::isValidUniqueId($user['openemis_no'],9) ? $this->uniqueUserId::getUniqueAlphanumeric() : $user['openemis_no'];
 
@@ -69,9 +69,9 @@ 
             ]);
         }
         return $user;
-       } catch (\Exception $th) {
-           $user['openemis_no'] = $this->uniqueUserId::getUniqueAlphanumeric();
-           $this->updateOrInsertRecord($user);
-       }
+        } catch (\Exception $th) {
+            $user['openemis_no'] = $this->uniqueUserId::getUniqueAlphanumeric();
+            $this->updateOrInsertRecord($user);
+        }
     }
 }

Spacing +3 added lines, -3 removed lines

@@ -56,10 +56,10 @@ 
     {
        try {
             // regenerate unique id if it's not available
-        $uniqueId =  $this->uniqueUserId::isValidUniqueId($user['openemis_no'],9) ? $this->uniqueUserId::getUniqueAlphanumeric() : $user['openemis_no'];
+        $uniqueId = $this->uniqueUserId::isValidUniqueId($user['openemis_no'], 9) ? $this->uniqueUserId::getUniqueAlphanumeric() : $user['openemis_no'];
 
         //check if the user's entry exits ?
-        $exists = Unique_user_id::where('unique_id' , $uniqueId)->exists();
+        $exists = Unique_user_id::where('unique_id', $uniqueId)->exists();
 
         if (!$exists) {
             // try to feed unique user id
@@ -69,7 +69,7 @@ 
             ]);
         }
         return $user;
-       } catch (\Exception $th) {
+       }catch (\Exception $th) {
            $user['openemis_no'] = $this->uniqueUserId::getUniqueAlphanumeric();
            $this->updateOrInsertRecord($user);
        }

app/Models/Institution_subject.php

Spacing +16 added lines, -16 removed lines

@@ -4,7 +4,7 @@ 
 
 use Illuminate\Database\Eloquent\Model;
 
-class Institution_subject extends Base_Model  {
+class Institution_subject extends Base_Model {
 
     /**
      * The database table used by the model.
@@ -42,42 +42,42 @@ 
     protected $dates = ['modified', 'created', 'modified', 'created'];
 
 
-    public  function institutionGradeSubject(){
-        return $this->belongsTo('App\Models\Education_grades_subject','education_subject_id','education_subject_id');
+    public  function institutionGradeSubject() {
+        return $this->belongsTo('App\Models\Education_grades_subject', 'education_subject_id', 'education_subject_id');
     }
 
-    public  function institutionOptionalGradeSubject(){
-        return $this->belongsTo('App\Models\Education_grades_subject','education_grade_id','education_grade_id');
+    public  function institutionOptionalGradeSubject() {
+        return $this->belongsTo('App\Models\Education_grades_subject', 'education_grade_id', 'education_grade_id');
     }
 
-    public  function institutionMandatoryGradeSubject(){
-        return $this->belongsTo('App\Models\Education_grades_subject','education_grade_id','education_grade_id');
+    public  function institutionMandatoryGradeSubject() {
+        return $this->belongsTo('App\Models\Education_grades_subject', 'education_grade_id', 'education_grade_id');
     }
 
 
-    public  function institutionClassSubject(){
-        return $this->hasMany('App\Models\Institution_class_subject','institution_class_id','id');
+    public  function institutionClassSubject() {
+        return $this->hasMany('App\Models\Institution_class_subject', 'institution_class_id', 'id');
     }
 
 
 
-    public function getInstitutionSubjects($institution_id,$academic_period_id){
-        return self::query()->where('institution_id',$institution_id)
-            ->where('academic_period_id',$academic_period_id)
+    public function getInstitutionSubjects($institution_id, $academic_period_id) {
+        return self::query()->where('institution_id', $institution_id)
+            ->where('academic_period_id', $academic_period_id)
             ->get()->toArray();
     }
 
     public  static function getStudentsCount($institution_subject_id)
     {
-        $total_male_students = self::with(['student' => function ($query) {
+        $total_male_students = self::with(['student' => function($query) {
             $query->where('student.gender_id', '=', 1);
-        }])->whereHas('student', function ($query) {
+        }])->whereHas('student', function($query) {
             $query->where('gender_id', '=', 1);
         })->where('institution_subject_id', '=', $institution_subject_id)->count();
 
-        $total_female_students = self::with(['student' => function ($query) {
+        $total_female_students = self::with(['student' => function($query) {
             $query->where('student.gender_id', '=', 2);
-        }])->whereHas('student', function ($query) {
+        }])->whereHas('student', function($query) {
             $query->where('gender_id', '=', 2);
         })->where('institution_subject_id', '=', $institution_subject_id)->count();
 

app/Models/Security_user.php

Spacing +10 added lines, -10 removed lines

@@ -149,9 +149,9 @@ 
     public function getMatches($student)
     {
         return $this
-        ->where('gender_id',$student['gender'] + 1)
-        ->where('institutions.code',$student['schoolid'])
-        ->where('date_of_birth',$student['b_date'])
+        ->where('gender_id', $student['gender'] + 1)
+        ->where('institutions.code', $student['schoolid'])
+        ->where('date_of_birth', $student['b_date'])
             ->join('institution_students', 'security_users.id', 'institution_students.student_id')
             ->join('institutions', 'institution_students.institution_id', 'institutions.id')
             ->get()->toArray();
@@ -166,9 +166,9 @@ 
     public function getStudentCount($student)
     {
         return $this
-        ->where('gender_id',$student['gender'] + 1)
-        ->where('institutions.code',$student['schoolid'])
-        ->where('date_of_birth',$student['b_date'])
+        ->where('gender_id', $student['gender'] + 1)
+        ->where('institutions.code', $student['schoolid'])
+        ->where('date_of_birth', $student['b_date'])
             ->join('institution_students', 'security_users.id', 'institution_students.student_id')
             ->join('institutions', 'institution_students.institution_id', 'institutions.id')
             ->count();
@@ -202,7 +202,7 @@ 
             $id = $this->insertGetId($studentData);
             $studentData['id'] = $id;
             return $studentData;
-        } catch (\Exception $th) {
+        }catch (\Exception $th) {
             Log::error($th->getMessage());
             // in case of duplication of the Unique ID this will recursive.
             $sis_student['openemis_no'] = $this->uniqueUId::getUniqueAlphanumeric();
@@ -223,7 +223,7 @@ 
         $this->uniqueUserId = new Unique_user_id();
         $this->uniqueUId = new UniqueUid();
         // regenerate unique id if it's not available
-        $uniqueId = ($this->uniqueUId::isValidUniqueId($sis_student['openemis_no'],9)) ?  $sis_student['openemis_no'] : $this->uniqueUId::getUniqueAlphanumeric();
+        $uniqueId = ($this->uniqueUId::isValidUniqueId($sis_student['openemis_no'], 9)) ? $sis_student['openemis_no'] : $this->uniqueUId::getUniqueAlphanumeric();
 
         $studentData = [
             'username' => str_replace('-', '', $uniqueId),
@@ -238,10 +238,10 @@ 
 
         try {
             $this->uniqueUserId->updateOrInsertRecord($studentData);
-            self::where( 'id'  , $sis_student['student_id'])->update($studentData);
+            self::where('id', $sis_student['student_id'])->update($studentData);
             $studentData['id'] = $sis_student['student_id'];
             return $studentData;
-        } catch (\Exception $th) {
+        }catch (\Exception $th) {
             Log::error($th);
             // in case of duplication of the Unique ID this will recursive.
             $sis_student['openemis_no'] = $this->uniqueUId::getUniqueAlphanumeric();